[PR] IGNITE-22489 Add units suffix to all configuration values [ignite-3]

2025-04-01 Thread via GitHub
valepakh opened a new pull request, #5541: URL: https://github.com/apache/ignite-3/pull/5541 https://issues.apache.org/jira/browse/IGNITE-22489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] IGNITE-24985 Add a test where a node joins to the cluster of two [ignite-3]

2025-04-01 Thread via GitHub
ibessonov opened a new pull request, #5542: URL: https://github.com/apache/ignite-3/pull/5542 https://issues.apache.org/jira/browse/IGNITE-24985 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022592310 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

[PR] IGNITE-24754 : query #17 possible require too much heap [ignite]

2025-04-01 Thread via GitHub
Vladsz83 opened a new pull request, #11977: URL: https://github.com/apache/ignite/pull/11977 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-01 Thread via GitHub
ascherbakoff commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022335542 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientRecordSerializer.java: ## @@ -126,10 +134,11 @@ void writeRecs( @Nullab

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022759815 ## modules/platforms/cpp/ignite/client/detail/sql/sql_impl.cpp: ## @@ -88,8 +89,28 @@ void write_args(protocol::writer &writer, const std::vector &args) { writer

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022790027 ## modules/platforms/cpp/ignite/client/sql/sql.h: ## @@ -44,49 +45,57 @@ class sql { sql() = delete; /** - * Executes single SQL statement asynchronous

[PR] IGNITE-22487 Remove compute.threadPoolStopTimeoutMillis config value [ignite-3]

2025-04-01 Thread via GitHub
valepakh opened a new pull request, #5539: URL: https://github.com/apache/ignite-3/pull/5539 https://issues.apache.org/jira/browse/IGNITE-22487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022790027 ## modules/platforms/cpp/ignite/client/sql/sql.h: ## @@ -44,49 +45,57 @@ class sql { sql() = delete; /** - * Executes single SQL statement asynchronous

[PR] IGNITE-24973 Only log long handling warnings in tests [ignite-3]

2025-04-01 Thread via GitHub
rpuch opened a new pull request, #5534: URL: https://github.com/apache/ignite-3/pull/5534 https://issues.apache.org/jira/browse/IGNITE-24973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-24973 Only log long handling warnings in tests [ignite-3]

2025-04-01 Thread via GitHub
rpuch merged PR #5534: URL: https://github.com/apache/ignite-3/pull/5534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-01 Thread via GitHub
vldpyatkov commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022412887 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java: ## @@ -499,7 +502,7 @@ private ReadOnlyTransactionImpl beginReadOnlyTra

Re: [PR] IGNITE-24588 Fixed client-side tuple serialization when the schema has field names containing non-standard characters. [ignite-3]

2025-04-01 Thread via GitHub
AMashenkov merged PR #5493: URL: https://github.com/apache/ignite-3/pull/5493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-01 Thread via GitHub
vldpyatkov commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022455407 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java: ## @@ -888,6 +873,48 @@ public int pending() { return startedT

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022817067 ## modules/platforms/cpp/ignite/client/detail/sql/sql_impl.cpp: ## @@ -88,8 +89,28 @@ void write_args(protocol::writer &writer, const std::vector &args) { writer

[PR] IGNITE-24982 C++: Add missing headers to public [ignite-3]

2025-04-01 Thread via GitHub
isapego opened a new pull request, #5540: URL: https://github.com/apache/ignite-3/pull/5540 https://issues.apache.org/jira/browse/IGNITE-24982 Added missing headers to public list. Filed a ticket to prevent problems like this one in the future: https://issues.apache.org/jira/br

[PR] IGNITE-24976 Sql. Optimize sql row materialization [ignite-3]

2025-04-01 Thread via GitHub
AMashenkov opened a new pull request, #5536: URL: https://github.com/apache/ignite-3/pull/5536 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022573722 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022601723 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.h: ## @@ -0,0 +1,85 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022689467 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.h: ## @@ -0,0 +1,85 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022690671 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego merged PR #5532: URL: https://github.com/apache/ignite-3/pull/5532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-24982 C++: Add missing headers to public [ignite-3]

2025-04-01 Thread via GitHub
isapego merged PR #5540: URL: https://github.com/apache/ignite-3/pull/5540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

[PR] IGNITE-22485 Rename deployment.deploymentLocation config value to deployment.location [ignite-3]

2025-04-01 Thread via GitHub
valepakh opened a new pull request, #5543: URL: https://github.com/apache/ignite-3/pull/5543 https://issues.apache.org/jira/browse/IGNITE-22485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-01 Thread via GitHub
ascherbakoff commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022356531 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransactions.java: ## @@ -73,19 +78,35 @@ static CompletableFuture beginAsync(

[PR] IGNITE-24986 Fixed throttling properties parsing and error message [ignite-3]

2025-04-01 Thread via GitHub
ibessonov opened a new pull request, #5545: URL: https://github.com/apache/ignite-3/pull/5545 https://issues.apache.org/jira/browse/IGNITE-24986 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022573722 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-24949 Refactor createTableLocally [ignite-3]

2025-04-01 Thread via GitHub
rpuch merged PR #5512: URL: https://github.com/apache/ignite-3/pull/5512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022596886 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022592310 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022598412 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-01 Thread via GitHub
isapego commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022605447 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-01 Thread via GitHub
ascherbakoff commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022355683 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransactions.java: ## @@ -73,19 +78,35 @@ static CompletableFuture beginAsync(

[PR] IGNITE-24975 Optimize BinaryTuple offset calculation [ignite-3]

2025-04-01 Thread via GitHub
AMashenkov opened a new pull request, #5535: URL: https://github.com/apache/ignite-3/pull/5535 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24949 Refactor createTableLocally [ignite-3]

2025-04-01 Thread via GitHub
Phillippko commented on code in PR #5512: URL: https://github.com/apache/ignite-3/pull/5512#discussion_r2022164592 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableAssignmentsManager.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Softwa