valepakh opened a new pull request, #5541:
URL: https://github.com/apache/ignite-3/pull/5541
https://issues.apache.org/jira/browse/IGNITE-22489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ibessonov opened a new pull request, #5542:
URL: https://github.com/apache/ignite-3/pull/5542
https://issues.apache.org/jira/browse/IGNITE-24985
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022592310
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
Vladsz83 opened a new pull request, #11977:
URL: https://github.com/apache/ignite/pull/11977
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### Th
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022335542
##
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientRecordSerializer.java:
##
@@ -126,10 +134,11 @@ void writeRecs(
@Nullab
mpoeter commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022759815
##
modules/platforms/cpp/ignite/client/detail/sql/sql_impl.cpp:
##
@@ -88,8 +89,28 @@ void write_args(protocol::writer &writer, const
std::vector &args) {
writer
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022790027
##
modules/platforms/cpp/ignite/client/sql/sql.h:
##
@@ -44,49 +45,57 @@ class sql {
sql() = delete;
/**
- * Executes single SQL statement asynchronous
valepakh opened a new pull request, #5539:
URL: https://github.com/apache/ignite-3/pull/5539
https://issues.apache.org/jira/browse/IGNITE-22487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022790027
##
modules/platforms/cpp/ignite/client/sql/sql.h:
##
@@ -44,49 +45,57 @@ class sql {
sql() = delete;
/**
- * Executes single SQL statement asynchronous
rpuch opened a new pull request, #5534:
URL: https://github.com/apache/ignite-3/pull/5534
https://issues.apache.org/jira/browse/IGNITE-24973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
rpuch merged PR #5534:
URL: https://github.com/apache/ignite-3/pull/5534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
vldpyatkov commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022412887
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##
@@ -499,7 +502,7 @@ private ReadOnlyTransactionImpl beginReadOnlyTra
AMashenkov merged PR #5493:
URL: https://github.com/apache/ignite-3/pull/5493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
vldpyatkov commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022455407
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##
@@ -888,6 +873,48 @@ public int pending() {
return startedT
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022817067
##
modules/platforms/cpp/ignite/client/detail/sql/sql_impl.cpp:
##
@@ -88,8 +89,28 @@ void write_args(protocol::writer &writer, const
std::vector &args) {
writer
isapego opened a new pull request, #5540:
URL: https://github.com/apache/ignite-3/pull/5540
https://issues.apache.org/jira/browse/IGNITE-24982
Added missing headers to public list.
Filed a ticket to prevent problems like this one in the future:
https://issues.apache.org/jira/br
AMashenkov opened a new pull request, #5536:
URL: https://github.com/apache/ignite-3/pull/5536
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
mpoeter commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022573722
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022601723
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.h:
##
@@ -0,0 +1,85 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
mpoeter commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022689467
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.h:
##
@@ -0,0 +1,85 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022690671
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
isapego merged PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ign
isapego merged PR #5540:
URL: https://github.com/apache/ignite-3/pull/5540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ign
valepakh opened a new pull request, #5543:
URL: https://github.com/apache/ignite-3/pull/5543
https://issues.apache.org/jira/browse/IGNITE-22485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022356531
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransactions.java:
##
@@ -73,19 +78,35 @@ static CompletableFuture beginAsync(
ibessonov opened a new pull request, #5545:
URL: https://github.com/apache/ignite-3/pull/5545
https://issues.apache.org/jira/browse/IGNITE-24986
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
mpoeter commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022573722
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
rpuch merged PR #5512:
URL: https://github.com/apache/ignite-3/pull/5512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022596886
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022592310
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022598412
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
isapego commented on code in PR #5532:
URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022605447
##
modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp:
##
@@ -0,0 +1,121 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or mo
ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2022355683
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransactions.java:
##
@@ -73,19 +78,35 @@ static CompletableFuture beginAsync(
AMashenkov opened a new pull request, #5535:
URL: https://github.com/apache/ignite-3/pull/5535
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
Phillippko commented on code in PR #5512:
URL: https://github.com/apache/ignite-3/pull/5512#discussion_r2022164592
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableAssignmentsManager.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Softwa
35 matches
Mail list logo