Vladsz83 opened a new pull request, #11850:
URL: https://github.com/apache/ignite/pull/11850
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
AMashenkov merged PR #5176:
URL: https://github.com/apache/ignite-3/pull/5176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Vladsz83 opened a new pull request, #11851:
URL: https://github.com/apache/ignite/pull/11851
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
xtern merged PR #5178:
URL: https://github.com/apache/ignite-3/pull/5178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
lowka commented on PR #5175:
URL: https://github.com/apache/ignite-3/pull/5175#issuecomment-2636348174
@PakhomovAlexander How can one configure this to run with specific values of
`@Param`s etc from a command line?
--
This is an automated message from the Apache Git Service.
To respond to
lowka commented on PR #5175:
URL: https://github.com/apache/ignite-3/pull/5175#issuecomment-2637262021
I would consider such behaviour counter-intuitive (At least I didn't expect
that). It is possible to run tests multiple times using the same command w/o
modifying any code.
--
This
nevdmitry opened a new pull request, #5183:
URL: https://github.com/apache/ignite-3/pull/5183
https://issues.apache.org/jira/browse/IGNITE-24416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ivanzlenko commented on code in PR #5184:
URL: https://github.com/apache/ignite-3/pull/5184#discussion_r1944192466
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2098,14 +2106,24 @@ protected CompletableFuture
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2639044834
## [](https://son
rpuch commented on code in PR #5166:
URL: https://github.com/apache/ignite-3/pull/5166#discussion_r1942997864
##
modules/configuration-api/src/main/java/org/apache/ignite/configuration/validation/ConfigurationValidationException.java:
##
@@ -41,7 +41,7 @@ public ConfigurationVal
timoninmaxim commented on code in PR #11841:
URL: https://github.com/apache/ignite/pull/11841#discussion_r1940770455
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/filename/NodeFileTree.java:
##
@@ -222,6 +277,26 @@ public File mkdirBinaryM
ygerzhedovich commented on code in PR #5119:
URL: https://github.com/apache/ignite-3/pull/5119#discussion_r1942703218
##
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java:
##
@@ -547,6 +597,133 @@ public static HybridTimestamp
clusterWi
Pochatkin merged PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
korlov42 merged PR #5165:
URL: https://github.com/apache/ignite-3/pull/5165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2637560576
## [](https://son
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2637515357
## [](https://son
ivanzlenko commented on code in PR #5184:
URL: https://github.com/apache/ignite-3/pull/5184#discussion_r1944179739
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2098,7 +2098,14 @@ protected CompletableFuture
e
tkalkirill commented on code in PR #5184:
URL: https://github.com/apache/ignite-3/pull/5184#discussion_r1944183637
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -898,8 +898,12 @@ public CompletableFuture get(Bin
zstan commented on code in PR #5145:
URL: https://github.com/apache/ignite-3/pull/5145#discussion_r1944245272
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BinaryInsertCoercionTest.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the A
zstan commented on code in PR #5145:
URL: https://github.com/apache/ignite-3/pull/5145#discussion_r1944245640
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##
@@ -235,6 +236,23 @@ public void testWithDifferentPa
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2639069800
## [](https://son
FewJuho opened a new pull request, #11855:
URL: https://github.com/apache/ignite/pull/11855
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943468073
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2128,13 +2149,21 @@ public CompletableFuture estimate
sonarqubecloud[bot] commented on PR #11854:
URL: https://github.com/apache/ignite/pull/11854#issuecomment-2638082643
## [](https://son
sonarqubecloud[bot] commented on PR #11854:
URL: https://github.com/apache/ignite/pull/11854#issuecomment-2638108630
## [](https://son
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2637249622
## [](https://son
wwwjames opened a new issue, #11853:
URL: https://github.com/apache/ignite/issues/11853
`org.apache.ignite.internal.util.GridUnsafe.objectFieldOffset(Field)` and
`staticFieldOffset(Field) `will throw an `UnsupportedOperationException` for
records since they use the matching (and deprecated
wwwjames commented on issue #11853:
URL: https://github.com/apache/ignite/issues/11853#issuecomment-2637903407
Tested with Java21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943112865
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/TableScanNodeExecutionTest.java:
##
@@ -263,7 +263,8 @@ private static class TestInte
sanpwc commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943375705
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/TableAware.java:
##
@@ -20,9 +20,10 @@
import org.apache.ignite.internal.network.Netw
sonarqubecloud[bot] commented on PR #11854:
URL: https://github.com/apache/ignite/pull/11854#issuecomment-2638177238
## [](https://son
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943002147
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/TableAware.java:
##
@@ -20,9 +20,10 @@
import org.apache.ignite.internal.network.Netw
rpuch commented on code in PR #5173:
URL: https://github.com/apache/ignite-3/pull/5173#discussion_r1943010738
##
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##
@@ -1205,36 +1205,41 @@ private C
ygerzhedovich commented on code in PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167#discussion_r1943013731
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##
@@ -197,6 +205,8 @@ public DdlSqlToComman
JAkutenshi commented on code in PR #5173:
URL: https://github.com/apache/ignite-3/pull/5173#discussion_r1943047302
##
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##
@@ -1205,36 +1205,41 @@ priv
sanpwc commented on code in PR #5159:
URL: https://github.com/apache/ignite-3/pull/5159#discussion_r1942966517
##
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apa
valepakh commented on code in PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167#discussion_r1943030018
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##
@@ -197,6 +205,8 @@ public DdlSqlToCommandConv
lowka commented on PR #5175:
URL: https://github.com/apache/ignite-3/pull/5175#issuecomment-2637091041
Looks like it not possible to run a benchmark multiple times w/o any code
modifications
Initial run (reduced the number of iterations to get the results a wee bit
faster)
```
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2637619596
## [](https://son
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2637641444
## [](https://son
nizhikov opened a new pull request, #11854:
URL: https://github.com/apache/ignite/pull/11854
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### Th
sonarqubecloud[bot] commented on PR #11854:
URL: https://github.com/apache/ignite/pull/11854#issuecomment-2638001928
## [](https://son
PakhomovAlexander commented on PR #5175:
URL: https://github.com/apache/ignite-3/pull/5175#issuecomment-2637226008
> Looks like it not possible to run a benchmark multiple times w/o any code
modifications
>
> Initial run (reduced the number of iterations to get the results a wee bit
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943461839
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItColocationTest.java:
##
@@ -233,6 +233,7 @@ public CompletableFuture finish(
Map g
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943458492
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/TableAware.java:
##
@@ -20,9 +20,10 @@
import org.apache.ignite.internal.network.Netw
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943468073
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2128,13 +2149,21 @@ public CompletableFuture estimate
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943472809
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java:
##
@@ -106,7 +105,7 @@ public void testZ
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943474490
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/TableAware.java:
##
@@ -20,9 +20,10 @@
import org.apache.ignite.internal.network.Netw
sk0x50 commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1943475382
##
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##
@@ -716,6 +716,55 @@ void
test
Phillippko commented on code in PR #5166:
URL: https://github.com/apache/ignite-3/pull/5166#discussion_r1944117643
##
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java:
##
@@ -0,0 +1,259 @@
+/*
+ * Licen
Phillippko commented on code in PR #5166:
URL: https://github.com/apache/ignite-3/pull/5166#discussion_r1944117817
##
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/ConfigurationDuplicatesValidator.java:
##
@@ -0,0 +1,259 @@
+/*
+ * Licen
sanpwc commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1944124632
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java:
##
@@ -106,7 +105,7 @@ public void testZ
sanpwc commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1944124337
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2128,13 +2149,21 @@ public CompletableFuture estimate
sanpwc commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1944123412
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItColocationTest.java:
##
@@ -233,6 +233,7 @@ public CompletableFuture finish(
Map g
ivanzlenko opened a new pull request, #5184:
URL: https://github.com/apache/ignite-3/pull/5184
https://issues.apache.org/jira/browse/IGNITE-24423
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask bot
tkalkirill commented on code in PR #5184:
URL: https://github.com/apache/ignite-3/pull/5184#discussion_r1944147970
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -2098,7 +2098,14 @@ protected CompletableFuture
e
sk0x50 commented on issue #11836:
URL: https://github.com/apache/ignite/issues/11836#issuecomment-2636578824
Hello @vitthalbywar-tibco ,
> Is this not a correct expectation that until the first transaction
complete(delete), second query should return either count before delete
transa
JAkutenshi commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1942848658
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItColocationTest.java:
##
@@ -341,6 +341,7 @@ public NetworkMessage clone() {
JAkutenshi commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1942862483
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItColocationTest.java:
##
@@ -341,6 +341,7 @@ public NetworkMessage clone() {
AMashenkov merged PR #5163:
URL: https://github.com/apache/ignite-3/pull/5163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
sonarqubecloud[bot] commented on PR #11841:
URL: https://github.com/apache/ignite/pull/11841#issuecomment-2636594248
## [](https://son
IgGusev opened a new pull request, #5181:
URL: https://github.com/apache/ignite-3/pull/5181
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
##
korlov42 opened a new pull request, #5182:
URL: https://github.com/apache/ignite-3/pull/5182
https://issues.apache.org/jira/browse/IGNITE-24418
--
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we
nizhikov merged PR #11841:
URL: https://github.com/apache/ignite/pull/11841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
korlov42 commented on code in PR #5145:
URL: https://github.com/apache/ignite-3/pull/5145#discussion_r1942738701
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/utils/BinaryPair.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache
lowka commented on code in PR #5119:
URL: https://github.com/apache/ignite-3/pull/5119#discussion_r1942799191
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java:
##
@@ -85,8 +85,14 @@ public interface IgniteResource {
@BaseMes
sonarqubecloud[bot] commented on PR #11852:
URL: https://github.com/apache/ignite/pull/11852#issuecomment-2636921729
## [](https://son
ygerzhedovich commented on code in PR #5119:
URL: https://github.com/apache/ignite-3/pull/5119#discussion_r1942977228
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteResource.java:
##
@@ -85,8 +85,14 @@ public interface IgniteResource {
JAkutenshi commented on PR #5173:
URL: https://github.com/apache/ignite-3/pull/5173#issuecomment-2636926877
Hm, it calls `PartitionReplicaLifecycleManager#stopPartition()`, yes, but
now the method indeed just stops zone replica and doesn't fire the
corresponding destruction local event, so
nizhikov opened a new pull request, #11852:
URL: https://github.com/apache/ignite/pull/11852
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### Th
70 matches
Mail list logo
