Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-28 Thread via GitHub
xtern merged PR #5113: URL: https://github.com/apache/ignite-3/pull/5113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
ygerzhedovich commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932413903 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -67,6 +71,7 @@ void before(

Re: [PR] IGNITE-24157 LastArchivedSegment metric for WAL archive [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11794: URL: https://github.com/apache/ignite/pull/11794#issuecomment-2619409595 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-24333 Extract Node class from ItReplicaLifecycleTest [ignite-3]

2025-01-28 Thread via GitHub
sashapolo opened a new pull request, #5131: URL: https://github.com/apache/ignite-3/pull/5131 https://issues.apache.org/jira/browse/IGNITE-24333 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
korlov42 commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932288663 ## .idea/codeStyles/Project.xml: ## Review Comment: unrelated changes ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/d

[PR] IGNITE-24317 Move WAL directories to IgniteDirectories [ignite]

2025-01-28 Thread via GitHub
nizhikov opened a new pull request, #11834: URL: https://github.com/apache/ignite/pull/11834 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932460706 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler( /*

[PR] IGNITE-24329 .NET: Fix LazyTransaction observable timestamp [ignite-3]

2025-01-28 Thread via GitHub
ptupitsyn opened a new pull request, #5129: URL: https://github.com/apache/ignite-3/pull/5129 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]

2025-01-28 Thread via GitHub
isapego commented on code in PR #5127: URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931817087 ## modules/platforms/python/CMakeLists.txt: ## @@ -16,7 +16,7 @@ # cmake_minimum_required(VERSION 3.18) -project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CXX)

Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]

2025-01-28 Thread via GitHub
ptupitsyn commented on code in PR #5127: URL: https://github.com/apache/ignite-3/pull/5127#discussion_r1931877159 ## modules/platforms/python/CMakeLists.txt: ## @@ -16,7 +16,7 @@ # cmake_minimum_required(VERSION 3.18) -project(pyignite3 VERSION ${IGNITE_VERSION} LANGUAGES CX

Re: [PR] IGNITE-24118 Investigate performance drop on master. [ignite-3]

2025-01-28 Thread via GitHub
vldpyatkov merged PR #5128: URL: https://github.com/apache/ignite-3/pull/5128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2618546294 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24324 DB API: Re-name package to pyignite-dbapi [ignite-3]

2025-01-28 Thread via GitHub
isapego merged PR #5127: URL: https://github.com/apache/ignite-3/pull/5127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

[PR] IGNITE-24325 Jdbc. Fix flaky ItJdbcMultiStatementSelfTest.testAutoCommitFalseTxControlStatementsNotSupported [ignite-3]

2025-01-28 Thread via GitHub
korlov42 opened a new pull request, #5130: URL: https://github.com/apache/ignite-3/pull/5130 https://issues.apache.org/jira/browse/IGNITE-24325 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2618772545 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-23085 Out of Memory preventive actions at startup [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11502: URL: https://github.com/apache/ignite/pull/11502#issuecomment-2618875438 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24325 Jdbc. Fix flaky ItJdbcMultiStatementSelfTest.testAutoCommitFalseTxControlStatementsNotSupported [ignite-3]

2025-01-28 Thread via GitHub
korlov42 merged PR #5130: URL: https://github.com/apache/ignite-3/pull/5130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1932096998 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() { * @p

Re: [PR] IGNITE-23085 Out of Memory preventive actions at startup [ignite]

2025-01-28 Thread via GitHub
petrov-mg merged PR #11502: URL: https://github.com/apache/ignite/pull/11502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24247 Indexes created with table must be created in AVAILABLE state [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5113: URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1932096998 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java: ## @@ -93,7 +94,7 @@ public String toString() { * @p

Re: [PR] [IGNITE-24262] AssertionError in ClusterTimeImpl.startSafeTimeScheduler [ignite-3]

2025-01-28 Thread via GitHub
sashapolo merged PR #5101: URL: https://github.com/apache/ignite-3/pull/5101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24319 Add RELEASE_NOTES [ignite-3]

2025-01-28 Thread via GitHub
ptupitsyn merged PR #5125: URL: https://github.com/apache/ignite-3/pull/5125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24298 DB API: Fix invalid freeing of an object [ignite-3]

2025-01-28 Thread via GitHub
isapego merged PR #5126: URL: https://github.com/apache/ignite-3/pull/5126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-24329 .NET: Fix LazyTransaction observable timestamp [ignite-3]

2025-01-28 Thread via GitHub
ptupitsyn merged PR #5129: URL: https://github.com/apache/ignite-3/pull/5129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24153: Sql. Dml. It is not possible to insert a varchar string that is longer than 65536 characters [ignite-3]

2025-01-28 Thread via GitHub
korlov42 commented on code in PR #5119: URL: https://github.com/apache/ignite-3/pull/5119#discussion_r1932004160 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java: ## @@ -116,12 +116,17 @@ public class CatalogUtils { public stati

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2618403305 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24274: Sql. Inbox does not handle closing properly [ignite-3]

2025-01-28 Thread via GitHub
ygerzhedovich merged PR #5103: URL: https://github.com/apache/ignite-3/pull/5103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11833: URL: https://github.com/apache/ignite/pull/11833#issuecomment-2618954672 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24317 Move WAL directories to IgniteDirectories [ignite]

2025-01-28 Thread via GitHub
sonarqubecloud[bot] commented on PR #11834: URL: https://github.com/apache/ignite/pull/11834#issuecomment-2619617523 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24157 LastArchivedSegment metric for WAL archive [ignite]

2025-01-28 Thread via GitHub
NSAmelchev merged PR #11794: URL: https://github.com/apache/ignite/pull/11794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932460706 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler( /*

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932460706 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler( /*

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932460706 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler( /*

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
xtern commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1932460706 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler( /*

Re: [PR] IGNITE-24336 : Calcite. Add support of user-defined table functions. [ignite]

2025-01-28 Thread via GitHub
alex-plekhanov commented on code in PR #11832: URL: https://github.com/apache/ignite/pull/11832#discussion_r1933324657 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ArrayRowHandler.java: ## @@ -72,6 +73,34 @@ private ArrayRowHandler()

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
korlov42 commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1933358048 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -67,6 +71,7 @@ void before() {

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
korlov42 commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1933358048 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -67,6 +71,7 @@ void before() {

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
korlov42 commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1933367687 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler(

[PR] IGNITE-24337 Don't throw NoSuchFileException in IgniteUtils.deleteIfExistsThrowable [ignite-3]

2025-01-28 Thread via GitHub
Phillippko opened a new pull request, #5132: URL: https://github.com/apache/ignite-3/pull/5132 https://issues.apache.org/jira/browse/IGNITE-24337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-24333 Extract Node class from ItReplicaLifecycleTest [ignite-3]

2025-01-28 Thread via GitHub
sashapolo merged PR #5131: URL: https://github.com/apache/ignite-3/pull/5131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] ignite-22197 Move ifExists flag handling inside a Catalog [ignite-3]

2025-01-28 Thread via GitHub
ygerzhedovich commented on code in PR #5121: URL: https://github.com/apache/ignite-3/pull/5121#discussion_r1933405831 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandler.java: ## @@ -134,115 +127,102 @@ public DdlCommandHandler(