[PR] IGNITE-23595 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill opened a new pull request, #4679: URL: https://github.com/apache/ignite-3/pull/4679 https://issues.apache.org/jira/browse/IGNITE-23595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829303913 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/descriptors/CatalogZoneDescriptorTest.java: ## @@ -39,7 +39,8 @@ void toStringContainsTypeAndFields(

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829310316 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateFromDefinitionImpl.java: ## @@ -84,6 +84,10 @@ CreateFromDefinitionImpl from(ZoneDefin

Re: [PR] IGNITE-23602 Add metastorage compaction revision check to divergency validation [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill closed pull request #4676: IGNITE-23602 Add metastorage compaction revision check to divergency validation URL: https://github.com/apache/ignite-3/pull/4676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] IGNITE-23594 WIP [ignite]

2024-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #11642: URL: https://github.com/apache/ignite/pull/11642#issuecomment-2456920427 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23610 Log WriteCommand class when logging about long WriteActionRequest processing [ignite-3]

2024-11-05 Thread via GitHub
rpuch opened a new pull request, #4678: URL: https://github.com/apache/ignite-3/pull/4678 https://issues.apache.org/jira/browse/IGNITE-23610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
kgusakov commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829252414 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/ConsistencyMode.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-05 Thread via GitHub
ibessonov merged PR #4668: URL: https://github.com/apache/ignite-3/pull/4668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23596 Start of Metastorage Raft node blocks a network thread [ignite-3]

2024-11-05 Thread via GitHub
rpuch merged PR #4673: URL: https://github.com/apache/ignite-3/pull/4673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
ibessonov commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1829357242 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java: ## @@ -1080,15 +1080,28 @@ clas

Re: [PR] IGNITE-23610 Log WriteCommand class when logging about long WriteActionRequest processing [ignite-3]

2024-11-05 Thread via GitHub
rpuch merged PR #4678: URL: https://github.com/apache/ignite-3/pull/4678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23614 Declare IGNITE3_EXTRA_JVM_ARGS as an ENV variable in Dockerfile [ignite-3]

2024-11-05 Thread via GitHub
rpuch merged PR #4680: URL: https://github.com/apache/ignite-3/pull/4680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23591 Fix entry and checkpoint locks orders [ignite]

2024-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #11641: URL: https://github.com/apache/ignite/pull/11641#issuecomment-2457410889 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

2024-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2457483018 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829643033 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CreateZoneCommand.java: ## @@ -245,6 +254,13 @@ public CreateZoneCommandBuilder storagePro

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829647098 ## modules/api/src/main/java/org/apache/ignite/catalog/definitions/ZoneDefinition.java: ## @@ -43,6 +43,8 @@ public class ZoneDefinition { private final String s

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828854759 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java: ## @@ -528,7 +539,8 @@ private void executeWithArguments(JdbcStatem

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828854759 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java: ## @@ -528,7 +539,8 @@ private void executeWithArguments(JdbcStatem

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828918971 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23446 Fix false-positive hasNext flag returned from sql cursor [ignite-3]

2024-11-05 Thread via GitHub
ygerzhedovich commented on code in PR #4662: URL: https://github.com/apache/ignite-3/pull/4662#discussion_r1828965057 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/AsyncRootNodeTest.java: ## @@ -78,8 +93,115 @@ void ensurePrefetchFutureIsNotC

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828922616 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBlob.java: ## @@ -134,57 +160,113 @@ public JdbcBlob(byte[] arr) { @Override public int setByt

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828922325 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBlob.java: ## @@ -134,57 +160,113 @@ public JdbcBlob(byte[] arr) { @Override public int setByt

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828929369 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlInputStreamWrapper.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828928318 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828928751 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlInputStreamWrapper.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828938146 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23446 Fix false-positive hasNext flag returned from sql cursor [ignite-3]

2024-11-05 Thread via GitHub
ygerzhedovich commented on code in PR #4662: URL: https://github.com/apache/ignite-3/pull/4662#discussion_r1828941004 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/AsyncRootNodeTest.java: ## @@ -78,8 +93,115 @@ void ensurePrefetchFutureIsNotC

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828917999 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

[PR] IGNITE-23602 Add metastorage compaction revision check to divergency validation [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill opened a new pull request, #4676: URL: https://github.com/apache/ignite-3/pull/4676 https://issues.apache.org/jira/browse/IGNITE-23602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-20322 Add ability to pass an observable timestamp to an implicit transaction [ignite-3]

2024-11-05 Thread via GitHub
vldpyatkov commented on PR #2537: URL: https://github.com/apache/ignite-3/pull/2537#issuecomment-2456724134 Incorrect TC runs were attached. https://ci.ignite.apache.org/buildConfiguration/ApacheIgnite3xGradle_Test_RunAllTests?branch=pull%2F2537&buildTypeTab=overview&mode=builds -- Thi

Re: [PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-05 Thread via GitHub
rpuch commented on code in PR #4668: URL: https://github.com/apache/ignite-3/pull/4668#discussion_r1829073687 ## packaging/docker/docker-compose.yml: ## @@ -20,6 +20,9 @@ name: ignite3 x-ignite-def: &ignite-def image: apacheignite/ignite3:${IGNITE3_VERSION:-latest} + env

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

2024-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2457326600 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23614 Declare IGNITE3_EXTRA_JVM_ARGS as an ENV variable in Dockerfile [ignite-3]

2024-11-05 Thread via GitHub
rpuch opened a new pull request, #4680: URL: https://github.com/apache/ignite-3/pull/4680 https://issues.apache.org/jira/browse/IGNITE-23614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23591 Fix entry and checkpoint locks orders [ignite]

2024-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #11641: URL: https://github.com/apache/ignite/pull/11641#issuecomment-2457465365 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829658796 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/ConsistencyMode.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829678777 ## modules/api/src/main/java/org/apache/ignite/catalog/annotations/Zone.java: ## @@ -90,4 +90,11 @@ * @return Nodes filter. */ String filter() default

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

2024-11-05 Thread via GitHub
chesnokoff closed pull request #11615: IGNITE-23472 Fix JavaLogger URL: https://github.com/apache/ignite/pull/11615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829652358 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java: ## @@ -189,6 +193,20 @@ public DdlSqlToCommandConve

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829668090 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CreateZoneCommand.java: ## @@ -136,7 +142,8 @@ private CatalogZoneDescriptor descriptor(int

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-05 Thread via GitHub
shishkovilja commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1829683730 ## modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java: ## @@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function longMetric, Func

Re: [PR] IGNITE-23592 Align serialization methods of HybridTimestamp [ignite-3]

2024-11-05 Thread via GitHub
rpuch commented on code in PR #4670: URL: https://github.com/apache/ignite-3/pull/4670#discussion_r1828904136 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -131,7 +132,18 @@ public static long hybridTimestampToLong(@Nullable HybridTime

Re: [PR] IGNITE-23592 Align serialization methods of HybridTimestamp [ignite-3]

2024-11-05 Thread via GitHub
rpuch commented on code in PR #4670: URL: https://github.com/apache/ignite-3/pull/4670#discussion_r1828904774 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -256,8 +268,21 @@ public HybridTimestamp roundUpToPhysicalTick() { /**

Re: [PR] IGNITE-23592 Align serialization methods of HybridTimestamp [ignite-3]

2024-11-05 Thread via GitHub
ivanzlenko commented on PR #4670: URL: https://github.com/apache/ignite-3/pull/4670#issuecomment-2456523297 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828921064 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828920619 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828915980 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828923177 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBlob.java: ## @@ -18,54 +18,80 @@ package org.apache.ignite.internal.jdbc2; import java.io.Byte

Re: [PR] IGNITE-23592 Align serialization methods of HybridTimestamp [ignite-3]

2024-11-05 Thread via GitHub
ivanzlenko commented on code in PR #4670: URL: https://github.com/apache/ignite-3/pull/4670#discussion_r1828914990 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -131,7 +132,18 @@ public static long hybridTimestampToLong(@Nullable Hybri

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828924233 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinResultSet.java: ## @@ -472,6 +474,9 @@ else if (cls == String.class || cls == Character.cla

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828925861 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] IGNITE-23169 Conflict put/remove cache operations metrics [ignite]

2024-11-05 Thread via GitHub
maksaska commented on code in PR #11627: URL: https://github.com/apache/ignite/pull/11627#discussion_r1829000141 ## modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsConflictOperationsTest.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-23169 Conflict put/remove cache operations metrics [ignite]

2024-11-05 Thread via GitHub
maksaska commented on code in PR #11627: URL: https://github.com/apache/ignite/pull/11627#discussion_r1828999593 ## modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsConflictOperationsTest.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[PR] Ignite 20322-2 [ignite-3]

2024-11-05 Thread via GitHub
vldpyatkov opened a new pull request, #4677: URL: https://github.com/apache/ignite-3/pull/4677 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] GG-40402 Concept of implicit transaction based on observable timestamp [ignite-3]

2024-11-05 Thread via GitHub
vldpyatkov closed pull request #4636: GG-40402 Concept of implicit transaction based on observable timestamp URL: https://github.com/apache/ignite-3/pull/4636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] IGNITE-23446 Fix false-positive hasNext flag returned from sql cursor [ignite-3]

2024-11-05 Thread via GitHub
korlov42 merged PR #4662: URL: https://github.com/apache/ignite-3/pull/4662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1829025957 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1829027489 ## modules/api/src/main/java/org/apache/ignite/lang/CancelHandleImpl.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1829026781 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItQueryCancelTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828880676 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1829026406 ## modules/core/src/main/java/org/apache/ignite/internal/util/Cancellable.java: ## @@ -27,4 +29,9 @@ public interface Cancellable { * @param timeout If process was

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829078516 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-05 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1829104910 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -44,61 +47,83 @@ import org.apache.ignite.i

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829120814 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829120814 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829124699 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829124699 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829125526 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23592 Align serialization methods of HybridTimestamp [ignite-3]

2024-11-05 Thread via GitHub
rpuch merged PR #4670: URL: https://github.com/apache/ignite-3/pull/4670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829080117 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-05 Thread via GitHub
zstan commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1828879749 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java: ## @@ -145,203 +143,212 @@ private CompletableFuture> ma

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-05 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1829117885 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -44,61 +47,83 @@ import org.apache.ignite.i

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829117718 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-05 Thread via GitHub
nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1829118203 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-05 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1829121459 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -44,61 +47,83 @@ import org.apache.ignite.i

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829795672 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -43,6 +44,74 @@ * Test SQL data typ

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829790918 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -333,16 +325,142 @@ public static byte convertT

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829810235 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -308,17 +297,20 @@ public static short convertT

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829810449 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -308,17 +297,20 @@ public static short convertT

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-05 Thread via GitHub
Cyrill commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829771783 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateFromDefinitionImpl.java: ## @@ -84,6 +84,10 @@ CreateFromDefinitionImpl from(ZoneDefin

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
Vladsz83 commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829819044 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -43,6 +44,74 @@ * Test SQL data types.

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829797075 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -43,6 +44,74 @@ * Test SQL data typ

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics v2 [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11644: URL: https://github.com/apache/ignite/pull/11644#discussion_r1829812592 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -43,6 +44,76 @@ * Test SQL data typ

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
Vladsz83 commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829815537 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -333,16 +325,142 @@ public static byte convertToByteE

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-05 Thread via GitHub
Vladsz83 commented on code in PR #11635: URL: https://github.com/apache/ignite/pull/11635#discussion_r1829815928 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -308,17 +297,20 @@ public static short convertToShort

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics v2 [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11644: URL: https://github.com/apache/ignite/pull/11644#discussion_r1829786854 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -283,14 +269,13 @@ public static int convertToI

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics v2 [ignite]

2024-11-05 Thread via GitHub
alex-plekhanov commented on code in PR #11644: URL: https://github.com/apache/ignite/pull/11644#discussion_r1830016716 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java: ## @@ -252,9 +252,11 @@ public static long convertToL

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830357315 ## modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/flush/RocksDbFlusher.java: ## @@ -41,8 +43,8 @@ import org.rocksdb.RocksDBException;

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830493832 ## modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/flush/RocksDbFlusher.java: ## @@ -279,6 +281,18 @@ public void stop() { * @return F

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-05 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1830444381 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +198,66 @@ public void te

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-05 Thread via GitHub
zstan commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1830456882 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -44,61 +47,83 @@ import org.apache.ignite.intern

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830357508 ## modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/flush/RocksDbFlusher.java: ## @@ -279,6 +281,18 @@ public void stop() { * @return F

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-05 Thread via GitHub
zstan commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1830413143 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -44,61 +47,83 @@ import org.apache.ignite.intern

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
tkalkirill commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830432042 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -688,13 +688,22 @@ public class IgniteImpl implements Ignite { RaftGr

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
ibessonov commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830480321 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -279,8 +301,17 @@ public RocksDbKey

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1830483081 ## modules/api/src/main/java/org/apache/ignite/lang/CancellationToken.java: ## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] Restrict substring args to INTEGER type family [ignite-3]

2024-11-05 Thread via GitHub
lowka closed pull request #3828: Restrict substring args to INTEGER type family URL: https://github.com/apache/ignite-3/pull/3828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Replaces a cast to CHAR(n) with a VARCHAR(n) [ignite-3]

2024-11-05 Thread via GitHub
lowka closed pull request #3909: Replaces a cast to CHAR(n) with a VARCHAR(n) URL: https://github.com/apache/ignite-3/pull/3909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-05 Thread via GitHub
lowka commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1830483334 ## modules/core/src/main/java/org/apache/ignite/internal/util/Cancellable.java: ## @@ -27,4 +29,9 @@ public interface Cancellable { * @param timeout If process was

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-05 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1830477835 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +198,66 @@ public void te

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-05 Thread via GitHub
ibessonov commented on code in PR #4679: URL: https://github.com/apache/ignite-3/pull/4679#discussion_r1830486890 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageListener.java: ## @@ -225,6 +225,7 @@ public void onConfigurationC

  1   2   >