tkalkirill commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221022352
##
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##
@@ -765,4 +781,18 @@ private List
getSortedIndexSt
rpuch commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221006155
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageOperation.java:
##
@@ -109,6 +109,34 @@ String inProcessErrorMessage(String storageIn
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221075045
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageOperation.java:
##
@@ -109,6 +109,34 @@ String inProcessErrorMessage(String stor
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221076805
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/MvPartitionStorages.java:
##
@@ -415,7 +430,15 @@ private String
createStorageInProgre
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221078830
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/MvPartitionStorages.java:
##
@@ -238,14 +240,16 @@ public CompletableFuture startRebala
sashapolo commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221082188
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -436,31 +436,39 @@ private CompletableFuture
onIndexCreate(ConfigurationNot
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221084037
##
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/util/MvPartitionStoragesTest.java:
##
@@ -326,8 +326,6 @@ void testStartRebalance() {
sashapolo commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221084523
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -436,31 +436,39 @@ private CompletableFuture
onIndexCreate(ConfigurationNot
sashapolo commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221086830
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -608,4 +599,54 @@ public CompletableFuture
onUpdate(ConfigurationNotificati
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221087363
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageOperation.java:
##
@@ -109,6 +109,34 @@ String inProcessErrorMessage(String stor
sashapolo commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221088319
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ClusterPerClassIntegrationTest.java:
##
@@ -526,7 +526,7 @@ protected static Map>
w
sashapolo opened a new pull request, #2158:
URL: https://github.com/apache/ignite-3/pull/2158
https://issues.apache.org/jira/browse/IGNITE-19658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
timoninmaxim commented on code in PR #10675:
URL: https://github.com/apache/ignite/pull/10675#discussion_r1221112180
##
modules/core/src/main/java/org/apache/ignite/internal/management/api/CliPositionalSubcommands.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221113719
##
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageOperation.java:
##
@@ -109,6 +109,34 @@ String inProcessErrorMessage(String stor
rpuch commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221124867
##
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/util/MvPartitionStoragesTest.java:
##
@@ -326,8 +326,6 @@ void testStartRebalance() {
tkalkirill commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221125474
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -436,31 +436,39 @@ private CompletableFuture
onIndexCreate(ConfigurationNo
tkalkirill commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221126692
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -436,31 +436,39 @@ private CompletableFuture
onIndexCreate(ConfigurationNo
tkalkirill commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221128770
##
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##
@@ -608,4 +599,54 @@ public CompletableFuture
onUpdate(ConfigurationNotificat
tkalkirill commented on code in PR #2143:
URL: https://github.com/apache/ignite-3/pull/2143#discussion_r1221149497
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ClusterPerClassIntegrationTest.java:
##
@@ -526,7 +526,7 @@ protected static Map>
SammyVimes merged PR #2158:
URL: https://github.com/apache/ignite-3/pull/2158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
tkalkirill merged PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
nizhikov commented on code in PR #10675:
URL: https://github.com/apache/ignite/pull/10675#discussion_r1221196751
##
modules/core/src/main/java/org/apache/ignite/internal/management/api/Command.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
nizhikov commented on code in PR #10675:
URL: https://github.com/apache/ignite/pull/10675#discussion_r1221208755
##
modules/core/src/main/java/org/apache/ignite/internal/management/cache/CacheCommand.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (A
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1580269491
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
rpuch commented on code in PR #2154:
URL: https://github.com/apache/ignite-3/pull/2154#discussion_r1221353399
##
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java:
##
@@ -519,7 +536,7 @@ public void handle(VersionedUpdate update) {
alex-plekhanov commented on code in PR #10768:
URL: https://github.com/apache/ignite/pull/10768#discussion_r1221414869
##
modules/core/src/test/java/org/apache/ignite/internal/managers/communication/IgniteMessageFactoryImplTest.java:
##
@@ -112,6 +132,75 @@ public void testRegis
ibessonov opened a new pull request, #2161:
URL: https://github.com/apache/ignite-3/pull/2161
https://issues.apache.org/jira/browse/IGNITE-19422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
korlov42 commented on code in PR #2047:
URL: https://github.com/apache/ignite-3/pull/2047#discussion_r1221528338
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##
@@ -306,70 +358,46 @@ public void validateAggregateParam
sonarcloud[bot] commented on PR #10732:
URL: https://github.com/apache/ignite/pull/10732#issuecomment-1580771425
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
nizhikov commented on code in PR #10675:
URL: https://github.com/apache/ignite/pull/10675#discussion_r1221561302
##
modules/core/src/main/java/org/apache/ignite/internal/management/api/WithCliConfirmParameter.java:
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foun
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1580789064
SonarCloud Quality Gate failed. [
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1580877059
SonarCloud Quality Gate failed. [ {
assert
AMashenkov commented on code in PR #2159:
URL: https://github.com/apache/ignite-3/pull/2159#discussion_r1221658256
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java:
##
@@ -285,16 +285,37 @@ public void testTypeOf() {
AMashenkov commented on code in PR #2159:
URL: https://github.com/apache/ignite-3/pull/2159#discussion_r1221658256
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java:
##
@@ -285,16 +285,37 @@ public void testTypeOf() {
AMashenkov commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1211722780
##
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##
@@ -164,4 +164,23 @@ public static Class columnTypeToClass(ColumnType type) {
vldpyatkov merged PR #2153:
URL: https://github.com/apache/ignite-3/pull/2153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
sanpwc commented on code in PR #2142:
URL: https://github.com/apache/ignite-3/pull/2142#discussion_r1221695867
##
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/exception/ReplicaStoppingException.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache So
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1580947874
SonarCloud Quality Gate failed. [ {
this
nizhikov commented on code in PR #10675:
URL: https://github.com/apache/ignite/pull/10675#discussion_r1221801192
##
modules/core/src/main/java/org/apache/ignite/internal/management/api/Command.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1581068182
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
petrov-mg merged PR #10768:
URL: https://github.com/apache/ignite/pull/10768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
yurinaryshkin commented on code in PR #10767:
URL: https://github.com/apache/ignite/pull/10767#discussion_r1221975526
##
modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java:
##
@@ -94,11 +97,34 @@ public IndexQuery(Class valCls, @Nullable String
idxName) {
yurinaryshkin commented on code in PR #10767:
URL: https://github.com/apache/ignite/pull/10767#discussion_r1221976007
##
modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java:
##
@@ -0,0 +1,350 @@
+package org.apache.ignite.cache.query;
+
+import
yurinaryshkin commented on code in PR #10767:
URL: https://github.com/apache/ignite/pull/10767#discussion_r1221977577
##
modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryTestSuite.java:
##
@@ -46,7 +46,8 @@
ThinClientIndexQueryTest.class,
Review Comme
sonarcloud[bot] commented on PR #10675:
URL: https://github.com/apache/ignite/pull/10675#issuecomment-1581270273
SonarCloud Quality Gate failed. [ {
return idxName;
alievmirza opened a new pull request, #2165:
URL: https://github.com/apache/ignite-3/pull/2165
https://issues.apache.org/jira/browse/IGNITE-19674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
sonarcloud[bot] commented on PR #10767:
URL: https://github.com/apache/ignite/pull/10767#issuecomment-1581298235
Kudos, SonarCloud Quality Gate passed! [