[GitHub] [ignite] sonarcloud[bot] commented on pull request #10761: IGNITE-19645 Suppress an illegal reflective access runtime warning for JDK11

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10761: URL: https://github.com/apache/ignite/pull/10761#issuecomment-1576177970 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] AMashenkov merged pull request #2085: IGNITE-19460 Sql. Implement missed DDL commands with using Catalog

2023-06-05 Thread via GitHub
AMashenkov merged PR #2085: URL: https://github.com/apache/ignite-3/pull/2085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] nizhikov merged pull request #10750: IGNITE-15629 Cache scan command implemented

2023-06-05 Thread via GitHub
nizhikov merged PR #10750: URL: https://github.com/apache/ignite/pull/10750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10675: IGNITE-15629 Management API introduced

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10675: URL: https://github.com/apache/ignite/pull/10675#issuecomment-1576249208 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2131: IGNITE-19559 NPE in deploy/undeploy calls in non-REPL mode

2023-06-05 Thread via GitHub
valepakh commented on code in PR #2131: URL: https://github.com/apache/ignite-3/pull/2131#discussion_r1217672545 ## modules/cli/src/main/java/org/apache/ignite/internal/cli/call/cluster/unit/DeployUnitReplCall.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2121: IGNITE-19565 Use JobClassLoader for loading job classes

2023-06-05 Thread via GitHub
Pochatkin commented on code in PR #2121: URL: https://github.com/apache/ignite-3/pull/2121#discussion_r1217686673 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -533,6 +528,28 @@ public class IgniteImpl implements Ignite { sql =

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10761: IGNITE-19645 Suppress an illegal reflective access runtime warning for JDK11

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10761: URL: https://github.com/apache/ignite/pull/10761#issuecomment-1576305330 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10752: IGNITE-15629 cache idle_verify command implemented

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10752: URL: https://github.com/apache/ignite/pull/10752#issuecomment-1576314634 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1576346367 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217731149 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTable

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217745926 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTable

[GitHub] [ignite] asfgit closed pull request #10760: IGNITE-19590 SQL Calcite: Add sensitive information hiding when IGNIT…

2023-06-05 Thread via GitHub
asfgit closed pull request #10760: IGNITE-19590 SQL Calcite: Add sensitive information hiding when IGNIT… URL: https://github.com/apache/ignite/pull/10760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217755685 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -491,6 +504,319 @@ public void testAddDropMultipleColumns() {

[GitHub] [ignite-3] xtern commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
xtern commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217769560 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTableDropC

[GitHub] [ignite-3] xtern commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
xtern commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217769560 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTableDropC

[GitHub] [ignite-3] xtern commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
xtern commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217769560 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTableDropC

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217772080 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java: ## @@ -415,6 +423,41 @@ private DefaultValueDef

[GitHub] [ignite-3] xtern commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
xtern commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217769560 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTableDropC

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217772080 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java: ## @@ -415,6 +423,41 @@ private DefaultValueDef

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1576437224 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1576551105 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] xtern commented on a diff in pull request #2105: IGNITE-19407 Sql. Introduce DDL command for ALTER COLUMN TYPE.

2023-06-05 Thread via GitHub
xtern commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1217924312 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -321,6 +341,89 @@ public CompletableFuture dropColumn(AlterTableDropC

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10761: IGNITE-19645 Suppress an illegal reflective access runtime warning for JDK11

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10761: URL: https://github.com/apache/ignite/pull/10761#issuecomment-1576633934 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] vldpyatkov opened a new pull request, #2144: IGNITE-19136 Handling timeout on waiting for replica readiness

2023-06-05 Thread via GitHub
vldpyatkov opened a new pull request, #2144: URL: https://github.com/apache/ignite-3/pull/2144 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10752: IGNITE-15629 cache idle_verify command implemented

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10752: URL: https://github.com/apache/ignite/pull/10752#issuecomment-1576758464 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2121: IGNITE-19565 Use JobClassLoader for loading job classes

2023-06-05 Thread via GitHub
Pochatkin commented on code in PR #2121: URL: https://github.com/apache/ignite-3/pull/2121#discussion_r1218074181 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java: ## @@ -262,8 +262,15 @@ public CompletableFuture statusAsy

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2121: IGNITE-19565 Use JobClassLoader for loading job classes

2023-06-05 Thread via GitHub
Pochatkin commented on code in PR #2121: URL: https://github.com/apache/ignite-3/pull/2121#discussion_r1218078510 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/JobClassLoaderFactory.java: ## @@ -71,22 +67,48 @@ public JobClassLoaderFactory(Function detectL

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2121: IGNITE-19565 Use JobClassLoader for loading job classes

2023-06-05 Thread via GitHub
Pochatkin commented on code in PR #2121: URL: https://github.com/apache/ignite-3/pull/2121#discussion_r1218081042 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/JobClassLoaderFactory.java: ## @@ -71,22 +67,48 @@ public JobClassLoaderFactory(Function detectL

[GitHub] [ignite] wendigo opened a new pull request, #10764: IGNITE-19652 Adapt to DirectByteBuffer ctor changes in JDK 21

2023-06-05 Thread via GitHub
wendigo opened a new pull request, #10764: URL: https://github.com/apache/ignite/pull/10764 Signature has changed in https://github.com/openjdk/jdk/commit/a56598f5a534cc9223367e7faa8433ea38661db9 Thank you for submitting the pull request to the Apache Ignite. In order to stream

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10764: IGNITE-19652 Adapt to DirectByteBuffer ctor changes in JDK 21

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10764: URL: https://github.com/apache/ignite/pull/10764#issuecomment-1576905327 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2131: IGNITE-19559 NPE in deploy/undeploy calls in non-REPL mode

2023-06-05 Thread via GitHub
PakhomovAlexander merged PR #2131: URL: https://github.com/apache/ignite-3/pull/2131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] zstan opened a new pull request, #2145: IGNITE-19493 Sql. Change query execution flow.

2023-06-05 Thread via GitHub
zstan opened a new pull request, #2145: URL: https://github.com/apache/ignite-3/pull/2145 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite] nizhikov merged pull request #10752: IGNITE-15629 cache idle_verify command implemented

2023-06-05 Thread via GitHub
nizhikov merged PR #10752: URL: https://github.com/apache/ignite/pull/10752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10675: IGNITE-15629 Management API introduced

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10675: URL: https://github.com/apache/ignite/pull/10675#issuecomment-1577118863 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10752: IGNITE-15629 cache idle_verify command implemented

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10752: URL: https://github.com/apache/ignite/pull/10752#issuecomment-1577129585 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1577178216 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan commented on a diff in pull request #2047: IGNITE-18831 Sql. Fix dynamic parameters type coercion.

2023-06-05 Thread via GitHub
zstan commented on code in PR #2047: URL: https://github.com/apache/ignite-3/pull/2047#discussion_r1198581363 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java: ## @@ -164,15 +166,30 @@ public void testWithDifferentParam

[GitHub] [ignite-3] Flaugh24 opened a new pull request, #2146: IGNITE-19517 Cache JobClassLoaders

2023-06-05 Thread via GitHub
Flaugh24 opened a new pull request, #2146: URL: https://github.com/apache/ignite-3/pull/2146 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1577566583 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10753: IGNITE-15629 Code cleanup

2023-06-05 Thread via GitHub
sonarcloud[bot] commented on PR #10753: URL: https://github.com/apache/ignite/pull/10753#issuecomment-1577584126 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2147: IGNITE-19653 Fix NPE in log from testRequestsMetrics

2023-06-05 Thread via GitHub
ptupitsyn opened a new pull request, #2147: URL: https://github.com/apache/ignite-3/pull/2147 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] zstan commented on a diff in pull request #2047: IGNITE-18831 Sql. Fix dynamic parameters type coercion.

2023-06-05 Thread via GitHub
zstan commented on code in PR #2047: URL: https://github.com/apache/ignite-3/pull/2047#discussion_r1218919837 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryQueryTest.java: ## @@ -18,17 +18,38 @@ package org.apa

[GitHub] [ignite] hhc109350716 opened a new issue, #10765: Setting TimeZone. setDefault for databases in idea does not work

2023-06-05 Thread via GitHub
hhc109350716 opened a new issue, #10765: URL: https://github.com/apache/ignite/issues/10765 I added TimeZone to the jdbc connection for ignite core SetDefault () was then packaged as a jar and loaded into databases using a custom driver, causing my query to select now (); The results are no