Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-12 Thread via GitHub
zstan merged PR #5751: URL: https://github.com/apache/ignite-3/pull/5751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-12 Thread via GitHub
zstan commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2084103537 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -754,17 +754,43 @@ SqlNode SqlAlterZone() : | ( - { - retur

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-09 Thread via GitHub
korlov42 commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2081568182 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -754,17 +754,43 @@ SqlNode SqlAlterZone() : | ( - { - re

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-07 Thread via GitHub
zstan commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2078046796 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -761,6 +761,10 @@ SqlNode SqlAlterZone() : { s.add(this); } optionList = AlterZoneOptions

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-07 Thread via GitHub
zstan commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2078046528 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlAlterZone.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-07 Thread via GitHub
zstan commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2078045238 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/DistributionZoneSqlDdlParserTest.java: ## @@ -291,13 +291,15 @@ public void alterZoneIfExis

Re: [PR] IGNITE-25159 Sql. Align ALTER ZONE syntax [ignite-3]

2025-05-06 Thread via GitHub
korlov42 commented on code in PR #5751: URL: https://github.com/apache/ignite-3/pull/5751#discussion_r2076890609 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -761,6 +761,10 @@ SqlNode SqlAlterZone() : { s.add(this); } optionList = AlterZoneOpti