Re: [PATCH] Linux packages: reword to mention supported RHEL derivatives

2022-09-28 Thread Konstantin Pavlov
Hi, On 28/09/2022 12:57 AM, Maxim Dounin wrote: Hello! On Tue, Sep 27, 2022 at 04:14:58PM +0400, Konstantin Pavlov wrote: # HG changeset patch # User Konstantin Pavlov # Date 1664280815 -14400 # Tue Sep 27 16:13:35 2022 +0400 # Node ID 9d1eec5b03a4ff9d863ad49b47721d713dcec76f # Parent

Re: [PATCH] fix weakness by logging of broken header by incorect proxy protocol (IDS/IPS/LOG-analysis)

2022-09-28 Thread Roman Arutyunyan
Hi Sergey, On Mon, Sep 26, 2022 at 11:16:05PM +0200, Dipl. Ing. Sergey Brester via nginx-devel wrote: > > > Hi, > > below is a patch to fix a weakness by logging of broken header by > incorrect proxy protocol. > > If some service (IDS/IPS) analyzing or monitoring log-file, regularly > form

Re: [PATCH] fix weakness by logging of broken header by incorect proxy protocol (IDS/IPS/LOG-analysis)

2022-09-28 Thread Dipl. Ing. Sergey Brester via nginx-devel
Sure, this was also my first intention. Just after all I thought the whole buffer could be better in order to provide a possibility to debug for someone searching for a bug. But there are another aids that would help, so indeed let it be so. As for the rest, well it is surely a subject of dif

Re: [PATCH] fix weakness by logging of broken header by incorect proxy protocol (IDS/IPS/LOG-analysis)

2022-09-28 Thread Mathew Heard
I really like the making safe of the error log as opposed to truncation. The more information logged in cases like this the better. Alternatively what about something that indicates further data was truncated? On Wed, 28 Sep 2022, 21:07 Dipl. Ing. Sergey Brester via nginx-devel, < nginx-devel@ngi

Re: [PATCH] fix weakness by logging of broken header by incorect proxy protocol (IDS/IPS/LOG-analysis)

2022-09-28 Thread Roman Arutyunyan
Hi, On Wed, Sep 28, 2022 at 01:07:18PM +0200, Dipl. Ing. Sergey Brester wrote: > > > Sure, this was also my first intention. Just after all I thought the > whole buffer > could be better in order to provide a possibility to debug for someone > searching > for a bug. A possible option would b

Re: [PATCH 11 of 11] SSL: automatic rotation of session ticket keys

2022-09-28 Thread Maxim Dounin
Hello! On Mon, Sep 26, 2022 at 02:17:18PM +0400, Sergey Kandaurov wrote: > > On 17 Sep 2022, at 01:08, Maxim Dounin wrote: > > > > On Thu, Sep 15, 2022 at 09:50:24AM +0400, Sergey Kandaurov wrote: > > > >>> On 26 Aug 2022, at 07:01, Maxim Dounin wrote: > >>> > >>> # HG changeset patch > >>>

[nginx-tests] Tests: upstream certificates specified as an empty string.

2022-09-28 Thread Eugene Grebenschikov via nginx-devel
changeset:   1797:c2c188c91488 tag:         tip user:        Eugene Grebenshchikov date:        Wed Sep 28 16:29:50 2022 -0700 summary:     Tests: upstream certificates specified as an empty string. diff -r e1fd234baac0 -r c2c188c91488 grpc_ssl.t --- a/grpc_ssl.tTue Sep 27 16:11:56 2022 -