Hello!
On Tue, Jun 28, 2022 at 06:13:31PM +0400, Sergey Kandaurov wrote:
> I agree, the patch looks good to me,
> tested in various configurations (including if() block, etc.)
Pushed to http://mdounin.ru/hg/nginx.
--
Maxim Dounin
http://mdounin.ru/
_
good to me,
tested in various configurations (including if() block, etc.)
>
>> -Original Message-
>> From: Maxim Dounin
>> Sent: Saturday, June 25, 2022 22:48
>> To: Pavel Pautov via nginx-devel
>> Subject: Re: SSL contexts reuse across locations
>>
>
gt; Subject: Re: SSL contexts reuse across locations
>
> EXTERNAL MAIL: nginx-devel-boun...@nginx.org
>
> Hello!
>
> On Sat, Jun 25, 2022 at 01:02:21AM +, Pavel Pautov via nginx-devel wrote:
>
> > > -Original Message-
> > > From: Maxim Dounin
Hello!
On Sat, Jun 25, 2022 at 01:02:21AM +, Pavel Pautov via nginx-devel wrote:
> > -Original Message-
> > From: Maxim Dounin
> > Sent: Thursday, June 16, 2022 18:51
> >
> > Hello!
> >
> > On Thu, Jun 16, 2022 at 08:26:48AM +, Pavel Pautov via nginx-devel
> > wrote:
> >
> >
Hi,
> -Original Message-
> From: Maxim Dounin
> Sent: Thursday, June 16, 2022 18:51
>
> Hello!
>
> On Thu, Jun 16, 2022 at 08:26:48AM +, Pavel Pautov via nginx-devel wrote:
>
> > Looks like, we've made a full circle then... I've replied to
> > that suggestion already and in last e-
Hello!
On Thu, Jun 16, 2022 at 08:26:48AM +, Pavel Pautov via nginx-devel wrote:
> Looks like, we've made a full circle then... I've replied to
> that suggestion already and in last e-mail (with patch) I note
> that moving additional logic into the ngx_http_proxy_set_ssl()
> has its own dr
y, June 15, 2022 17:37
> To: Pavel Pautov via nginx-devel
> Subject: Re: SSL contexts reuse across locations
>
> EXTERNAL MAIL: nginx-devel-boun...@nginx.org
>
> Hello!
>
> On Tue, Jun 14, 2022 at 05:55:22PM +, Pavel Pautov via nginx-devel wrote:
>
> &g
Hello!
On Tue, Jun 14, 2022 at 05:55:22PM +, Pavel Pautov via nginx-devel wrote:
> Any comments?
As already suggested in the very first review:
: You may want to focus on actually making the code more readable
: and abstracting it into ngx_http_proxy_set_ssl() instead.
: Something like ngx_
Any comments?
> -Original Message-
> From: Pavel Pautov via nginx-devel
> Sent: Tuesday, May 24, 2022 23:16
> To: nginx-devel@nginx.org; Maxim Dounin
> Cc: Pavel Pautov
> Subject: RE: SSL contexts reuse across locations
>
> EXTERNAL MAIL: nginx-devel-b
Hi,
Here is another iteration of patch, now it completely avoids creating SSL
contexts without SSL proxying.
Also changed some variable names and formatting in attempt to improve
readability.
Not sure about moving of merge/reuse logic into ngx_http_proxy_set_ssl(). I
assume, it could look like
Hi,
Attaching updated PoC patch, which also reuses contexts from 'http' level.
> -Original Message-
> From: Maxim Dounin
> Sent: Friday, May 20, 2022 16:23
>
> Hello!
>
> On Fri, May 20, 2022 at 06:52:54AM +, Pavel Pautov via nginx-devel wrote:
>
> > > -Original Message-
>
Hello!
On Fri, May 20, 2022 at 06:52:54AM +, Pavel Pautov via nginx-devel wrote:
> > -Original Message-
> > From: Maxim Dounin
> > Sent: Wednesday, May 18, 2022 11:32
> [..]
> > > At very least, ngx_http_proxy_set_ssl() needs to be converted
> > > into ngx_http_proxy_create_ssl().
>
Hi,
> -Original Message-
> From: Maxim Dounin
> Sent: Wednesday, May 18, 2022 11:32
[..]
> > At very least, ngx_http_proxy_set_ssl() needs to be converted
> > into ngx_http_proxy_create_ssl().
>
> You may want to focus on actually making the code more readable
> and abstracting it into n
Hello!
On Wed, May 18, 2022 at 07:20:51AM +, Pavel Pautov via nginx-devel wrote:
> Hello,
>
> Attaching POC patch for
> https://trac.nginx.org/nginx/ticket/1234.
>
> At very least, ngx_http_proxy_set_ssl() needs to be converted
> into ngx_http_proxy_create_ssl().
You may want to focus on
Hello,
Attaching POC patch for https://trac.nginx.org/nginx/ticket/1234.
At very least, ngx_http_proxy_set_ssl() needs to be converted into
ngx_http_proxy_create_ssl(). But there are also a couple of things to discuss:
1. Patch uses pretty straightforward reuse criteria (absence of directives),
15 matches
Mail list logo
