Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Maxim Dounin
Hello! On Mon, May 22, 2023 at 01:06:53AM +0200, Alejandro Colomar wrote: > Hello! > > On 5/21/23 23:22, Maxim Dounin wrote: > >> While the data being written was correctly written via memcpy(3), > >> you wouldn't be allowed to access it later as anything that is > >> not 'struct sockaddr'. For

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Alejandro Colomar
Hello! On 5/21/23 23:22, Maxim Dounin wrote: >> While the data being written was correctly written via memcpy(3), >> you wouldn't be allowed to access it later as anything that is >> not 'struct sockaddr'. For example, the following is a >> strict-aliasing violation: >> >> struct s { int a;

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Maxim Dounin
Hello! On Sun, May 21, 2023 at 04:35:00PM +0200, Alejandro Colomar wrote: > On 5/21/23 15:09, Maxim Dounin wrote: > > Hello! > > > > On Sun, May 21, 2023 at 11:31:32AM +0200, Alejandro Colomar wrote: > > > >> On 5/21/23 03:42, Maxim Dounin wrote: > >>> # HG changeset patch > >>> # User Maxim Do

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Alejandro Colomar
Hello Maxim! On 5/21/23 15:09, Maxim Dounin wrote: > Hello! > > On Sun, May 21, 2023 at 11:31:32AM +0200, Alejandro Colomar wrote: > >> On 5/21/23 03:42, Maxim Dounin wrote: >>> # HG changeset patch >>> # User Maxim Dounin >>> # Date 1684633125 -10800 >>> # Sun May 21 04:38:45 2023 +0300 >

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Maxim Dounin
Hello! On Sun, May 21, 2023 at 11:31:32AM +0200, Alejandro Colomar wrote: > On 5/21/23 03:42, Maxim Dounin wrote: > > # HG changeset patch > > # User Maxim Dounin > > # Date 1684633125 -10800 > > # Sun May 21 04:38:45 2023 +0300 > > # Node ID 68fa4b86ed46138dd1a8fcf2cfd80206de068bec > > # P

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Maxim Dounin
Hello! On Sun, May 21, 2023 at 01:06:59PM +0400, Roman Arutyunyan wrote: > On Sun, May 21, 2023 at 04:42:30AM +0300, Maxim Dounin wrote: > > # HG changeset patch > > # User Maxim Dounin > > # Date 1684633125 -10800 > > # Sun May 21 04:38:45 2023 +0300 > > # Node ID 68fa4b86ed46138dd1a8fcf2c

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Alejandro Colomar
Hi Maxim, On 5/21/23 03:42, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1684633125 -10800 > # Sun May 21 04:38:45 2023 +0300 > # Node ID 68fa4b86ed46138dd1a8fcf2cfd80206de068bec > # Parent 235d482ef6bc8c40a956b2413865d42c94e0fc05 > QUIC: better sockaddr initial

Re: [PATCH] QUIC: better sockaddr initialization

2023-05-21 Thread Roman Arutyunyan
Hi, On Sun, May 21, 2023 at 04:42:30AM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1684633125 -10800 > # Sun May 21 04:38:45 2023 +0300 > # Node ID 68fa4b86ed46138dd1a8fcf2cfd80206de068bec > # Parent 235d482ef6bc8c40a956b2413865d42c94e0fc05 > QUIC: bette