RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-06 Thread Michael Kourlas via nginx-devel
Hello, Thanks for your lengthy explanation -- it's much appreciated. I'll find a way to support my use case in the upstream server instead. Best, Michael Kourlas Confidentiality notice This e-mail message and any attachment hereto contain confidential informat

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-03 Thread Maxim Dounin
Hello! On Mon, Apr 03, 2023 at 06:33:21PM +, Michael Kourlas via nginx-devel wrote: > > Consider the following rewrite: > > > > rewrite ^/(.*) /$1 break; > > > > Assuming request to "GET /foo%2fbar/", what > > $uri_encoded_percent_and_reserved do you expect after each of > > these rewrites? >

RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-03 Thread Michael Kourlas via nginx-devel
Hello, Thanks again for your feedback. > Consider the following rewrite: > > rewrite ^/(.*) /$1 break; > > Assuming request to "GET /foo%2fbar/", what > $uri_encoded_percent_and_reserved do you expect after each of > these rewrites? I do not think that rewrite does anything in practice. Followin

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-04-01 Thread Maxim Dounin
Hello! On Thu, Mar 30, 2023 at 05:19:08PM +, Michael Kourlas via nginx-devel wrote: > Hello, > > Thanks again for your comments. > > > This implies, basically, that there are 3 forms of the request > > URI: 1) fully encoded, as in $request_uri, 2) fully decoded, as in > > $uri now, and 3) "

RE: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-03-30 Thread Michael Kourlas via nginx-devel
Hello, Thanks again for your comments. > This implies, basically, that there are 3 forms of the request > URI: 1) fully encoded, as in $request_uri, 2) fully decoded, as in > $uri now, and 3) "all-except-percent-and-reserved". To implement this > correctly, it needs clear definition when each for

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-03-28 Thread Maxim Dounin
Hello! On Mon, Mar 27, 2023 at 04:19:27PM +, Michael Kourlas via nginx-devel wrote: > > As far as I understand, it will irreversibly corrupt URIs with > > double-encoded reserved characters. For example, "%252F" will > > become "%2F" when proxying in the following configuration: > > > >

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-03-27 Thread Michael Kourlas via nginx-devel
Hello, Thanks for your comments! Sorry for the delay in responding -- I was on vacation. > As far as I understand, it will irreversibly corrupt URIs with > double-encoded reserved characters. For example, "%252F" will > become "%2F" when proxying in the following configuration: > > location

Re: [PATCH] HTTP: Add new uri_normalization_percent_decode option

2023-02-17 Thread Maxim Dounin
Hello! On Wed, Feb 15, 2023 at 11:50:13AM -0500, Michael Kourlas via nginx-devel wrote: > # HG changeset patch > # User Michael Kourlas > # Date 1676408746 18000 > # Tue Feb 14 16:05:46 2023 -0500 > # Node ID 129437ade41b14a584fb4b7558accc1b8dee7f45 > # Parent cffaf3f2eec8fd33605c2a37814f5