> Hello!
>
> On Thu, Mar 02, 2017 at 01:52:58PM +, Eran Kornblau wrote:
>
> [...]
>
> > # User Eran Kornblau # Date 1488462360 18000
> > # Thu Mar 02 08:46:00 2017 -0500
> > # Node ID ecf63ae67df1d5768be40966a5afadb751d894bc
> > # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876
> > Ad
Hello!
On Thu, Mar 02, 2017 at 01:52:58PM +, Eran Kornblau wrote:
[...]
> # User Eran Kornblau
> # Date 1488462360 18000
> # Thu Mar 02 08:46:00 2017 -0500
> # Node ID ecf63ae67df1d5768be40966a5afadb751d894bc
> # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876
> Added missing static s
>
> -Original Message-
> From: nginx-devel [mailto:nginx-devel-boun...@nginx.org] On Behalf Of Maxim
> Dounin
> Sent: Thursday, March 2, 2017 3:37 PM
> To: nginx-devel@nginx.org
> Subject: Re: Add missing static specifiers
>
> Hello!
>
> On Thu, Mar 0
Hello!
On Thu, Mar 02, 2017 at 07:15:25AM +, Eran Kornblau wrote:
[...]
> > > diff -r 8b7fd958c59f -r 050f8b3c3c67 src/event/ngx_event.c
> > > --- a/src/event/ngx_event.c Mon Feb 27 22:36:15 2017 +0300
> > > +++ b/src/event/ngx_event.c Tue Feb 28 16:06:25 2017 -0500
> > > @@ -59,
Thanks, updated patch attached.
> Hello!
>
> On Tue, Feb 28, 2017 at 09:20:37PM +, Eran Kornblau wrote:
>
> [...]
>
> > > > diff -r 8b7fd958c59f -r 4b4b8f5413a4 src/os/unix/ngx_linux_init.c
> > > > --- a/src/os/unix/ngx_linux_init.c Mon Feb 27 22:36:15 2017 +0300
> > > > +++ b/src/os/u
Hello!
On Tue, Feb 28, 2017 at 09:20:37PM +, Eran Kornblau wrote:
[...]
> > > diff -r 8b7fd958c59f -r 4b4b8f5413a4 src/os/unix/ngx_linux_init.c
> > > --- a/src/os/unix/ngx_linux_init.cMon Feb 27 22:36:15 2017 +0300
> > > +++ b/src/os/unix/ngx_linux_init.cTue Feb 28 11:49:07 2
a444e29e3f55b6b2a
> > # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876
> > add missing static specifiers
>
> Style nitpicking:
>
> Added missing static specifiers.
>
Changed
>
> >
> > diff -r 8b7fd958c59f -r 4b4b8f5413a4 src/core/ngx_resolver.c
> > --- a/src/core/ngx_res
gt; all other flags there are exported.
Thank you, looks interesting.
Quick review below.
> # HG changeset patch
> # User Eran Kornblau
> # Date 1488300547 18000
> # Tue Feb 28 11:49:07 2017 -0500
> # Node ID 4b4b8f5413a4a1679d6ad0aa444e29e3f55b6b2a
> # Parent 8b7fd958
Hi all,
Wrote a small script to find missing 'static's in my module -
https://github.com/kaltura/nginx-vod-module/blob/master/test/test_static.py
I executed it on nginx core and found a few of those too, see attached patch.
The logic for finding these was -
1. An exported symbol (found by
