Re: [nginx] CONF: Make ssl_client_certificate directive optional with TLSv1.3

2024-08-27 Thread Praveen Chaudhary
Bringing it up again. Thanks for contributing client certificate validation with OCSP . We were waiting for this feature. Kindly merge below fix as well. Also, let me know if we need to keep check si

Re: [nginx] CONF: Make ssl_client_certificate directive optional with TLSv1.3

2024-08-21 Thread Praveen Chaudhary
@a.bavs...@nginx.com Gentle Reminder for review. This feature to make ssl_client_certificate optional may help us here at Nvidia. Thanks in advance. Kindly let me know if any more modification is needed in fix. Note: AFAIK, mTLS was not supported with SSLv2. I kept the NGX_SSL_SSLv2 flag in fix,

Re: [nginx] CONF: Make ssl_client_certificate directive optional with TLSv1.3

2024-08-19 Thread Praveen Chaudhary
Thanks Aleksei for the review. Agree, It makes sense to have explicit error message to require either ssl_client_certificate or ssl_trusted_certificate. Because: Nginx prints error number from SSL to identify SSL error\routine, but for a client or admin, it may be still hard to find why "SSL certi

Re: [nginx] CONF: Make ssl_client_certificate directive optional with TLSv1.3

2024-08-19 Thread Aleksei Bavshin
On 8/16/2024 8:02 AM, Praveen Chaudhary wrote: Hi Nginx Devs Bumping patch to the top for review. CC: @Sergey Kandaurov Thanks for contributing client certificate validation with OSCP.  It is a long awaited feature. In this patch, I am trying to fix another lingering concern. It will be great

[nginx] CONF: Make ssl_client_certificate directive optional with TLSv1.3

2024-08-16 Thread Praveen Chaudhary
Hi Nginx Devs Bumping patch to the top for review. CC: @Sergey Kandaurov Thanks for contributing client certificate validation with OSCP. It is a long awaited feature. In this patch, I am trying to fix another lingering concern. It will be great, if you can have a look. # HG changeset patch # U