Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-17 Thread Piotr Sikora via nginx-devel
Hey Valentin, > I've overlooked this while doing previous review, but it looks strange. > > Why do you use NGX_LOG_WARN for trailers headers? It results in > finalizing request with an error (in case of HTTP/2 it means RST_STREAM). > > For main headers the NGX_LOG_CRIT level is used. It looks to

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-17 Thread Piotr Sikora via nginx-devel
Hey Maxim, > Series committed with the above change. > Thanks to all involved. Thanks! :) Best regards, Piotr Sikora ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-15 Thread Maxim Dounin
Hello! On Wed, Jun 14, 2017 at 08:33:34PM +0300, Maxim Dounin wrote: > Hello! > > On Wed, Jun 14, 2017 at 08:06:02PM +0300, Valentin V. Bartenev wrote: > > > On Wednesday 14 June 2017 19:54:47 Maxim Dounin wrote: > > > Hello! > > > > > > On Wed, Jun 14, 2017 at 06:12:25PM +0300, Valentin V. Ba

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-14 Thread Maxim Dounin
Hello! On Wed, Jun 14, 2017 at 08:06:02PM +0300, Valentin V. Bartenev wrote: > On Wednesday 14 June 2017 19:54:47 Maxim Dounin wrote: > > Hello! > > > > On Wed, Jun 14, 2017 at 06:12:25PM +0300, Valentin V. Bartenev wrote: > > > > > On Tuesday 13 June 2017 05:19:54 Piotr Sikora via nginx-devel

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-14 Thread Valentin V. Bartenev
On Wednesday 14 June 2017 19:54:47 Maxim Dounin wrote: > Hello! > > On Wed, Jun 14, 2017 at 06:12:25PM +0300, Valentin V. Bartenev wrote: > > > On Tuesday 13 June 2017 05:19:54 Piotr Sikora via nginx-devel wrote: > > > # HG changeset patch > > > # User Piotr Sikora > > > # Date 1490351854 25200

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-14 Thread Maxim Dounin
Hello! On Wed, Jun 14, 2017 at 06:12:25PM +0300, Valentin V. Bartenev wrote: > On Tuesday 13 June 2017 05:19:54 Piotr Sikora via nginx-devel wrote: > > # HG changeset patch > > # User Piotr Sikora > > # Date 1490351854 25200 > > # Fri Mar 24 03:37:34 2017 -0700 > > # Node ID 73f67e06ab103e0

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-14 Thread Valentin V. Bartenev
On Tuesday 13 June 2017 05:19:54 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490351854 25200 > # Fri Mar 24 03:37:34 2017 -0700 > # Node ID 73f67e06ab103e0368d1810c6f8cac5c70c4e246 > # Parent 07a5d26b49f04425ff54cc998f885aa987b7823f > HTTP/2: ad

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-13 Thread Piotr Sikora via nginx-devel
Hey Valentin, > It's better to keep return values consistent with > ngx_http_v2_create_headers_frame() and introduce > NGX_HTTP_V2_NO_TRAILERS instead of NGX_HTTP_V2_FRAME_ERROR. NGX_HTTP_V2_NO_TRAILERS feels a bit weird, but whatever works for you is fine. > There's no reason to check "trailers

[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-13 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490351854 25200 # Fri Mar 24 03:37:34 2017 -0700 # Node ID 73f67e06ab103e0368d1810c6f8cac5c70c4e246 # Parent 07a5d26b49f04425ff54cc998f885aa987b7823f HTTP/2: added support for trailers in HTTP responses. Signed-off-by: Piotr Sikora diff -r

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-07 Thread Valentin V. Bartenev
On Friday 02 June 2017 20:33:46 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1493191954 25200 > # Wed Apr 26 00:32:34 2017 -0700 > # Node ID 8d74ff6c2015180f5c1f399f492214d7d0a52b3f > # Parent 41c09a2fd90410e25ad8515793bd48028001c954 > HTTP/2: add

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-06 Thread Maxim Konovalov
On 05/06/2017 21:00, Maxim Dounin wrote: > Hello! > > On Fri, Jun 02, 2017 at 08:33:46PM -0700, Piotr Sikora via nginx-devel wrote: > >> # HG changeset patch >> # User Piotr Sikora >> # Date 1493191954 25200 >> # Wed Apr 26 00:32:34 2017 -0700 >> # Node ID 8d74ff6c2015180f5c1f399f492214d7d0

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-05 Thread Maxim Dounin
Hello! On Fri, Jun 02, 2017 at 08:33:46PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1493191954 25200 > # Wed Apr 26 00:32:34 2017 -0700 > # Node ID 8d74ff6c2015180f5c1f399f492214d7d0a52b3f > # Parent 41c09a2fd90410e25ad8515793bd4802800

[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-02 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1493191954 25200 # Wed Apr 26 00:32:34 2017 -0700 # Node ID 8d74ff6c2015180f5c1f399f492214d7d0a52b3f # Parent 41c09a2fd90410e25ad8515793bd48028001c954 HTTP/2: added support for trailers in HTTP responses. Signed-off-by: Piotr Sikora diff -r

[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

2017-06-02 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1493191954 25200 # Wed Apr 26 00:32:34 2017 -0700 # Node ID e84aa49c5bc7a3250d4844b581e4bf3ed42db5f5 # Parent b0a910ad494158427ba102bdac71ce01d0667f72 HTTP/2: added support for trailers in HTTP responses. Signed-off-by: Piotr Sikora diff -r