Re: [PATCH] Proxy: make timeout directives accept variables

2017-02-01 Thread Thibault Charbonnier
On 2/1/17 8:58 AM, Maxim Dounin wrote: I'm highly sceptical about introducing variables support everywhere just to save some configuration complexity in very special cases. In most cases there better ways to organize things without using variables, as initial nginx configuration approach suggest

Re: [PATCH] Proxy: make timeout directives accept variables

2017-02-01 Thread Maxim Dounin
Hello! On Wed, Feb 01, 2017 at 08:40:55AM -0800, Thibault Charbonnier wrote: > > On Feb 1, 2017, at 4:54 AM, Maxim Dounin wrote: > > > > until there is a way to introduce variables > > support with less effort. > > What do you suggest to reduce the patch size? Should it take > care of those

Re: [PATCH] Proxy: make timeout directives accept variables

2017-02-01 Thread Thibault Charbonnier
Hello > On Feb 1, 2017, at 4:54 AM, Maxim Dounin wrote: > > until there is a way to introduce variables > support with less effort. What do you suggest to reduce the patch size? Should it take care of those other timeout directives in other modules? One of my other hunch was to add the com

Re: [PATCH] Proxy: make timeout directives accept variables

2017-02-01 Thread Maxim Dounin
Hello! On Tue, Jan 31, 2017 at 10:17:36AM -0800, Thibault Charbonnier wrote: > On 1/31/17 8:00 AM, Maxim Dounin wrote: > > You may want to provide more details on what problem you are > > trying to solve. > > The use-case was originally to use a longer proxy_read_timeout on > certain upstream l

Re: [PATCH] Proxy: make timeout directives accept variables

2017-01-31 Thread Thibault Charbonnier
Hi! On 1/31/17 8:00 AM, Maxim Dounin wrote: You may want to provide more details on what problem you are trying to solve. The use-case was originally to use a longer proxy_read_timeout on certain upstream locations without duplicating too much configuration (our location block). I then thoug

Re: [PATCH] Proxy: make timeout directives accept variables

2017-01-31 Thread Maxim Dounin
Hello! On Mon, Jan 30, 2017 at 05:39:13PM -0800, Thibault Charbonnier wrote: > This is a proposal to allow for better granularity (eventually, on a > per-request basis?) regarding the proxy_*_timeout directives. > > Please let me know how you feel about such a feature, and if you think > this

[PATCH] Proxy: make timeout directives accept variables

2017-01-30 Thread Thibault Charbonnier
Hello! This is a proposal to allow for better granularity (eventually, on a per-request basis?) regarding the proxy_*_timeout directives. Please let me know how you feel about such a feature, and if you think this patch should be implemented in a different way. Thanks! # HG changeset patch