Re: [PATCH] Core: free connections and read/write events at shutdown

2024-03-20 Thread Piotr Sikora via nginx-devel
Hi Sergey, > While I agree that false positives do not allow to run LeakSanitizer > in a clean fashion, I don't think it is nginx which should be fixed. > Rather, sanitizer analysis could be improved instead to prevent FPs. Patches welcome? > Meanwhile, leak sanitizer can be used with suppressio

Re: [PATCH] Core: free connections and read/write events at shutdown

2024-03-15 Thread Sergey Kandaurov
> On 8 Mar 2024, at 19:45, Piotr Sikora via nginx-devel > wrote: > > Hi Sergey, > >> Since this is not a real memory leak (the allocations made in the >> init_process method of the ngx_event_core_module module are used up >> to this function and already freed on exit automatically, as this >>

Re: [PATCH] Core: free connections and read/write events at shutdown

2024-03-08 Thread Piotr Sikora via nginx-devel
Hi Sergey, > Since this is not a real memory leak (the allocations made in the > init_process method of the ngx_event_core_module module are used up > to this function and already freed on exit automatically, as this > function never returns), I don't think there is something to fix. Agreed, this

Re: [PATCH] Core: free connections and read/write events at shutdown

2024-03-07 Thread Sergey Kandaurov
> On 28 Feb 2024, at 05:21, Piotr Sikora via nginx-devel > wrote: > > # HG changeset patch > # User Piotr Sikora > # Date 1708977616 0 > # Mon Feb 26 20:00:16 2024 + > # Branch patch002 > # Node ID f8d9fb94eab212f6e640b7a68ed111562e3157d5 > # Parent a8a592b9b62eff7bca03e8b46669f59d2d

[PATCH] Core: free connections and read/write events at shutdown

2024-02-27 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1708977616 0 # Mon Feb 26 20:00:16 2024 + # Branch patch002 # Node ID f8d9fb94eab212f6e640b7a68ed111562e3157d5 # Parent a8a592b9b62eff7bca03e8b46669f59d2da689ed Core: free connections and read/write events at shutdown. Found with LeakSanit