Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-13 Thread Maxim Dounin
Hello! On Wed, Dec 13, 2023 at 04:16:15PM -0600, Julio Suarez wrote: > 1. > > Yes, double checked configuration (what I'm running isn't exactly what's > in that link). No shared memory zones or thread pools enabled. Sounds > like a change in configuration is needed to test this. > > Would ena

Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-13 Thread Julio Suarez
Hi, This is very discussion helpful. 1. Yes, double checked configuration (what I'm running isn't exactly what's in that link). No shared memory zones or thread pools enabled. Sounds like a change in configuration is needed to test this. Would enabling proxy_cache_path be sufficient for t

Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-12 Thread Maxim Dounin
Hello! On Mon, Dec 11, 2023 at 05:09:17PM -0600, Julio Suarez wrote: > Hi Maxim, > > > Nitpicking: Added ISB as ngx_cpu_pause() for aarch64. > > Yes, we can make that change. > > > Could you please clarify what do you mean by "a bug"? An empty > > ngx_cpu_pause() is certainly not a bug, it's

Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-11 Thread Julio Suarez
Hi Maxim, Nitpicking: Added ISB as ngx_cpu_pause() for aarch64. Yes, we can make that change. Could you please clarify what do you mean by "a bug"? An empty ngx_cpu_pause() is certainly not a bug, it's just a lack of a more optimal solution for the particular architecture. Agree, not a bug.

Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-08 Thread Maxim Dounin
Hello! Thank you for the patch. Some comments and questions below. On Wed, Dec 06, 2023 at 10:06:57AM -0600, julio.sua...@foss.arm.com wrote: > # HG changeset patch > # User Julio Suarez > # Date 1701877879 21600 > # Wed Dec 06 09:51:19 2023 -0600 > # Node ID 53d289b8676fc678ca90e02ece1743

[PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-06 Thread julio . suarez
# HG changeset patch # User Julio Suarez # Date 1701877879 21600 # Wed Dec 06 09:51:19 2023 -0600 # Node ID 53d289b8676fc678ca90e02ece174300a3631f79 # Parent f366007dd23a6ce8e8427c1b3042781b618a2ade Added asm ISB as asm pause for ngx_cpu_pause() for aarch64 For aarch64 (A.K.A. Arm64), ngx_c