Actually this is "Last-Modified:" header. In case of several files,
caching will improve processing speed, but it is useful for benchmarks
only. In real life environment we have tons of files.
___
nginx-devel mailing list
nginx-devel@nginx.org
http://ma
Hi!
ngx_http_time() is called once per request and it call a heavy
ngx_sprintf() function.
Why not cache the output for one second (resolution of time_t)?
I find nice time caching framework on ngx_times.c, with slots and memory
barriers, but ngx_http_time() is not using it for some reason.
In this
oper though, so this post is only intended as
> advice)
>
> Tom
>
>
>> On 5 aug. 2013, at 08:58, "Serguei I. Ivantsov"
>> wrote:
>>
>> I think it is not a matter for trade - "dead code" - is bad programming
>> technique. And it shoul
get exact counters.
> Hello!
>
> On Mon, Aug 05, 2013 at 12:15:04AM +0300, Serguei I. Ivantsov wrote:
>
> [...]
>
>> A little test with high volume of simple requests shows 0.5% overall
>> speed
>> improvement.
>
> Are you sure the numbers are significant?
Hi,
While researching nginx, I found that there are a lot of dead code, mostly
in ngx_event_accept.c
One of those blocks:
if (ngx_event_flags & NGX_USE_RTSIG_EVENT) {
ev->available = 1;
} else if (!(ngx_event_flags & NGX_USE_KQUEUE_EVENT)) {
ev->available = ecf->multi_acce
Well, please apply the proper patch.
It will also speeds up building on Linux, because rt signals (and
included sysctl.h) are very rare nowadays.
> Yes, that's fine. But you placed the include added before
> semaphore.h instead of adding it to other event method related
> includes. I mean to do
>> +#if (NGX_HAVE_RTSIG)
>> +#include
>> +#endif
>> +
>>
>> #if (NGX_HAVE_POSIX_SEM)
>> #include
>This probably needs to be moved to other event method related
>conditional includes
I did not find an example how and where conditionally include system
header. BTW, I just make the same way I fo
l.h:19:3: error: #error "sysctl system call is
>unsupported in x32 kernel"
> # error "sysctl system call is unsupported in x32 kernel"
sysctl() is only used within RTSIG module, but included anyway in
ngx_linux_config.h.
Please find the patch attached to ad
l.h:19:3: error: #error "sysctl system call is
>unsupported in x32 kernel"
> # error "sysctl system call is unsupported in x32 kernel"
sysctl() is only used within RTSIG module, but included anyway in
ngx_linux_config.h.
Please find the patch attached to ad