Re: [PATCH] Year 2024

2024-01-23 Thread Maxim Dounin
Hello! On Tue, Jan 23, 2024 at 12:56:47PM +, Yaroslav Zhuravlev wrote: > GNUmakefile | 2 +- > text/LICENSE | 2 +- > xml/menu.xml | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > > # HG changeset patch > # User Yaroslav Zhuravlev > # Date 1706014530 0 > # Tue Jan 2

Re: [PATCH] Documented opensourcing of the OTel module

2024-01-23 Thread Maxim Dounin
Hello! On Tue, Jan 23, 2024 at 01:49:07PM +, Yaroslav Zhuravlev wrote: > xml/en/docs/index.xml | 8 +++- > xml/en/docs/ngx_otel_module.xml | 20 +++- > xml/ru/docs/index.xml | 10 -- > 3 files changed, 30 insertions(+), 8 deletions(-) > >

[njs] Moving out HostLoadImportedModule from njs core.

2024-01-23 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/9b3dac56fd8a branches: changeset: 2272:9b3dac56fd8a user: Dmitry Volyntsev date: Tue Jan 23 16:34:10 2024 -0800 description: Moving out HostLoadImportedModule from njs core. HostLoadImportedModule should be implemented by host environment accord

[njs] Change: imported modules are not resolved relative to current dir.

2024-01-23 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/7eaaa7d57636 branches: changeset: 2271:7eaaa7d57636 user: Dmitry Volyntsev date: Tue Jan 23 16:33:52 2024 -0800 description: Change: imported modules are not resolved relative to current dir. Previously, when a module was imported with a relativ

[njs] Shell: fixed unhandled rejected promises handling.

2024-01-23 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/6485ad23565e branches: changeset: 2270:6485ad23565e user: Dmitry Volyntsev date: Tue Jan 23 16:33:29 2024 -0800 description: Shell: fixed unhandled rejected promises handling. The issue was introduced in dffdf7c50dfc (not released yet). diffsta

[PATCH] Events: protection from stale changes to level-triggered kevents

2024-01-23 Thread Sergey Kandaurov
# HG changeset patch # User Sergey Kandaurov # Date 1706055243 -14400 # Wed Jan 24 04:14:03 2024 +0400 # Node ID d47ed07b06e93f4c6137ccd4ddfce0de23afb6a2 # Parent ee40e2b1d0833b46128a357fbc84c6e23be9be07 Events: protection from stale changes to level-triggered kevents. When kqueue events ar

Re: Core: Avoid memcpy from NULL

2024-01-23 Thread Ben Kallus
Hi Maxim, > As already pointed out previously, there are no known cases > when memcpy(p, NULL, 0) can result in miscompilation of nginx > code, ... If you think there are cases when the code can be > miscompiled in practice, and not theoretically, please share. There is no such thing as "miscomp

Re: [njs] Ignoring UndefinedBehaviorSanitizer warnings where appropriate.

2024-01-23 Thread Ben Kallus
> Casting NaN to integer is undefined behavior, > but it is fine in some cases where we do additional checks later. > For example: > int64_t i64 = njs_unsafe_cast_double_to_int64(num); > if (i64 == num) { > // num is integer > } This could be fine, but it's not guaranteed by the standard. For

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-01-23 Thread Maxim Dounin
Hello! On Mon, Jan 22, 2024 at 07:48:01PM +0400, Roman Arutyunyan wrote: > Hi, > > On Mon, Jan 22, 2024 at 02:59:21PM +0300, Maxim Dounin wrote: > > Hello! > > > > On Mon, Jan 22, 2024 at 02:49:54PM +0400, Roman Arutyunyan wrote: > > > > > # HG changeset patch > > > # User Roman Arutyunyan >

[PATCH] Documented opensourcing of the OTel module

2024-01-23 Thread Yaroslav Zhuravlev
xml/en/docs/index.xml | 8 +++- xml/en/docs/ngx_otel_module.xml | 20 +++- xml/ru/docs/index.xml | 10 -- 3 files changed, 30 insertions(+), 8 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1704815768 0 # Tue Jan 09 15

[PATCH] Year 2024

2024-01-23 Thread Yaroslav Zhuravlev
GNUmakefile | 2 +- text/LICENSE | 2 +- xml/menu.xml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1706014530 0 # Tue Jan 23 12:55:30 2024 + # Node ID 9fa58eaa9b8fd4dcd9677d37a86140f945eaf7c6 # Parent 87d313e1bf7f365