[PATCH] HTTP/2: add debug logging of control frames

2017-04-07 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 7414a1467d0684a73d091c508834973b944890cd # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of control frames. Signed-off-by: Piotr Sikora diff -r 22be63bf2

Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-07 Thread Piotr Sikora via nginx-devel
Hey Valentin, > You can always find these values in configuration, and I can't remember a > case where > I've ever needed them. On the contrary, there's always a problem with the > huge size > of typical http/2 debug log. So it's not a good idea to add something just > because > we can. As s

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

2017-04-07 Thread Piotr Sikora via nginx-devel
Hey Valentin, > Maybe "http2 pseudo-header: \":%V: %V\""? > Because it doesn't look like a valid "http header". I was going back and forth between different versions, but I ended up using "http header", which matches rest of the headers and has the same alignment, because then pseudo-headers look