RE: Add missing static specifiers

2017-03-01 Thread Eran Kornblau
Thanks, updated patch attached. > Hello! > > On Tue, Feb 28, 2017 at 09:20:37PM +, Eran Kornblau wrote: > > [...] > > > > > diff -r 8b7fd958c59f -r 4b4b8f5413a4 src/os/unix/ngx_linux_init.c > > > > --- a/src/os/unix/ngx_linux_init.c Mon Feb 27 22:36:15 2017 +0300 > > > > +++ b/src/os/u

Re: [PATCH] Contrib: vim syntax, update 3rd party module directives

2017-03-01 Thread Maxim Dounin
Hello! On Wed, Mar 01, 2017 at 11:49:05PM +0800, othree wrote: > # HG changeset patch > # User othree > # Date 1488382899 -28800 > # Wed Mar 01 23:41:39 2017 +0800 > # Node ID 7fca6f60d5cafa0127b5bc4d6b74fcd06ab532a3 > # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876 > Contrib: vim syntax

[nginx] Contrib: vim syntax, update 3rd party module directives.

2017-03-01 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/7fca6f60d5ca branches: changeset: 6921:7fca6f60d5ca user: othree date: Wed Mar 01 23:41:39 2017 +0800 description: Contrib: vim syntax, update 3rd party module directives. diffstat: contrib/vim/syntax/nginx.vim | 1477 +++

Re: Add missing static specifiers

2017-03-01 Thread Maxim Dounin
Hello! On Tue, Feb 28, 2017 at 09:20:37PM +, Eran Kornblau wrote: [...] > > > diff -r 8b7fd958c59f -r 4b4b8f5413a4 src/os/unix/ngx_linux_init.c > > > --- a/src/os/unix/ngx_linux_init.cMon Feb 27 22:36:15 2017 +0300 > > > +++ b/src/os/unix/ngx_linux_init.cTue Feb 28 11:49:07 2

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

2017-03-01 Thread Maxim Dounin
Hello! On Wed, Mar 01, 2017 at 12:20:38PM -0800, Piotr Sikora via nginx-devel wrote: > Hi Maxim, > > > As I already wrote, I certainly disagree with this change. > > Yes, that was expected (that's why it was originally split into > separate change). > > Is there a particular reason why do you

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

2017-03-01 Thread Maxim Dounin
Hello! On Wed, Mar 01, 2017 at 12:16:39PM -0800, Piotr Sikora via nginx-devel wrote: > Hi Maxim, > > > Not sure it's good idea to don't count a 429 response as a peer > > failure. Contrary, counting it as a failure will naturally reduce > > load on the particular server, resulting in less rejec

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

2017-03-01 Thread Piotr Sikora via nginx-devel
Hi Maxim, > As I already wrote, I certainly disagree with this change. Yes, that was expected (that's why it was originally split into separate change). Is there a particular reason why do you disagree? It's hard to have a constructive discussion if you don't provide any reasoning for your (poss

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

2017-03-01 Thread Piotr Sikora via nginx-devel
Hi Maxim, > Not sure it's good idea to don't count a 429 response as a peer > failure. Contrary, counting it as a failure will naturally reduce > load on the particular server, resulting in less rejects. But 429 can be returned on a per request basis (think client IP exceeding limit_req limits,

[PATCH] Contrib: vim syntax, update 3rd party module directives

2017-03-01 Thread othree
# HG changeset patch # User othree # Date 1488382899 -28800 # Wed Mar 01 23:41:39 2017 +0800 # Node ID 7fca6f60d5cafa0127b5bc4d6b74fcd06ab532a3 # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876 Contrib: vim syntax, update 3rd party module directives. diff --git a/contrib/vim/syntax/nginx.vi

Re: [PATCH] Contrib: vim syntax, update 3rd party module directives

2017-03-01 Thread OOO
OH Yes, Not direct related. My original plan is have another commit to add skipempty. (skipwhite not include newline, so this change is required to make sure highlight correct) I will fix this commit. 2017-03-01 20:47 GMT+08:00 Maxim Dounin : > Hello! > > On Wed, Mar 01, 2017 at 11:44:11AM +08

Re: [PATCH 3 of 3] Limit req: change default response code when rate-limiting

2017-03-01 Thread Maxim Dounin
Hello! On Tue, Feb 28, 2017 at 03:40:01PM -0800, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1488324535 28800 > # Tue Feb 28 15:28:55 2017 -0800 > # Node ID c9d43c652ac776068e78f695dde00606eed184f8 > # Parent e21f12a958010e1f3e5cdc1640859e335e0

Re: [PATCH 2 of 3] Upstream: allow recovery from "429 Too Many Requests" response

2017-03-01 Thread Maxim Dounin
Hello! On Tue, Feb 28, 2017 at 03:40:00PM -0800, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1488324535 28800 > # Tue Feb 28 15:28:55 2017 -0800 > # Node ID e21f12a958010e1f3e5cdc1640859e335e032ca5 > # Parent 9a63d6e990d230db0ec6b03250265447f64

Re: [PATCH] Contrib: vim syntax, update 3rd party module directives

2017-03-01 Thread Maxim Dounin
Hello! On Wed, Mar 01, 2017 at 11:44:11AM +0800, othree wrote: > # HG changeset patch > # User othree > # Date 1488339792 -28800 > # Wed Mar 01 11:43:12 2017 +0800 > # Node ID b57cf9a765d8f5603f1bf359eb95dadc0a832f18 > # Parent 8b7fd958c59f8280d167fe7dd93f1942bfed5876 > Contrib: vim syntax