Re: LibCSS: Flexbox property support review

2017-10-01 Thread Tim Hill
In article <03eccc20-da08-a0f8-54e8-47abe8241...@codethink.co.uk>, Michael Drake wrote: > On 30/09/17 21:05, Tim Hill wrote: > > In article <0a012258-3662-78c0-93ca-5dac0982b...@codethink.co.uk>, > > Michael Drake wrote: > > This is great news even though I suspect you didn't mean to po

Re: LibCSS: Flexbox property support review

2017-10-01 Thread Michael Drake
On 30/09/17 21:05, Tim Hill wrote: In article <0a012258-3662-78c0-93ca-5dac0982b...@codethink.co.uk>, Michael Drake wrote: This is great news even though I suspect you didn't mean to post it to 'users' :). Yes, I meant to send it to the dev list, sorry. This work adds handling of fle

Re: LibCSS: Flexbox property support review

2017-09-30 Thread Tim Hill
In article <0a012258-3662-78c0-93ca-5dac0982b...@codethink.co.uk>, Michael Drake wrote: > Hello, > This is a review of the lcneves/flexbox-tidy branch. [Snip] This is great news even though I suspect you didn't mean to post it to 'users' :). I use flex containers a lot to allow blobs of con

LibCSS: Flexbox property support review

2017-09-30 Thread Michael Drake
Hello, This is a review of the lcneves/flexbox-tidy branch. First off I think this is really good work. Almost all the things I spotted range from minor to trivial. Aside from the unset values for unit and length in the min-{width|height} computed style getters, and the fact that NetSurf is ab