Re: libcss memory leak

2015-03-06 Thread Ralf Junker
On 05.03.2015 21:38, Michael Drake wrote: I need to check that adding unref_interned_strings_in_tokens(parser); in css__parser_destroy does not introduce an attempt to unref token strings twice in the case where both _data_done and _destroy are called. FWIW, the proposed fix passes all my test

Re: libcss memory leak

2015-03-05 Thread Michael Drake
On 03/03/15 16:55, Ralf Junker wrote: libcss may leak memory if css_stylesheet_data_done() > is not called. See the attached source for an example. Hi Ralf, thanks for pointing this out. I agree, the API does not make it clear that you must call _data_done before _destroy if you want to abor

libcss memory leak

2015-03-03 Thread Ralf Junker
libcss may leak memory if css_stylesheet_data_done() is not called. See the attached source for an example. One might argue that css_stylesheet_data_done() is a mandatory call, but I believe that a library should try to avoid memory leaks as much as possible. Hence I propose fix below which add