Re: Patch to make Javascript writeln() work (attempt 3)

2015-10-01 Thread Rob Kendrick
On Thu, Oct 01, 2015 at 04:15:38AM -0800, Dave Higton wrote: > On Thu, 1 Oct 2015 12:41:12 +0100 Vincent wrote: > > On Thu, Sep 24, 2015 at 09:36:41PM +0100, Dave Higton wrote: > >> This patch to Document/bnd makes the Javascript writeln() function > >> work as well as write(). This version insert

Re: Patch to make Javascript writeln() work (attempt 3)

2015-10-01 Thread Dave Higton
On Thu, 1 Oct 2015 12:41:12 +0100 Vincent wrote: > On Thu, Sep 24, 2015 at 09:36:41PM +0100, Dave Higton wrote: >> This patch to Document/bnd makes the Javascript writeln() function >> work as well as write(). This version inserts "\n", which seems >> to be what the language requires. was wrong.

Re: Patch to make Javascript writeln() work (attempt 3)

2015-10-01 Thread Vincent Sanders
On Thu, Sep 24, 2015 at 09:36:41PM +0100, Dave Higton wrote: > This patch to Document/bnd makes the Javascript writeln() function > work as well as write(). This version inserts "\n", which seems > to be what the language requires. was wrong. applied -- Regards Vincent http://www.kyllikki.or

Re: Patch to make Javascript writeln() work

2015-09-24 Thread Michael Drake
Hi Dave, On 24/09/15 21:02, Dave Higton wrote: You pay two small prices: 1) it's slower; I wouldn't worry too much about that unless profiling actually shows it as in any way significant. 2) the log says "Writing..." regardless of whether write() or writeln() has been called. At the mome

Re: Patch to make Javascript writeln() work

2015-09-24 Thread Dave Higton
In message <20150924082904.GA14703@somnambulist.local> Daniel Silverstone wrote: >On Wed, Sep 23, 2015 at 21:43:13 +0100, Dave Higton wrote: >> Second version using SLEN() instead of strlen(). >> >> This patch to Document/bnd makes the Javascript writeln() function >> work as well as w

Re: Patch to make Javascript writeln() work

2015-09-24 Thread Daniel Silverstone
On Wed, Sep 23, 2015 at 21:43:13 +0100, Dave Higton wrote: > Second version using SLEN() instead of strlen(). > > This patch to Document/bnd makes the Javascript writeln() function > work as well as write(). >From my reading of the spec, it inserts a newline, not a line break. Also, you could ch