Re: [RFC] Bug 2182--revised patch

2015-03-17 Thread Vincent Sanders
On Sun, Mar 15, 2015 at 05:38:54PM +, David Gee wrote: > Attached is a revised patch for bug 2182. This time with more detailed > comments. Hope this is suitable and in the correct format. Pretty close. I just had to tweak your first line to be the summary text As i heard nothing from

[RFC] Bug 2182--revised patch

2015-03-15 Thread David Gee
Attached is a revised patch for bug 2182. This time with more detailed comments. Hope this is suitable and in the correct format. -- David Gee Gateshead >From aecce8ffbc596bf62d2cf9609f35c1e1c1a28077 Mon Sep 17 00:00:00 2001 From: David Gee Date: Sun, 15 Mar 2015 17:30:50 + Subject: [PA

Re: Bug 2182 (revised patch--please ignore previous email)

2015-03-15 Thread Vincent Sanders
On Sat, Mar 14, 2015 at 09:12:40PM +, David Gee wrote: > Hi, > > The patch attached to my previous email contained an error. Somehow I'd > inadvertently removed the 'x' from an xwimp call which I didn't intend > to change. The general (hand wave) way to mark such "please give feedback" patche

Bug 2182 (revised patch--please ignore previous email)

2015-03-14 Thread David Gee
Hi, The patch attached to my previous email contained an error. Somehow I'd inadvertently removed the 'x' from an xwimp call which I didn't intend to change. I've used git to revert the changes and then (once again) removed the xwimp_create_menu(WIMP_CLOSE_MENU,0,0) call from ro_gui_send_datasave

Re: Bug 2182

2015-03-14 Thread Jeremy Nicoll - ml netsurf
David Gee wrote: >I've looked at Bug 2182 and made appropriate modifications to >riscos/save.c. This wasn't *too* tricky since the identifier of the bug >also suggested how it might be solved. Poking my nose in where it's probably not welcome... I peeked at the diffs ju

Bug 2182

2015-03-14 Thread David Gee
I've looked at Bug 2182 and made appropriate modifications to riscos/save.c. This wasn't *too* tricky since the identifier of the bug also suggested how it might be solved. I've tested the fix and it appears to have resolved the issue and not caused any other problems. Once agai

Bug 2182

2015-03-12 Thread David Gee
Having managed to get everything set up and working, including an installation of RPCEmu/RO5.20 as well as the Netsurf build tools, I was thinking about tackling bug 2182 over the next few days--unless Glen is already working on it. I have managed to reproduce the bug as follows: 1. Select

Re: Bug 2182

2015-03-11 Thread Glen Walker
20 as well as the Netsurf build tools, I was thinking about tackling bug 2182 over the next few days--unless Glen is already working on it. I have managed to reproduce the bug as follows: 1. Select text in !Netsurf 2. Do Selection|Copy to Clipboard 3. Start !StrongED and open a new text file. 4. Do