Re: [PATCH 2/2] Truncate caret of text input field at top & bottom boundaries.

2014-03-21 Thread Achal Aggarwal
I was wondering why there is one pixel gap at the cropped caret, so that is the reason. I can't thank you enough for describing me this so well, As you said, caret should be cropped against crop rectangle but it is not happening, so I will try to find out why is that. Regards Achal On Fri, Ma

Re: [PATCH 2/2] Truncate caret of text input field at top & bottom boundaries.

2014-03-20 Thread Michael Drake
Hi Achal-Aggarwal, Thanks for looking at this. On 20/03/14 21:21, Achal-Aggarwal wrote: --- desktop/textarea.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 8e4b1dd..c148a58 100644 --- a/desktop/textarea.c +++ b/desk

[PATCH 2/2] Truncate caret of text input field at top & bottom boundaries.

2014-03-20 Thread Achal-Aggarwal
--- desktop/textarea.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 8e4b1dd..c148a58 100644 --- a/desktop/textarea.c +++ b/desktop/textarea.c @@ -462,12 +462,19 @@ static bool textarea_set_caret_internal(struct textarea