Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Drake
On Sun, 17 Sept 2023 at 15:58, Michael Orlitzky wrote: > I've also submitted a patch for a libcss segfault that is probably > causing a lot of netsurf crashes at, > > https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Nice patch. Applied! Thanks, Michael

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread John-Mark Bell
On 17/09/2023 15:58, Michael Orlitzky wrote: While I have your attention and whereas no good deed goes unpunished, I've also submitted a patch for a libcss segfault that is probably causing a lot of netsurf crashes at, https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Thanks :) Mic

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Orlitzky
While I have your attention and whereas no good deed goes unpunished, I've also submitted a patch for a libcss segfault that is probably causing a lot of netsurf crashes at, https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Thanks :) ___ netsur

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Orlitzky
On 2023-09-17 14:52:25, John-Mark Bell wrote: > > Thanks for these. I have not applied them, however, as the underlying > causes were failure to deal with a) errors within the libxml SAX > handlers and b) within the node addition logic. In either case, there is > no reasonable recovery path, so

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread John-Mark Bell
On 12/08/2023 03:45, Michael Orlitzky wrote: The libsvgtiny test suite exposes two segfaults in libdom's libxml2 parser. The first I'm somewhat confident in: linking dom/xml nodes can fail (or never happen), and if we encounter an unlinked node, something is wrong. Reasonable enough. The second

[PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-08-11 Thread Michael Orlitzky
The libsvgtiny test suite exposes two segfaults in libdom's libxml2 parser. The first I'm somewhat confident in: linking dom/xml nodes can fail (or never happen), and if we encounter an unlinked node, something is wrong. Reasonable enough. The second was easy to fix, but I'm not as sure that the f