Re: [PATCH] Fix line_height eval and centering of text in text input field.

On 21/03/14 18:14, Achal Aggarwal wrote: This change is not right. First, you're introducing a multiply 1.3, which is a floating point operation. The rest of that calculation is using fixed point to avoid using floating point. Second you're doing setup->text.size/FONT_SI

Re: [PATCH] Fix line_height eval and centering of text in text input field.

On Fri, Mar 21, 2014 at 3:38 AM, Michael Drake wrote: > Hi Achal-Aggarwal, > > Thanks for this patch. We need to fix up a few things, but you did a good > job tracking down the source of the bug in our rather large code base. I > hope this is an instructive and valuable experience for you. > >

Re: [PATCH] Fix line_height eval and centering of text in text input field.

Hi Achal-Aggarwal, Thanks for this patch. We need to fix up a few things, but you did a good job tracking down the source of the bug in our rather large code base. I hope this is an instructive and valuable experience for you. On 20/03/14 21:32, Achal-Aggarwal wrote: --- desktop/textarea.

[PATCH] Fix line_height eval and centering of text in text input field.

--- desktop/textarea.c | 9 + render/font.c | 3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 584642d..dcaa2e8 100644 --- a/desktop/textarea.c +++ b/desktop/textarea.c @@ -1786,7 +1786,9 @@ static void textarea_setup_