Re: Possible integer overflow when calculating hysteresis in desktop/netsurf.c

2021-01-24 Thread ori
Quoth Thorsten Otto : > On Sonntag, 24. Januar 2021 19:09:35 CET Jonas wrote: > > What do you think? > > I think that a compiler that defines size_t to be 32bit on a 64bit system is > broken ;) > > It's perfectly legal -- size_t is required to hold the maximum allowed object size. It's not req

Re: libnslog: portability fixes for plan9

2020-03-30 Thread ori
> What about when neither of these cases match? > > Maybe something like this would be better > > #else > #if defined(_PLAN9) > #pragma varargck nslog__log argpos 2 > #endif > #define PRINTF(pos, args) > #endif Yeah, that would definitely be better.

nsfb plan9 support

2020-03-22 Thread ori
>From cb45b499fb048c7bfcaea0744f4303b964d48469 From: Ori Bernstein Date: Sun, 22 Mar 2020 19:06:30 -0700 Subject: [PATCH] Add support for plan 9 surface, remove gcc dependency. This adds framebuffer support for plan 9 image surfaces, and puts macros like UNUSED and __attribute__((construc

libnslog: portability fixes for plan9

2020-03-22 Thread ori
>From be21e1a1d3ffa0b3baa073bdb4b04c80af7f7bee From: Ori Bernstein Date: Sun, 22 Mar 2020 18:08:23 -0700 Subject: [PATCH] portability fixes for plan9 this fixes 3 issues: - First off, the plan 9 C compilers don't handle GNU style varargs, so we switch over to c99 style. - Sec

[PATCH] make source a compatible type

2020-03-22 Thread ori
>From 5b1b4fc13212991968bff51e98cba9da5552d983 From: Ori Bernstein Date: Sun, 22 Mar 2020 18:04:44 -0700 Subject: [PATCH] make source a compatible type We pass uint32_t source as an out parameter which takes an int32_t pointer, and the plan 9 compilers complain about this. This makes the t

libnspsl -- remove bitfields

2020-03-22 Thread ori
This patch will probably be something we need to carry forward in our own port, but I'm going to submit it for discussion anyways. Currently, the plan 9 C compilers do *not* support static initialization of bitfields, so we need to do somethign about that. We can replace them with an enum and flag

[PATCH] libcss portability fixes for plan9

2020-03-22 Thread ori
>From 294f0ec43f6f64765d85d2e85ac9b4dafeb0e045 From: Ori Bernstein Date: Sun, 22 Mar 2020 18:00:34 -0700 Subject: [PATCH] portability fixes for plan9 Several changes are made here: - Our compilers don't like double-declared enum tags, so we rename them to avoid conflicts. - We don&

libwapcaplet portability fixes (re: plan 9 port)

2020-03-22 Thread ori
patches. Here's the first patch. >From b02d1e93846df7f135bc8c1c82c9a2e3291480cf From: Ori Bernstein Date: Sun, 22 Mar 2020 17:47:46 -0700 Subject: [PATCH] portability fixes for Plan 9 The plan 9 compilers are not gcc, and do not handle many gcc extensions like expression templates. this change replaces them