Re: CSS support in libsvgtiny

2023-09-17 Thread John-Mark Bell
On 17/09/2023 22:18, Michael Orlitzky wrote: On 2023-09-17 20:50:42, Michael Drake wrote: For what it's worth, I'm happy for anything of mine in that area to be relicensed as MIT. Good to know! I tried to track down the origins of the selection handlers, but it looks like most of them go back

Re: CSS support in libsvgtiny

2023-09-17 Thread Michael Orlitzky
On 2023-09-17 20:50:42, Michael Drake wrote: > > For what it's worth, I'm happy for anything of mine in that area to be > relicensed as MIT. > Good to know! I tried to track down the origins of the selection handlers, but it looks like most of them go back to, commit ddeadd1c02880367ad786b113

Re: CSS support in libsvgtiny

2023-09-17 Thread Michael Drake
On Sun, 17 Sept 2023 at 15:18, John-Mark Bell wrote: > On 14/09/2023 14:43, Michael Drake wrote: > > I agree, it would be better to have a shared implementation of the > > LibCSS/LibDOM integration. Either as a LibDOM-CSS or maybe as > > an optional LibDOM binding for LibCSS, a bit like LibDOM ha

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Drake
On Sun, 17 Sept 2023 at 15:58, Michael Orlitzky wrote: > I've also submitted a patch for a libcss segfault that is probably > causing a lot of netsurf crashes at, > > https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Nice patch. Applied! Thanks, Michael

Re: CSS support in libsvgtiny

2023-09-17 Thread Michael Orlitzky
On 2023-09-17 15:17:57, John-Mark Bell wrote: > > > > I agree, it would be better to have a shared implementation of the > > LibCSS/LibDOM integration. Either as a LibDOM-CSS or maybe as > > an optional LibDOM binding for LibCSS, a bit like LibDOM has > > the Hubbub/LibXML bindings. What do you th

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread John-Mark Bell
On 17/09/2023 15:58, Michael Orlitzky wrote: While I have your attention and whereas no good deed goes unpunished, I've also submitted a patch for a libcss segfault that is probably causing a lot of netsurf crashes at, https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Thanks :) Mic

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Orlitzky
While I have your attention and whereas no good deed goes unpunished, I've also submitted a patch for a libcss segfault that is probably causing a lot of netsurf crashes at, https://bugs.netsurf-browser.org/mantis/view.php?id=2854 Thanks :) ___ netsur

Re: [PATCH] makefiles/Makefile.top: dependencies for PRE_ and POST_TARGETS

2023-09-17 Thread Michael Orlitzky
On 2023-09-17 15:08:33, John-Mark Bell wrote: > > Merged, thank you. I moved where these additional rules are declared and > made them conditional on there being any PRE/POST_TARGETS, but it should > be semantically equivalent to what you had. > Again, thanks. _

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread Michael Orlitzky
On 2023-09-17 14:52:25, John-Mark Bell wrote: > > Thanks for these. I have not applied them, however, as the underlying > causes were failure to deal with a) errors within the libxml SAX > handlers and b) within the node addition logic. In either case, there is > no reasonable recovery path, so

Re: CSS support in libsvgtiny

2023-09-17 Thread John-Mark Bell
On 14/09/2023 14:43, Michael Drake wrote: Hi Michael, On Tue, 12 Sept 2023 at 23:45, Michael Orlitzky wrote: I dumped the new properties into the default level, but this raises a question: should libcss use a different CSS level for SVG? Good question. What do you think John-Mark?

Re: [PATCH] makefiles/Makefile.top: dependencies for PRE_ and POST_TARGETS

2023-09-17 Thread John-Mark Bell
On 14/08/2023 18:23, Michael Orlitzky wrote: The PRE_TARGETS and POST_TARGETS are supposed to be built before and after $(OBJECTS), respectively -- at least according to the comments in Makefile.top: [...] Merged, thank you. I moved where these additional rules are declared and made them cond

Re: [PATCH 0/2] libdom: fix two more libxml parser segfaults

2023-09-17 Thread John-Mark Bell
On 12/08/2023 03:45, Michael Orlitzky wrote: The libsvgtiny test suite exposes two segfaults in libdom's libxml2 parser. The first I'm somewhat confident in: linking dom/xml nodes can fail (or never happen), and if we encounter an unlinked node, something is wrong. Reasonable enough. The second