Re: [PATCH 2/2] Truncate caret of text input field at top & bottom boundaries.

2014-03-20 Thread Michael Drake
Hi Achal-Aggarwal, Thanks for looking at this. On 20/03/14 21:21, Achal-Aggarwal wrote: --- desktop/textarea.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 8e4b1dd..c148a58 100644 --- a/desktop/textarea.c +++ b/desk

Re: [PATCH] Fix line_height eval and centering of text in text input field.

2014-03-20 Thread Michael Drake
Hi Achal-Aggarwal, Thanks for this patch. We need to fix up a few things, but you did a good job tracking down the source of the bug in our rather large code base. I hope this is an instructive and valuable experience for you. On 20/03/14 21:32, Achal-Aggarwal wrote: --- desktop/textarea.

[PATCH] Fixes bug # 2097

2014-03-20 Thread Achal-Aggarwal
#Repo : netsurf #sURL : https://github.com/Achal-Aggarwal/netsurf.git #sRef : fix-text-input #SHA1 : 056758e75dbc47c42d64b1c239839b6757203675 #Land : master #link : https://github.com/Achal-Aggarwal/netsurf/tree/fix-text-input #bugtracker : http://bugs.netsurf-browser.org/mantis/view.php?id=2097

[PATCH] Fix line_height eval and centering of text in text input field.

2014-03-20 Thread Achal-Aggarwal
--- desktop/textarea.c | 9 + render/font.c | 3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 584642d..dcaa2e8 100644 --- a/desktop/textarea.c +++ b/desktop/textarea.c @@ -1786,7 +1786,9 @@ static void textarea_setup_

[PATCH 2/2] Truncate caret of text input field at top & bottom boundaries.

2014-03-20 Thread Achal-Aggarwal
--- desktop/textarea.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/desktop/textarea.c b/desktop/textarea.c index 8e4b1dd..c148a58 100644 --- a/desktop/textarea.c +++ b/desktop/textarea.c @@ -462,12 +462,19 @@ static bool textarea_set_caret_internal(struct textarea

[PATCH 1/2] Truncate caret of text area at top & bottom boundaries.

2014-03-20 Thread Achal-Aggarwal
--- desktop/textarea.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/desktop/textarea.c b/desktop/textarea.c index 584642d..8e4b1dd 100644 --- a/desktop/textarea.c +++ b/desktop/textarea.c @@ -755,6 +755,16 @@ static void textarea_scrollbar_callback(void *client_data,

[PATCH 0/2] Fixes bug #2098

2014-03-20 Thread Achal-Aggarwal
#Repo : netsurf #sURL : https://github.com/Achal-Aggarwal/netsurf.git #sRef : fix-2098 #SHA1 : fdb490b6682ac03867706cd3aa32d16bdd060b1d #Land : master #link : https://github.com/Achal-Aggarwal/netsurf/tree/fix-2098 #bugtracker : http://bugs.netsurf-browser.org/mantis/view.php?id=2098 #Description