Re: JavaScript

2012-06-30 Thread Chris Young
On 30 Jun 2012 10:57:15 +0100, Chris Young wrote: > On Sat, 30 Jun 2012 02:13:45 +0200, Ole wrote: > > > This patch adds support for older spidermonkey versions (tested with > > 1.7): > > http://pastebin.com/XEUhYhYY Also required, and I forgot to mention, is the inline function JS_NewCompar

Re: Patch: avoid repeated initialization/allocation of global object in js_newcompartment

2012-06-30 Thread Michael Drake
In article <20120630121057.gc11...@kyllikki.org>, Vincent Sanders wrote: [Explanation of the js objects and their lifetimes] Thanks for the summary. :) > The content *must* be given a fresh global object or the content will > not be starting from the state the previously loaded page left

Re: Patch: avoid repeated initialization/allocation of global object in js_newcompartment

2012-06-30 Thread Vincent Sanders
On Sat, Jun 30, 2012 at 01:20:01PM +0200, Ole wrote: > Hello, > > this patch tries to avoid repeated initialization of JS context, > altough there is already one setup. > > Maybe an assert(JS_GetGlobalObject(cx) == NULL) would be better > here, because js_newcompartment is not intended to be call

Patch: avoid repeated initialization/allocation of global object in js_newcompartment

2012-06-30 Thread Ole
Hello, this patch tries to avoid repeated initialization of JS context, altough there is already one setup. Maybe an assert(JS_GetGlobalObject(cx) == NULL) would be better here, because js_newcompartment is not intended to be called twice on the same context? (fixes an failed assert in spi

Re: Patch: desktop/textarea.c, add text fragment select on double click

2012-06-30 Thread John-Mark Bell
On Sat, 2012-06-23 at 02:11 +0200, Ole wrote: > >Am Freitag, den 22.06.2012, 00:33 +0200 schrieb John-Mark Bell > > : > > The textarea_select_fragment function looks wrong to me. There seems > > to be some confusion between character indices and byte offsets. > > Attached is a slightly adjuste

SVN is now readonly

2012-06-30 Thread John-Mark Bell
All, As preparation for the move to Git tomorrow, SVN is now read-only. Cheers, J.

Re: JavaScript

2012-06-30 Thread Chris Young
On Sat, 30 Jun 2012 02:13:45 +0200, Ole wrote: > This patch adds support for older spidermonkey versions (tested with > 1.7): > http://pastebin.com/XEUhYhYY That seems to work with 1.5, bar a crash in js_Execute() which I can ignore past (and don't have time to investigate atm). > Also reme

Re: JavaScript

2012-06-30 Thread Rob Kendrick
On Sat, Jun 30, 2012 at 02:13:45AM +0200, Ole wrote: > This patch adds support for older spidermonkey versions (tested with > 1.7): > http://pastebin.com/XEUhYhYY You should probably attach it in an email rather than slap it in a paste bin. B.

Re: JavaScript

2012-06-30 Thread Chris Young
On Fri, 29 Jun 2012 23:16:58 +0100, Vincent Sanders wrote: > the spidermonkey versions i have been targetting are the c API > versions of the 1.8 series so are simply heavy rather than obease Ah, obviously I downloaded the wrong one. > most probably because the JSAPI native calling function spec