On 2024-10-23 19:01:26, Michael Drake wrote:
> On Tue, 22 Oct 2024 at 13:35, Michael Orlitzky wrote:
>
> > One small concern: since we are looking for indices and sheets that the
> > API has just told us exist... if get_sheet() or remove_sheet() fail, an
> > svgtiny_LIBCSS_ERROR doesn't really do
On Tue, 22 Oct 2024 at 13:35, Michael Orlitzky wrote:
> One small concern: since we are looking for indices and sheets that the
> API has just told us exist... if get_sheet() or remove_sheet() fail, an
> svgtiny_LIBCSS_ERROR doesn't really do it justice. Maybe an assert()
> for these as well?
Go
On Mon, 2024-10-21 at 20:36 +0100, Michael Drake wrote:
>
> This fixes it for DOM_NO_MEM_ERR, but in general I think the
> best approach is if a function returns an error code, we should
> handle any non-successful value.
No problem, I changed it.
> However I'm a bit uncomfortable about leaving
On Mon, 21 Oct 2024 at 00:08, Michael Orlitzky wrote:
>
> On Sat, 2024-10-19 at 16:28 +0100, Michael Drake wrote:
> > https://gitweb.michael.orlitzky.com/?p=libsvgtiny.git;a=blob;f=src/svgtiny_css.c;h=96991ddfcfcfe4684b9411709c44367b4651fa92;hb=refs/heads/libcss#l1929
> I fixed the dom_string le
On Sat, 2024-10-19 at 16:28 +0100, Michael Drake wrote:
>
> Sorry it's taken so long. I've finally had another look.
No problem, thanks for taking the time!
> https://gitweb.michael.orlitzky.com/?p=libsvgtiny.git;a=blob;f=src/svgtiny_css.c;h=96991ddfcfcfe4684b9411709c44367b4651fa92;hb=refs/head
On Mon, 14 Oct 2024 at 17:37, Michael Orlitzky wrote:
>
> On Mon, 2023-11-20 at 12:27 -0500, Michael Orlitzky wrote:
> >
> > https://gitweb.michael.orlitzky.com/?p=libsvgtiny.git;a=shortlog;h=refs/heads/libcss
> Any chance I can rekindle the interest in this? I'm still around to
> support the
On Mon, 2023-11-20 at 12:27 -0500, Michael Orlitzky wrote:
> As promised, and only a month late. My branch is available at,
>
> https://gitweb.michael.orlitzky.com/libsvgtiny.git libcss
>
> For best results, you should also apply the libcss patch I recently
> posted that makes fill- and stroke-
On 2024-01-21 15:45:09, Michael Drake wrote:
> Hi Michael,
>
> I'm sorry it's taken so long to get back to you.
No problem, I wasn't expecting it to be a quick review. I've pushed a
few more commits to my branch that fix all of these issues (except
-pedantic, see below).
> When I tried building
Hi Michael,
I'm sorry it's taken so long to get back to you.
I've had a look now.
When I tried building I got a lot of `-Werror=pedantic` warnings due to the use
of a libwapcaplet macro. For example:
src/svgtiny_css.c: In function ‘node_name’:
include/libwapcaplet/libwapcaplet.h:137:29:
