[netsurf-dev] Re: Pull request: CSS support for libsvgtiny

2024-10-30 Thread Michael Orlitzky
On 2024-10-23 19:01:26, Michael Drake wrote: > On Tue, 22 Oct 2024 at 13:35, Michael Orlitzky wrote: > > > One small concern: since we are looking for indices and sheets that the > > API has just told us exist... if get_sheet() or remove_sheet() fail, an > > svgtiny_LIB

[netsurf-dev] Re: Pull request: CSS support for libsvgtiny

2024-10-22 Thread Michael Orlitzky
On Mon, 2024-10-21 at 20:36 +0100, Michael Drake wrote: > > This fixes it for DOM_NO_MEM_ERR, but in general I think the > best approach is if a function returns an error code, we should > handle any non-successful value. No problem, I changed it. > However I'm a bit uncomfortable about leaving

[netsurf-dev] Re: Pull request: CSS support for libsvgtiny

2024-10-20 Thread Michael Orlitzky
On Sat, 2024-10-19 at 16:28 +0100, Michael Drake wrote: > > Sorry it's taken so long. I've finally had another look. No problem, thanks for taking the time! > https://gitweb.michael.orlitzky.com/?p=libsvgtiny.git;a=blob;f=src/svgtiny_css.c;h=96991ddfcfcfe4684b9411709c44367b4651fa92;hb=refs/head

[netsurf-dev] Re: Pull request: CSS support for libsvgtiny

2024-10-14 Thread Michael Orlitzky
On Mon, 2023-11-20 at 12:27 -0500, Michael Orlitzky wrote: > As promised, and only a month late. My branch is available at, > > https://gitweb.michael.orlitzky.com/libsvgtiny.git libcss > > For best results, you should also apply the libcss patch I recently > posted that make

[netsurf-dev] Re: [PATCH] libcss SVG properties fill, stroke and stroke-width

2024-05-02 Thread Michael Orlitzky
On Thu, 2024-05-02 at 17:20 -0600, Rodrigo Hernandez wrote: > Hello, > > The attached patch adds SVG properties fill, stroke and stroke-width as > well as some basic tests to libCSS. > > I noticed that fill and stroke opacity were recently added, and I will > likely be adding more SVG related p

[netsurf-dev] Re: [PATCH] test: nsgif: make failing tests fatal

2024-03-03 Thread Michael Orlitzky
On 2024-02-16 12:49:15, matoro wrote: > Right now, failing tests is not currently considered fatal, and also the > definitions of "error" vs "failure" are reversed from how they are > usually intended. This corrects the usage and makes any instance of > either fatal. > > See: https://github.com/g

[netsurf-dev] Re: netsurf: branch jmb/ssl-purge created. release/3.11-16-g6bb70e881

2024-02-09 Thread Michael Orlitzky
On Thu, 2024-02-08 at 20:48 +, John-Mark Bell wrote: > > This builds fine for me against both OpenSSL 1.1.1 and 3.x. All our SDKs > contain 3.x so CI builds that use it should also be fine. However, I've > not actually tested LibreSSL and I believe at least one of the Amiga > builds uses Am

[netsurf-dev] [PATCH 1/1] bindings/xml/libxml_xmlparser.c: update for libxml2 >= 2.12.0

2024-02-07 Thread Michael Orlitzky
Version 2.12.0 of libxml2 changes a few functions to return (const xmlError *) where previously they returned only (xmlError *). Compilers generally are not happy with this. For example, bindings/xml/libxml_xmlparser.c: In function 'xml_parser_start_document': bindings/xml/libxml_xmlparser.c:3

[netsurf-dev] [PATCH 1/1] bindings/xml/libxml_xmlparser.c: add stdlib.h include

2024-02-03 Thread Michael Orlitzky
This file uses malloc() but does not include stdlib.h directly. With glibc, that apparently works out just fine... but with musl, it leads to implicit declaration warnings/errors, most likely because musl does not include stdlib.h transitively via any of the other headers used by this file. --- bi

[netsurf-dev] Dead mailing list links

2024-02-02 Thread Michael Orlitzky
Just a heads up, the three mailing list links on the "Contacting the Developers" page are down: https://www.netsurf-browser.org/lists/netsurf-users https://www.netsurf-browser.org/lists/netsurf-dev https://www.netsurf-browser.org/lists/netsurf-commits

[netsurf-dev] Re: Pull request: CSS support for libsvgtiny

2024-01-26 Thread Michael Orlitzky
On 2024-01-21 15:45:09, Michael Drake wrote: > Hi Michael, > > I'm sorry it's taken so long to get back to you. No problem, I wasn't expecting it to be a quick review. I've pushed a few more commits to my branch that fix all of these issues (except -pedantic, see below). > When I tried building