Re: [Netstack] reviews, merges, and next steps

2011-07-29 Thread Dan Wendlandt
Great work on the fixes + reviews folks. We now are much closer to having having trunk's unit tests running clean for a D-3 drop. There are two remaining bugs with the unit tests, one of which was discovered only after the other tests were merged into trunk: - https://bugs.launchpad.net/quantum/

Re: [Netstack] reviews, merges, and next steps

2011-07-29 Thread Somik Behera
This is a long awaited branch! It had slipped me, I'll review it soon. Thanks, Somik On Fri, Jul 29, 2011 at 8:45 AM, Salvatore Orlando < salvatore.orla...@eu.citrix.com> wrote: > Hi, > > ** ** > > I would like to add that the branch that fixes most of the failing tests > is: > https://code

Re: [Netstack] reviews, merges, and next steps

2011-07-29 Thread Salvatore Orlando
Hi, I would like to add that the branch that fixes most of the failing tests is: https://code.launchpad.net/~salvatore-orlando/quantum/quantum-api/+merge/65979 This branch has been waiting for a review for a week now. The "needs fixing" vote that you see on the merge proposal is related to a pre

[Netstack] Launchpad: The meaning of "Fix Committed" for bugs

2011-07-29 Thread Salvatore Orlando
Hi all, I think the definition of "Fix Committed" is quite unclear. I've noticed in Quantum developers are updating bugs to this state when a patch/branch is attached. I think the approach in nova, and generally in other Openstack and Launchpad projects, is to update the bug to "fix committed" w

Re: [Netstack] reviews, merges, and next steps

2011-07-29 Thread Dan Wendlandt
Thanks for pointing that out Santhosh. To avoid confusion, I updated the status of the old merge request from "work in progress" to "rejected" to indicate that it is no longer expected to be merged (this should keep the history around, as I did not delete the merge request). The new merge request