Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-10 Thread tanhuazhong
On 2020/12/10 13:40, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen For some new device, it supports forwarding packet to queues of specified TC when flow director rule hit. So extend the command handle to support it. ... static int hclge

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-10 Thread tanhuazhong
On 2020/12/10 12:50, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen Currently, the HNS3 driver only supports offload for tc number and prio_tc. This patch adds support for other qopts, including queues count and offset for each tc. When enable

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-10 Thread tanhuazhong
On 2020/12/11 4:24, Saeed Mahameed wrote: On Thu, 2020-12-10 at 20:27 +0800, tanhuazhong wrote: On 2020/12/10 12:50, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen Currently, the HNS3 driver only supports offload for tc number and prio_tc

Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-10 Thread tanhuazhong
On 2020/12/11 4:46, Saeed Mahameed wrote: On Thu, 2020-12-10 at 20:24 +0800, tanhuazhong wrote: On 2020/12/10 13:40, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen For some new device, it supports forwarding packet to queues of specified TC

Re: [PATCH net-next 2/3] net: hns3: add priv flags support to switch limit promisc mode

2020-12-05 Thread tanhuazhong
On 2020/12/5 10:24, Jakub Kicinski wrote: On Thu, 3 Dec 2020 20:18:55 +0800 Huazhong Tan wrote: @@ -224,6 +224,7 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en, static int hclge_set_vf_promisc_mode(struct hclge_vport *vport,

Re: [PATCH net-next 3/3] net: hns3: refine the VLAN tag handle for port based VLAN

2020-12-05 Thread tanhuazhong
On 2020/12/5 10:22, Jakub Kicinski wrote: On Thu, 3 Dec 2020 20:18:56 +0800 Huazhong Tan wrote: tranmist Please spell check the commit messages and comments. will fix spelling mistakes, thanks .

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -433,6 +433,7 @@ struct ethtool_modinfo { *a TX interrupt, when the pac

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/20 6:02, Michal Kubecek wrote: On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/20 6:02, Michal Kubecek wrote: On Thu, Nov 19, 2020 at 04:56:42PM +0800, tanhuazhong wrote: On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread tanhuazhong
On 2020/11/21 5:22, Michal Kubecek wrote: On Fri, Nov 20, 2020 at 02:39:38PM +0100, Andrew Lunn wrote: On Fri, Nov 20, 2020 at 08:23:22AM +0100, Michal Kubecek wrote: On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: On 2020/11/20 6:02, Michal Kubecek wrote: We could use a

Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread tanhuazhong
On 2020/11/20 23:25, Andrew Lunn wrote: @@ -310,6 +334,13 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct genl_info *info) ret = dev->ethtool_ops->set_coalesce(dev, &coalesce); if (ret < 0) goto out_ops; + + if (ops->set_ext_coalesce) { +

Re: [PATCH net-next 5/7] net: hns3: add more info to hns3_dbg_bd_info()

2020-11-27 Thread tanhuazhong
On 2020/11/28 4:53, Jakub Kicinski wrote: On Fri, 27 Nov 2020 16:47:20 +0800 Huazhong Tan wrote: Since TX hardware checksum and RX completion checksum have been supported now, so add related information in hns3_dbg_bd_info(). Signed-off-by: Huazhong Tan drivers/net/ethernet/hisilicon/hns3

Re: [PATCH net-next 1/7] net: hns3: add support for RX completion checksum

2020-11-27 Thread tanhuazhong
On 2020/11/28 4:52, Jakub Kicinski wrote: On Fri, 27 Nov 2020 16:47:16 +0800 Huazhong Tan wrote: In some cases (for example ip fragment), hardware will calculate the checksum of whole packet in RX, and setup the HNS3_RXD_L2_CSUM_B flag in the descriptor, so add support to utilize this checksu

Re: [PATCH V2 net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting

2020-11-10 Thread tanhuazhong
On 2020/11/11 9:13, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:29 +0800 Huazhong Tan wrote: + if (rx_vector->tx_group.coal.ql_enable) Is this supposed to be rx_group, not tx? yes, will fix it. thanks. + hns3_set_vector_coalesce_r

Re: [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation

2020-11-10 Thread tanhuazhong
On 2020/11/11 9:20, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote: Add dynamic interrupt moderation support for the HNS3 driver. Signed-off-by: Huazhong Tan I'm slightly confused here. What does the adaptive moderation do in your driver/device if you still nee

Re: [PATCH V2 net-next 09/11] net: hns3: add support for EQ/CQ mode configuration

2020-11-10 Thread tanhuazhong
On 2020/11/11 9:25, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:37 +0800 Huazhong Tan wrote: For device whose version is above V3(include V3), the GL can select EQ or CQ mode, so adds support for it. In CQ mode, the coalesced timer will restart upon new completion, while in EQ mode, the t

Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

2020-11-10 Thread tanhuazhong
On 2020/11/11 9:28, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote: Since user may need to check the current configuration of the interrupt coalesce, so add debugfs support for query this info, which includes DIM profile, coalesce configuration of both software and

Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

2020-11-11 Thread tanhuazhong
On 2020/11/12 0:15, Jakub Kicinski wrote: On Wed, 11 Nov 2020 11:16:37 +0800 tanhuazhong wrote: On 2020/11/11 9:28, Jakub Kicinski wrote: On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote: Since user may need to check the current configuration of the interrupt coalesce, so add debugfs

Re: [PATCH V3 net-next 06/10] net: hns3: add ethtool priv-flag for DIM

2020-11-16 Thread tanhuazhong
On 2020/11/15 2:54, Jakub Kicinski wrote: On Thu, 12 Nov 2020 11:33:14 +0800 Huazhong Tan wrote: Add a control private flag in ethtool for enable/disable DIM feature. Signed-off-by: Huazhong Tan Please work on a common ethtool API for the configuration instead of using private flags. Pri

Re: [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration

2020-11-08 Thread tanhuazhong
On 2020/11/8 1:46, Jakub Kicinski wrote: On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote: For device whose version is above V3(include V3), the GL configuration can set as 1us unit, so adds support for configuring this field. Signed-off-by: Huazhong Tan Doesn't build. drivers/net/et

Re: [PATCH net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ

2020-11-08 Thread tanhuazhong
On 2020/11/8 1:47, Jakub Kicinski wrote: On Sat, 7 Nov 2020 14:31:20 +0800 Huazhong Tan wrote: +static void hns3_update_cqe_mode(struct net_device *netdev, bool enable, bool is_tx) Wrap this to 80 characters, please. Will fix it. Thanks .

Re: [PATCH net-next v3 05/10] net: sched: add API for registering unlocked offload block callbacks

2019-08-28 Thread tanhuazhong
On 2019/8/26 21:45, Vlad Buslov wrote: Extend struct flow_block_offload with "unlocked_driver_cb" flag to allow registering and unregistering block hardware offload callbacks that do not require caller to hold rtnl lock. Extend tcf_block with additional lockeddevcnt counter that is incremented

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-26 Thread tanhuazhong
Hi Stephen & David, It is my mistake, so sorry about this. There is a redundant "net: hns3: " in the fixes tag. How could I fix it? Thanks. On 2019/2/25 16:00, Stephen Rothwell wrote: Hi all, In commit a638b1d8cc87 ("net: hns3: fix get VF RSS issue") Fixes tag Fixes: 374ad291762a

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-26 Thread tanhuazhong
On 2019/2/27 10:23, Stephen Rothwell wrote: Hi, On Wed, 27 Feb 2019 09:12:57 +0800 tanhuazhong wrote: It is my mistake, so sorry about this. There is a redundant "net: hns3: " in the fixes tag. How could I fix it? Since Dave doesn't rebase his tree, there is no way to fi

Re: [PATCH net] net: hns3: add rmb() for rx description

2019-03-04 Thread tanhuazhong
On 2019/3/4 13:15, David Miller wrote: From: Huazhong Tan Date: Sat, 2 Mar 2019 16:49:30 +0800 From: Jian Shen HW can not guarantee complete write desc->rx.size, even though HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction to make sure desc->rx.size is always valid. Fix

Re: [PATCH net-next] net: hns3: adds support for reading module eeprom info

2020-04-28 Thread tanhuazhong
On 2020/4/29 2:49, Jakub Kicinski wrote: On Tue, 28 Apr 2020 19:58:25 +0800 Huazhong Tan wrote: From: Yonglong Liu This patch adds support for reading the optical module eeprom info via "ethtool -m". Signed-off-by: Yonglong Liu Signed-off-by: Huazhong Tan diff --git a/drivers/net/ethe

Re: [PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-07 Thread tanhuazhong
On 2020/9/7 17:22, Willem de Bruijn wrote: On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote: On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote: There are two updates relates to UDP GSO. #1 adds a new GSO type for UDPv6 #2 adds check for UDP GSO when csum is disable in netdev_fix_feat

Re: [PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-07 Thread tanhuazhong
On 2020/9/7 23:35, Willem de Bruijn wrote: On Mon, Sep 7, 2020 at 3:38 PM tanhuazhong wrote: On 2020/9/7 17:22, Willem de Bruijn wrote: On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote: On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote: There are two updates relates to UDP GSO

Re: [RFC net-next] udp: add a GSO type for UDPv6

2020-09-02 Thread tanhuazhong
On 2020/9/2 22:33, Willem de Bruijn wrote: On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan wrote: In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4

Re: [RFC net-next] udp: add a GSO type for UDPv6

2020-09-02 Thread tanhuazhong
On 2020/9/3 6:43, David Miller wrote: From: Huazhong Tan Date: Wed, 2 Sep 2020 20:15:11 +0800 In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4

RE: [PATCH net-next 02/12] net: hns3: add rx multicast packets statistic

2019-01-22 Thread tanhuazhong
-Original Message- From: Eric Dumazet [mailto:eric.duma...@gmail.com] Sent: Wednesday, January 23, 2019 2:39 AM To: tanhuazhong ; da...@davemloft.net Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; huangdaode ; Zhuangyuzeng (Yisen) ; Salil Mehta ; Linuxarm ; shenjian (K

Re: [Patch net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()

2018-10-27 Thread tanhuazhong
On 2018/10/28 3:02, Sergei Shtylyov wrote: Hello! On 27.10.2018 5:41, Huazhong Tan wrote: It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be resetted    s/resetted/reset/. OK, thanks. in the up operato

Re: [Patch net 09/11] net: hns3: bugfix for handling mailbox while the command queue reinitialized

2018-10-27 Thread tanhuazhong
On 2018/10/28 3:05, Sergei Shtylyov wrote: On 27.10.2018 5:41, Huazhong Tan wrote: In a multi-core machine, the mailbox service and reset service will be executed at the same time. The reset server will re-initialize the commond queue, before that, the mailbox handler can only get some   

Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()

2018-10-28 Thread tanhuazhong
On 2018/10/28 16:09, Sergei Shtylyov wrote: Hello! On 28.10.2018 6:34, Huazhong Tan wrote: It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be reset in the up operaton. And the judgment of the HCLGE_STATE_RST_HA

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread tanhuazhong
On 2018/10/30 1:44, Joe Perches wrote: On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. [] diff --git a/drivers/net/ethernet/hisilicon/hn

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread tanhuazhong
On 2018/10/30 9:31, Joe Perches wrote: On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote: On 2018/10/30 1:44, Joe Perches wrote: On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add

Re: [Patch V4 net 02/11] net: hns3: add error handler for hns3_get_ring_config/hns3_queue_to_ring

2018-10-30 Thread tanhuazhong
On 2018/10/30 17:09, Sergei Shtylyov wrote: Hello! On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_get_ring_config()/hns3_queue_to_ring() failed during resetting, the allocated memory has not been freed before hns3_get_ring_config() and hns3_queue_to_ring() return. So this patch fixes

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-30 Thread tanhuazhong
On 2018/10/30 17:11, Sergei Shtylyov wrote: On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Eth

Re: [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client

2020-05-10 Thread tanhuazhong
On 2020/5/10 4:48, Jakub Kicinski wrote: On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote: This patch provides a new interface for the client to query whether CMDQ is ready to work. Signed-off-by: Huazhong Tan diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/et

Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F

2020-05-13 Thread tanhuazhong
On 2020/5/13 21:12, Andrew Lunn wrote: On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote: From: Yufeng Mo PHY loopback is already supported by genphy driver. This patch adds the set_loopback interface to RTL8211F PHY driver, so the PHY selftest can run properly on it. Signed-off

Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F

2020-05-17 Thread tanhuazhong
On 2020/5/13 21:12, Andrew Lunn wrote: On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote: From: Yufeng Mo PHY loopback is already supported by genphy driver. This patch adds the set_loopback interface to RTL8211F PHY driver, so the PHY selftest can run properly on it. Signed-off

Re: [PATCH net-next 00/11] net: hns3: misc updates for -next

2020-05-28 Thread tanhuazhong
Sorry, please ignore this patchset, will resend it later. On 2020/5/28 20:45, Huazhong Tan wrote: This patchset includes some updates for the HNS3 ethernet driver. #1 adds a missing mutex destroy. #2&3 refactor two function, make them more readable and maintainable. #4&5 fix unsuitable type of

Re: [PATCH 02/12] net: hns3: Destroy a mutex after initialisation failure in hclge_init_ad_dev()

2020-05-28 Thread tanhuazhong
On 2020/5/29 2:42, Markus Elfring wrote: Add a mutex destroy call in hclge_init_ae_dev() when fails. How do you think about a wording variant like the following? Change description: The function “mutex_init” was called before a call of the function “hclge_pci_init”. But the

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

2020-05-20 Thread tanhuazhong
On 2020/5/21 5:06, Jakub Kicinski wrote: On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: From: GuoJia Liao There is a scenario which needs vNICs enable the VLAN filter in access port, while disable the VLAN filter in trunk port. Access port and trunk port can switch according to the

Re: [PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

2020-05-20 Thread tanhuazhong
On 2020/5/21 9:36, Jakub Kicinski wrote: On Thu, 21 May 2020 09:33:14 +0800 tanhuazhong wrote: On 2020/5/21 5:06, Jakub Kicinski wrote: On Wed, 20 May 2020 09:20:12 +0800 Huazhong Tan wrote: From: GuoJia Liao There is a scenario which needs vNICs enable the VLAN filter in access port

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-22 Thread tanhuazhong
On 2020/5/22 5:37, David Miller wrote: From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] adds support for 'QoS' field to PVID. Change

Re: [PATCH net-next 1/5] net: hns3: add support for VF to query ring and vector mapping

2020-05-22 Thread tanhuazhong
On 2020/5/23 1:39, Jakub Kicinski wrote: On Fri, 22 May 2020 10:49:42 +0800 Huazhong Tan wrote: From: Guangbin Huang This patch adds support for VF to query the mapping of ring and vector. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan Hi, Jakub. Could you explain a lit

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-26 Thread tanhuazhong
On 2020/5/22 17:35, tanhuazhong wrote: On 2020/5/22 5:37, David Miller wrote: From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2

Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO

2020-07-08 Thread tanhuazhong
On 2020/7/8 13:26, Eric Dumazet wrote: On 7/7/20 8:48 PM, Huazhong Tan wrote: Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with s/NETIF_F_SOFTWARE_GSO/NETIF_F_GSO_UDP_L4/ yes, thanks. a software fallback. This allows UDP GSO to be used even if the hardware does not supp

Re: [RFC net-next 2/2] net: disable UDP GSO feature when CSUM is disabled

2020-07-08 Thread tanhuazhong
On 2020/7/8 13:36, Eric Dumazet wrote: On 7/7/20 8:48 PM, Huazhong Tan wrote: Since UDP GSO feature is depended on checksum offload, so disable UDP GSO feature when CSUM is disabled, then from user-space also can see UDP GSO feature is disabled. Signed-off-by: Huazhong Tan --- net/core/

Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO

2020-07-08 Thread tanhuazhong
On 2020/7/8 20:11, Willem de Bruijn wrote: On Tue, Jul 7, 2020 at 11:50 PM Huazhong Tan wrote: Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with a software fallback. This allows UDP GSO to be used even if the hardware does not support it, That is already the case if just call

Re: [RFC net-next 2/2] net: disable UDP GSO feature when CSUM is disabled

2020-07-08 Thread tanhuazhong
On 2020/7/9 10:47, Eric Dumazet wrote: On 7/8/20 7:30 PM, tanhuazhong wrote: On 2020/7/8 13:36, Eric Dumazet wrote: On 7/7/20 8:48 PM, Huazhong Tan wrote: Since UDP GSO feature is depended on checksum offload, so disable UDP GSO feature when CSUM is disabled, then from user-space

答复: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread tanhuazhong
Sorry, please ignore this patch. I will resend it. -邮件原件- 发件人: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] 代表 Huazhong Tan 发送时间: 2018年8月1日 17:53 收件人: da...@davemloft.net 抄送: netdev@vger.kernel.org; Linuxarm 主题: [Patch net-next] net: hns3: fix return value error whi

Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed

2018-08-01 Thread tanhuazhong
On 2018/8/2 1:03, David Miller wrote: From: Huazhong Tan Date: Wed, 1 Aug 2018 17:53:28 +0800 From: fredalu While cleaning the command queue, the value of the HEAD register is not in the range of next_to_clean and next_to_use, meaning that this value is invalid. This also means that there