Re: [PATCH net-next] netfilter: nf_conntrack_bridge: Fix build error without IPV6

On 2019/5/31 16:02, Pablo Neira Ayuso wrote: > On Fri, May 31, 2019 at 11:06:49AM +0800, Yuehaibing wrote: >> +cc netdev >> >> On 2019/5/31 10:46, YueHaibing wrote: >>> Fix gcc build error while CONFIG_IPV6 is not set >>> >>> In file included fro

[PATCH net-next] can: sja1000: f81601: remove unused including

Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/net/can/sja1000/f81601.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/sja1000/f81601.c b/drivers/net/can/sja1000/f81601.c index 362a9d4f44d5..8f25e95814ef 100644 --- a/drivers/net/can/sj

[PATCH net-next] can: ti_hecc: remove set but not used variable 'mbx_mask'

-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/can/ti_hecc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index b62f75fa03f0..e63e2f86c289 100644 --- a/drivers/net/can/ti_hecc.c +++ b/drivers/net/can/ti_hec

[PATCH net-next] can: kvaser_pciefd: Remove unused including

Remove including that don't need it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/can/kvaser_pciefd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c index 3af747cbbde4..952a022b8343 100644 --- a/dr

[PATCH v2] team: Add vlan tx offload to hw_enc_features

We should also enable team's vlan tx offload in hw_enc_features, pass the vlan packets to the slave devices with vlan tci, let the slave handle vlan tunneling offload implementation. Fixes: 3268e5cb494d ("team: Advertise tunneling offload features") Signed-off-by: YueHaibing ---

[PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR'

never returns NULL, so NULL test should be removed. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c | 2 +-

[PATCH] net: macb: Fix passing zero to 'PTR_ERR'

Check PTR_ERR with IS_ERR to fix this. Fixes: cd5afa91f078 ("net: macb: Add null check for PCLK and HCLK") Signed-off-by: YueHaibing --- drivers/net/ethernet/cadence/macb_main.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethern

[PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()

quot;) Signed-off-by: YueHaibing --- drivers/net/dsa/sja1105/sja1105_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.c b/drivers/net/dsa/sja1105/sja1105_ptp.c index 1b90570b257b..1e41d491c854 100644 --- a/drivers/net/dsa/sja1105/sja1105_ptp.c +

[PATCH] nfp: Fix passing zero to 'PTR_ERR'

nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns NULL. The NULL test should be removed, also return correct err. Fixes: 63461a028f76 ("nfp: add the PF driver") Signed-off-by: YueHaibing --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 4 +--- 1 file changed, 1 inser

[PATCH net-next] liquidio: cn68xx: Remove duplicated include

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 2a6d1cadac9e

[PATCH net-next] net: hns3: Remove duplicated include

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index 3606240025a8

[PATCH net-next] net/mlx5e: Remove duplicated include

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 599f5b5ebc97..58c177756dc4 100644

[PATCH] sfp: Fix error handing in sfp_probe()

gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next] openvswitch: Use IS_ERR instead of IS_ERR_OR_NULL

Fix smatch warning: net/openvswitch/meter.c:427 ovs_meter_cmd_set() warn: passing zero to 'PTR_ERR' dp_meter_create() never returns NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. Signed-off-by: YueHaibing --- net/openvswitch/meter.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next] netfilter: conntrack: Remove unused variable declaration

commit e97c3e278e95 ("tproxy: split off ipv6 defragmentation to a separate module") left behind this. Signed-off-by: YueHaibing --- include/net/netfilter/ipv6/nf_conntrack_ipv6.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/net/netfilter/ipv6/nf_conntrack_ipv6.h b/i

[PATCH -next] vdpa: Remove duplicate include

Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vhost/vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f88894..95e2b8307a2a 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -22,7 +22,6

[PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- drivers/net/

Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

On 2020/8/18 22:51, Andreas Schwab wrote: > On Aug 18 2020, YueHaibing wrote: > >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >> >> Fixes

[PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- v2: use rc to do err ha

Re: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

On 2020/8/19 1:04, Andrew Lunn wrote: > On Tue, Aug 18, 2020 at 11:15:00PM +0800, YueHaibing wrote: >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >&

[PATCH net-next] libcxgb,cxgb4: use __skb_put_zero to simplfy code

use helper __skb_put_zero to replace the pattern of __skb_put() && memset() Signed-off-by: YueHaibing --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4/srq.c | 3 +-- drivers/net/ethernet/chelsio/libcxgb/libcxgb_c

[PATCH net-next] can: dev: use skb_put_zero to simplfy code

use helper skb_put_zero to replace the pattern of skb_put() && memset() Signed-off-by: YueHaibing --- drivers/net/can/dev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b177956..d8140a9 100644 --- a/drivers

[PATCH bpf] tools: bpf: fix NULL return handling in bpf__prepare_load

bpf_object__open()/bpf_object__open_buffer can return error pointer or NULL, check the return values with IS_ERR_OR_NULL() in bpf__prepare_load and bpf__prepare_load_buffer Signed-off-by: YueHaibing --- tools/perf/util/bpf-loader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH] mac80211_hwsim: fix a possible memory leak in hwsim_new_radio_nl()

'hwname' should be freed before leaving from the error handling cases, otherwise it will cause mem leak Fixes: cb1a5bae5684 ("mac80211_hwsim: add permanent mac address option for new radios") Signed-off-by: YueHaibing --- drivers/net/wireless/mac80211_hwsim.c | 1 + 1 file

[PATCH net-next] bridge: use hlist_entry_safe

Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 --- a/net/bridge/br_forward.c +++ b/net

Re: [PATCH] mac80211_hwsim: fix a possible memory leak in hwsim_new_radio_nl()

cc Ben Hutchings On 2018/4/24 11:08, YueHaibing wrote: > 'hwname' should be freed before leaving from the error handling cases, > otherwise it will cause mem leak > > Fixes: cb1a5bae5684 ("mac80211_hwsim: add permanent mac address option for > new radios

[PATCH] ptp_pch: use helpers function for converting between ns and timespec

use ns_to_timespec64() and timespec64_to_ns() instead of open coding Signed-off-by: YueHaibing --- drivers/ptp/ptp_pch.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index b328517..78ccf93 100644 --- a/drivers/ptp

[PATCH net-next] net: socionext: remove set but not used variable 'pkts'

ince commit ba2b232108d3 ("net: netsec: add XDP support") Signed-off-by: YueHaibing --- drivers/net/ethernet/socionext/netsec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index

[PATCH v2 net-next] net: socionext: remove set but not used variable 'pkts'

next/netsec.c:637:15: warning: variable 'pkts' set but not used [-Wunused-but-set-variable] It is not used since commit ba2b232108d3 ("net: netsec: add XDP support") Signed-off-by: YueHaibing Acked-by: Ilias Apalodimas --- v2: keep reverse christmas-tree ordering of the l

[PATCH v3 net-next] net: socionext: remove set but not used variable 'pkts'

ince commit ba2b232108d3 ("net: netsec: add XDP support") Signed-off-by: YueHaibing Acked-by: Ilias Apalodimas --- v3: remove misplaced cc in patch log v2: keep reverse christmas-tree ordering of the local variables --- drivers/net/ethernet/socionext/netsec.c | 3 +-- 1 file changed, 1 in

[PATCH net-next] net: dsa: vsc73xx: Fix Kconfig warning and build errors

d5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver") Signed-off-by: YueHaibing --- v2: Use "depends on" instead of "select" NET_DSA_VITESSE_VSC73XX --- drivers/net/dsa/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/Kconfig

[PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- kernel/bpf/xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 4cc28e226398..942c662e2eed 100644 --- a/kernel/bpf/xskmap.c +++ b

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

On 2019/8/20 17:44, Dan Carpenter wrote: > On Tue, Aug 20, 2019 at 11:25:29AM +0200, Björn Töpel wrote: >> On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: >>> >>> On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: For future patches: Prefix AF_XDP socket work with "xsk:" and use

[PATCH net-next] cirrus: cs89x0: remove set but not used variable 'lp'

6751edeb8700 ("cirrus: cs89x0: Use managed interfaces") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ethernet/cirrus/cs89x0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c index

[PATCH v2 net-next] cirrus: cs89x0: remove set but not used variable 'lp'

Fixes: 6751edeb8700 ("cirrus: cs89x0: Use managed interfaces") Signed-off-by: YueHaibing --- v2: add Fixes tag --- drivers/net/ethernet/cirrus/cs89x0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c index

[PATCH net-next] net: hns3: remove set but not used variable 'qos'

but-set-variable] Reported-by: Hulk Robot Fixes: 70a214903da9 ("net: hns3: reduce the parameters of some functions") Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethern

Re: [PATCH net-next] yellowfin: fix remove set but not used variable warning

On 2019/2/19 4:13, David Miller wrote: > From: YueHaibing > Date: Mon, 18 Feb 2019 08:15:46 + > >> @@ -1050,8 +1050,11 @@ static int yellowfin_rx(struct net_device *dev) >> struct sk_buff *rx_skb = yp->rx_skbuff[entry]; >> s16 fra

[PATCH net-next] net: rose: add missing dev_put() on error in rose_bind

when capable check failed, dev_put should be call before return -EACCES. Signed-off-by: YueHaibing --- net/rose/af_rose.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index d00a0ef..c96f63f 100644 --- a/net/rose/af_rose.c +++ b

[PATCH net-next] mlxsw: spectrum: remove set but not used variable 'autoneg_status'

t-set-variable] It's not used since commit 475b33cb66c9 ("mlxsw: spectrum: Remove unsupported eth_proto_lp_advertise field in PTYS") Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethe

[PATCH] ath9k: remove set but not used variable 'acq'

ter 89cea7493a34 ("ath9k: Switch to mac80211 TXQ scheduling and airtime APIs"). Also remove related variables. Signed-off-by: YueHaibing --- drivers/net/wireless/ath/ath9k/recv.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/re

Re: [PATCH] xfrm: correctly check policy index in verify_newpolicy_info

Pls ignore this, sorry On 2019/2/25 17:27, Yue Haibing wrote: > From: YueHaibing > > UBSAN report this: > > UBSAN: Undefined behaviour in net/xfrm/xfrm_policy.c:1289:24 > index 6 is out of range for type 'unsigned int [6]' > CPU: 1 PID: 0 Comm: swapper/1 Not ta

[PATCH] cfg80211: Use kmemdup in cfg80211_gen_new_ie()

Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- net/wireless/scan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 287518c6caa4..04d888628f29 100644 --- a/net/wireless/scan.c +++ b/net

[PATCH] rtlwifi: rtl8723be: Remove set but not used variable 'b_last_is_cur_rdlstate'

sed [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwif

[PATCH] rtlwifi: rtl8192se: Remove set but not used variable 'seg_ptr'

t-set-variable] It's not used after commit 59ae1d127ac0 ("networking: introduce and use skb_put_data()") Signed-off-by: YueHaibing --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/fw.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/

[PATCH] rtlwifi: rtl8723ae: Remove set but not used variable 'bt_retry_cnt'

sed [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c b/drivers/net/wireless/realte

Re: [PATCH v2] xfrm: correctly check policy index in verify_newpolicy_info

On 2019/2/25 21:43, Herbert Xu wrote: > On Mon, Feb 25, 2019 at 05:56:00PM +0800, Yue Haibing wrote: >> >> the check. Then __xfrm_policy_unlink use the index to access array >> policy_count >> whose size is XFRM_POLICY_MAX * 2, triggering out of bounds access. > > No it doesn't. Even if it did t

Re: [PATCH] appletalk: Fix use-after-free in atalk_proc_exit

On 2019/2/28 2:14, David Miller wrote: > From: Yue Haibing > Date: Wed, 27 Feb 2019 22:59:00 +0800 > >> @@ -1925,7 +1925,10 @@ static int __init atalk_init(void) >> >> register_netdevice_notifier(&ddp_notifier); >> aarp_proto_init(); >> -atalk_proc_init(); >> +rc = atalk_proc_

Re: [PATCH -next] appletalk: use remove_proc_subtree to simplify procfs code

On 2019/2/28 7:28, kbuild test robot wrote: > Hi YueHaibing, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on next-20190227] > > url: > https://github.com/0day-ci/linux/commits/Yue-Haibing/appletalk-use-remove_proc_subtree

Re: [PATCH v2] xfrm: policy: Fix possible user after free in __xfrm_policy_unlink

On 2019/2/28 14:41, Herbert Xu wrote: > On Thu, Feb 28, 2019 at 02:38:01PM +0800, Yue Haibing wrote: >> >> diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c >> index a131f9f..aaa45c9 100644 >> --- a/net/xfrm/xfrm_user.c >> +++ b/net/xfrm/xfrm_user.c >> @@ -1424,7 +1424,8 @@ static int veri

Re: [PATCH v3] xfrm: policy: Fix possible user after free in __xfrm_policy_unlink

Pls ignore this, will fix the patch title On 2019/2/28 14:56, Yue Haibing wrote: > From: YueHaibing > > UBSAN report this: > > UBSAN: Undefined behaviour in net/xfrm/xfrm_policy.c:1289:24 > index 6 is out of range for type 'unsigned int [6]' > CPU: 1 PID: 0 Comm

Re: [PATCH v2 -next] appletalk: use remove_proc_subtree to simplify procfs code

Pls igore this, will resend a new serials with another patch. On 2019/2/28 9:31, Yue Haibing wrote: > From: YueHaibing > > Use remove_proc_subtree to remove the whole subtree > on cleanup.Also do some cleanup. > > Signed-off-by: YueHaibing > --- > net/app

Re: [PATCH v2] appletalk: Fix use-after-free in atalk_proc_exit

On 2019/2/28 20:38, kbuild test robot wrote: > Hi YueHaibing, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > [also build test WARNING on v5.0-rc8 next-20190228] > [if your patch is applied to the wrong git t

Re: [PATCH 0/2] appletalk: A cleanup and bugfix

On 2019/3/1 4:44, David Miller wrote: > > This series mixes cleanups with a bug fix. > > The cleanup is only appropriate for net-next, and the bug fix is > appropriate for net. patch 2 is based on patch 1 now, atalk_proc_exit context is changed, if they go separately, a small conflict will occur

Re: [PATCH] appletalk: Correctly handle return value of register_snap_client

On 2019/3/7 2:17, David Miller wrote: > From: Yue Haibing > Date: Wed, 6 Mar 2019 15:27:40 +0800 > >> @@ -879,15 +879,17 @@ static struct notifier_block aarp_notifier = { >> >> static unsigned char aarp_snap_id[] = { 0x00, 0x00, 0x00, 0x80, 0xF3 }; >> >> -void __init aarp_proto_init(void) >>

Re: [PATCH v2] appletalk: Correctly check return value of register_snap_client

ping. On 2019/3/7 10:22, Yue Haibing wrote: > From: YueHaibing > > register_snap_client may return NULL, all the callers > check it, but only print a warning. This will result in > NULL pointer dereference in unregister_snap_client and other > places. > > It has al

Re: [PATCH] proc/sysctl: Fix NULL pointer dereference in put_links

ping. On 2019/3/4 21:54, Yue Haibing wrote: > From: YueHaibing > > Syzkaller report this: > > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] SMP KASAN PTI > CPU: 1 PID: 5373 Comm: syz-executor.0 Not tainted 5.0.0-rc

Re: [PATCH] proc/sysctl: Fix NULL pointer dereference in put_links

+cc Al Viro On 2019/3/4 21:54, Yue Haibing wrote: > From: YueHaibing > > Syzkaller report this: > > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] SMP KASAN PTI > CPU: 1 PID: 5373 Comm: syz-executor.0 Not

Re: [PATCH] proc/sysctl: Fix NULL pointer dereference in put_links

path of get_subdir -->put_links //call xlate_dir whose 2nd param is '&new->header->parent' --> xlate_dir //access dir->header,however 'dir' is NULL which comes from '&new->header->parent' Please co

Re: [PATCH v2] appletalk: Correctly check return value of register_snap_client

Hi David, Is there something need do for this patch? Pls let me know. I saw the patchwork status labled to 'Not Applicable' https://patchwork.ozlabs.org/patch/1052624/ On 2019/3/7 10:22, Yue Haibing wrote: > From: YueHaibing > > register_snap_client may return NULL, all

Re: BUG: KASAN: use-after-free Read in tun_net_xmit

On 2019/4/24 17:11, Jason Wang wrote: > > On 2019/4/24 上午12:41, Cong Wang wrote: >> On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote: >>> >>> On 2019/4/23 下午2:00, Cong Wang wrote: >>>> On Mon, Apr 22, 2019 at 2:41 AM Jason Wang wrote: >>>>&

Re: BUG: KASAN: use-after-free Read in tun_net_xmit

On 2019/4/24 20:25, YueHaibing wrote: > On 2019/4/24 17:11, Jason Wang wrote: >> >> On 2019/4/24 上午12:41, Cong Wang wrote: >>> On Mon, Apr 22, 2019 at 11:42 PM Jason Wang wrote: >>>> >>>> On 2019/4/23 下午2:00, Cong Wang wrote: >>>>> On

[PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

Change the call to PTR_ERR to access the value just tested by IS_ERR. Signed-off-by: YueHaibing --- drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index c3cba46fac9d..e37680654a13

[PATCH net-next] bpf: Use PTR_ERR_OR_ZERO in bpf_fd_sk_storage_update_elem()

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- net/core/bpf_sk_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c index a8e9ac71b22d..cc9597a87770 100644 --- a/net/core

Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

On 2019/4/29 21:56, Andrew Lunn wrote: > On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote: >> Change the call to PTR_ERR to access the value just tested by IS_ERR. >> >> Signed-off-by: YueHaibing > > Please could you add a Fixes: tag. > Ok, will sendv2,

[PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

Change the call to PTR_ERR to access the value just tested by IS_ERR. Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn --- v2: add Fixes tag --- drivers/net/ethernet/ti/cpsw.c | 2

Re: [PATCH v2 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

On 2019/4/30 0:30, Julia Lawall wrote: > > > On Mon, 29 Apr 2019, YueHaibing wrote: > >> Change the call to PTR_ERR to access the value just tested by IS_ERR. > > I assume you didn't find the problem just looking through the code by > hand. If you used a

[PATCH v3 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe, The proper pointer to use is clk instead of mode. This issue was detected with the help of Coccinelle. Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization") Signed-off-by: YueHaibing R

[PATCH net-next] net: mvpp2: cls: Remove set but not used variable 'act'

iable] It is never used since introduction in commit 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support") Signed-off-by: YueHaibing --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls

Re: [PATCH] packet: Fix error path in packet_init

On 2019/5/8 23:50, Eric Dumazet wrote: > On Wed, May 8, 2019 at 8:33 AM YueHaibing wrote: >> >> kernel BUG at lib/list_debug.c:47! >> invalid opcode: [#1 >> CPU: 0 PID: 11195 Comm: rmmod Tainted: GW 5.1.0+ #33 >> Hardware name: QEMU Standa

[PATCH] net/smc: Fix error path in smc_init

If register_pernet_subsys success in smc_init, we should cleanup it in case any other error. Fixes: 64e28b52c7a6 (net/smc: add pnet table namespace support") Signed-off-by: YueHaibing --- net/smc/af_smc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/smc/af_sm

[PATCH] ppp: deflate: Fix possible crash in deflate_init

initialization failed out, however ppp_deflate_draft may has been regiestred and not unregistered before return. Then the seconed modprobe will trigger crash like this. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ppp/ppp_deflate.c | 14 +- 1 file changed, 9

Re: [PATCH] ppp: deflate: Fix possible crash in deflate_init

On 2019/5/14 22:05, Guillaume Nault wrote: > On Tue, May 14, 2019 at 03:43:00PM +0800, YueHaibing wrote: >> >> If ppp_deflate fails to register in deflate_init, >> module initialization failed out, however >> ppp_deflate_draft may has been regiestred and not >> un

[PATCH v2] ppp: deflate: Fix possible crash in deflate_init

initialization failed out, however ppp_deflate_draft may has been regiestred and not unregistered before return. Then the seconed modprobe will trigger crash like this. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- v2: also check ppp_deflate_draft registration --- drivers/net/ppp

[PATCH] ipvs: Fix use-after-free in ip_vs_in

ps_free to free the net_generic directly while __ip_vs_cleanup finished, then calling ip_vs_in will triggers use-after-free. Reported-by: Hulk Robot Fixes: efe41606184e ("ipvs: convert to use pernet nf_hook api") Signed-off-by: YueHaibing --- net/netfilter/ipvs/ip_vs_core.c | 1 + 1

[PATCH] can: Fix error path of can_init

This patch add error path for can_init to avoid possible crash if some error occurs. Fixes: 0d66548a10cb ("[CAN]: Add PF_CAN core module") Signed-off-by: YueHaibing --- net/can/af_can.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git

[PATCH] can: gw: Fix error path of cgw_module_init

This patch fix error path for cgw_module_init to avoid possible crash if some error occurs. Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing") Signed-off-by: YueHaibing --- net/can/gw.c | 46 +++--- 1 file changed, 31 inserti

Re: [PATCH] ipvs: Fix use-after-free in ip_vs_in

On 2019/5/17 15:30, Julian Anastasov wrote: > > Hello, > > On Wed, 15 May 2019, YueHaibing wrote: > >> BUG: KASAN: use-after-free in ip_vs_in.part.29+0xe8/0xd20 [ip_vs] >> Read of size 4 at addr 8881e9b26e2c by task sshd/5603 >> >> CPU: 0 PID: 5

[PATCH v2] ipvs: Fix use-after-free in ip_vs_in

ed grace period. Reported-by: Hulk Robot Fixes: efe41606184e ("ipvs: convert to use pernet nf_hook api") Suggested-by: Julian Anastasov Signed-off-by: YueHaibing --- v2: fix by moving nf_unregister_net_hooks from __ip_vs_cleanup() to __ip_vs_dev_cleanup() --- net/netfilter/ipvs/ip

[PATCH v2] can: gw: Fix error path of cgw_module_init

This patch add error path for cgw_module_init to avoid possible crash if some error occurs. Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing") Signed-off-by: YueHaibing --- net/can/gw.c | 48 +--- 1 file changed, 33 inserti

[PATCH bpf-next] bpf: remove duplicated include from syscall.c

Remove duplicated include. Signed-off-by: YueHaibing --- kernel/bpf/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 8339d81..3c9636f 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -30,7 +30,6 @@ #include #include

[PATCH can-next] can: ucan: remove duplicated include from ucan.c

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/can/usb/ucan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c index 0678a38..c6f4b41 100644 --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb/ucan.c

[PATCH can-next] can: ucan: remove set but not used variable 'udev'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': drivers/net/can/usb/ucan.c:1578:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] struct usb_device *udev; Signed-off-by: YueHai

[PATCH net-next] net/ncsi: remove duplicated include from ncsi-netlink.c

Remove duplicated include. Signed-off-by: YueHaibing --- net/ncsi/ncsi-netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ncsi/ncsi-netlink.c b/net/ncsi/ncsi-netlink.c index 45f33d6..32cb775 100644 --- a/net/ncsi/ncsi-netlink.c +++ b/net/ncsi/ncsi-netlink.c @@ -12,7 +12,6

[PATCH net-next] net: remove duplicated include from net_failover.c

Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/net_failover.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 7ae1856..192ae1c 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -19,7

[PATCH net-next] failover: remove set but not used variable 'primary_dev'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing ---

[PATCH net-next] bnxt_en: remove set but not used variable 'rx_stats'

ct bnxt_vf_rep_stats *rx_stats; Signed-off-by: YueHaibing --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c index e31f5d8..b574fe8 100644 --- a/driv

[PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

t-set-variable] Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c index bd0153e..c6f4cbd 100

Re: [PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

sorry, patch description is messy, will fix it in V2. On 2018/8/31 19:53, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/request_manager.c: In function > 'lio_process_iq_request_list': > d

[PATCH v2 net-next] liquidio: remove set but not used variable 'irh'

t-set-variable] Signed-off-by: YueHaibing --- v2: fix patch description,remove 'cHECK-' --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

On 2018/9/1 0:39, Samudrala, Sridhar wrote: > On 8/30/2018 8:46 PM, YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/net_failover.c: In function 'net_failover_slave_unregister': >> drivers/net/net_failover.c:5

[PATCH net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

alidity of 'slave_dev'. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Suggested-by: Samudrala, Sridhar Signed-off-by: YueHaibing --- drivers/net/net_failover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover

[PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

alidity of 'slave_dev'. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: YueHaibing --- v2: use WARN_ON_ONCE as Liran Alon suggested --- drivers/net/net_failover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/net_failover.c b/drivers/net/

[PATCH net-next] bnxt_en: remove set but not used variable 'addr_type'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c: In function 'bnxt_tc_parse_flow': drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:186:6: warning: variable 'addr_type' set but not used [-Wunused-but-set-variable] Signed-of

[PATCH net-next] liquidio CN23XX: Remove set but not used variable 'ring_flag'

used-but-set-variable] Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c

[PATCH net-next] qlcnic: Remove set but not used variables 'fw_mbx' and 'hdr_size'

From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c: In function 'qlcnic_sriov_pull_bc_msg': drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:907:6: warning: variable 'fw_mbx' set but not used [-Wunused-but-set-varia

Re: [PATCH net-next] net/smc: cast sizeof to int for comparison

On 2018/9/15 19:35, Andreas Schwab wrote: > On Sep 15 2018, YueHaibing wrote: > >> Comparing an int to a size, which is unsigned, causes the int to become >> unsigned, giving the wrong result. kernel_sendmsg can return a negative >> error code. >> >> Signed-of

[PATCH net-next] net: fec: remove stale comment

This comment is outdated as fec_ptp_ioctl has been replaced by fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl") Signed-off-by: YueHaibing --- drivers/net/ethernet/freescale/fec_ptp.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [PATCH net-next] cxgb4: Check for kvzalloc allocation failure

On 2018/5/24 23:07, David Miller wrote: > From: YueHaibing > Date: Tue, 22 May 2018 15:07:18 +0800 > >> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> index 130d1ee..019cffe 100644 >> --- a/d

[PATCH net-next] bpfilter: fix a build err

on of bpfilter kernel module") Signed-off-by: YueHaibing --- net/bpfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile index 2af752c..3f3cb87 100644 --- a/net/bpfilter/Makefile +++ b/net/bpfilter/Makefile @@

Re: [PATCH net-next] bpfilter: fix a build err

On 2018/5/26 0:19, Alexei Starovoitov wrote: > On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote: >> gcc-7.3.0 report following err: >> >> HOSTCC net/bpfilter/main.o >> In file included from net/bpfilter/main.c:9:0: >> ./include/uapi/linux/bpf.h:12:10

  1   2   3   4   >