; RAX: ffda RBX: 0004 RCX: 20011000
> > > > RDX: RSI: RDI: 20008000
> > > > RBP: 001c R08: R09:
> > > > R10: R11: 0
w_head before accessing the skb->data pointer.
Fixes: 01b8d064d58b4 ("net: ip6_gre: Request headroom in __gre6_xmit()")
Reported-by: Haichao Ma
Signed-off-by: William Tu
---
v1-v2: add more details in commit message.
---
net/ipv6/ip6_gre.c | 6 +++---
1 file changed, 3 insertions(+), 3 d
Please ignore this patch and allow me to investigate more.
On Thu, May 30, 2019 at 10:23 AM Gregory Rose wrote:
>
>
> On 5/30/2019 9:59 AM, William Tu wrote:
> > When increases the headroom, skb's data pointer might get re-allocated.
> > As a result, the skb->data be
nel option, there is no need to drop the packet and
> break all geneve rx traffic. Just set opt_class to 0 in this test and
> keep returning TC_ACT_OK.
>
> Signed-off-by: Hangbin Liu
> ---
LGTM.
Acked-by: William Tu
com
> Reported-by: Christian Pössinger
> Signed-off-by: Stephen Hemminger
> ---
LGTM, Thanks.
Acked-by: William Tu
span version II support")
> Cc: u9012...@gmail.com
> Cc: Stephen Hemminger
> Reported-by: Christian Poessinger
> Signed-off-by: Christian Poessinger
> ---
LGTM, thanks
Acked-by: William Tu
.")
> Signed-off-by: Hangbin Liu
> ---
LGTM, thanks.
Acked-by: William Tu
e bash instead.
>
> Also remove the 'set -e' since the script actually relies on that the
> return value can be used to determine pass/fail of the test.
>
> Fixes: 996139e801fd ("selftests: bpf: add a test for XDP redirect")
> Signed-off-by: Björn Töpel
> ---
LGTM, thanks.
Acked-by: William Tu
If true, this indicated that the
mirrored packet is truncated and set the erspan truncate bit.
I tested the patch using bpf_skb_change_tail helper function to
shrink the packet size and send to erspan tunnel.
Reported-by: Xiaoyan Jin
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 6 ++
Bring the erspan uapi header file so BPF tunnel helpers can use it.
Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.")
Reported-by: Yonghong Song
Signed-off-by: William Tu
---
tools/include/uapi/linux/erspan.h | 52 +++
1 file changed, 52
On Mon, Apr 30, 2018 at 2:05 AM, Daniel Borkmann wrote:
> On 04/30/2018 09:02 AM, Y Song wrote:
>> Hi, William,
>>
>> When compiled the selftests/bpf in my centos 7 based system, I have
>> the following failures,
>>
>> clang -I. -I./include/uapi -I../../../include/uapi
>> -Wno-compare-distinct-poi
Yonghong Song
Signed-off-by: Yifeng Sun
Signed-off-by: William Tu
---
kernel/bpf/verifier.c | 2 +-
tools/testing/selftests/bpf/test_verifier.c | 13 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index
On Tue, May 1, 2018 at 4:16 PM, Alexei Starovoitov
wrote:
> On Mon, Apr 30, 2018 at 10:15:05AM -0700, William Tu wrote:
>> Existing verifier does not allow 'ctx + const + const'. However, due to
>> compiler optimization, there is a case where BPF compilerit generates
On Wed, May 2, 2018 at 1:29 AM, Daniel Borkmann wrote:
> On 05/02/2018 06:52 AM, Alexei Starovoitov wrote:
>> On Tue, May 01, 2018 at 09:35:29PM -0700, William Tu wrote:
>>>
>>>> How did you test this patch?
>>>>
>>> Without the patch, the tes
gt;len.
Reported-by: Xiaoyan Jin
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 6 ++
net/ipv6/ip6_gre.c | 6 ++
2 files changed, 12 insertions(+)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index dfe5b22f6ed4..2409e648454d 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip
ied.
>
> Fixes: 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()")
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Quentin Monnet
> ---
Thanks. We also hit this issue when creating geneve tunnel.
Acked-by: William Tu
The patch zeros the fields in
ip_tunnel_info.
Signed-off-by: William Tu
Reported-by: Yifeng Sun
---
net/core/filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 8e45c6c7ab08..d3781daa26ab 100644
--- a/net/core/filter.c
+++ b/net/core/fil
get_tunnel,
ip6ip6_set_tunnel, ip6ip6_get_tunnel
Signed-off-by: William Tu
---
samples/bpf/Makefile | 1 -
samples/bpf/tcbpf2_kern.c | 612 --
samples/bpf/test_tunnel_bpf.sh | 390 --
too
On Wed, Apr 25, 2018 at 12:54 AM, Daniel Borkmann wrote:
> On 04/25/2018 08:46 AM, William Tu wrote:
>> The percpu metadata_dst might carry the stale ip_tunnel_info
>> and cause incorrect behavior. When mixing tests using ipv4/ipv6
>> bpf vxlan and geneve tunnel, the ipv6 tu
On Wed, Apr 25, 2018 at 8:01 AM, William Tu wrote:
> The patch migrates the original tests at samples/bpf/tcbpf2_kern.c
> and samples/bpf/test_tunnel_bpf.sh to selftests. There are a couple
> changes from the original:
> 1) add ipv6 vxlan, ipv6 geneve, ipv6 ipip tests
>
t_tunnel, ipip_get_tunnel
IP6IP:ipip6_set_tunnel, ipip6_get_tunnel,
ip6ip6_set_tunnel, ip6ip6_get_tunnel
XFRM: xfrm_get_state
William Tu (2):
selftests/bpf: bpf tunnel test.
samples/bpf: remove the bpf tunnel testsuite.
samples/bpf/Makefile
Move the testsuite to
selftests/bpf/{test_tunnel_kern.c, test_tunnel.sh}
Signed-off-by: William Tu
---
samples/bpf/Makefile | 1 -
samples/bpf/tcbpf2_kern.c | 612 -
samples/bpf/test_tunnel_bpf.sh | 390 --
3 files
get_tunnel,
ip6ip6_set_tunnel, ip6ip6_get_tunnel
XFRM: xfrm_get_state
Signed-off-by: William Tu
---
tools/testing/selftests/bpf/Makefile | 5 +-
tools/testing/selftests/bpf/test_tunnel.sh | 729 +
tools/testing/selftests/bpf/test_tunnel_ke
|.
>
> Detected by CoverityScan, CID#1466039 ("Operands don't affect result")
>
> Fixes: 77a5196a804e ("gre: add sequence number for collect md mode.")
> Signed-off-by: Colin Ian King
Thanks for the fix!
btw, how can I access the CoverityScan result with this CI
On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> This RFC introduces a new address family called AF_XDP that is
> optimized for high performance packet processing and zero-copy
> semantics. Throughput improvements can be up to 20x compared to V2 and
> V3 for the micro b
Hi Jesper,
Thanks a lot for your prompt reply.
>> Hi,
>> I also did an evaluation of AF_XDP, however the performance isn't as
>> good as above.
>> I'd like to share the result and see if there are some tuning suggestions.
>>
>> System:
>> 16 core, Intel(R) Xeon(R) CPU E5-2440 v2 @ 1.90GHz
>> Inte
On Tue, Mar 27, 2018 at 2:37 AM, Jesper Dangaard Brouer
wrote:
> On Mon, 26 Mar 2018 14:58:02 -0700
> William Tu wrote:
>
>> > Again high count for NMI ?!?
>> >
>> > Maybe you just forgot to tell perf that you want it to decode the
>> > bp
> Indeed. Intel iommu has least effect on RX because of premap/recycle.
> But TX dma map and unmap is really expensive!
>
>>
>> Basically the IOMMU can make creating/destroying a DMA mapping really
>> expensive. The easiest way to work around it in the case of the Intel
>> IOMMU is to boot with "io
Hi Jesper,
Thanks for the comments.
>> I assume this xdpsock code is small and should all fit into the icache.
>> However, doing another perf stat on xdpsock l2fwd shows
>>
>> 13,720,109,581 stalled-cycles-frontend # 60.01% frontend cycles
>> idle (23.82%)
>>
>> stalled-cycles-bac
; broader perspective and find the most low hanging fruit.
>
> Thanks Ilya for this fix.
>
> Acked-by: Magnus Karlsson
>
> > Fixes: c497176cb2e4 ("xsk: add Rx receive functions and poll support")
> > Signed-off-by: Ilya Maximets
> > ---
Tested on my machine and works ok.
Tested-by: William Tu
>> + if (greinfo[IFLA_GRE_ERSPAN_INDEX])
>> + erspan_idx =
>> rta_getattr_u32(greinfo[IFLA_GRE_ERSPAN_INDEX]);
>> }
>
> Are you missing a ntohl() here?
>
> It is encoded as htonl() when sending to kernel.
>
> addattr32(n, 1024, IFLA_GRE_FWMARK
>>
>> +static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi,
>> + int gre_hdr_len)
>> +{
>> + struct net *net = dev_net(skb->dev);
>> + struct ip_tunnel_net *itn;
>> + struct ip_tunnel *tunnel;
>> + struct metadata_dst *tun_dst = NULL;
>> + const
2.16.1.200 remote 172.16.1.100
Signed-off-by: William Tu
Signed-off-by: Meenakshi Vohra
Cc: Stephen Hemminger
Cc: Alexey Kuznetsov
---
v2->v3:
- make erspan index 0 as reserved, only set to kernel
when index is non-zero
- endianness: make the index host byte order
v1->v2:
Add
100 global
[1] https://tools.ietf.org/html/draft-foschiano-erspan-01
[2] iproute2 patch: http://marc.info/?l=linux-netdev&m=150306086924951&w=2
[3] test script: http://marc.info/?l=linux-netdev&m=150231021807304&w=2
Signed-off-by: William Tu
Signed-off-by: Meenakshi Vohra
Cc: Ale
>> + struct metadata_dst *tun_dst = NULL;
>> + const struct iphdr *iph;
>> + struct erspanhdr *ershdr;
>> + __be32 index;
>> + __be32 session_id;
>> + int len;
>
> Please order local variables from longest to shortest line, ie. reverse
> christmas tree format.
>
thanks for t
807304&w=2
Signed-off-by: William Tu
Signed-off-by: Meenakshi Vohra
Cc: Alexey Kuznetsov
Cc: Hideaki YOSHIFUJI
---
v3->v4:
fix skb_may_pull len
fix local variable ordering
fix commit message Nexus set-up
v2->v3:
add skb_may_pull check at erspan_rcv
a couple of minor fixes a
Fix typo: pnet_tap_faied.
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 6e8a62289e03..5a20ba9b9b50 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -1467,7 +1467,7
Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to
operate in 'collect metadata' mode. bpf_skb_[gs]et_tunnel_key() helpers
can make use of it right away. OVS can use it as well in the future.
Signed-off-by: William Tu
---
include/net/ip_tunnels.h | 4 +-
net/ipv
Extend existing tests for vxlan, gre, geneve, ipip to
include ERSPAN tunnel.
Signed-off-by: William Tu
---
samples/bpf/tcbpf2_kern.c | 63 +-
samples/bpf/test_tunnel_bpf.sh | 29 +++
2 files changed, 91 insertions(+), 1 deletion
The patch refactors the gre_fb_xmit function, by creating
prepare_fb_xmit function for later ERSPAN collect_md mode patch.
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 55 ---
1 file changed, 40 insertions(+), 15 deletions(-)
diff --git
prepare_fb_xmit function and adding ERSPAN specific logic. The final patch
adds the test case using bpf_skb_{set,get}_tunnel_{key,opt}.
Thank you
William Tu (3):
gre: refactor the gre_fb_xmit
gre: add collect_md mode to ERSPAN tunnel
samples/bpf: extend test_tunnel_bpf.sh with ERSPAN
include/net
The patch refactors the gre_fb_xmit function, by creating
prepare_fb_xmit function for later ERSPAN collect_md mode patch.
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 55 ---
1 file changed, 40 insertions(+), 15 deletions(-)
diff --git
Extend existing tests for vxlan, gre, geneve, ipip to
include ERSPAN tunnel.
Signed-off-by: William Tu
Acked-by: Alexei Starovoitov
---
samples/bpf/tcbpf2_kern.c | 63 +-
samples/bpf/test_tunnel_bpf.sh | 29 +++
2 files changed, 91
Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to
operate in 'collect metadata' mode. bpf_skb_[gs]et_tunnel_key() helpers
can make use of it right away. OVS can use it as well in the future.
Signed-off-by: William Tu
---
include/net/ip_tunnels.h | 4 +-
net/ipv
On Tue, Aug 13, 2019 at 5:07 AM Toshiaki Makita
wrote:
>
> This is a rough PoC for an idea to offload TC flower to XDP.
>
>
> * Motivation
>
> The purpose is to speed up software TC flower by using XDP.
>
> I chose TC flower because my current interest is in OVS. OVS uses TC to
> offload flow tabl
On Thu, Aug 22, 2019 at 11:10 PM Björn Töpel wrote:
>
> On 2019-08-22 19:32, William Tu wrote:
> > On Thu, Aug 22, 2019 at 10:21 AM Alexander Duyck
> > wrote:
> >>
> >> On Thu, Aug 22, 2019 at 10:12 AM Ilya Maximets
> >> wrote:
> >>>
KMAP. Instead, the
> bpf_map_delete_elem() function should be used for that.
>
> This patch also simplifies the code by breaking up
> xsk_update_bpf_maps() into three smaller functions.
>
> Reported-by: William Tu
> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets"
passed
> to munmap.
>
> When the userspace application tried to tear down an AF_XDP socket,
> the operation failed and the application would still have a reference
> to socket it wished to get rid of.
>
> Reported-by: William Tu
> Fixes: 1cad07884239 ("libbpf: add sup
The libbpf_util.h is used by xsk.h, so add it to
the install headers.
Reported-by: Ben Pfaff
Signed-off-by: William Tu
---
tools/lib/bpf/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index c6c06bc6683c..f91639bf5650 100644
--- a
On Thu, May 2, 2019 at 1:18 PM Y Song wrote:
>
> On Thu, May 2, 2019 at 11:34 AM William Tu wrote:
> >
> > The libbpf_util.h is used by xsk.h, so add it to
> > the install headers.
>
> Can we try to change code a little bit to avoid exposing libbpf_util.h?
When increases the headroom, skb's pointer might get re-allocated.
Fix it by moving skb_cow_head before accessing the skb->data pointer.
Fixes: 01b8d064d58b4 ("net: ip6_gre: Request headroom in __gre6_xmit()")
Reported-by: Haichao Ma
Signed-off-by: William Tu
---
net/
On Thu, Oct 5, 2017 at 6:59 AM, David Laight wrote:
> From: William Tu
>> Sent: 05 October 2017 01:14
>> Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
>> is the length of the whole ether packet. So skb->len should subtract
>> the dev
ve tunnel support for ERSPAN")
Signed-off-by: William Tu
Cc: Xin Long
Cc: David Laight
---
v1->v2:
use addition to avoid overflow
fix pskb_trim size
---
net/ipv4/ip_gre.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
ind
On Fri, Oct 6, 2017 at 2:38 AM, David Laight wrote:
> From: William Tu
>> Sent: 05 October 2017 22:21
> ...
>> >> - if (skb->len > dev->mtu) {
>> >> + if (skb->len - dev->hard_header_len > dev->mtu) {
>> >
>> >
On Fri, Oct 6, 2017 at 3:22 PM, David Miller wrote:
> From: William Tu
> Date: Fri, 6 Oct 2017 15:09:29 -0700
>
>> Yes, adding another field in the struct net_device can avoid the
>> arithmetic operation. I'm not sure it's a good idea to add new field
>
The first two patches are to fix some issues for mtu and needed_headroom length
calculation from the gre and erspan tunnel header. The last path tries to avoid
arithmetic operation for every packet when checking for erspan truncate.
William Tu (3):
ip_gre: fix mtu and headroom size
ip_gre
e/UDP foo-over-udp
encapsulation")
Signed-off-by: William Tu
Cc: Tom Herbert
---
net/ipv4/ip_gre.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index c105a315b1a3..286065c35959 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip
the ip_tunnel_bind_dev(), the mtu is adjusted to
1464 - 14 (dev->hard_header_len) = 1450.
The maximum skb->len the erspan tunnel can carry without
being truncated is 1450 + 14 = 1464 byte.
Signed-off-by: William Tu
Cc: Xin Long
---
include/net/erspan.h | 1 +
net/ipv4/ip_gre.c| 11 +
The patch introduces ip_tunnel->ether_mtu fields to cache the value of
dev->mtu + dev->hard_header_len. This avoids the arithmetic operation
on every packet.
Signed-off-by: William Tu
Cc: David Laight
---
include/net/ip_tunnels.h | 1 +
net/ipv4/ip_gre.c| 8
>> @@ -1242,14 +1241,14 @@ static int erspan_tunnel_init(struct net_device *dev)
>> struct ip_tunnel *tunnel = netdev_priv(dev);
>> int t_hlen;
>>
>> - tunnel->tun_hlen = 8;
>> + tunnel->tun_hlen = ERSPAN_GREHDR_LEN;
>> tunnel->parms.iph.protocol = IPPROTO_GRE;
>
port")
> Signed-off-by: Prashant Bhole
> ---
Thanks for the fix.
Acked-by: William Tu
xmit.
William Tu (3):
ip6gre: add erspan v2 to tunnel lookup
ip6erspan: improve error handling for erspan version number.
ip6erspan: make sure enough headroom at xmit.
net/ipv6/ip6_gre.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.7.4
The patch adds the erspan v2 proto in ip6gre_tunnel_lookup
so the erspan v2 tunnel can be found correctly.
Signed-off-by: William Tu
---
net/ipv6/ip6_gre.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 18a3dfbd0300
When users fill in incorrect erspan version number through
the struct erspan_metadata uapi, current code skips pushing
the erspan header but continue pushing the gre header, which
is incorrect. The patch fixes it by returning error.
Signed-off-by: William Tu
---
net/ipv6/ip6_gre.c | 2 ++
1
The patch adds skb_cow_header() to ensure enough headroom
at ip6erspan_tunnel_xmit before pushing the erspan header
to the skb.
Signed-off-by: William Tu
---
net/ipv6/ip6_gre.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 4ab476d3a46e
On Tue, Mar 27, 2018 at 9:59 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> This RFC introduces a new address family called AF_XDP that is
> optimized for high performance packet processing and, in upcoming
> patch sets, zero-copy semantics. In this v2 version, we have removed
> all zero-copy rel
ixes: dd9d598c6657 ("ip_gre: add the support for i/o_flags update via
>> netlink")
>> Signed-off-by: Sabrina Dubroca
>> ---
Looks good to me.
Acked-by: William Tu
>> net/ipv4/ip_gre.c | 6 ++
>> 1 file changed, 6 insertions(+)
>>
>> diff --
On Mon, Apr 9, 2018 at 11:47 PM, Björn Töpel wrote:
> 2018-04-09 23:51 GMT+02:00 William Tu :
>> On Tue, Mar 27, 2018 at 9:59 AM, Björn Töpel wrote:
>>> From: Björn Töpel
>>>
>>> This RFC introduces a new address family called AF_XDP that is
>>> opt
The patch adds tests for GRE sequence number
support for metadata mode tunnel.
Signed-off-by: William Tu
---
samples/bpf/tcbpf2_kern.c | 6 --
samples/bpf/test_tunnel_bpf.sh | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/samples/bpf/tcbpf2_kern.c b/samples/bpf
ype having sequence number.
William Tu (2):
gre: add sequence number for collect md mode.
samples/bpf: add gre sequence number test.
include/uapi/linux/bpf.h | 1 +
net/core/filter.c | 4 +++-
net/ipv4/ip_gre.c | 7 +--
net/ipv6/ip6_gre.c
sequence number is shared in the same tunnel device.
That is, different tunnel keys using the same collect_md
tunnel share single sequence number.
Signed-off-by: William Tu
---
include/uapi/linux/bpf.h | 1 +
net/core/filter.c| 4 +++-
net/ipv4/ip_gre.c| 7 +--
net/ipv6
On Thu, Mar 1, 2018 at 2:18 AM, Daniel Borkmann wrote:
> On 03/01/2018 01:11 AM, William Tu wrote:
>> Currently GRE sequence number can only be used in native
>> tunnel mode. This patch adds sequence number support for
>> gre collect metadata mode. RFC2890 defines GRE seq
On Thu, Mar 1, 2018 at 2:30 AM, Daniel Borkmann wrote:
> On 03/01/2018 01:11 AM, William Tu wrote:
>> The patch adds tests for GRE sequence number
>> support for metadata mode tunnel.
>>
>> Signed-off-by: William Tu
>> ---
>> samples/bpf/tcbpf2
Hi,
We're running commands below on kernel 4.15.0:
1) ip netns add at_ns0
2) ip link add p0 type veth peer name ovs-p0
3) ip link set p0 netns at_ns0
4) ip link set dev ovs-p0 up
However, it always hangs at creating veth peer, command (2) when we
run above commands in GNU autotest. Running the sa
On Thu, Mar 1, 2018 at 10:36 AM, David Ahern wrote:
> On 3/1/18 10:29 AM, William Tu wrote:
>> Hi,
>>
>> We're running commands below on kernel 4.15.0:
>> 1) ip netns add at_ns0
>> 2) ip link add p0 type veth peer name ovs-p0
>> 3) ip link set p0
sequence number is shared in the same tunnel device.
That is, different tunnel keys using the same collect_md
tunnel share single sequence number.
Signed-off-by: William Tu
---
include/uapi/linux/bpf.h | 1 +
net/core/filter.c| 4 +++-
net/ipv4/ip_gre.c| 7 +--
net/ipv6
_F_GRE_SEQ to BPF_F_SEQ_NUMBER suggested by Daniel
--
William Tu (2):
gre: add sequence number for collect md mode.
samples/bpf: add gre sequence number test.
include/uapi/linux/bpf.h | 1 +
net/core/filter.c | 4 +++-
net/ipv4/ip_gre.c | 7 +--
net/ipv6/ip6_gre.c
The patch adds tests for GRE sequence number
support for metadata mode tunnel.
Signed-off-by: William Tu
---
samples/bpf/tcbpf2_kern.c | 6 --
samples/bpf/test_tunnel_bpf.sh | 5 +++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/samples/bpf/tcbpf2_kern.c b/samples
>
> I still can not reproduce the hang, but try this and see if it fixes
> your problem (whitespace damaged on paste):
>
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 7ca47b22581a..9d692afbc740 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -670,8 +672,9 @@ static int __
On Thu, Mar 1, 2018 at 6:22 PM, Prashant Bhole
wrote:
> This patch removes testns after test failure so that next test can
> continue with clean ns
>
> Signed-off-by: Prashant Bhole
Thanks for the fix.
Acked-by: William Tu
This causes the 'unsign int length' to become super
large because it is negative value, causing the later ovs_vport_send
to drop it due to over-mtu size. The patch fixes it by setting it to 0.
Signed-off-by: William Tu
---
net/openvswitch/vport.c | 4 ++--
1 file changed, 2 inser
On Wed, Mar 7, 2018 at 1:18 PM, Pravin Shelar wrote:
> On Tue, Mar 6, 2018 at 5:56 PM, William Tu wrote:
>> When sending a packet to a tunnel device, the dev's hard_header_len
>> could be larger than the skb->len in function packet_length().
>> In the case of ip6g
This causes the 'unsign int length' to become super
large because it is negative value, causing the later ovs_vport_send
to drop it due to over-mtu size. The patch fixes it by setting it to 0.
Signed-off-by: William Tu
---
v1->v2:
replace the return type from unsigned int to int
---
Add type II erspan vport implementation. Since erspan protocol is
on top of the GRE header, the implementation is extended from the
existing gre implementation.
Signed-off-by: William Tu
Cc: Pravin B Shelar
---
include/net/gre.h| 2 ++
include/uapi/linux/openvswitch.h | 2
On Wed, Oct 4, 2017 at 2:31 PM, Pravin Shelar wrote:
> On Wed, Oct 4, 2017 at 5:02 AM, William Tu wrote:
>> Add type II erspan vport implementation. Since erspan protocol is
>> on top of the GRE header, the implementation is extended from the
>> existing gre implementation
Add erspan netlink interface for OVS.
Signed-off-by: William Tu
Cc: Pravin B Shelar
---
v1->v2: remove unnecessary compat code.
---
include/uapi/linux/openvswitch.h | 1 +
net/openvswitch/flow_netlink.c | 51 +++-
2 files changed, 51 insertions(+)
Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
is the length of the whole ether packet. So skb->len should subtract
the dev->hard_header_len.
Fixes: 1a66a836da63 ("gre: add collect_md mode to ERSPAN tunnel")
Signed-off-by: William Tu
Cc: Xin Long
---
net/i
> Thanks for working on this, LGTM! Are you also planning to get ixgbe
> out after that?
>
I currently don't have i40e nic to test, so
I'm also looking forward to the ixgbe patch!
Thank you
William
Add test cases for gretap and ip6gretap, native mode
and external (collect metadata) mode.
Signed-off-by: William Tu
---
tools/testing/selftests/net/rtnetlink.sh | 98
1 file changed, 98 insertions(+)
diff --git a/tools/testing/selftests/net/rtnetlink.sh
b
On Tue, Dec 19, 2017 at 2:17 PM, David Ahern wrote:
> On 12/15/17 6:06 PM, William Tu wrote:
>> @@ -343,6 +355,22 @@ get_failed:
>> invarg("invalid erspan index\n", *argv);
>> if (erspan_idx &
users to set ERSPAN engine ID within a system.
As for manpage, the ERSPAN descriptions used to be under GRE, IPIP,
SIT Type paragraph. Since IP6GRE/IP6GRETAP also supports ERSPAN,
the patch removes the old one, creates a separate ERSPAN paragrah,
and adds an example.
Signed-off-by: William Tu
On Tue, Dec 19, 2017 at 5:28 PM, David Ahern wrote:
> Hi William:
>
> On 12/19/17 6:08 PM, William Tu wrote:
>> @@ -343,6 +355,26 @@ get_failed:
>> invarg("invalid erspan index\n", *argv);
>> if (erspan_id
users to set ERSPAN engine ID within a system.
As for manpage, the ERSPAN descriptions used to be under GRE, IPIP,
SIT Type paragraph. Since IP6GRE/IP6GRETAP also supports ERSPAN,
the patch removes the old one, creates a separate ERSPAN paragrah,
and adds an example.
Signed-off-by: William Tu
---
On Tue, Dec 19, 2017 at 6:07 PM, Haishuang Yan
wrote:
> If md is NULL, tun_dst must be freed, otherwise it will cause memory
> leak.
>
> Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode")
> Cc: William Tu
> Signed-off-by: Haishuang Yan
>
> ---
&
users to set ERSPAN engine ID within a system.
As for manpage, the ERSPAN descriptions used to be under GRE, IPIP,
SIT Type paragraph. Since IP6GRE/IP6GRETAP also supports ERSPAN,
the patch removes the old one, creates a separate ERSPAN paragrah,
and adds an example.
Signed-off-by: William Tu
--
Fixes: 50670b6ee9bc ("ip_gre: fix potential memory leak in erspan_rcv")
Cc: Haishuang Yan
Signed-off-by: William Tu
---
net/ipv4/ip_gre.c | 5 -
net/ipv6/ip6_gre.c | 4
2 files changed, 9 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 90c912307814..47
The patch adds erspan usage description, so 'ip link help erspan'
and 'ip link help ip6erspan' shows the options.
Signed-off-by: William Tu
---
ip/link_gre.c | 4
ip/link_gre6.c | 4
2 files changed, 8 insertions(+)
diff --git a/ip/link_gre.c b/ip/link_gre.
Add test cases for ipv4, ipv6 erspan, v1 and v2 native mode
and external (collect metadata) mode.
Signed-off-by: William Tu
---
tools/testing/selftests/net/rtnetlink.sh | 131 +++
1 file changed, 131 insertions(+)
diff --git a/tools/testing/selftests/net
Hi Serhey,
On Wed, Dec 27, 2017 at 3:28 AM, Serhey Popovych
wrote:
> Also add "noexternal" variant to be inline
> with geneve and vxlan tunnel types.
>
> Signed-off-by: Serhey Popovych
> ---
> ip/link_gre.c |3 +++
> ip/link_ip6tnl.c |4 +++-
> ip/link_iptnl.c |4
Hi Serhey,
On Thu, Dec 28, 2017 at 3:12 AM, Serhey Popovych
wrote:
> One is missing in JSON output because fprintf()
> is used instead of print_uint().
>
> Signed-off-by: Serhey Popovych
> ---
> ip/link_gre.c |3 ++-
> ip/link_gre6.c |4 +++-
> 2 files changed, 5 insertions(+), 2 delet
1 - 100 of 317 matches
Mail list logo
