[PATCH net-next] Update my email address

2019-05-31 Thread Wei Liu
Signed-off-by: Wei Liu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0c55b0fedbe2..e212c6a42ddf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17295,7 +17295,7 @@ F: Documentation/ABI/stable/sysfs-hypervisor-xen F

Re: [PATCH] xen-netback: no need to check return value of debugfs_create functions

2019-08-11 Thread Wei Liu
On Sat, Aug 10, 2019 at 12:31:08PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Wei Liu > Cc:

Re: [PATCH v2] hv_netvsc: Add (more) validation for untrusted Hyper-V values

2021-01-17 Thread Wei Liu
On Sat, Jan 16, 2021 at 02:02:01PM +0100, Andrea Parri wrote: > On Fri, Jan 15, 2021 at 08:30:22PM -0800, Jakub Kicinski wrote: > > On Thu, 14 Jan 2021 21:26:28 +0100 Andrea Parri (Microsoft) wrote: > > > For additional robustness in the face of Hyper-V errors or malicious > > > behavior, validate

Re: [PATCH 2/2] x86: make hyperv support optional

2020-11-18 Thread Wei Liu
On Tue, Nov 17, 2020 at 09:23:08PM +0100, Enrico Weigelt, metux IT consult wrote: > Make it possible to opt-out from hyperv support. > "Hyper-V support". Have you tested this patch? If so, how? > Signed-off-by: Enrico Weigelt, metux IT consult > --- > arch/x86/Kconfig | 7 +++

Re: [PATCH] hv_netvsc: Validate number of allocated sub-channels

2020-11-24 Thread Wei Liu
On Wed, Nov 18, 2020 at 05:37:15PM -0800, Jakub Kicinski wrote: > On Wed, 18 Nov 2020 16:33:10 +0100 Andrea Parri (Microsoft) wrote: > > Lack of validation could lead to out-of-bound reads and information > > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > > allocated sub-chan

Re: [PATCH v9 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-11-13 Thread Wei Liu
rea Parri (Microsoft) > Reviewed-by: Michael Kelley > Acked-by: Jakub Kicinski > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org Reviewed-by: Wei Liu

Re: [PATCH v9 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

2020-11-17 Thread Wei Liu
On Mon, Nov 09, 2020 at 11:03:59AM +0100, Andrea Parri (Microsoft) wrote: > Currently, VMbus drivers use pointers into guest memory as request IDs > for interactions with Hyper-V. To be more robust in the face of errors > or malicious behavior from a compromised Hyper-V, avoid exposing > guest memo

Re: [PATCH v3] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2021-01-05 Thread Wei Liu
On Tue, Dec 22, 2020 at 01:59:34PM +, Michael Kelley wrote: > From: Andrea Parri (Microsoft) Sent: Monday, > December 7, 2020 8:53 PM > > > > From: Andres Beltran > > > > Pointers to ring-buffer packets sent by Hyper-V are used within the > > guest VM. Hyper-V can send packets with erroneo

Re: [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2020-11-04 Thread Wei Liu
n-netback/xenbus.c:1001: warning: Function parameter or member > 'id' not described in 'netback_probe' > > Cc: Wei Liu If this is ever needed: Acked-by: Wei Liu

Re: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

2021-02-11 Thread Wei Liu
e a event being spurious if no rx OR no tx requests are > pending. > > Fix that plus using local variables for rx/tx pending indicators in > order to split function calls and if condition. > > Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding") > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu

Re: Regressions with VMBus/VSCs hardening changes

2021-02-15 Thread Wei Liu
On Fri, Feb 12, 2021 at 05:50:50PM +0100, Andrea Parri wrote: > Hi all, [...] > 2) IIUC a8c3209998afb5 could be dropped (after rebase) without further modi- >fications to hyperv-next. I've reverted the said patch from hyperv-next. Wei.

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Wed, Apr 07, 2021 at 08:08:59AM +, Dexuan Cui wrote: > > From: kernel test robot > > Sent: Tuesday, April 6, 2021 6:31 PM > > ... > > Hi Dexuan, > > I love your patch! Perhaps something to improve: > > > > All warnings (new ones prefixed by >>): > > > >drivers/pci/controller/pci-hype

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Tue, Apr 06, 2021 at 04:23:21PM -0700, Dexuan Cui wrote: [...] > +config MICROSOFT_MANA > + tristate "Microsoft Azure Network Adapter (MANA) support" > + default m > + depends on PCI_MSI > + select PCI_HYPERV OOI which part of the code requires PCI_HYPERV? Asking because I can'

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Wed, Apr 07, 2021 at 02:34:01PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Wei Liu > > Sent: Wednesday, April 7, 2021 9:17 AM > > To: Dexuan Cui > > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > > ; H

Re: [PATCH v3 hyperv-next 0/4] Drivers: hv: vmbus: Restrict devices and configurations on 'isolated' guests

2021-02-01 Thread Wei Liu
On Mon, Feb 01, 2021 at 03:48:10PM +0100, Andrea Parri (Microsoft) wrote: > Andrea Parri (Microsoft) (4): > x86/hyperv: Load/save the Isolation Configuration leaf > Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests > Drivers: hv: vmbus: Enforce 'VMBus version >= 5.2' on isolated g

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-02 Thread Wei Liu
> associated queue held. > > Reported-by: Igor Druzhinin > Fixes: 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [patch 12/14] PCI: hv: Use tasklet_disable_in_atomic()

2021-03-10 Thread Wei Liu
> Signed-off-by: Thomas Gleixner Acked-by: Wei Liu

Re: [PATCH 4/7] xen/events: link interdomain events to associated xenbus device

2021-02-09 Thread Wei Liu
aces to take the pointer to the xenbus device as a > parameter instead of the domain id of the other side. > > While at it remove the stale prototype of bind_evtchn_to_irq_lateeoi(). > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu

Re: [Xen-devel] [PATCH 4/6] xen-netfront: add range check for Tx response id

2018-05-01 Thread Wei Liu
On Mon, Apr 30, 2018 at 11:01:48PM +0200, Marek Marczykowski-Górecki wrote: > Tx response ID is fetched from shared page, so make sure it is sane > before using it as an array index. > > CC: sta...@vger.kernel.org > Signed-off-by: Marek Marczykowski-Górecki > --- > drivers/net/xen-netfront.c | 1

Re: [PATCH 2/3] xen netback: add fault injection facility

2018-04-23 Thread Wei Liu
On Fri, Apr 20, 2018 at 10:47:31AM +, Stanislav Kinsburskii wrote: > > #include > #include > @@ -1649,6 +1650,7 @@ static int __init netback_init(void) > PTR_ERR(xen_netback_dbg_root)); > #endif /* CONFIG_DEBUG_FS */ > > + (void) xen_netbk_fi_init(); If you c

Re: [PATCH] xen-netback: fix xenvif_start_xmit()'s return type

2018-04-24 Thread Wei Liu
ng 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Acked-by: Wei Liu

Re: [Xen-devel] [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-04-24 Thread Wei Liu
ng 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Reviewed-by: Wei Liu

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-26 Thread Wei Liu
> > Signed-off-by: Joe Perches > --- > drivers/net/xen-netback/xenbus.c | 4 +- > drivers/net/xen-netfront.c | 6 +-- Reviewed-by: Wei Liu

Re: [PATCH net-next] xen-netback: update ubuf_info initialization to anonymous union

2017-08-28 Thread Wei Liu
initializers to match their > nested position in the struct. After this, compilation succeeds again. > > Fixes: 4ab6c99d99bb ("sock: MSG_ZEROCOPY notification coalescing") > Reported-by: kbuild bot > Signed-off-by: Willem de Bruijn Acked-by: Wei Liu

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 09:46:57AM +, Paul Durrant wrote: > > -Original Message- > > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > > Sent: 28 February 2019 02:03 > > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; > > linux-ker.

Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
On Thu, Feb 28, 2019 at 12:07:07PM +, Paul Durrant wrote: > Yes, I meant kfree_skb(nskb). > In that case I think your patch looks fine. Wei.

Re: [PATCH v2] xen-netback: fix occasional leak of grant ref mappings under memory pressure

2019-02-28 Thread Wei Liu
of page cache writes coexist with active atomic skb allocations from > network traffic. Additionally, rework the logic to deal with frag_list > deallocation in a single place. > > Signed-off-by: Paul Durrant > Signed-off-by: Igor Druzhinin Acked-by: Wei Liu > --- > drivers/n

Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Wei Liu
he guest can no longer be pinged. > > xen_net{front|back} should not allow the user to set this value which causes > network problems. > > Reported-by: Chen Shi > Signed-off-by: Mohammed Gamal Acked-by: Wei Liu CC netfront maintainers

Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

2018-02-23 Thread Wei Liu
22:6: warning: symbol 'xenvif_rx_skb' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Acked-by: Wei Liu Thanks

Re: [PATCH] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-28 Thread Wei Liu
On Mon, Apr 27, 2020 at 08:30:43PM -0700, Nathan Chancellor wrote: > netvsc_start_xmit is used as a callback function for the ndo_start_xmit > function pointer. ndo_start_xmit's return type is netdev_tx_t but > netvsc_start_xmit's return type is int. > > This causes a failure with Control Flow Int

Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-14 Thread Wei Liu
On Mon, Sep 14, 2020 at 04:46:00PM +0800, Boqun Feng wrote: > On Thu, Sep 10, 2020 at 10:34:52PM +0800, Boqun Feng wrote: > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > least 2 * PAGE_SIZE: one page for the header and at least one page of > > the data part (because

Re: [RFC 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl

2020-07-21 Thread Wei Liu
On Tue, Jul 21, 2020 at 09:41:25AM +0800, Boqun Feng wrote: > Since the hypervisor always uses 4K as its page size, the size of PFNs > used for gpadl should be HV_HYP_PAGE_SIZE rather than PAGE_SIZE, so > adjust this accordingly as the preparation for supporting 16K/64K page > size guests. It may

Re: [RFC 02/11] Drivers: hv: vmbus: Move __vmbus_open()

2020-07-21 Thread Wei Liu
two patches to make it easy to review. > > Signed-off-by: Boqun Feng Reviewed-by: Wei Liu

Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Wei Liu
Hi Chi Thanks for your patch. A few things need to be fixed before it can be accepted upstream. On Fri, Jul 17, 2020 at 06:04:31AM +, Chi Song wrote: > The network is observed with low performance, if TX indirection table > is imbalance. But the table is in memory and set in runtime, it's >

Re: [PATCH v4 00/11] Hyper-V: Support PAGE_SIZE larger than 4K

2020-09-28 Thread Wei Liu
On Wed, Sep 16, 2020 at 11:48:06AM +0800, Boqun Feng wrote: > This patchset add the necessary changes to support guests whose page > size is larger than 4K. And the main architecture which we develop this > for is ARM64 (also it's the architecture that I use to test this > feature). > > Previous v

Re: [PATCH] net: xenbus: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-10 Thread Wei Liu
On Mon, Dec 10, 2018 at 10:53:29AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Acked-by: Wei Liu Thanks for the patch.

Re: [PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread Wei Liu
CC netfront maintainers. On Mon, Nov 20, 2017 at 11:41:09AM +0100, Eduardo Otubo wrote: > When unloading module xen_netfront from guest, dmesg would output > warning messages like below: > > [ 105.236836] xen:grant_table: WARNING: g.e. 0x903 still in use! > [ 105.236839] deferring g.e. 0x90

Re: [PATCH 0/3] Drivers: hv: vmbus: vmbus_requestor data structure

2020-06-26 Thread Wei Liu
On Thu, Jun 25, 2020 at 11:37:20AM -0400, Andres Beltran wrote: > From: Andres Beltran (Microsoft) > > Currently, VMbus drivers use pointers into guest memory as request IDs > for interactions with Hyper-V. To be more robust in the face of errors > or malicious behavior from a compromised Hyper-V

Re: [PATCH 0/3] Drivers: hv: vmbus: vmbus_requestor data structure

2020-06-26 Thread Wei Liu
On Fri, Jun 26, 2020 at 04:48:17PM +0200, Andrea Parri wrote: > On Fri, Jun 26, 2020 at 01:42:27PM +0000, Wei Liu wrote: > > On Thu, Jun 25, 2020 at 11:37:20AM -0400, Andres Beltran wrote: > > > From: Andres Beltran (Microsoft) > > > > > > Currently, VMbus dr

Re: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-29 Thread Wei Liu
On Mon, Jun 29, 2020 at 09:33:15PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Andres Beltran > > Sent: Monday, June 29, 2020 4:02 PM > > To: KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger ; > > wei@kernel.org > > Cc: linux-hyp...@vger.kernel.org; linux-ke

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-29 Thread Wei Liu
David Do you want this to go through net tree? I can submit it via hyperv tree if that's preferred. Wei. On Tue, Apr 28, 2020 at 10:54:56AM -0700, Nathan Chancellor wrote: > netvsc_start_xmit is used as a callback function for the ndo_start_xmit > function pointer. ndo_start_xmit's return type i

Re: [PATCH net-next] MAINTAINERS: xen-netback: update my email address

2019-09-13 Thread Wei Liu
On Fri, 13 Sep 2019 at 13:47, Paul Durrant wrote: > > My Citrix email address will expire shortly. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH net-next] MAINTAINERS: xen-netback: update my email address

2019-09-13 Thread Wei Liu
On Fri, 13 Sep 2019 at 16:28, Wei Liu wrote: > > On Fri, 13 Sep 2019 at 13:47, Paul Durrant wrote: > > > > My Citrix email address will expire shortly. > > > > Signed-off-by: Paul Durrant > > Acked-by: Wei Liu Or rather: Acked-by: Wei Liu

[PATCH net] xen-netback: correctly schedule rate-limited queues

2017-06-21 Thread Wei Liu
Add a flag to indicate if a queue is rate-limited. Test the flag in NAPI poll handler and avoid rescheduling the queue if true, otherwise we risk locking up the host. The rescheduling will be done in the timer callback function. Reported-by: Jean-Louis Dupond Signed-off-by: Wei Liu Tested-by

Re: [PATCH 54/58] net/xen-netback: Convert timers to use timer_setup()

2017-10-20 Thread Wei Liu
On Mon, Oct 16, 2017 at 05:29:38PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Wei Liu > Cc:

Re: [RFC PATCH 02/13] xen-netback: xenbus feature persistent support

2015-05-19 Thread Wei Liu
On Tue, May 12, 2015 at 07:18:26PM +0200, Joao Martins wrote: > Checks for "feature-persistent" that indicates persistent grants > support. Adds max_persistent_grants module param that specifies the max > number of persistent grants, which if set to zero disables persistent > grants. > > Signed-of

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-05-19 Thread Wei Liu
On Tue, May 12, 2015 at 07:18:30PM +0200, Joao Martins wrote: > By introducing persistent grants we speed up the RX thread with the > decreased copy cost, that leads to a throughput decrease of 20%. > It is observed that the rx_queue stays mostly at 10% of its capacity, > as opposed to full capacit

Re: [Xen-devel] [RFC 21/23] net/xen-netback: Make it running on 64KB page granularity

2015-05-20 Thread Wei Liu
On Tue, May 19, 2015 at 11:56:39PM +0100, Julien Grall wrote: > > >>diff --git a/drivers/net/xen-netback/common.h > >>b/drivers/net/xen-netback/common.h > >>index 0eda6e9..c2a5402 100644 > >>--- a/drivers/net/xen-netback/common.h > >>+++ b/drivers/net/xen-netback/common.h > >>@@ -204,7 +204,7 @@

Re: [PATCH net v2] xen/netback: Properly initialize credit_bytes

2015-05-27 Thread Wei Liu
t; prevented bandwidth limiting from working. Initialize the field as it > was done before multiqueue support was added. > > Signed-off-by: Ross Lagerwall Acked-by: Wei Liu > --- > > Changed in v2: Fixed multiple-assignment. > > drivers/net/xen-netback/xenbus.c | 1

Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

2015-05-29 Thread Wei Liu
that for you. > > > > Thanks, Konrad. > > > > I am copying Wei too who had fixed the below problem earlier. > > It fixed the incorrect ip_hdr(). tcp_hdr() still needs to fixed. > > > > commit d554f73df6bc35ac8f6a65e5560bf1d31dfebed9 > > Author:

Re: [PATCH] xen: netback: fix error printf format string.

2015-05-29 Thread Wei Liu
t; [-Wformat=] > (txreq.offset&~PAGE_MASK) + txreq.size); > ^ > > txreq.offset and .size are uint16_t fields. > > Signed-off-by: Ian Campbell Acked-by: Wei Liu > --- > drivers/net/xen-netback/netback.c |2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-05-29 Thread Wei Liu
On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: [...] > if (be->vif != NULL) > return 0; > @@ -417,12 +409,23 @@ static int backend_create_xenvif(struct backend_info > *be) > return (err < 0) ? err : -EINVAL; > } > > + script = xenbus_rea

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Wei Liu
On Mon, Jun 01, 2015 at 09:52:45AM +0100, Ian Campbell wrote: > On Fri, 2015-05-29 at 18:38 +0100, Wei Liu wrote: > > On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: > > [...] > > > if (be->vif != NULL) > > > return 0; &g

Re: [PATCH v2] xen: netback: fix printf format string warning

2015-06-01 Thread Wei Liu
t; [-Wformat=] > (txreq.offset&~PAGE_MASK) + txreq.size); > ^ > > PAGE_MASK's type can vary by arch, so a cast is needed. > > Signed-off-by: Ian Campbell Acked-by: Wei Liu > > v2: Cast to unsigned long, since PAGE_MASK can vary by arch. >

Re: [PATCH v2 net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Wei Liu
t this state machine is > fragile and prone to anger... > > A modern Xen system only relies on the hotplug uevent for driver > domains, when the backend is in the same domain as the toolstack it > will run the necessary setup/teardown directly in the correct sequence > wrt xenstore

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

2015-06-02 Thread Wei Liu
Hi Eric Sorry for coming late to the discussion. On Thu, Apr 16, 2015 at 05:42:16AM -0700, Eric Dumazet wrote: > On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: > > > He suggested that after he'd been prodded by 4 more e-mails in which two > > of us guessed what he was trying to get at.

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:24:39AM +, Joao Martins wrote: > > On 19 May 2015, at 17:23, Wei Liu wrote: > > On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: > >> Introduces persistent grants for TX path which follows similar code path > >> as th

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:25:10AM +, Joao Martins wrote: > > On 19 May 2015, at 17:32, Wei Liu wrote: > > > On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: > >> It starts by doing a lookup in the tree for a gref. If no persistent > >> grant

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:26:48AM +, Joao Martins wrote: [...] > >>return IRQ_HANDLED; > >> } > >> @@ -168,8 +169,12 @@ static int xenvif_start_xmit(struct sk_buff *skb, > >> struct net_device *dev) > >>cb = XENVIF_RX_CB(skb); > >>cb->expires = jiffies + vif->drain_timeout; > >>

Re: [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > I changed patch with valid format. > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > Since vzalloc can be failed in memory pressure, > > writes -ENOMEM to xenstore to indicate error. > > > > Signed-off-by: Insu Yun > > --- > >

Re: [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > > I changed patch with valid format. > > > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > > > Since vzalloc can be failed in memo

Re: [PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-16 Thread Wei Liu
ned-off-by: Joe Jin > Cc: Wei Liu > Cc: Ian Campbell > Cc: David S. Miller > --- > drivers/net/xen-netfront.c |9 ++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > index f821a

Re: [PATCH V3 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-26 Thread Wei Liu
On Fri, Oct 23, 2015 at 05:44:44PM +0800, Joe Jin wrote: > Should not allocate xen vif queues number more than online cpus. I think it's absolutely fine for administrators to override the value should they choose to. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH net-next 4/8] xen-netback: accept an L4 or L3 skb hash value from the frontend

2015-10-26 Thread Wei Liu
et a hash on the skb. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Wei Liu Reviewed-by: Wei Liu [...] > > + /* We support hash values. */ > + err = xenbus_printf(xbt, dev->nodename, > + "feat

Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash

Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

2015-10-26 Thread Wei Liu
> Cc: Ian Campbell > Cc: Wei Liu Reviewed-by: Wei Liu > static int xenvif_rx_ring_slots_needed(struct xenvif *vif) > { > - if (vif->gso_mask) > - return DIV_ROUND_UP(vif->dev->gso_max_size, PAGE_SIZE) + 1; > + int needed; > + > + i

Re: [PATCH net-next 8/8] xen-netback: add support for toeplitz hashing

2015-10-26 Thread Wei Liu
ithm itself was based on pseudo-code provided by > Microsoft at: > > https://msdn.microsoft.com/en-us/library/windows/hardware/ff570725.aspx > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Wei Liu [...] > > diff --git a/drivers/net/xen-netback/interface.

Re: [PATCH net-next 1/8] xen-netback: re-import canonical netif header

2015-10-26 Thread Wei Liu
_netif_rx/g > ,s/netif_extra_info/xen_netif_extra_info/g > w > EOF > > indent --linux-style netif.h -o include/xen/interface/io/netif.h > > Signed-off-by: Paul Durrant > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Wei Liu > --- &g

Re: [PATCH net-next 2/8] xen-netback: remove GSO information from xenvif_rx_meta

2015-10-26 Thread Wei Liu
n the array and > removes many lines of code. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Wei Liu Reviewed-by: Wei Liu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH net-next 3/8] xen-netback: support multiple extra info segments passed from frontend

2015-10-26 Thread Wei Liu
modification, for better bisectability. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Wei Liu Reviewed-by: Wei Liu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-10 Thread Wei Liu
On Thu, May 05, 2016 at 12:19:27PM +0100, Paul Durrant wrote: [...] > > +static int connect_ctrl_ring(struct backend_info *be) > +{ Please use goto style error handling in this function. Other than this the code looks good. Wei.

Re: [PATCH net-next 4/4] xen-netback: use hash value from the frontend

2016-05-10 Thread Wei Liu
in a hash extra > info fragment passed from the guest frontend in a transmit-side > (i.e. netback receive side) packet to set the skb hash accordingly. > > Signed-off-by: Paul Durrant > Cc: Wei Liu Acked-by: Wei Liu

Re: [PATCH net-next 3/4] xen-netback: pass hash value to the frontend

2016-05-10 Thread Wei Liu
calculated for > guest receive-side packets (i.e. netback transmit side) to the frontend. > > Signed-off-by: Paul Durrant > Cc: Wei Liu Acked-by: Wei Liu

Re: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-10 Thread Wei Liu
patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant > Cc: Wei Liu > --- > drivers/net/xen-netback/Makefile

Re: [PATCH net-next v3 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Wei Liu
patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH net-next v3 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Wei Liu
necessary code to xen-netback to map this new shared > ring, should it be created by a frontend, but does not add implementations > for any of the defined protocol messages. These are added in a subsequent > patch for clarity. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()

2016-05-12 Thread Wei Liu
ntered when processing packets containing extra info fragments. > This patch fixes the problem. > > Signed-off-by: Paul Durrant > Reported-by: Jan Beulich > Cc: Wei Liu Acked-by: Wei Liu > --- > drivers/net/xen-netback/netback.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH net-next v4 2/4] xen-netback: add control protocol implementation

2016-05-13 Thread Wei Liu
patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant > Cc: Wei Liu Acked-by: Wei Liu

Re: [PATCH net-next] xen-netback: correct length checks on hash copy_ops

2016-05-18 Thread Wei Liu
static analysis checks. > > This patch replaces checks of 'len' with 'copy_op.len' in both cases > to correct the incorrect check, keep the two checks consistent, and to > make it clear what the checks are for. > > Signed-off-by: Paul Durrant >

Re: [PATCH net-next] xen-netback: only deinitialized hash if it was initialized

2016-05-18 Thread Wei Liu
ient to ensure > it is only called if xenvif_init_hash() was called previously. > > Signed-off-by: Paul Durrant > Reported-by: Boris Ostrovsky > Tested-by: Boris Ostrovsky > Cc: Wei Liu Acked-by: Wei Liu > --- > drivers/net/xen-netback/interface.c | 3 +-- > 1 file cha

Re: [PATCH net-next v1] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
On Mon, Feb 01, 2016 at 02:40:53PM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + > +

Re: [PATCH net-next v2] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
On Tue, Feb 02, 2016 at 11:31:08AM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + > +

Re: [PATCH net-next v3] xen-netback: implement dynamic multicast control

2016-02-02 Thread Wei Liu
ture off. > Instead the backend watches the "request-multicast-control" key in xenstore > and turns the feature off if the key value is written to zero. > > This patch adds support for dynamic multicast control in xen-netback. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > Cc: Wei Liu Acked-by: Wei Liu

Re: [PATCH net-next 1/3] xen-netback: re-import canonical netif header

2016-03-10 Thread Wei Liu
AB}/g > w > $ > w > EOF > > indent --line-length 80 --linux-style netif.h \ > -o include/xen/interface/io/netif.h > > Signed-off-by: Paul Durrant > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: Wei Liu Acked-by: Wei Liu

Re: [PATCH net-next 3/3] xen-netback: reduce log spam

2016-03-10 Thread Wei Liu
On Thu, Mar 10, 2016 at 12:30:28PM +, Paul Durrant wrote: > Remove the "prepare for reconnect" pr_info in xenbus.c. It's largely > uninteresting and the states of the frontend and backend can easily be > observed by watching the (o)xenstored log. > > Signed-off-b

Re: [PATCH net-next 2/3] xen-netback: support multiple extra info fragments passed from frontend

2016-03-10 Thread Wei Liu
here > is only ever a single extra info fragment. > > This patch modifies xenvif_get_extras() to pass back a count of extra > info fragments, which is then passed to make_tx_response() (after > possibly being stashed in pending_tx_info for deferred responses). > > Signed-off-b

Re: [PATCH] MAINTAINERS: Drop myself as xen netback maintainer

2016-02-19 Thread Wei Liu
On Fri, Feb 19, 2016 at 11:44:51AM +, Ian Campbell wrote: > Wei has been picking this up for quite a while now. > > Signed-off-by: Ian Campbell > Cc: Wei Liu Acked-by: Wei Liu > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTA

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-04 Thread Wei Liu
I think the original code is fine. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread Wei Liu
The comment at the beginning of the file is the canonical source of licenses for this module. Currently it contains GPL and MIT license. Fix the code to reflect the reality. Signed-off-by: Wei Liu --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread Wei Liu
On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: > On 22/01/16 12:34, Wei Liu wrote: > > The comment at the beginning of the file is the canonical source of > > licenses for this module. Currently it contains GPL and MIT license. Fix > > the code to reflect the r

[PATCH v2 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread Wei Liu
nt, simply make the code to use "GPL" only. Signed-off-by: Wei Liu --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 61b97c3..e9601d1 100644 --- a/drivers/

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-23 Thread Wei Liu
On Fri, Jan 22, 2016 at 08:25:21PM +, One Thousand Gnomes wrote: > > The fact what include/linux/license.h:license_is_gpl_compatible includes > > "Dual MIT/GPL" as an option seems to suggest that it is enough of a thing > > to be validly used as the contents of a MODULE_LICENSE() thing. > > Ye

Re: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

2017-03-02 Thread Wei Liu
On Thu, Mar 02, 2017 at 10:50:20AM +, Anoob Soman wrote: > Allocation of new_hash, inside xenvif_new_hash(), always happen > in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new > hash allocation. > > Signed-off-by: Anoob Soman Acked-by: Wei Liu

Re: BUG due to "xen-netback: protect resource cleaning on XenBus disconnect"

2017-03-02 Thread Wei Liu
On Thu, Mar 02, 2017 at 12:56:20PM +0100, Juergen Gross wrote: > With commits f16f1df65 and 9a6cdf52b we get in our Xen testing: > > [ 174.512861] switch: port 2(vif3.0) entered disabled state > [ 174.522735] BUG: sleeping function called from invalid context at > /home/build/linux-linus/mm/vmal

Re: [PATCH net 1/2] xen-netback: keep a local pointer for vif in backend_disconnect()

2017-03-02 Thread Wei Liu
On Thu, Mar 02, 2017 at 12:54:25PM +, Paul Durrant wrote: > This patch replaces use of 'be->vif' with 'vif' and hence generally > makes the function look tidier. No semantic change. > > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH net 2/2] xen-netback: don't vfree() queues under spinlock

2017-03-02 Thread Wei Liu
0x40/0x40 > [ 174.541898] ret_from_fork+0x21/0x2c > [ 174.548635] switch: port 2(vif3.0) entered disabled state > > This patch defers the vfree() until after the spinlock is released. > > Reported-by: Juergen Gross > Signed-off-by: Paul Durrant Acked-by: Wei Liu

Re: [PATCH 0/2] xen/net: limit number of tx/rx queues

2017-01-10 Thread Wei Liu
ximum on both sides to 8. Both > frontend and backend maximum can be individually tuned via module > parameters. > > Juergen Gross (2): > xen/netfront: set default upper limit of tx/rx queues to 8 > xen/netback: set default upper limit of tx/rx queues to 8 > Acked-by: Wei Liu

Re: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

2017-01-13 Thread Wei Liu
On Thu, Jan 12, 2017 at 05:51:56PM +, Igor Druzhinin wrote: > Eliminate memory leaks introduced several years ago by cleaning the queue > resources which are allocated on XenBus connection event. Namely, queue > structure array and pages used for IO rings. > vif->lock is used to protect statist

Re: [PATCH v2 2/2] xen-netback: protect resource cleaning on XenBus disconnect

2017-01-18 Thread Wei Liu
On Tue, Jan 17, 2017 at 08:49:38PM +, Igor Druzhinin wrote: > vif->lock is used to protect statistics gathering agents from using the > queue structure during cleaning. > > Signed-off-by: Igor Druzhinin Acked-by: Wei Liu

Re: [PATCH v2 1/2] xen-netback: fix memory leaks on XenBus disconnect

2017-01-18 Thread Wei Liu
Igor Druzhinin Acked-by: Wei Liu

  1   2   3   >