[PATCH RFC iproute2-next 1/2] rdma: update rdma_netlink.h to get provider attrs

2018-04-30 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 45474f1..faea9d5 100644 --- a/rdma

[PATCH RFC iproute2-next 0/2] RDMA tool provider resource tracking

2018-04-30 Thread Steve Wise
-next branch (and all reviewing is complete), I'll post a final version and request merging. Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64013.html Steve Wise (2): rdma: update rdma_netlink.h to get provider attrs rdma: print provider resource attributes rdma/include

[PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

2018-04-30 Thread Steve Wise
44 rqt_hwaddr 0x2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise --- rdma/rdma.c | 7 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 194 +++

[PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-07 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 45474f1..40be0d8 100644 --- a/rdma

[PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-07 Thread Steve Wise
merged, I think. Changes since v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma: update rdma_netlink.h to

[PATCH v1 iproute2-next 3/3] rdma: update man pages

2018-05-07 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/rdma

[PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-07 Thread Steve Wise
2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise --- rdma/rdma.c | 7 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 194

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-10 Thread Steve Wise
On 5/9/2018 11:08 PM, David Ahern wrote: > On 5/7/18 9:53 AM, Steve Wise wrote: >> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >> pretty_output = true; >> break; >> case 'd': >&g

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-22 Thread Steve Wise
1:32 AM, Leon Romanovsky wrote: >>>>>> On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: >>>>>>> On 3/12/18 8:16 AM, Steve Wise wrote: >>>>>>>> Hey all, >>>>>>>> >>>>>>>>

RE: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

2018-03-25 Thread Steve Wise
development flow created delays to the rdma tool developers, > who uses rdma-next tree as a basis for their work. > > Move RDMA UAPI file to be under rdma/ folder, so whole responsibility > of syncing this file will be on them. > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

Re: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

2018-03-26 Thread Steve Wise
On 3/26/2018 9:03 AM, David Ahern wrote: > On 3/25/18 12:38 AM, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> In iproute2 package, the updates of UAPIs files are performed >> after the needed feature lands in kernel's net-next tree. >> >> Such development flow created delays to the rdma

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 9:17 AM, David Ahern wrote: > On 2/27/18 9:07 AM, Steve Wise wrote: >> diff --git a/rdma/rdma.h b/rdma/rdma.h >> index 5809f70..e55205b 100644 >> --- a/rdma/rdma.h >> +++ b/rdma/rdma.h >> @@ -18,10 +18,12 @@ >> #include >> #include

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 9:44 AM, David Ahern wrote: > On 3/26/18 8:30 AM, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>> index 5809f70..e55205b 1006

Re: [PATCH iproute2-next 2/2] rdma: Print net device name and index for RDMA device

2018-03-26 Thread Steve Wise
tdev_index", idx); > + } else { > + pr_out("netdev %s ", netdev_name); > + if (rd->show_details) > + pr_out("netdev_index %u ", idx); > + } > +} > + Why is the netdev_index under &#x

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 10:08 AM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:44 AM, David Ahern wrote: >>> On 3/26/18 8:30 AM, Steve Wise wrote: >>>> On 3/26/2018 9:17 AM, David Ahern wrote: >&g

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 12:06 PM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 10:24:25AM -0500, Steve Wise wrote: >> >> On 3/26/2018 10:08 AM, Leon Romanovsky wrote: >>> On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >>>> On 3/26/2018 9:44 AM, David A

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 10:40 AM, David Ahern wrote: > On 2/27/18 9:07 AM, Steve Wise wrote: >> Sample output: >> >> # rdma resource >> 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 >> 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 >> >> # rdma resource show cm_id >> l

[PATCH v3 iproute2-next 0/8] cm_id, cq, mr, and pd resource tracking

2018-03-26 Thread Steve Wise
- fixed memory leaks - removed PD_FLAGS attribute - filter on "mrlen" for mrs - filter on "poll-ctx" for cqs - don't require addrs or qp_type for parsing cm_ids - only filter optional attrs if they are present - remove PGSIZE MR attr to match kernel [1] https://www.spinics.net/li

[PATCH v3 iproute2-next 2/8] rdma: Makefile change to find

2018-03-26 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/Makefile b/rdma/Makefile index 819fcbe..2cb46b6 100644 --- a/rdma/Makefile +++ b/rdma/Makefile @@ -4,7 +4,7 @@ include ../config.mk TARGETS := ifeq ($(HAVE_MNL),y) -CFLAGS

[PATCH v3 iproute2-next 7/8] rdma: Add MR resource tracking information

2018-03-26 Thread Steve Wise
65536 pid 0 comm [nvme_rdma] link cxgb4_0/- rkey 0x68fe4e9 lkey 0x68fe4e9 iova 0x835b91000 mrlen 65536 pid 0 comm [nvme_rdma] Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- include/json_writer.h | 2 + lib/json_writer.c | 11 + rdma/res.c| 127

[PATCH v3 iproute2-next 1/8] rdma: include rdma-core

2018-03-26 Thread Steve Wise
This avoids requiring rdma-core be installed on systems. Signed-off-by: Steve Wise --- rdma/include/rdma/rdma_cma.h | 728 +++ 1 file changed, 728 insertions(+) create mode 100644 rdma/include/rdma/rdma_cma.h diff --git a/rdma/include/rdma/rdma_cma.h b

[PATCH v3 iproute2-next 4/8] rdma: initialize the rd struct

2018-03-26 Thread Steve Wise
Initialize the rd struct so port_idx is 0 unless set otherwise. Otherwise, strict_port queries end up passing an uninitialized PORT nlattr. Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/rdma.c b

[PATCH v3 iproute2-next 3/8] rdma: update rdma_netlink.h

2018-03-26 Thread Steve Wise
From: Steve Wise Pull in the latest rdma_netlink.h which has support for the rdma nldev resource tracking objects being added with this patch series. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 38 +++ 1 file changed, 38 insertions

[PATCH v3 iproute2-next 6/8] rdma: Add CQ resource tracking information

2018-03-26 Thread Steve Wise
comm [ib_core] # rdma resource show cq pid 30489 link mlx4_0/- cqe 63 users 2 pid 30489 comm rping Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/res.c | 139 +++ rdma/utils.c | 5 +++ 2 files changed, 144 insertions

[PATCH v3 iproute2-next 8/8] rdma: Add PD resource tracking information

2018-03-26 Thread Steve Wise
pid 0 comm [ib_srpt] link mlx4_0/- local_dma_lkey 0x8000 users 0 pid 0 comm [ib_srp] link mlx4_0/- local_dma_lkey 0x8000 users 1 pid 0 comm [ib_core] link cxgb4_0/- local_dma_lkey 0x0 users 0 pid 0 comm [ib_srp] Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/res.c | 95

[PATCH v3 iproute2-next 5/8] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
cxgb4_0/2 lqpn 1040 qp-type RC state CONNECT ps TCP pid 30498 comm rping src-addr 172.16.2.1:38246 dst-addr 172.16.2.1:7174 link mlx4_0/1 lqpn 538 qp-type RC state CONNECT ps TCP pid 30492 comm rping src-addr 172.16.99.1:43670 dst-addr 172.16.99.1:7174 Signed-off-by: Steve Wise Reviewed-by

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-26 Thread Steve Wise
On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>> inde

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-27 Thread Steve Wise
son Gunthorpe wrote: > > > > > On Mon, Mar 26, 2018 at 04:34:44PM -0500, Steve Wise wrote: > > > > > > > > > > > > On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > > > > > > > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise w

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-27 Thread Steve Wise
> On Tue, Mar 27, 2018 at 10:45:30AM -0500, Steve Wise wrote: > > > > > > > > On Tue, Mar 27, 2018 at 06:15:44PM +0300, Leon Romanovsky wrote: > > > > On Tue, Mar 27, 2018 at 08:44:55AM -0600, Jason Gunthorpe wrote: > > > > > On Tue, Mar

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-27 Thread Steve Wise
> > On Tue, Mar 27, 2018 at 11:20:25AM -0500, Steve Wise wrote: > > > On Tue, Mar 27, 2018 at 10:45:30AM -0500, Steve Wise wrote: > > > > > > > > > > > > > > On Tue, Mar 27, 2018 at 06:15:44PM +0300, Leon Romanovsky wrote: > > &g

[PATCH v1 iproute2-next 0/4] Dynamic rdma link creation

2019-02-21 Thread Steve Wise
for the network device, do avoid confused with the ib_device name. - got rid of the "type" parameter for link delete. Also pass down the device index instead of the name, using the common rd services for validating the device name and fetching the index. Thanks, Steve. Steve W

[PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h

2019-02-21 Thread Steve Wise
Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / RDMA_NLDEV_CMD_DELLINK API. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 74 +++ 1 file changed, 58 insertions(+), 16 deletions(-) diff --git a/rdma/include/uapi/rdma

[PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-21 Thread Steve Wise
This function sends the constructed netlink message and then receives the response, displaying any error text. Change 'rdma dev set' to use it. Signed-off-by: Steve Wise --- rdma/dev.c | 2 +- rdma/rdma.h | 1 + rdma/utils.c | 21 + 3 files changed, 23 insert

[PATCH v1 iproute2-next 4/4] rdma: man page update for link add/delete

2019-02-21 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 47 +++ 1 file changed, 47 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index bddf34

[PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-21 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe netdev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 67

RE: [PATCH iproute2-next v1 01/19] rdma: update uapi headers

2019-02-21 Thread Steve Wise
sible entries > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all visible objects

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all > visible objects > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print > code > > From: Leon Romanovsky > > There is no need to keep same print functions for > uint32_t and uint64_t, unify them into one function. > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID

2019-02-21 Thread Steve Wise
res_print_uint(rd, "pdn", pdn); > + > if (nla_line[RDMA_NLDEV_ATTR_RES_PID]) > free(comm); > > @@ -964,6 +991,7 @@ static int res_pd_parse_cb(const struct nlmsghdr > *nlh, void *data) > uint32_t local_dma_lkey = 0, unsafe_global_rkey = 0; > struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {}; > char *comm = NULL; > + uint32_t ctxn = 0; > uint32_t pid = 0; > uint32_t pdn = 0; > uint64_t users; > @@ -997,7 +1025,13 @@ static int res_pd_parse_cb(const struct nlmsghdr > *nlh, void *data) > comm = get_task_name(pid); > } > > - if (rd_check_is_filtered(rd, "pid", pid)) > +if (rd_check_is_filtered(rd, "pid", pid)) Did this add some whitespace problem? Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file

2019-02-21 Thread Steve Wise
y: Leon Romanovsky > --- Why does it need to be self contained? Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR logic to separate file

2019-02-21 Thread Steve Wise
f-by: Leon Romanovsky > --- Ah I guess you're moving them all into their own files. Ok. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic to separate file

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic > to separate file > > From: Leon Romanovsky > > Logically separate resource CQ logic to separate file, > in order to make CQ specific logic self-contained. > > Signed-off-by: Leon Romanovsky > --- Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID logic to separate file

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID > logic to separate file > > From: Leon Romanovsky > > Logically separate resource CM-ID logic to separate file, > in order to make CM-ID specific logic self-contained. > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 09/19] rdma: Move resource PD logic to separate file

2019-02-21 Thread Steve Wise
les changed, 252 insertions(+), 237 deletions(-) > create mode 100644 rdma/res-qp.c Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool license

2019-02-21 Thread Steve Wise
this type of license. > > Signed-off-by: Leon Romanovsky > --- > rdma/Makefile | 2 +- > rdma/dev.c| 7 +-- > rdma/link.c | 7 +-- > rdma/rdma.c | 7 +-- > rdma/rdma.h | 7 +-- > rdma/res.c| 7 +-- > rdma/utils.c | 7 +-- > 7 files changed, 7 insertions(+), 37 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse existing functions

2019-02-21 Thread Steve Wise
- > rdma/res-cmid.c | 4 ++-- > rdma/res-cq.c | 14 +++--- > rdma/res-mr.c | 2 +- > rdma/res-pd.c | 4 ++-- > rdma/res-qp.c | 14 +++--- > rdma/res.c | 34 ++ > rdma/res.h | 3 --- > 7 files changed, 13 insertions(+), 62 deletions(-) > Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code

2019-02-21 Thread Steve Wise
-- > 1 file changed, 124 insertions(+), 122 deletions(-) Not sure why you refactored, but ok. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 14/19] rdma: Separate MR code

2019-02-21 Thread Steve Wise
s(-) The commit description is wrong. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-cq.c | 177 ++ > 1 file changed, 91 insertions(+), 86 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 15/19] rdma: Separate PD code

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 15/19] rdma: Separate PD code > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-pd.c | 170 ++ > 1 file changed, 89 insertions(+), 81 deletions(-) commit text is wrong. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate function

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate > function > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-qp.c | 253 +- > 1 file changed, 127 insertions(+), 126 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute checks prior to prints

2019-02-21 Thread Steve Wise
--- > rdma/res.h | 6 ++++-- > 7 files changed, 53 insertions(+), 51 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to query specific objects

2019-02-21 Thread Steve Wise
| 32 ++- > rdma/res.c | 34 +++- > rdma/res.h | 84 - > rdma/utils.c| 20 ++++ > 9 files changed, 239 insertions(+), 73 deletions(-) > Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions

2019-02-21 Thread Steve Wise
+++--- > rdma/utils.c| 26 ++ > 7 files changed, 112 insertions(+), 77 deletions(-) Reviewed-by: Steve Wise

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to us

Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h

2019-02-26 Thread Steve Wise
On 2/23/2019 3:28 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:07AM -0800, Steve Wise wrote: >> Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / >> RDMA_NLDEV_CMD_DELLINK API. >> >> Signed-off-by: Steve Wise >> --- >>

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:31 AM, Leon Romanovsky wrote: > On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>> This function sends the constructed netlink message and then >>> receives the response

Re: [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-26 Thread Steve Wise
On 2/23/2019 3:43 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:12AM -0800, Steve Wise wrote: >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >> device to a netdev interface. >> >> EG: >> >

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/26/2019 1:16 PM, Leon Romanovsky wrote: > On Tue, Feb 26, 2019 at 11:19:12AM -0600, Steve Wise wrote: >> On 2/23/2019 3:31 AM, Leon Romanovsky wrote: >>> On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >>>> On Thu, Feb 21, 2019 at 08:1

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:14 AM > To: Leon Romanovsky > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next

RE: [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:25 AM > To: Leon Romanovsky > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next 3/4] rdma:

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to us

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/28/2019 1:56 PM, Leon Romanovsky wrote: > On Thu, Feb 28, 2019 at 01:41:20PM -0600, Steve Wise wrote: >> On 2/23/2019 3:26 AM, Leon Romanovsky wrote: >>> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>>> This function sends the constr

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-04 Thread Steve Wise
> > > > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > > >> This function sends the constructed netlink message and then > > > >> receives the response, displ

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-06 Thread Steve Wise
On 3/4/2019 8:13 AM, Steve Wise wrote: > Hey Leon, adding this to rd_recv_msg(): > > @@ -693,10 +693,28 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void > *data, unsigned int seq) > ret = mnl_cb_run(buf, ret, seq, portid, callback, data); >

[PATCH v2 iproute2-next 4/4] rdma: man page update for link add/delete

2019-03-26 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 47 1 file changed, 47 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index bddf3474..b3b40

[PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-03-26 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe netdev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 83

[PATCH v2 iproute2-next 1/4] Add .mailmap file

2019-03-26 Thread Steve Wise
.mailmap allows tracking multiple email addresses to the proper user name. Signed-off-by: Steve Wise --- .mailmap | 8 1 file changed, 8 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index ..c012d3d0 --- /dev/null +++ b

[PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-03-26 Thread Steve Wise
This function sends the constructed netlink message and then receives the response. Change rd_recv_msg() to display any error messages. Change 'rdma dev set' to use rd_sendrecv_msg(). Signed-off-by: Steve Wise --- rdma/dev.c | 2 +- rdma/rdma.h | 2 ++ rdma/res.h | 1 + rd

[PATCH v2 iproute2-next 0/4] Dynamic rdma link creation

2019-03-26 Thread Steve Wise
evice, do avoid confused with the ib_device name. - got rid of the "type" parameter for link delete. Also pass down the device index instead of the name, using the common rd services for validating the device name and fetching the index. Thanks, Steve. Steve Wise

iproute2 won't compile without AF_VSOCK

2018-06-19 Thread Steve Wise
Hey David, I'm trying to compile the latest iproute2 on an RHEL-7.3 distro, and it fails to compile because AF_VSOCK is not defined.  Should this functionality be a configure option to disable it on older distros? Thanks, Steve. misc     CC   ss.o ss.c:301:27: error: ‘AF_VSOCK’ undec

Re: iproute2 won't compile without AF_VSOCK

2018-06-19 Thread Steve Wise
On 6/19/2018 3:29 PM, David Ahern wrote: > On 6/19/18 2:27 PM, David Ahern wrote: >> On 6/19/18 9:47 AM, Stephen Hemminger wrote: >>> On Tue, 19 Jun 2018 10:17:45 -0500 >>> Steve Wise wrote: >>> >>>> Hey David, >>>> >>>>

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-16 Thread Steve Wise
Hey Max: On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > > > On 7/16/2018 5:59 PM, Sagi Grimberg wrote: >> >>> Hi, >>> I've tested this patch and seems problematic at this moment. >> >> Problematic how? what are you seeing? > > Connection failures and same error Steve saw: > > [Mon Jul 16 16:19:11 2

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-17 Thread Steve Wise
> On 7/16/2018 8:08 PM, Steve Wise wrote: > > Hey Max: > > > > > > Hey, > > > On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > >> > >> > >> On 7/16/2018 5:59 PM, Sagi Grimberg wrote: > >>> > >>>> Hi, >

RE: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-12 Thread Steve Wise
dma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Steve Wise > Sent: Friday, March 02, 2018 1:56 PM > To: dsah...@gmail.com > Cc: l...@kernel.org; step...@networkplumber.org; netdev@vger.kernel.org; > linux-r...@vger.kernel.org > Subject: [PATCH v2 iproute2

RE: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

2018-03-12 Thread Steve Wise
> > On 3/12/18 8:16 AM, Steve Wise wrote: > > Hey all, > > > > The kernel side of this series has been merged for rdma-next [1]. Let me > > know if this iproute2 series can be merged, of if it needs more changes. > > > > The problem is that iproute2

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

2018-03-13 Thread Steve Wise
> On Tue, Feb 27, 2018 at 08:07:05AM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource > > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > > > # rdma resource show cm_id > > link cxgb4_0/- l

interdependencies with cxgb4 and iw_cxgb4

2018-03-14 Thread Steve Wise
Hey Dave, We've been discussing dependency issues between cxgb4 and the upper layer drivers including iw_cxgb4 on linux-rdma [1], and I want to broaden this discussion to include netdev and you, since this involves both linux-rdma and netdev. (note the SRQ patch submission that triggered this di

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Steve Wise
> Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code already has an explicit barrier call, changing writel() to > writel_relaxed

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Steve Wise
> > On Fri, Mar 16, 2018 at 04:05:10PM -0500, Steve Wise wrote: > > > Code includes wmb() followed by writel(). writel() already has a barrier > > on > > > some architectures like arm64. > > > > > > This ends up CPU observing two barriers back to

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Steve Wise
> > On 3/16/2018 5:05 PM, Steve Wise wrote: > >> Code includes wmb() followed by writel(). writel() already has a barrier > > on > >> some architectures like arm64. > >> > >> This ends up CPU observing two barriers back to back before executing

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-17 Thread Steve Wise
IDX_T5_V(inc) | QID_V(wq->rq.bar2_qid), > +wq->rq.bar2_va + SGE_UDB_KDOORBELL); > } > > /* Flush user doorbell area writes. */ > wmb(); > return; > } > - writel(QID_V(wq->rq.qid) | PIDX_V(inc), wq->db); > + __raw_writel(QID_V(wq->rq.qid) | PIDX_V(inc), wq->db); > + mmiowmb(); > } > > Yes, this is what chelsio recommended to me. Reviewed-by: Steve Wise

Re: interdependencies with cxgb4 and iw_cxgb4

2018-03-19 Thread Steve Wise
On 3/16/2018 11:21 AM, David Miller wrote: From: "Steve Wise" Date: Wed, 14 Mar 2018 10:31:24 -0500 This issue has also been dealt-with for Mellanox drivers, I believe. I take it the solution for them was a k.o. signed repo, that they maintain, where both linux-rdma and netde

RE: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Steve Wise
> From: Steve Wise > Date: Mon, 19 Mar 2018 14:50:57 -0500 > > > Let me ask a dumb question:  Why cannot one of the maintaners pull the > > commit from the other mainainer's git repo directly?  IE why have this > > third trusted/signed git repo that h

RE: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Steve Wise
> >> > Let me ask a dumb question:  Why cannot one of the maintaners pull > the > >> > commit from the other mainainer's git repo directly?  IE why have this > >> > third trusted/signed git repo that has to be on k.o, from which both > >> > maintainers pull?  If one of you can pull it in via a pat

RE: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Steve Wise
> > From: "Steve Wise" > Date: Tue, 20 Mar 2018 10:08:44 -0500 > > > For the maintainers, yes. But it avoids setting up k.o accounts and > > git repos for each device driver maintainer that has this issue. > > I think this is quite a reasonable requ

[PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

2018-03-29 Thread Steve Wise
arsing cm_ids - only filter optional attrs if they are present - remove PGSIZE MR attr to match kernel [1] https://www.spinics.net/lists/linux-rdma/msg61720.html [2] https://www.spinics.net/lists/linux-rdma/msg62979.html https://www.spinics.net/lists/linux-rdma/msg62980.html --- Steve Wise (

[PATCH v4 iproute2-next 1/7] rdma: update rdma_netlink.h

2018-03-29 Thread Steve Wise
From: Steve Wise Pull in the latest rdma_netlink.h which has support for the rdma nldev resource tracking objects being added with this patch series. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 38 +++ 1 file changed, 38 insertions

[PATCH v4 iproute2-next 2/7] rdma: add UAPI rdma_user_cm.h

2018-03-29 Thread Steve Wise
This allows parsing rdma_cm_id UAPI values. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_user_cm.h | 324 ++ 1 file changed, 324 insertions(+) create mode 100644 rdma/include/uapi/rdma/rdma_user_cm.h diff --git a/rdma/include/uapi/rdma

[PATCH v4 iproute2-next 3/7] rdma: initialize the rd struct

2018-03-29 Thread Steve Wise
Initialize the rd struct so port_idx is 0 unless set otherwise. Otherwise, strict_port queries end up passing an uninitialized PORT nlattr. Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/rdma.c b

[PATCH v4 iproute2-next 4/7] rdma: Add CM_ID resource tracking information

2018-03-29 Thread Steve Wise
cxgb4_0/2 lqpn 1040 qp-type RC state CONNECT ps TCP pid 30498 comm rping src-addr 172.16.2.1:38246 dst-addr 172.16.2.1:7174 link mlx4_0/1 lqpn 538 qp-type RC state CONNECT ps TCP pid 30492 comm rping src-addr 172.16.99.1:43670 dst-addr 172.16.99.1:7174 Signed-off-by: Steve Wise Reviewed-by

[PATCH v4 iproute2-next 7/7] rdma: Add PD resource tracking information

2018-03-29 Thread Steve Wise
[ib_srpt] dev mlx4_0 local_dma_lkey 0x8000 users 0 pid 0 comm [ib_srp] dev mlx4_0 local_dma_lkey 0x8000 users 1 pid 0 comm [ib_core] dev cxgb4_0 local_dma_lkey 0x0 users 0 pid 0 comm [ib_srp] Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/res.c | 95

[PATCH v4 iproute2-next 6/7] rdma: Add MR resource tracking information

2018-03-29 Thread Steve Wise
comm [nvme_rdma] dev cxgb4_0 rkey 0x68fe4e9 lkey 0x68fe4e9 iova 0x835b91000 mrlen 65536 pid 0 comm [nvme_rdma] Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- include/json_writer.h | 2 + lib/json_writer.c | 11 + rdma/res.c| 127

[PATCH v4 iproute2-next 5/7] rdma: Add CQ resource tracking information

2018-03-29 Thread Steve Wise
] # rdma resource show cq pid 30489 dev mlx4_0 cqe 63 users 2 pid 30489 comm rping Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/res.c | 149 +++ rdma/utils.c | 5 ++ 2 files changed, 154 insertions(+) diff --git a

RE: [PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

2018-04-01 Thread Steve Wise
> > On Sun, Apr 01, 2018 at 09:22:14AM -0600, David Ahern wrote: > > On 3/29/18 3:38 PM, Steve Wise wrote: > > > This series enhances the iproute2 rdma tool to include dumping of > > > connection manager id (cm_id), completion queue (cq), memory region > (mr)

RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes

2018-04-03 Thread Steve Wise
> -Original Message- > From: Leon Romanovsky > Sent: Tuesday, April 3, 2018 2:29 AM > To: Stephen Hemminger > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list r...@vger.kernel.org>; David Ahern ; Steve Wise > > Subject: [PATCH iproute2 rdma: Ignore

RE: [PATCH RFC iproute-next 4/5] rdma: Add MR resource tracking information

2018-02-26 Thread Steve Wise
> -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Tuesday, February 20, 2018 8:12 AM > To: Steve Wise > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH RFC i

RE: [PATCH RFC iproute-next 2/5] rdma: Add CM_ID resource tracking information

2018-02-26 Thread Steve Wise
> > On Wed, Feb 14, 2018 at 01:07:01PM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource > > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > > > # rdma resource show cm_id > > [root@ste

RE: [PATCH RFC iproute-next 5/5] rdma: Add PD resource tracking information

2018-02-26 Thread Steve Wise
> > On Wed, Feb 14, 2018 at 01:07:01PM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource show pd > > link cxgb4_0/- local_dma_lkey 0x0 usecnt 4 flags 0x0 pid 30503 comm rping > > One more thing, flags need to be pre-parsed and accessible w

RE: [PATCH RFC iproute-next 3/5] rdma: Add CQ resource tracking information

2018-02-26 Thread Steve Wise
> > On Wed, Feb 14, 2018 at 01:07:01PM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource show cq > > link cxgb4_0/- cqe 46 usecnt 2 pid 30503 comm rping > > link cxgb4_0/- cqe 46 usecnt 2 pid 30498 comm rping > > link mlx4_0/- cqe 63 use

  1   2   3   4   5   6   >