Re: "KMSAN: uninit-value in rt2500usb_bbp_read" and "KMSAN: uninit-value in rt2500usb_probe_hw" should be duplicate crash reports

2021-01-21 Thread Stanislaw Gruszka
On Thu, Jan 21, 2021 at 04:47:37PM +0800, 慕冬亮 wrote: > ## Patch > > I propose to memset reg variable before invoking > rt2x00usb_vendor_req_buff_lock/rt2x00usb_vendor_request_buff. > >

Re: [PATCH] rt2x00: save survey for every channel visited

2020-10-20 Thread Stanislaw Gruszka
On Mon, Oct 19, 2020 at 07:06:47PM +, Марков Михаил Александрович wrote: > rt2800 only gives you survey for current channel. > .watchdog= rt2800_watchdog, > +.update_survey= rt2800_update_survey, Since this feature is rt2800 specific, I would do not add new generic ca

Re: [PATCH v2] rt2x00: save survey for every channel visited

2020-10-21 Thread Stanislaw Gruszka
nd be able to give away > that information. > > There is a bug registered https://dev.archive.openwrt.org/ticket/19081 and > this patch solves the issue. > > Signed-off-by: Markov Mikhail > > --- > Changes are now aggregated in rt2800lib.c. Acked-by: Stanislaw Gruszka Thanks Stanislaw

Re: [PATCH v2] rt2x00: save survey for every channel visited

2020-11-04 Thread Stanislaw Gruszka
On Mon, Nov 02, 2020 at 06:19:32PM +0200, Kalle Valo wrote: > Марков Михаил Александрович writes: > > > rt2800 only gives you survey for current channel. > > > > Survey-based ACS algorithms are failing to perform their job when working > > with rt2800. > > > > Make rt2800 save survey for every ch

Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables

2021-02-18 Thread Stanislaw Gruszka
On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A > || A && B is equivalent to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/

Re: [PATCH] iwlegacy: Add missing check in il4965_commit_rxon

2021-02-28 Thread Stanislaw Gruszka
On Sun, Feb 28, 2021 at 08:25:22PM +0800, Dinghao Liu wrote: > There is one il_set_tx_power() call in this function without > return value check. Print error message and return error code > on failure just like the other il_set_tx_power() call. We have few calls for il_set_tx_power(), on some case

Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables

2021-02-04 Thread Stanislaw Gruszka
-by: Jiapeng Chong Acked-by: Stanislaw Gruszka

Re: [PATCH net-next 3/5] iwlegacy: avoid -Wempty-body warning

2021-03-22 Thread Stanislaw Gruszka
avoids the > warnings and adds useful format string checks. > > Signed-off-by: Arnd Bergmann Acked-by: Stanislaw Gruszka

Re: [PATCH] rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

2018-04-18 Thread Stanislaw Gruszka
On Wed, Apr 18, 2018 at 12:47:50PM +0100, Colin King wrote: > From: Colin Ian King > > Rename several macros that contain mispellings of UNKNOWN > > Signed-off-by: Colin Ian King Acked-by: Stanislaw Gruszka

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-12 Thread Stanislaw Gruszka
Hi On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote: > I've got the following report while fuzzing the kernel with syzkaller. > > On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). > > I'm not sure whether this is a bug in the driver, or just a way to > report misbeha

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-16 Thread Stanislaw Gruszka
Hi Dmitry On Sat, Oct 14, 2017 at 04:38:03PM +0200, Dmitry Vyukov wrote: > On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka > wrote: > > Hi > > > > On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote: > >> I've got the following report w

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2017-09-22 Thread Stanislaw Gruszka
Content type information was added at the end of the topic, but I think Kalle can fix that when he will be committing the patch. Acked-by: Stanislaw Gruszka

Re: [PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

2018-01-03 Thread Stanislaw Gruszka
t; Signed-off-by: Markus Elfring Acked-by: Stanislaw Gruszka

Re: [PATCH] rt61pci: Work around a firmware bug with shared keys

2019-01-16 Thread Stanislaw Gruszka
ware is > trying to be smarter than the driver, which is bound > to fail. > > As workaround the function rt61pci_config_shared_key > requests software decryption of the shared keys, > by returning EOPNOTSUPP. However, pairwise keys are > still handled by hardware which works just fine. > > Signed-off-by: Bernd Edlinger Acked-by: Stanislaw Gruszka

Re: [PATCH] rt2x00: make const array glrt_table static

2017-07-11 Thread Stanislaw Gruszka
hex filename > 131772 4733 0 136505 21539 rt2800lib.o > > After: >text data bss dec hex filename > 131043 4789 0 135832 21298 rt2800lib.o > > Signed-off-by: Colin Ian King Acked-by: Stanislaw Gruszka I wonder why co

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Stanislaw Gruszka
On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > With CONFIG_KASAN enabled and gcc-7, we get a warning about rather high > stack usage (with a private patch set I have to turn on this warning, > which I intend to get into the next kernel release): > > wireless/ralink/rt2x00/rt2800l

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: > From: Stanislaw Gruszka > Date: Mon, 15 May 2017 16:28:01 +0200 > > > On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > >> With CONFIG_KASAN enabled and gcc-7, we get a warning about rather hig

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote: > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > > > In rt2x00 driver we use poor convention in other kind of registers > > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr >

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-16 Thread Stanislaw Gruszka
On Tue, May 16, 2017 at 01:55:17PM +0200, Stanislaw Gruszka wrote: > On Mon, May 15, 2017 at 10:39:51AM -0400, David Miller wrote: > > From: Stanislaw Gruszka > > Date: Mon, 15 May 2017 16:28:01 +0200 > > > > > On Mon, May 15, 2017 at 03:46:55PM +0200, Ar

Re: [PATCH] wireless: iwlegacy: Convert timers to use timer_setup()

2017-10-19 Thread Stanislaw Gruszka
On Mon, Oct 16, 2017 at 04:37:44PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Stanislaw Grusz

Re: [PATCH] iwl4965: Enable checking of format strings

2015-04-28 Thread Stanislaw Gruszka
On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote: > Rasmus Villemoes writes: > > > Since these fmt_* variables are just const char*, and not const > > char[], gcc (and smatch) doesn't to type checking of the arguments to > > the printf functions. Since the linker knows perfectly well to

Re: [PATCH] iwlegacy: avoid warning about missing braces

2016-05-19 Thread Stanislaw Gruszka
ses] > > This adds a set of curly braces to avoid the warning. > > Signed-off-by: Arnd Bergmann Acked-by: Stanislaw Gruszka

myri10ge: fix sleeping with bh disabled

2016-04-25 Thread Stanislaw Gruszka
[ 114.317673] [] __might_sleep+0x173/0x230 [ 114.320566] [] napi_disable+0x27/0x90 [ 114.323254] [] myri10ge_close+0xbf/0x3f0 [myri10ge] Signed-off-by: Stanislaw Gruszka --- diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index

Re: [PATCH] rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

2016-03-07 Thread Stanislaw Gruszka
On Tue, Feb 23, 2016 at 11:09:22PM +0800, Anthony Wong wrote: > Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong > Cc: sta...@vger.kernel.org Acked-by: Stanislaw Gruszka

Re: [PATCH 1/3] net-iwlegacy: Refactoring for il_eeprom_init()

2016-01-04 Thread Stanislaw Gruszka
On Fri, Jan 01, 2016 at 09:30:10PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 20:54:25 +0100 > > Return directly if a memory allocation failed at the beginning. > > Signed-off-by: Markus Elfring Acked-by: Stanislaw Gruszka -- To unsubscr

Re: [PATCH] iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

2016-01-04 Thread Stanislaw Gruszka
On Wed, Dec 30, 2015 at 12:20:49PM +0100, Julia Lawall wrote: > The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka -- To unsubscribe from this list: send the li

[PATCH 4.11] genetlink: fix counting regression on ctrl_dumpfamily()

2017-03-22 Thread Stanislaw Gruszka
track families") Signed-off-by: Stanislaw Gruszka --- Dave, please also target this for 4.10+ -stable. net/netlink/genetlink.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index fb6e10f..92e0981 100644 --- a/

[PATCH] ethtool: do not vzalloc(0) on registers dump

2017-02-02 Thread Stanislaw Gruszka
0kB kernel_stack:160kB pagetables:984kB bounce:0kB free_pcp:2236kB local_pcp:660kB free_cma:0kB lowmem_reserve[]: 0 0 4456 4456 Signed-off-by: Stanislaw Gruszka --- net/core/ethtool.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/core/ethtool.c b/net/core/ethtoo

[PATCH v2] ethtool: do not vzalloc(0) on registers dump

2017-02-02 Thread Stanislaw Gruszka
0kB kernel_stack:160kB pagetables:984kB bounce:0kB free_pcp:2236kB local_pcp:660kB free_cma:0kB lowmem_reserve[]: 0 0 4456 4456 Signed-off-by: Stanislaw Gruszka --- v1 -> v2: nullify regbuf to avoid using uninitialized variable in line: if (regbuf && copy_to_user(useraddr, re

Re: [PATCH v2] ethtool: do not vzalloc(0) on registers dump

2017-02-02 Thread Stanislaw Gruszka
On Thu, Feb 02, 2017 at 09:27:18AM -0500, John W. Linville wrote: > > - regbuf = vzalloc(reglen); > > - if (reglen && !regbuf) > > - return -ENOMEM; > > + regbuf = NULL; > > Any reason to prefer this over changing the declaration to include > the assignment? > > void *regbuf

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-14 Thread Stanislaw Gruszka
On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. > > > > As can be seen in the current code ba

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-15 Thread Stanislaw Gruszka
On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the >

Re: [PATCH 08/26] iwlegacy: constify local structures

2016-09-12 Thread Stanislaw Gruszka
sed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

2015-12-10 Thread Stanislaw Gruszka
o work around this in the only file > that shows the behavior, by marking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. I don't think this is good way to "fix" the issue, but also have nothin

Re: [PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb

2015-08-12 Thread Stanislaw Gruszka
ROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. > > Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields. > > Tested with a rt2570 device. > > Signed-off-by: Adrien Schildknecht Acked-by: Stanislaw Gruszka -- To unsubscribe from this list: send the line "unsubs