Re: [PATCH 8/9] acpi: Use built-in RCU list checking for acpi_ioremaps list (v1)

2019-07-15 Thread Rafael J. Wysocki
On Mon, Jul 15, 2019 at 4:43 PM Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu has built-in RCU and lock checking. Make use of > it for acpi_ioremaps list traversal. > > Signed-off-by: Joel Fernandes (Google) Acked-by: Rafael J. Wysocki > --- > drivers/acpi/

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko wrote: > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > wrote: > > > > Using fwnode_get_id(), get the reg property value for DT node > > or get the _ADR object value for ACPI node. > > > > Signed-off-by: Calvin Johnson > > --- > > > > Changes i

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 7:44 PM Andy Shevchenko wrote: > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 4:47 PM Andy Shevchenko > > wrote: > > > On Tue, Jan 12, 2021 at 3:42 PM Calvin Johnson > > > wrote: > &g

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko wrote: > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 7:02 PM Andy Shevchenko > > wrote: > > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > > &g

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-20 Thread Rafael J. Wysocki
On Tue, Jan 12, 2021 at 7:02 PM Andy Shevchenko wrote: > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote: > > On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson > > wrote: > > > > > > Using fwnode_get_id(), get the reg property value for DT node > > > or get the _ADR object value fo

Re: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Wed, Jan 20, 2021 at 9:01 PM Saravana Kannan wrote: > > On Wed, Jan 20, 2021 at 11:15 AM Rafael J. Wysocki wrote: > > > > On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko > > wrote: > > > > > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki >

Re: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson wrote: > > Using fwnode_get_id(), get the reg property value for DT node > or get the _ADR object value for ACPI node. So I'm not really sure if this is going to be generically useful. First of all, the meaning of the _ADR return value is specific t

Re: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 6:12 PM Andy Shevchenko wrote: > > On Fri, Jan 22, 2021 at 05:40:41PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson > > wrote: > > > > > > Using fwnode_get_id(), get the reg property value for DT nod

Re: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson wrote: > > Using fwnode_get_id(), get the reg property value for DT node > or get the _ADR object value for ACPI node. > > Signed-off-by: Calvin Johnson > --- > > Changes in v4: > - Improve code structure to handle all cases > > Changes in v3: > - Mo

Re: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 7:11 PM Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 6:12 PM Andy Shevchenko > wrote: > > > > On Fri, Jan 22, 2021 at 05:40:41PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson > > > wro

Re: [net-next PATCH v4 09/15] device property: Introduce fwnode_get_id()

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 7:13 PM Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson > wrote: > > > > Using fwnode_get_id(), get the reg property value for DT node > > or get the _ADR object value for ACPI node. This is not accurate AFAICS, be

Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-22 Thread Rafael J. Wysocki
On Fri, Jan 22, 2021 at 4:43 PM Calvin Johnson wrote: > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > provide them to be connected to MAC. > > Describe properties "phy-handle" and "phy-mode". > > Signed-off-by: Calvin Johnson > --- > > Changes in v4: > - More cleanup This

Re: [PATCH v2] PM: runtime: replace pm_runtime_resume_and_get with pm_runtime_resume_and_get_sync

2020-11-30 Thread Rafael J. Wysocki
On Sat, Nov 28, 2020 at 11:17 PM Zhang Qilong wrote: > > In the pm_runtime_resume_and_get, pm_runtime_resume() is > synchronous. Caller had to look into the implementation > to verify that a change for pm_runtime_resume_and_get [0]. Well, "resume" is "sync" by definition. > So we use pm_rauntime

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

2020-11-30 Thread Rafael J. Wysocki
On Fri, Nov 27, 2020 at 11:16 AM Geert Uytterhoeven wrote: > > Hi Zhang, > > On Tue, Nov 10, 2020 at 10:29 AM Zhang Qilong wrote: > > In many case, we need to check return value of pm_runtime_get_sync, but > > it brings a trouble to the usage counter processing. Many callers forget > > to decreas

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

2020-11-30 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 6:35 PM Laurent Pinchart wrote: > > On Mon, Nov 30, 2020 at 05:37:52PM +0100, Rafael J. Wysocki wrote: > > On Fri, Nov 27, 2020 at 11:16 AM Geert Uytterhoeven wrote: > > > On Tue, Nov 10, 2020 at 10:29 AM Zhang Qilong > > > wrote: > >

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

2020-11-30 Thread Rafael J. Wysocki
On Mon, Nov 30, 2020 at 7:50 PM Laurent Pinchart wrote: > > Hi Rafael, > > On Mon, Nov 30, 2020 at 06:55:57PM +0100, Rafael J. Wysocki wrote: > > On Mon, Nov 30, 2020 at 6:35 PM Laurent Pinchart wrote: > > > On Mon, Nov 30, 2020 at 05:37:52PM +0100, Rafael J. Wysocki wr

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Rafael J. Wysocki
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: [cut] > > > > Maintainers routinely review 1-line trivial patches, not to mention > > internal API changes, etc. > >

Re: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 2:24 PM zhangqilong wrote: > > Hi > > > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong > > wrote: > > > > > > In many case, we need to check return value of pm_runtime_get_sync, > > > but it brings a trouble to the usage counter processing. Many callers > > > forget to decre

Re: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong wrote: > > In many case, we need to check return value of pm_runtime_get_sync, but > it brings a trouble to the usage counter processing. Many callers forget > to decrease the usage counter when it failed. It has been discussed a > lot[0][1]. So we add a

Re: [PATCH 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 2:46 PM zhangqilong wrote: > > Hi, > > > > > On Mon, Nov 9, 2020 at 2:24 PM zhangqilong > > wrote: > > > > > > Hi > > > > > > > > On Mon, Nov 9, 2020 at 9:05 AM Zhang Qilong > > > > > > > > wrote: > > > > > > > > > > In many case, we need to check return value of > > > > >

Re: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong wrote: > > In many case, we need to check return value of pm_runtime_get_sync, but > it brings a trouble to the usage counter processing. Many callers forget > to decrease the usage counter when it failed. It has been discussed a > lot[0][1]. So we add a

Re: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 4:50 PM Ulf Hansson wrote: > > On Mon, 9 Nov 2020 at 16:20, Rafael J. Wysocki wrote: > > > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong wrote: > > > > > > In many case, we need to check return value of pm_runtime_get_sync, but &g

Re: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 4:50 PM zhangqilong wrote: > > > operation to deal with usage counter > > > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong > > wrote: > > > > > > In many case, we need to check return value of pm_runtime_get_sync, > > > but it brings a trouble to the usage counter processing

Re: [PATCH v2 1/2] PM: runtime: Add a general runtime get sync operation to deal with usage counter

2020-11-09 Thread Rafael J. Wysocki
On Mon, Nov 9, 2020 at 5:15 PM zhangqilong wrote: > > Hi > > > > > On Mon, Nov 9, 2020 at 4:50 PM zhangqilong > > wrote: > > > > > > > operation to deal with usage counter > > > > > > > > On Mon, Nov 9, 2020 at 4:00 PM Zhang Qilong > > > > > > > > wrote: > > > > > > > > > > In many case, we need

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

2020-11-16 Thread Rafael J. Wysocki
erence leak. It has been discussed a lot[0][1]. So we add a function > to deal with the usage counter for better coding. > > [0]https://lkml.org/lkml/2020/6/14/88 > [1]https://patchwork.ozlabs.org/project/linux-tegra/list/?series=178139 > Signed-off-by: Zhang Qilong Acked-by: Rafael

Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-28 Thread Rafael J. Wysocki
On Thu, Jan 28, 2021 at 12:27 PM Calvin Johnson wrote: > > Hi Rafael, > > Thanks for the review. I'll work on all the comments. > > On Fri, Jan 22, 2021 at 08:22:21PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 4:43 PM Calvin Johnson > >

Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-28 Thread Rafael J. Wysocki
On Thu, Jan 28, 2021 at 2:12 PM Calvin Johnson wrote: > > On Thu, Jan 28, 2021 at 01:00:40PM +0100, Rafael J. Wysocki wrote: > > On Thu, Jan 28, 2021 at 12:27 PM Calvin Johnson > > wrote: > > > > > > Hi Rafael, > > > > > > Thanks for the rev

Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-29 Thread Rafael J. Wysocki
On Fri, Jan 29, 2021 at 7:48 AM Calvin Johnson wrote: > > On Thu, Jan 28, 2021 at 02:27:00PM +0100, Rafael J. Wysocki wrote: > > On Thu, Jan 28, 2021 at 2:12 PM Calvin Johnson > > wrote: > > > > > > On Thu, Jan 28, 2021 at 01:00:40PM +0100, Rafael J. Wysocki

Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-01-29 Thread Rafael J. Wysocki
On Fri, Jan 29, 2021 at 5:37 PM Rafael J. Wysocki wrote: > > On Fri, Jan 29, 2021 at 7:48 AM Calvin Johnson > wrote: > > > > On Thu, Jan 28, 2021 at 02:27:00PM +0100, Rafael J. Wysocki wrote: > > > On Thu, Jan 28, 2021 at 2:12 PM Calvin Johnson > > > wrot

Re: [PATCH 15/39] acpi/battery: simplify procfs code

2018-04-22 Thread Rafael J. Wysocki
It is OK AFAICS. Reviewed-by: Rafael J. Wysocki

Re: [PATCH 0/6] drivers: make device_attribute const

2017-08-21 Thread Rafael J. Wysocki
On Mon, Aug 21, 2017 at 1:43 PM, Bhumika Goyal wrote: > Make these const. Done using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct device_attribute s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > identifier match.s; > expr

Re: [PATCH RFC 3/5] sched/cpufreq: Fix incorrect RCU API usage

2019-02-21 Thread Rafael J. Wysocki
On Thursday, February 21, 2019 6:49:40 AM CET Joel Fernandes (Google) wrote: > Recently I added an RCU annotation check to rcu_assign_pointer(). All > pointers assigned to RCU protected data are to be annotated with __rcu > inorder to be able to use rcu_assign_pointer() similar to checks in > other

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Rafael J. Wysocki
On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > Hi Ard, > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > On Wed, 27 Feb 2019 at 11:02, Marc Zyngier wrote: > > > On 26/02/2019 23:28, Brian Norris wrote: > > > > You're not the first person to notice this. All the moti

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-28 Thread Rafael J. Wysocki
On Thu, Feb 28, 2019 at 3:29 AM Brian Norris wrote: > > Hi Rafael, > > On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris > > wrote: > > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: &g

Re: r8169 Wake-on-LAN causes immediate ACPI GPE wakeup

2017-10-05 Thread Rafael J. Wysocki
On Thu, Oct 5, 2017 at 10:57 AM, Daniel Drake wrote: > Hi, > > On the Acer laptop models Aspire ES1-533, Aspire ES1-732, PackardBell > ENTE69AP and Gateway NE533, we are seeing a problem where the system > immediately wakes up after being put into S3 suspend. > > This problem has been seen on all

Re: [PATCH v2 09/15] ACPI: configfs: make config_item_type const

2017-10-16 Thread Rafael J. Wysocki
; > > -static struct config_item_type acpi_root_group_type = { > +static const struct config_item_type acpi_root_group_type = { > .ct_owner = THIS_MODULE, > }; > > Acked-by: Rafael J. Wysocki

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Rafael J. Wysocki
> > const struct raid6_calls raid6_sse2x2 = { > raid6_sse22_gen_syndrome, > @@ -366,9 +366,9 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > kernel_fpu_end(); > } > > - static void raid6_sse24_xor_syndrome(int disks, int start, int stop, > +static void raid6_sse24_xor_syndrome(int disks, int start, int stop, >size_t bytes, void **ptrs) > - { > +{ > u8 **dptr = (u8 **)ptrs; > u8 *p, *q; > int d, z, z0; > @@ -471,7 +471,7 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > } > asm volatile("sfence" : : : "memory"); > kernel_fpu_end(); > - } > +} > > > const struct raid6_calls raid6_sse2x4 = { > diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c > index 0c11f434a374..ec619f51d336 100644 > --- a/sound/soc/fsl/fsl_dma.c > +++ b/sound/soc/fsl/fsl_dma.c > @@ -879,7 +879,7 @@ static const struct snd_pcm_ops fsl_dma_ops = { > }; > > static int fsl_soc_dma_probe(struct platform_device *pdev) > - { > +{ > struct dma_object *dma; > struct device_node *np = pdev->dev.of_node; > struct device_node *ssi_np; > > -- Acked-by: Rafael J. Wysocki for the ACPI part. Thanks!

Re: [RFC PATCH v12 0/5] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-12-26 Thread Rafael J. Wysocki
On Tuesday, December 26, 2017 3:36:41 AM CET Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v13: > Fix compiler error reported by kbuild test robot > >

Re: ACPI issues on cold power on [bisected]

2018-01-02 Thread Rafael J. Wysocki
On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim wrote: > On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDowell wrote: >> On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: >> > On Fri, Dec 08, 2017 at 03:11:59PM +, Jonathan McDowell wrote: >> > > I've been sitting on this for a whi

Re: [net-next: PATCH v2 1/5] device property: Introduce fwnode_get_mac_address()

2018-01-03 Thread Rafael J. Wysocki
dress(). This commit also changes > device_get_mac_address() routine to be its wrapper, in order > to prevent unnecessary duplication. > > Signed-off-by: Marcin Wojtas The changes look reasonable to me, so Acked-by: Rafael J. Wysocki > --- > drivers/base/property.c | 28 ++

Re: ACPI issues on cold power on [bisected]

2018-01-03 Thread Rafael J. Wysocki
On Wednesday, January 3, 2018 11:38:12 AM CET Jonathan McDowell wrote: > On Wed, Jan 03, 2018 at 11:11:29AM +0900, Joonsoo Kim wrote: > > On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > > > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim > > > wrote: &

Re: [net-next: PATCH v2 2/5] device property: Introduce fwnode_get_phy_mode()

2018-01-03 Thread Rafael J. Wysocki
_mode(). This commit also changes > device_get_phy_mode() routine to be its wrapper, in order > to prevent unnecessary duplication. > > Signed-off-by: Marcin Wojtas Acked-by: Rafael J. Wysocki > --- > drivers/base/property.c | 24 > include/linux/pro

Re: [net-next PATCH v7 1/6] Documentation: ACPI: DSD: Document MDIO PHY

2020-07-29 Thread Rafael J. Wysocki
Hi Andrew, On Tue, Jul 28, 2020 at 10:34 PM Andrew Lunn wrote: > > Hi Everybody > > So i think it is time to try to bring this discussion to some sort of > conclusion. > > No ACPI maintainer is willing to ACK any of these patches. Nor are > they willing to NACK them. Let's first clarify one thin

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-31 Thread Rafael J. Wysocki
On Fri, Jul 31, 2020 at 4:14 PM Boris Ostrovsky wrote: > > On 7/30/20 7:06 PM, Anchal Agarwal wrote: > > On Mon, Jul 27, 2020 at 06:08:29PM -0400, Boris Ostrovsky wrote: > >> CAUTION: This email originated from outside of the organization. Do not > >> click links or open attachments unless you ca

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-08-28 Thread Rafael J. Wysocki
On Fri, Aug 28, 2020 at 8:26 PM Anchal Agarwal wrote: > > On Fri, Aug 21, 2020 at 10:22:43PM +, Anchal Agarwal wrote: > > Hello, > > This series fixes PM hibernation for hvm guests running on xen hypervisor. > > The running guest could now be hibernated and resumed successfully at a > > later

Re: [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY

2020-09-30 Thread Rafael J. Wysocki
On Wed, Sep 30, 2020 at 6:05 PM Calvin Johnson wrote: > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > provide them to be connected to MAC. > > Describe properties "phy-handle" and "phy-mode". > > Signed-off-by: Calvin Johnson > --- > > Documentation/firmware-guide/acpi/ds

Re: [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY

2020-10-02 Thread Rafael J. Wysocki
On Fri, Oct 2, 2020 at 1:09 PM Grant Likely wrote: > > > > On 30/09/2020 17:37, Rafael J. Wysocki wrote: > > On Wed, Sep 30, 2020 at 6:05 PM Calvin Johnson > > wrote: > >> > >> Introduce ACPI mechanism to get PHYs registered on a MDIO bus an

Re: [RFC PATCH 1/3] acpi: Add acpi mdio support code

2018-11-07 Thread Rafael J. Wysocki
On Thursday, November 8, 2018 8:22:16 AM CET Wang Dongsheng wrote: > Add support for parsing the ACPI data node for PHY devices on an MDIO bus. > The current implementation depend on mdio bus scan. > With _DSD device properties we can finally do this: > > Device (MDIO) { > Name (_DSD,

Re: [RFC PATCH 1/3] acpi: Add acpi mdio support code

2018-11-08 Thread Rafael J. Wysocki
On Thursday, November 8, 2018 8:55:47 AM CET Wang, Dongsheng wrote: > On 2018/11/8 15:44, Rafael J. Wysocki wrote: > > On Thursday, November 8, 2018 8:22:16 AM CET Wang Dongsheng wrote: > >> Add support for parsing the ACPI data node for PHY devices on an MDIO bus. > >>

Re: [PATCH] Bluetooth: Allow suspend even when preparation has failed

2020-06-04 Thread Rafael J. Wysocki
On Wed, Jun 3, 2020 at 10:22 PM Abhishek Pandit-Subedi wrote: > > It is preferable to allow suspend even when Bluetooth has problems > preparing for sleep. When Bluetooth fails to finish preparing for > suspend, log the error and allow the suspend notifier to continue > instead. > > To also make i

Re: [PATCH 7/8] PM: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > This change builds on top of the previous commit 6da2f2

Re: [PATCH 2/8] ACPI: PM: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > Signed-off-by: Krzysztof Wilczyński > --- > drivers/a

Re: [PATCH 5/8] usb: phy: fsl: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > Signed-off-by: Krzysztof Wilczyński > --- > drivers/u

Re: [PATCH 2/8] ACPI: PM: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Tue, May 26, 2020 at 11:45 AM Pavel Machek wrote: > > On Tue 2020-05-26 10:37:36, Rafael J. Wysocki wrote: > > On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > > > > > Use the new device_to_pm() helper to access Power Management callbacs &

Re: [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Tue, May 26, 2020 at 5:07 PM Krzysztof Wilczyński wrote: > > Hello Greg, > > [...] > > It's "interesting" how using your new helper doesn't actually make the > > code smaller. Perhaps it isn't a good helper function? > > The idea for the helper was inspired by the comment Dan made to Bjorn > a

Re: [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-26 Thread Rafael J. Wysocki
On Tue, May 26, 2020 at 5:28 PM Alan Stern wrote: > > On Tue, May 26, 2020 at 05:19:07PM +0200, Rafael J. Wysocki wrote: > > On Tue, May 26, 2020 at 5:07 PM Krzysztof Wilczyński wrote: > > > > > > Hello Greg, > > > > > > [...] > > > > I

Re: [net-next PATCH v2 0/3] Introduce new APIs to support phylink and phy layers

2020-04-29 Thread Rafael J. Wysocki
On Wed, Apr 29, 2020 at 7:38 AM Calvin Johnson wrote: > > On Mon, Apr 27, 2020 at 03:48:07PM +0100, Russell King - ARM Linux admin > wrote: > > On Mon, Apr 27, 2020 at 08:02:38PM +0530, Calvin Johnson wrote: > > > On Mon, Apr 27, 2020 at 02:58:20PM +0100, Russell King - ARM Linux admin > > > wro

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-07-25 Thread Rafael J. Wysocki
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has already

Re: [PATCH 1/6] ACPI: make device_attribute const

2017-08-28 Thread Rafael J. Wysocki
On Monday, August 21, 2017 1:43:07 PM CEST Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the function > device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal > ---

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-09-02 Thread Rafael J. Wysocki
On Friday, September 1, 2017 1:29:43 AM CEST Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, so > switch to this in all callers. > > Cc: "Rafael J. Wysocki" >

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Rafael J. Wysocki
On 12/18/2017 10:17 AM, Marcin Wojtas wrote: Hi, This patchset introduces ACPI support in mvpp2 and mvmdio drivers. First three patches introduce fwnode helpers for obtaining PHY information from nodes and also MDIO fwnode API for registering the bus with its PHY/devices. Following patches upda

Re: [net-next: PATCH v4 3/7] device property: Introduce fwnode_irq_get()

2018-01-22 Thread Rafael J. Wysocki
On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Until now there were two very similar functions allowing > to get Linux IRQ number from ACPI handle (acpi_irq_get()) > and OF node (of_irq_get()). The first one appeared to be used > only as a subroutine of platform_irq_get(), which (in the g

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

2018-01-22 Thread Rafael J. Wysocki
dress(). This commit also changes > device_get_mac_address() routine to be its wrapper, in order > to prevent unnecessary duplication. > > Signed-off-by: Marcin Wojtas > Acked-by: Rafael J. Wysocki > --- > drivers/base/property.c | 28 ++-- > include/linux/property.h

Re: [net-next: PATCH v4 4/7] device property: Allow iterating over available child fwnodes

2018-01-22 Thread Rafael J. Wysocki
o introduces a macro, thanks to which it is > possible to iterate over the available fwnodes, using the > new function described above. > > Signed-off-by: Marcin Wojtas Acked-by: Rafael J. Wysocki > --- > drivers/base/property.c | 26 > include/linux/pro

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

2018-01-23 Thread Rafael J. Wysocki
On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas wrote: > Hi Rafael, > >> > if (res) >> > return res; >> > >> > - return device_get_mac_addr(dev, "address", addr, alen); >> > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); >> > +} >> > +EXPORT_SYMBOL(

Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-10-28 Thread Rafael J. Wysocki
On Friday, October 27, 2017 9:26:05 AM CEST Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v10: > Use device_set_wakeup_capable() instead of device_set_w

[RFC][PATCH] Add suspend and resume support to uli526x

2007-06-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Add suspend/resume support to the uli526x network driver (tested on x86_64, with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40'). Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> drivers/net/

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Rafael J. Wysocki
Hi, On Monday, 4 June 2007 13:11, Pavel Machek wrote: > Hi! > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Add suspend/resume support to the uli526x network driver (tested on x86_64, > > with 'Ethernet controller: ALi Corporati

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-04 Thread Rafael J. Wysocki
Hi, On Monday, 4 June 2007 23:16, Nigel Cunningham wrote: > Hi. > > On Mon, 2007-06-04 at 15:49 +0200, Rafael J. Wysocki wrote: > > On Monday, 4 June 2007 13:11, Pavel Machek wrote: > > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > >

Re: [RFC][PATCH] Add suspend and resume support to uli526x

2007-06-05 Thread Rafael J. Wysocki
On Tuesday, 5 June 2007 07:56, Stephen Hemminger wrote: > I hope soon to add suspend/resume to the network device class > and remove driver specific suspend/resume from lots of devices. > > The class suspend routine would just be: > pci_save_state > dev->stop > > resume is > pci

Re: 2.6.22-rc4 hibernate disables skge wol

2007-06-15 Thread Rafael J. Wysocki
On Friday, 15 June 2007 23:50, David Greaves wrote: > I've started a new thread here since the old one got somewhat hijacked. > > Rafael J. Wysocki wrote: > > On Friday, 1 June 2007 23:23, David Greaves wrote: > >> Not a regression though, it does it in 2.6.21 >

Re: [Bugme-new] [Bug 8678] New: Kernel OOPSes when suspend/resume

2007-06-26 Thread Rafael J. Wysocki
On Tuesday, 26 June 2007 19:42, CIJOML wrote: > Dne úterý 26 červen 2007 19:09 Andrew Morton napsal(a): > > On Tue, 26 Jun 2007 08:22:11 -0700 (PDT) [EMAIL PROTECTED] > wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8678 > > > > > >Summary: Kernel OOPSes when suspend/resume >

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
On Saturday 12 August 2006 15:39, Jeff Garzik wrote: > Andrew Morton wrote: > > It would be good if you could poke around in gdb, work out exactly which > > statement it's oopsing at, please. > > I'm also interested to know if the problem goes away when you disable > preempt... That will take so

2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
Hi, On 2.6.18-rc3-mm2 with hotfixes I get things like the appended one on attempts to suspend to disk. It occurs while devices are being suspended and is fairly reproducible. Greetings, Rafael Suspending device :01:00.0 Suspending device :02:02.0 Suspending device :02:01.4 Suspendi

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
On Saturday 12 August 2006 14:28, Andrew Morton wrote: > On Sat, 12 Aug 2006 12:07:42 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > On 2.6.18-rc3-mm2 with hotfixes I get things like the appended one on > > attempts >

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
On Saturday 12 August 2006 18:12, Edgar E. Iglesias wrote: > On Sat, Aug 12, 2006 at 04:31:18PM +0200, Rafael J. Wysocki wrote: > > On Saturday 12 August 2006 14:28, Andrew Morton wrote: > > > On Sat, 12 Aug 2006 12:07:42 +0200 > > > "Rafael J. Wysocki" <[EM

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
On Saturday 12 August 2006 16:32, Rafael J. Wysocki wrote: > On Saturday 12 August 2006 15:39, Jeff Garzik wrote: > > Andrew Morton wrote: > > > It would be good if you could poke around in gdb, work out exactly which > > > statement it's oopsing at, please. > &g

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-12 Thread Rafael J. Wysocki
On Saturday 12 August 2006 20:16, Edgar E. Iglesias wrote: > On Sat, Aug 12, 2006 at 07:13:01PM +0200, Rafael J. Wysocki wrote: > > Apparently it doesn't. > > Hi, could you try and see if this helps? With the patch I can't reproduce the problem. I sometimes get th

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-14 Thread Rafael J. Wysocki
On Monday 14 August 2006 22:06, Laurent Riffard wrote: > Le 14.08.2006 19:47, Laurent Riffard a écrit : > > Le 14.08.2006 18:50, Andrew Morton a écrit : > >> On Mon, 14 Aug 2006 16:38:47 +0200 > >> Laurent Riffard <[EMAIL PROTECTED]> wrote: > >> > >>> Le 13.08.2006 10:24, Andrew Morton a __crit : >

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-15 Thread Rafael J. Wysocki
On Tuesday 15 August 2006 01:01, Laurent Riffard wrote: > Le 14.08.2006 23:25, Rafael J. Wysocki a écrit : > > On Monday 14 August 2006 22:06, Laurent Riffard wrote: > >> Le 14.08.2006 19:47, Laurent Riffard a écrit : > >>> Le 14.08.2006 18:50, Andrew Morton a écrit :

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-15 Thread Rafael J. Wysocki
On Tuesday 15 August 2006 17:38, Laurent Riffard wrote: > > Le 15.08.2006 12:10, Rafael J. Wysocki a écrit : > > On Tuesday 15 August 2006 01:01, Laurent Riffard wrote: > >> Le 14.08.2006 23:25, Rafael J. Wysocki a écrit : > >>> On Monday 14 August 2006 22:06,

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Rafael J. Wysocki
On Tuesday, 13 of November 2007, Mark Lord wrote: > Matthew Wilcox wrote: > > On Tue, Nov 13, 2007 at 01:43:53PM -0500, Mark Lord wrote: > > > >> mkdir t > >> cd t > >> git clone > >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git > >> (wait half an hour) > >> /usr/bin/du -s

Re: 2.6.24-rc3: find complains about /proc/net

2007-11-19 Thread Rafael J. Wysocki
On Monday, 19 of November 2007, Pavel Machek wrote: > Hi! > > I think that this worked before: > > [EMAIL PROTECTED]:/proc# find . -name "timer_info" > find: WARNING: Hard link count is wrong for ./net: this may be a bug > in your filesystem driver. Automatically turning on find's -noleaf > opti

Re: 2.6.24-rc3: find complains about /proc/net

2007-11-20 Thread Rafael J. Wysocki
On Wednesday, 21 of November 2007, Roland McGrath wrote: > > can you see any danger to providing a /proc/self_task/ link? (or can you > > think of a better name/API/approach) > > That is a poor name to choose given /proc/self/task exists as something > else (just try writing a sentence comparing

Re: 2.6.24-rc1-gb4f5550 oops

2007-11-08 Thread Rafael J. Wysocki
On Thursday, 8 of November 2007, Grant Wilson wrote: > On Thu, 8 Nov 2007 01:06:21 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Monday, 5 of November 2007, Grant Wilson wrote: > > > Hi, > > > I got this oops on 2.6.24-rc1-641-gb

Re: 2.6.24-rc1-gb4f5550 oops

2007-11-08 Thread Rafael J. Wysocki
On Thursday, 8 of November 2007, Grant Wilson wrote: > On Thu, 8 Nov 2007 16:53:10 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Thursday, 8 of November 2007, Grant Wilson wrote: > > > On Thu, 8 Nov 2007 01:06:21 +0100 > > &

Re: 2.6.24-rc1-gb4f5550 oops

2007-11-08 Thread Rafael J. Wysocki
On Thursday, 8 of November 2007, Grant Wilson wrote: > On Thu, 8 Nov 2007 22:42:21 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Thursday, 8 of November 2007, Grant Wilson wrote: > > > On Thu, 8 Nov 2007 16:53:10 +0100 > > &

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Rafael J. Wysocki
On Friday, 14 of December 2007, Ray Lee wrote: > tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just > fine. A quick scan of the log between 2.6.24-rc3 and current tip > (-rc5) doesn't show any obvious fixes, but then again, what do I know. > I'll check current tip on the weekend when

Re: [BUG] lack of /proc/net/ax25 with 2.6.24-rc5

2007-12-17 Thread Rafael J. Wysocki
On Sunday, 16 of December 2007, Bernard Pidoux wrote: > With 2.6.24-rc5 there is no /proc/net/ax25 FYI, I've created a Bugzilla entry for this issue at: http://bugzilla.kernel.org/show_bug.cgi?id=9589 Please add your address to the CC list in there. Thanks, Rafael > Here is an extract from dme

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-08 Thread Rafael J. Wysocki
On Tuesday, 8 of January 2008, Linus Torvalds wrote: > > On Tue, 8 Jan 2008, Arjan van de Ven wrote: > > > > ok done; I had to fizzle a bit because some things aren't *exactly* a > > BUG() statement but I track them anyway (things like the "sleeping in > > invalid context" check), so I had to s

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread Rafael J. Wysocki
> http://bugzilla.kernel.org/show_bug.cgi?id=9721 On Friday, 11 of January 2008, supersud501 wrote: > > Stephen Hemminger wrote: > > On Wed, 9 Jan 2008 16:03:00 -0800 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > >> (switched to email. Please respond via emailed reply-to-all, not via the >

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-11 Thread Rafael J. Wysocki
On Friday, 11 of January 2008, supersud501 wrote: > > Rafael J. Wysocki wrote: > >> http://bugzilla.kernel.org/show_bug.cgi?id=9721 > allright, didn't see that before, sorry, here are the results: > > kernel 2.6.23.12 acpi=off: when shutting down the system doesn&#

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-12 Thread Rafael J. Wysocki
> http://bugzilla.kernel.org/show_bug.cgi?id=9721 On Saturday, 12 of January 2008, supersud501 wrote: > I'll do the git-bisect (just downloading linux-2.6.git), but i forgot to > mention one little thing: i'm using x64 version of kernel - does this > play an important role? No, it doesn't. --

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Rafael J. Wysocki
On Sunday, 13 of January 2008, Andrew Morton wrote: > > 2.6.23 also has this warning in sky2_err_intr() but it doesn't trigger > there. Rafael, I think we'd have to class this as a post-2.6.23 > regression. Yes, it's been being tracked already. -- To unsubscribe from this list: send the line "un

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Rafael J. Wysocki
I wonder if commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac "sky2: remove check for PCI wakeup setting from BIOS" has anything to do with it, btw. supersud501, can you please check if the bug is still present in the current Linus' tree? -- To unsubscribe from this list: send the line "unsubscribe

Re: [V4 PATCH 1/6] ACPI / scan: Parse _CCA and setup device coherency

2015-05-18 Thread Rafael J. Wysocki
On Monday, May 18, 2015 05:38:17 PM Suravee Suthikulanit wrote: > Hi Rafael, > > On 5/15/2015 6:53 PM, Rafael J. Wysocki wrote: > > On Friday, May 15, 2015 04:23:09 PM Suravee Suthikulpanit wrote: > >> [...] > >> diff --git a/drivers/acpi/acpi_platform.c b/driver

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
ct acpi_device > *acpi_dev) > if (!has_acpi_companion(dev)) > ACPI_COMPANION_SET(dev, acpi_dev); > > + if (acpi_check_dma(acpi_dev, &coherent)) > + arch_setup_dma_ops(dev, 0, 0, NULL, coherent); > + Well, so is this going to work fo

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: > Not sure if this went out earlier. So I am resending. > > On 5/22/15 16:56, Rafael J. Wysocki wrote: > >> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c > >> >index 39c485b..b9657af 100644 &

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 07:15:17 PM Suravee Suthikulanit wrote: > On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: > > On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: > >> Not sure if this went out earlier. So I am resending. > >> > >> On 5/

Re: [PATCH v4 net-next 00/13] net: hns: add support of ACPI

2016-06-03 Thread Rafael J. Wysocki
On Friday, June 03, 2016 10:55:08 AM Yisen Zhuang wrote: > From: Kejian Yan > > This series adds HNS support of acpi. The routine will call some ACPI > helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which > are not included in other cases. In order to make system compile > succe

  1   2   >