Re: [PATCH net] tcp: select sane initial rcvq_space.space for big MSS

2020-12-10 Thread Mohamed Abuelfotoh, Hazem
Hi Eric, I don't see the patch in the stable queue. Can we add it to stable so we can cherry pick it in Amazon Linux kernel? Thank you. Hazem On 09/12/2020, 00:29, "David Miller" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attach

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-07 Thread Mohamed Abuelfotoh, Hazem
the sender side? Thank you. Hazem On 07/12/2020, 15:26, "Eric Dumazet" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Sat, Dec 5, 2020 at

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-07 Thread Mohamed Abuelfotoh, Hazem
nfirm the sender and know the content is safe. On Mon, Dec 7, 2020 at 5:09 PM Mohamed Abuelfotoh, Hazem wrote: > > >Since I can not reproduce this problem with another NIC on x86, I > >really wonder if this is not an issue with ENA driver on PowerPC &

Re: [PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS

2020-12-07 Thread Mohamed Abuelfotoh, Hazem
> I find using icsk->icsk_ack.rcv_mss misleading. > I would either use TCP_MSS_DEFAULT , or maybe simply 0, since we had > no samples yet, there is little point to use a magic value. My point is by definition rcv_space is used in TCP's internal auto-tuning to grow socket buffers bas

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-07 Thread Mohamed Abuelfotoh, Hazem
:45, "Greg KH" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Dec 07, 2020 at 04:34:57PM +, Mohamed Abuelfotoh, Hazem wrote: > 100ms RTT

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-07 Thread Mohamed Abuelfotoh, Hazem
n Mon, Dec 7, 2020 at 5:34 PM Neal Cardwell wrote: > > On Mon, Dec 7, 2020 at 11:23 AM Eric Dumazet wrote: > > > > On Mon, Dec 7, 2020 at 5:09 PM Mohamed Abuelfotoh, Hazem > > wrote: > > > > > > >Since I

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-08 Thread Mohamed Abuelfotoh, Hazem
al work. Thank you. Hazem On 07/12/2020, 17:28, "Eric Dumazet" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Dec 7, 2020 at 6:1

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

2020-12-08 Thread Mohamed Abuelfotoh, Hazem
Feel free to ignore this message as I sent it before seeing your newly submitted patch ( Thank you. Hazem On 08/12/2020, 16:28, "Mohamed Abuelfotoh, Hazem" wrote: >Please try again, with a fixed tcp_rmem[1] on receiver, taking into >account bigger memory