[PATCH] net: lantiq_etop: check the result of request_irq()

quest_irq', declared with attribute warn_unused_result [-Wunused-result]   281 |    request_irq(irq, ltq_etop_dma_irq, 0, "etop_rx", priv);       |    ^~~~~~ Reported-by: Miguel Ojeda Signed-off-by: Masahiro Yamada --- drivers/net

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

me warnings. Tomorrow's linux-next should be OK and, you can send my patch in this merge window. -- Best Regards Masahiro Yamada

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > The declaration of request_irq() in is marked as > > __must_check. > > > > Without the return value check, I see the following warnings

[PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

ger needed. I see a lot of defconfig (arch/*/configs/*_defconfig) files having: # CONFIG_ENABLE_MUST_CHECK is not set I did not touch them for now since it would be a big churn. If arch maintainers want to clean them up, please go ahead. Signed-off-by: Masahiro Yamada --- inc

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > > > Our goal is to always enable __must_check where appreciate, so this > > CONFIG option is no longer needed. > > This would be great. It also

[PATCH v2] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

t_check to compiler_attributes.h from compiler_types.h Signed-off-by: Masahiro Yamada --- Changes in v2: - Move __must_check to compiler_attributes.h include/linux/compiler_attributes.h | 7 +++ include/linux/compiler_types.h | 6 -- lib/Kco

[PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

t_check to compiler_attributes.h from compiler_types.h Signed-off-by: Masahiro Yamada Acked-by: Jason A. Donenfeld --- Changes in v3: - Fix a typo Changes in v2: - Move __must_check to compiler_attributes.h include/linux/compiler_attributes.h | 7 +++ include/linux/compil

Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

FOO = y'. For example, choice prompt "Default" config DEFAULT_FOO bool "Use foo for default" depends on FOO = y config DEFAULT_BAR bool "Use bar for default" depends on BAR = y config DEFAULT_FALLBACK bool "fallback when nothing else is builtin" endchoice -- Best Regards Masahiro Yamada

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

ole-version.sh b/scripts/pahole-version.sh > new file mode 100755 > index ..6de6f734a345 > --- /dev/null > +++ b/scripts/pahole-version.sh > @@ -0,0 +1,16 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Usage: $ ./scripts/pahole-version.sh pahole > +# > +# Print the pahole version as a three digit string > +# such as `119' for pahole v1.19 etc. > + > +pahole="$*" > + > +if ! [ -x "$(command -v $pahole)" ]; then > +echo 0 > +exit 1 > +fi > + > +$pahole --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/' > > base-commit: e22d7f05e445165e58feddb4e40cc9c0f94453bc > -- > 2.30.0 > -- Best Regards Masahiro Yamada

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor wrote: > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > > wrote: > > > > > > After commit da5fb18225b4 ("bpf: Support pre-2.

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

> I expected this kind of mess when I saw 33a57ce0a54d498275f432db04850001175dfdfa The tools/ directory is a completely different world governed by a different build system (no, not a build system, but a collection of adhoc makefile code) All the other programs used during the kernel build are located under scripts/, and can be built with a simple syntax, and cleaned up correctly. It is simple, clean and robust. objtool is the first alien that opt out Kbuild, and this is the second one. It is scary to mix up two different things, which run in different working directories. See, this is wired up in the top Makefile in an ugly way, and you are struggling in suppressing issues, where you can never do it in the right way. -- Best Regards Masahiro Yamada

[PATCH 2/2] tools: do not include scripts/Kbuild.include

66d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada --- tools/testing/selftests/bpf/Makefile | 3 ++- tools/testing/se

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

On Thu, Apr 15, 2021 at 4:40 PM Paolo Bonzini wrote: > > On 15/04/21 09:27, Masahiro Yamada wrote: > > Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to > > scripts/Makefile.compiler"), some kselftests fail to build. > > > > The tools/ d

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

On Fri, Apr 16, 2021 at 2:56 PM Christian Borntraeger wrote: > > > On 15.04.21 10:06, Christian Borntraeger wrote: > > > > On 15.04.21 09:27, Masahiro Yamada wrote: > >> Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to > >> scripts/

[PATCH v2] tools: do not include scripts/Kbuild.include

f7-a5ac-cb8c-64966d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada --- Changes in v2: - copy macros to tools/bu

Re: [PATCH v2] tools: do not include scripts/Kbuild.include

On Fri, Apr 16, 2021 at 10:01 PM Masahiro Yamada wrote: > > Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to > scripts/Makefile.compiler"), some kselftests fail to build. > > The tools/ directory opted out Kbuild, and went in a different > direction.

[PATCH] net: sysctl: remove redundant #ifdef CONFIG_NET

CONFIG_NET is a bool option, and this file is compiled only when CONFIG_NET=y. Remove #ifdef CONFIG_NET, which we know it is always met. Signed-off-by: Masahiro Yamada --- net/core/sysctl_net_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/sysctl_net_core.c b/net/core

[PATCH 4/4] net: l3mdev: use obj-$(CONFIG_NET_L3_MASTER_DEV) form in net/Makefile

CONFIG_NET_L3_MASTER_DEV is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_NET_L3_MASTER_DEV) form. Use obj-y in net/l3mdev/Makefile because Kbuild visits this Makefile only when CONFIG_NET_L3_MASTER_DEV=y. Signed-off-by: Masahiro Yamada --- net/Makefile| 4

[PATCH 1/4] net: move CONFIG_NET guard to top Makefile

Signed-off-by: Masahiro Yamada --- Makefile | 3 ++- net/Makefile | 11 --- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index b0e4767735dc..61357f7eb55f 100644 --- a/Makefile +++ b/Makefile @@ -649,7 +649,8 @@ ifeq ($(KBUILD_EXTMOD)

[PATCH 2/4] net: dcb: use obj-$(CONFIG_DCB) form in net/Makefile

CONFIG_DCB is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_DCB) form. Use obj-y in net/dcb/Makefile because Kbuild visits this Makefile only when CONFIG_DCB=y. Signed-off-by: Masahiro Yamada --- net/Makefile | 4 +--- net/dcb/Makefile | 2 +- 2 files changed, 2

[PATCH 3/4] net: switchdev: use obj-$(CONFIG_NET_SWITCHDEV) form in net/Makefile

CONFIG_NET_SWITCHDEV is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_NET_SWITCHDEV) form. Use obj-y in net/switchdev/Makefile because Kbuild visits this Makefile only when CONFIG_NET_SWITCHDEV=y. Signed-off-by: Masahiro Yamada --- net/Makefile | 4

[PATCH] net: remove redundant 'depends on NET'

These Kconfig files are included from net/Kconfig, inside the if NET ... endif. Remove 'depends on NET', which we know it is already met. Signed-off-by: Masahiro Yamada --- net/9p/Kconfig | 1 - net/batman-adv/Kconfig | 1 - net/bluetooth/Kconfig | 2 +- ne

Re: of_mdio: Checking build dependencies

en, I checked out 14b26b127c098bba and rebuilt. I did not see such an error. I also checked the Kbuild code, and it looks good too. Please let me know if you find steps to reproduce it. -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

OBJCOPY arch/x86/boot/vmlinux.bin AS arch/x86/boot/header.o LD arch/x86/boot/setup.elf OBJCOPY arch/x86/boot/setup.bin BUILD arch/x86/boot/bzImage Setup is 15612 bytes (padded to 15872 bytes). System is 12673 kB CRC 697aaf88 Kernel: arch/x86/boot/bzImage is ready (#6) real 0m53.024s user 0m32.076s sys 0m9.296s Also, I notice $(ARCH) must be fixed to $(SRCARCH), but that is one of minor issues. We should take time for careful review and test. Please give me more time for thorough review. -- Best Regards Masahiro Yamada

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

On Tue, Feb 19, 2019 at 1:14 PM Masahiro Yamada wrote: > > On Fri, Feb 15, 2019 at 11:48 PM Alexei Starovoitov > wrote: > > > > On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote: > > > Introduce in-kernel headers and other artifacts which

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

s/dtc/include-prefixes/powerpc: No such file or directory. Can't do inplace edit: kernel/kheaders_data.txz.tmp/scripts/dtc/include-prefixes/dt-bindings is not a regular file. [ massive amount of error messages continues ] > I can't think any other ways at the moment to break the circular dependency > so I'm thinking this is good enough for now especially since Kbuild will > print a proper warning. Let me know what you think? > > thanks, > > - Joel > -- Best Regards Masahiro Yamada

Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh

On Thu, Feb 21, 2019 at 11:46 PM Guenter Roeck wrote: > > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > > Currently, the header search paths -Itools/include and > > -Itools/include/uapi are not used. Let's drop the unused code. > > > > We ca

[PATCH] bpfilter: re-add header search paths to tools include to fix build error

bpfilter: fix a build err"). Apology for the breakage, and thanks to Guenter for reporting this. Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh") Reported-by: Guenter Roeck Signed-off-by: Masahiro Yamada --- Guenter, Sorry for bothering you,

Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error

On Fri, Feb 22, 2019 at 2:55 PM Guenter Roeck wrote: > > On 2/21/19 7:23 PM, Masahiro Yamada wrote: > > I thought header search paths to tools/include(/uapi) were unneeded, > > but it looks like a build error occurs depending on the compiler. > > > > Commit 303a339

Re: [PATCH v2] samples: guard sub-directories with CONFIG options

On Thu, May 9, 2019 at 10:01 AM Masahiro Yamada wrote: > > Do not descend to sub-directories when unneeded. > > I used subdir-$(CONFIG_...) for hidraw, seccomp, and vfs because > they only contain host programs. > > While we are here, let's add SPDX License tag

[PATCH 10/12] net/mlx4: replace with

ssing where radix tree accessors are used. Signed-off-by: Masahiro Yamada --- drivers/net/ethernet/mellanox/mlx4/cq.c | 1 + drivers/net/ethernet/mellanox/mlx4/mlx4.h | 2 +- drivers/net/ethernet/mellanox/mlx4/qp.c | 1 + drivers/net/ethernet/mellanox/mlx4/srq.c | 1 + include/linux/mlx4/dev

[PATCH 00/12] radix-tree: split out struct radix_tree_root out to

the series. Perhaps, the first two for v4.15. Then, rest of series will be sent per-subsystem for v4.16? Or, can somebody take care of the whole series? I checked allmodconfig for x86 and arm64. I am expecting 0 day testing will check it too. Masahiro Yamada (12): radix-tree: replace wit

[PATCH 11/12] net/mlx5: replace with

. Signed-off-by: Masahiro Yamada --- include/linux/mlx5/driver.h | 2 +- include/linux/mlx5/qp.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h index 401c897..0aea568 100644 --- a/include/linux/mlx5/driver.h

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 2:00 GMT+09:00 David Miller : > From: Masahiro Yamada > Date: Mon, 9 Oct 2017 01:10:11 +0900 > >> The headers >> - include/linux/mlx4/device.h >> - drivers/net/ethernet/mellanox/mlx4/mlx4.h >> require the definition of struct radix_tree_root, bu

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 2:32 GMT+09:00 Joe Perches : > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. > We should use a

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: >> 2017-10-09 2:00 GMT+09:00 David Miller : >> > From: Masahiro Yamada >> > Date: Mon, 9 Oct 2017 01:10:11 +0900 >> > >> >>

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > <...> >> >> By splitting out the radix_tree_root definition, >> we can reduce the header file dependency. >> >> Reducing the header

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-09 2:32 GMT+09:00 Joe Perches : > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. > BTW, talking about

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-10 21:18 GMT+09:00 Matthew Wilcox : > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: >> Reducing the header dependency will help for speeding the kernel >> build, suppressing unnecessary recompile of objects during >> git-bisect'ing, etc. >

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

gmii"; > + phy-handle = <ðphy>; > + local-mac-address = [00 00 00 00 00 00]; > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; > + }; > -- > 2.7.4 > -- Best Regards Masahiro Yamada

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; > + }; > -- > 2.7.4 > I found the following code in 2/2. + /* get clock */ + priv->clk = clk_get(dev, NULL); + if (IS_ERR(priv->clk)) + priv->clk = NULL; + + /* get reset */ + priv->rst = reset_control_get(dev, NULL); + if (IS_ERR(priv->rst)) + priv->rst = NULL; + This doc needs to describe "clocks", "resets". -- Best Regards Masahiro Yamada

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

ove. > + priv->rst = reset_control_get(dev, NULL); > + if (IS_ERR(priv->rst)) > + priv->rst = NULL; reset_control_get() is deprecated. Do not use it in a new driver. Again, missing reset_control_put(). devm? The reset seems optional (again, ignoring EPROBE_DEFER) but you did not use reset_control_get_optional, why? >From your code, this reset is used as shared. priv->rst = devm_reset_control_get_optional_shared(dev, NULL); if (IS_ERR(priv->rst)) return PTR_ERR(priv->rst); -- Best Regards Masahiro Yamada

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

) $< $(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) ;\ > + $(CONFIG_SHELL) $< ; \ > $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true) > > vmlinux: scripts/link-vmlinux.sh vmlinux_prereq $(vmlinux-deps) FORCE -- Best Regards Masahiro Yamada

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

2018-04-06 3:59 GMT+09:00 Jiri Olsa : > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa : >> > There's no need to pass LD* arguments to link-vmlinux.sh, >> > because they are passed as variables. The only a

Re: [PATCH net-next v8 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

#address-cells = <1>; > + #size-cells = <0>; > + ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; Andrew Lunn suggested to put a blank line before the "mdio" subnode in v7: https://patchwork.kernel.org/patch/10127461/ Does it apply to the "ethphy" subnode, too? Looks like you have a chance for v9. Please consider it. -- Best Regards Masahiro Yamada

[PATCH 2/2] build_bug.h: remove BUILD_BUG_ON_NULL()

This macro is only used by net/ipv6/mcast.c, but there is no reason why it must be BUILD_BUG_ON_NULL(). Replace it with BUILD_BUG_ON_ZERO(), and remove BUILD_BUG_ON_NULL() definition from . Signed-off-by: Masahiro Yamada --- include/linux/build_bug.h | 2 -- net/ipv6/mcast.c | 8

[PATCH 0/2] Consolidate BUILD_BUG macros

Masahiro Yamada (2): genl_magic: remove own BUILD_BUG_ON*() defines build_bug.h: remove BUILD_BUG_ON_NULL() include/linux/build_bug.h | 2 -- include/linux/genl_magic_func.h | 12 +--- net/ipv6/mcast.c| 8 3 files changed, 5 insertions(+), 17

BPFilter: bit size mismatch between bpfiter_umh and vmliux

Regards Masahiro Yamada

Re: [PATCH 00/16] kbuild: support 'userprogs' syntax

Hi Sam, On Sat, Apr 25, 2020 at 8:53 PM Sam Ravnborg wrote: > > Hi Masahiro > > On Thu, Apr 23, 2020 at 04:39:13PM +0900, Masahiro Yamada wrote: > > > > Several Makefiles use 'hostprogs' for building the code for > > the host architecture is not appropri

Re: [PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

ging fruits, or ones with higher priority as Arnd mentions about -Wmissing-{declaration,prototypes}. For example, you might be able to set 'subdir-ccflags-y += -Wmissing-declarations' to drivers/net/Makefile, while 'subdir-ccflags-y += -Wunused-but-set-variable' stays in drivers/net/ethernet/Makefile. -- Best Regards Masahiro Yamada

Re: [PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

cpu, struct task_struct *stop) | ^~~ Do we need to specify both in W=1 ? If yes, what is the difference between them? -- Best Regards Masahiro Yamada

Re: [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem

3 ++--- > 4 files changed, 27 insertions(+), 15 deletions(-) > > -- > 2.28.0 > -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: explicitly specify the build id style

el/vdso/Makefile | 2 +- > arch/s390/kernel/vdso64/Makefile | 2 +- > arch/sparc/vdso/Makefile | 2 +- > arch/x86/entry/vdso/Makefile | 2 +- > tools/testing/selftests/bpf/Makefile | 2 +- > 10 files changed, 11 insertions(+), 11 deletions(-) Applied to linux-kbuild. Thanks. -- Best Regards Masahiro Yamada

[PATCH] net: lmc: remove -I. header search path

The header search path -I. in kernel Makefiles is very suspicious; it allows the compiler to search for headers in the top of $(srctree), where obviously no header file exists. I was able to build without this header search path. Signed-off-by: Masahiro Yamada --- drivers/net/wan/lmc/Makefile

[PATCH] net: wireless: prefix header search paths with $(srctree)/

without it. [1]: https://patchwork.kernel.org/patch/9632347/ Signed-off-by: Masahiro Yamada --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 ++-- drivers/net/wireless/broadcom/brcm80211/brcmsmac/Makefile | 6 +++--- drivers/net/wireless/broadcom/brcm80211/brcmutil/Ma

[PATCH] bpfilter: remove extra header search paths for bpfilter_umh

Currently, the header search paths -Itools/include and -Itools/include/uapi are not used. Let's drop the unused code. We can remove -I. too by fixing up one C file. Signed-off-by: Masahiro Yamada --- Perhaps, are these extra header search paths for more upstreaming in the future? If

Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh

On Sat, Feb 2, 2019 at 9:00 AM Alexei Starovoitov wrote: > > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > > Currently, the header search paths -Itools/include and > > -Itools/include/uapi are not used. Let's drop the unused code. > > > >

[PATCH 1/3] treewide: remove explicit rules for *offsets.s

These explicit rules are unneeded because scripts/Makefile.build provides a pattern rule to create %.s from %.c Signed-off-by: Masahiro Yamada --- Kbuild | 9 + arch/arm/mach-at91/Makefile | 3 --- arch/arm/mach-omap2/Makefile| 3 --- arch

[PATCH 2/3] treewide: add intermediate .s files to targets

Avoid unneeded recreation of these in the incremental build. Signed-off-by: Masahiro Yamada --- arch/arm/mach-at91/Makefile | 2 ++ arch/arm/mach-omap2/Makefile| 2 ++ arch/ia64/kernel/Makefile | 2 ++ arch/x86/um/Makefile| 1 + drivers/memory

Re: [PATCH 1/3] treewide: remove explicit rules for *offsets.s

On Sun, Dec 23, 2018 at 7:32 PM Masahiro Yamada wrote: > > These explicit rules are unneeded because scripts/Makefile.build > provides a pattern rule to create %.s from %.c > > Signed-off-by: Masahiro Yamada > --- Series, applied to linux-kbuild. > Kbuild

[PATCH] bpf: promote bpf_perf_event.h to mandatory UAPI header

Since commit c895f6f703ad ("bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type"), all architectures (except um) are required to have bpf_perf_event.h in uapi/asm. Add it to mandatory-y so "make headers_install" can check it. Signed-off-by: Masahiro Yamada --

[PATCH 0/2] x86: turn off wrongly enabled CONFIG_GENERIC_HWEIGHT

/hweight.c at all. The real implementation is located in arch/x86/lib/hweight.S Masahiro Yamada (2): wireless: mt76: call hweight8() instead of __sw_hweight8() x86: disable CONFIG_GENERIC_HWEIGHT and remove __HAVE_ARCH_SW_HWEIGHT arch/x86/Kconfig | 3 --- arch/x86

[PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8()

__sw_hweight8() is just internal implementation. Drivers should use the common API, hweight8(). Signed-off-by: Masahiro Yamada --- This patch should go to x86 tree along with 2/2. Otherwise, all{yes,mod}config of x86 would be broken. This patch is trivial enough. I want ACK from the net

[PATCH] net: hamradio: remove unused hweight*() defines

This file does not use hweight*() at all, and the definition is surrounded by #if 0 ... #endif. Signed-off-by: Masahiro Yamada --- drivers/net/hamradio/baycom_ser_fdx.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/net/hamradio/baycom_ser_fdx.c b

Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8()

On Tue, Feb 19, 2019 at 4:38 AM Kalle Valo wrote: > > Kalle Valo writes: > > > Kalle Valo writes: > > > >> Masahiro Yamada writes: > >> > >>> __sw_hweight8() is just internal implementation. > >>> > >>> Drivers should

Re: [PATCH 2/2] kbuild: remove all dummy assignments to obj-

2017-11-08 1:31 GMT+09:00 Masahiro Yamada : > Now kbuild core scripts create empty built-in.o where necessary. > Remove "obj- := dummy.o" tricks. > > Signed-off-by: Masahiro Yamada > --- > Applied to linux-kbuild/kbuild. -- Best Regards Masahiro Yamada

Re: [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh

Hi Michal, Alexei, On Mon, Jun 8, 2020 at 8:56 PM Michal Kubecek wrote: > > On Thu, Apr 23, 2020 at 04:39:17PM +0900, Masahiro Yamada wrote: > > The user mode helper should be compiled for the same architecture as > > the kernel. > > > > This Makefile reuses the &#

Re: linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

ipts/Makefile.host:112: net/bpfilter/bpfilter_umh] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [scripts/Makefile.build:488: net/bpfilter] Error 2 make: *** [Makefile:1722: net] Error 2 > > commit 0592c3c367c4c823f2a939968e72d39360fce1f4 > Author: Masahiro Yamada

[PATCH] bpfilter: check if $(CC) can static link in Kconfig

: cannot find -lc collect2: error: ld returned 1 exit status Add CONFIG_CC_CAN_LINK_STATIC, and make CONFIG_BPFILTER_UMH depend on it. Reported-by: Valdis Kletnieks Signed-off-by: Masahiro Yamada --- I will insert this after https://patchwork.kernel.org/patch/11515997/ init/Kconfig | 5

Re: [PATCH] bpfilter: document build requirements for bpfilter_umh

o_execv won't be able to find the elf interpreter. > endif > -- Best Regards Masahiro Yamada

Re: [PATCH] bpfilter: check if $(CC) can static link in Kconfig

On Sun, May 10, 2020 at 10:04 AM Alexei Starovoitov wrote: > > On Sat, May 9, 2020 at 12:40 AM Masahiro Yamada wrote: > > > > On Fedora, linking static libraries requires the glibc-static RPM > > package, which is not part of the glibc-devel package. > > > > C

Re: [PATCH] net: can: remove "WITH Linux-syscall-note" from SPDX tag of C files

On Fri, Apr 3, 2020 at 11:35 PM Oliver Hartkopp wrote: > > > > On 03/04/2020 09.37, Masahiro Yamada wrote: > > The "WITH Linux-syscall-note" exception is intended for UAPI headers. > > > > See LICENSES/exceptions/Linux-syscall-note > > > >

Re: [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh

On Mon, Jun 8, 2020 at 8:56 PM Michal Kubecek wrote: > > On Thu, Apr 23, 2020 at 04:39:17PM +0900, Masahiro Yamada wrote: > > The user mode helper should be compiled for the same architecture as > > the kernel. > > > > This Makefile reuses the 'hostprogs&#

Re: BPFilter: bit size mismatch between bpfiter_umh and vmliux

o. Thanks for the comments. This issue will be fixed by this: https://patchwork.kernel.org/patch/11515997/ and the Makefile will be cleaned up by this: https://patchwork.kernel.org/patch/11515995/ They are parts of the big series of Makefile cleanups. So, I will apply the whole to kbuild tree. Thanks. -- Best Regards Masahiro Yamada

[PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

th a good way to describe it. Fixes: 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build bpfilter_umh") Reported-by: Michal Kubecek Signed-off-by: Masahiro Yamada --- net/bpfilter/Kconfig | 10 ++ net/bpfilter/Makefile | 2 ++ 2 files changed, 8 insertions(+), 4

Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

On Thu, Jul 2, 2020 at 2:46 AM Alexei Starovoitov wrote: > > On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote: > > Originally, bpfilter_umh was linked with -static only when > > CONFIG_BPFILTER_UMH=y. > > > > Commit 8a2cc0505cc4 ("bpfilt

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

Please install kernel headers locally (make headers_install). error: unable to create target: 'No available targets are compatible with triple "bpf"' 1 error generated. readelf: Error: './llvm_btf_verify.o': No such file *** ERROR: LLVM (llc) does not support 'bpf' target NOTICE: LLVM version >= 3.7.1 required -- Best Regards Masahiro Yamada

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

On Tue, Oct 1, 2019 at 11:16 PM Björn Töpel wrote: > > On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada > wrote: > > > > Hi Bjorn > > > > On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel wrote: > > > > [...] > > > subdir-$(CONFIG_SAMPLE_VF

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel wrote: > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk > wrote: > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada > > > wrote: > > >&g

[PATCH 0/2] kbuild: remove all "obj- := dummy.o" tricks

/patch/10041881/ I CCed DT forks to informs them of conflicts with those patches Rob Herring offered to apply. I doubt if he wants to review this series... Masahiro Yamada (2): kbuild: create built-in.o automatically if parent directory wants it kbuild: remove all dummy assignments to obj

[PATCH 2/2] kbuild: remove all dummy assignments to obj-

Now kbuild core scripts create empty built-in.o where necessary. Remove "obj- := dummy.o" tricks. Signed-off-by: Masahiro Yamada --- arch/arm/mach-uniphier/Makefile | 1 - arch/mips/boot/dts/brcm/Makefile | 3 --- arch/mips/boot/dts/cavium-octeon/Makefile | 3 ---

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

cast to restricted __le16 drivers/net/ethernet/socionext/sni_ave.c:1398:15: warning: cast to restricted __le32 drivers/net/ethernet/socionext/sni_ave.c:1400:20: warning: cast to restricted __le16 -- Best Regards Masahiro Yamada

Re: [PATCH] kbuild: make Makefile|Kbuild in each directory optional

If the save-* variables changed error out > ifeq ($(KBUILD_NOPEDANTIC),) > -- > 2.15.1 > -- Best Regards Masahiro Yamada

Re: [PATCH 01/10] net/sched: kconfig: Remove empty help texts

gnusson > > Applied. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I had applied the whole series into linux-kbui

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

l in the driver. > Referring to your suggested method, I'll fix the part of clk and reset. > Why is clk optional? -- Best Regards Masahiro Yamada

Re: [PATCH net-next v3 2/2] net: ethernet: socionext: add AVE ethernet driver

atic dma_addr_t ave_dma_map(struct net_device *ndev, struct ave_desc *desc, > + void *ptr, size_t len, > + enum dma_data_direction dir) > +{ > + dma_addr_t paddr; > + > + paddr = dma_map_single(ndev->dev.parent, ptr, len, dir); > + if (unlikely(dma_mapping_error(ndev->dev.parent, paddr))) { > + paddr = (dma_addr_t)-ENOMEM; Yuk! Re-write the code. > + } else { > + desc->skbs_dma = paddr; > + desc->skbs_dmalen = len; > + } > + > + return paddr; > +} -- Best Regards Masahiro Yamada

[PATCH] ath10k: replace config_enabled() with IS_REACHABLE()

ut I guess IS_REACHABLE() is the best fit for this case because both CONFIG_HWMON and CONFIG_ATH10K are tristate. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/d

[PATCH 0/3] ath10k: a little bit clean-up of ATH10K driver

leaving it to other developers. Masahiro Yamada (3): ath10k: use devm_clk_get() instead of clk_get() ath10k: use devm_reset_control_get() instead of reset_control_get() ath10k: do not check if reset is NULL drivers/net/wireless/ath/ath10k/ahb.c | 105 +++--- 1

[PATCH 1/3] ath10k: use devm_clk_get() instead of clk_get()

Use the managed variant of clk_get() to simplify the failure path and the .remove callback. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/ath

[PATCH 3/3] ath10k: do not check if reset is NULL

Since reset_control_get() never returns NULL, we can use IS_ERR() instead of IS_ERR_OR_NULL(). The return statements can be simpler as well. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions

[PATCH 2/3] ath10k: use devm_reset_control_get() instead of reset_control_get()

Use the managed variant of reset_control_get() to simplify the failure path and the .remove callback. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/ath/ath10k/ahb.c | 56 +++ 1 file changed, 10 insertions(+), 46 deletions(-) diff --git a/drivers/net

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

> + imply BAZ > + > + config BAZ > + tristate > + depends on BAr s/BAr/BAR/ ? -- Best Regards Masahiro Yamada