Re: [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values

2021-01-23 Thread Mark Wielaard
Hi Jiri, On Sat, 2021-01-23 at 19:51 +0100, Jiri Olsa wrote: > On Fri, Jan 22, 2021 at 02:55:51PM -0800, Andrii Nakryiko wrote: > > > > > I don't understand this.. gelf_getsymshndx will return both > > > symbol and proper index, no? also sym_sec_idx is already > > > assigned from previou call >

Re: [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values

2021-01-23 Thread Mark Wielaard
Hi, On Sat, 2021-01-23 at 12:07 -0800, Andrii Nakryiko wrote: > > the latest upstream code seems to set it always, > > but I agree we should be careful > > oh, then maybe it's not necessary. I honestly don't even know where > the authoritative source code of libelf is, so I just found some > rand

Re: Kernel build error on BTFIDS vmlinux

2020-08-18 Thread Mark Wielaard
Hi, Adding Nick, the binutils maintainer, so we can make sure binutils/elfutils agree on some ELF section compression corner case. On Tue, 2020-08-18 at 18:33 +0200, Jesper Dangaard Brouer wrote: > On Tue, 18 Aug 2020 15:45:43 +0200 > Jiri Olsa wrote: > > > On Tue, Aug 18, 2020 at 12:56:08PM +0

Re: Kernel build error on BTFIDS vmlinux

2020-08-19 Thread Mark Wielaard
. So for now the workaround will be needed and it would be nice if binutils ld could also be fixed to set the sh_addralign field correctly. Cheers, Mark From 55c5c9a568ed707bcea1388bf3a525212d8cf4b8 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 19 Aug 2020 23:41:24 +0200 Subject: [PATCH] lib

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-20 Thread Mark Wielaard
Hi, On Wed, 2020-08-19 at 20:23 -0700, Yonghong Song wrote: > On 8/19/20 7:27 PM, Fāng-ruì Sòng wrote: > > > > > > > I think this is resolve_btfids's bug. GNU ld and LLD are innocent. > > These .debug_* sections work fine if their sh_addralign is 1. > > When the section flag SHF_COMPRESSED is set

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-20 Thread Mark Wielaard
Hi On Thu, 2020-08-20 at 08:51 -0700, Yonghong Song wrote: > > > Do you think we could skip these .debug_* sections somehow in elf > > > parsing in resolve_btfids? resolve_btfids does not need to read > > > these sections. This way, no need to change their alignment > > > either. > > > > The issu

Re: sendmmsg flags userspace ABI change in kernel 4.6

2018-04-22 Thread Mark Wielaard
Hi, Adding valgrind-developers to CC. On Wed, 2018-04-18 at 21:03 +0200, Florian Weimer wrote: > Since this commit: > > commit 28a94d8fb35b3a75b802f368ae6f4a9f6b0d435a > Author: Tom Herbert > Date:   Mon Mar 7 14:11:02 2016 -0800 > > net: Allow MSG_EOR in each msghdr of sendmmsg > > T