On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> Hi,
>
> while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time
> parameter is
> incorrectly configured. The problem is the utility function get_s64() used by
> TAPRIO doesn't parse the v
omiscuous mode
> [ 60.334905] br0: port 1(sw0p2) entered blocking state
> [ 60.340142] br0: port 1(sw0p2) entered forwarding state
> Warning: dsa_core: skipping configuration of VLAN. # This was the pvid
> $ bridge vlan add dev sw0p2 vid 100
> Warning: dsa_core: skipping configuration of VLAN.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Kurt Kanzenbach
signature.asc
Description: PGP signature
schedule up to eight seconds in the future. The
TAPRIO interface provides an absolute base time. Therefore, periodic delayed
work is leveraged to check whether a schedule may be started or not.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 298
:
* https://lkml.kernel.org/netdev/20201121115703.23221-1-k...@linutronix.de/
Changes since v1:
* Use taprio data structure
* Calculate base_time if in past
* Validate input parameters
* Minor things
Kurt Kanzenbach (1):
net: dsa: hellcreek: Add TAPRIO offloading support
drivers/net/dsa
On Tue Jan 19 2021, Jakub Kicinski wrote:
> On Sat, 16 Jan 2021 13:49:22 +0100 Kurt Kanzenbach wrote:
>> +if (base_time_ns - current_ns < (s64)8 * NSEC_PER_SEC)
>> +return true;
>> +
>> +return false;
>
> nit:
> return base_time_
| 7 +-
> include/soc/mscc/ocelot.h | 3 +-
> net/dsa/dsa_priv.h| 18 ++--
> net/dsa/port.c| 97 ---
> net/dsa/slave.c | 17 ++--
> net/dsa/switch.c
A and let drivers to propagate
> errors directly from the .port_vlan_add callback.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Kurt Kanzenbach
for the hellcreek part.
Thanks,
Kurt
signature.asc
Description: PGP signature
Hi,
fix two minor issues in the hellcreek driver.
Thanks,
Kurt
Kurt Kanzenbach (2):
net: dsa: tag_hellcreek: Cleanup includes
net: dsa: hellcreek: Don't print error message on defer
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
net/dsa/tag_hellcreek.c| 4 +---
2
Remove unused and add needed includes. No functional change.
Suggested-by: Vladimir Oltean
Signed-off-by: Kurt Kanzenbach
---
net/dsa/tag_hellcreek.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/dsa/tag_hellcreek.c b/net/dsa/tag_hellcreek.c
index 2061de06eafb
When DSA is not loaded when the driver is probed an error message is
printed. But, that's not really an error, just a defer. Use dev_err_probe()
instead.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
schedule up to eight seconds in the future. The
TAPRIO interface provides an absolute base time. Therefore, periodic delayed
work is leveraged to check whether a schedule may be started or not.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 314
cks as delayed work is executed in user context and mutexes can
be used which makes everything much simpler.
Thanks,
Kurt
Kurt Kanzenbach (1):
net: dsa: hellcreek: Add TAPRIO offloading support
drivers/net/dsa/hirschmann/hellcreek.c | 314 +
drivers/net/dsa/hirschmann/h
On Mon Nov 23 2020, Vladimir Oltean wrote:
> Hi Kurt,
>
> On Sat, Nov 21, 2020 at 12:57:03PM +0100, Kurt Kanzenbach wrote:
>> The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic
>> schedules may be configured individually on each front port. Each port ha
On Tue Nov 24 2020, Christian Eggers wrote:
> Replace use of magic number with recently introduced define.
>
> Signed-off-by: Christian Eggers
> Cc: Kurt Kanzenbach
Reviewed-by: Kurt Kanzenbach
signature.asc
Description: PGP signature
On Mon Nov 09 2020, Colin King wrote:
> From: Colin Ian King
>
> The left shift of u16 variable high is promoted to the type int and
> then sign extended to a 64 bit u64 value. If the top bit of high is
> set then the upper 32 bits of the result end up being set by the
> sign extension. Fix this
; Addresses-Coverity: ("Unintended sign extension")
> Fixes: e4b27ebc780f ("net: dsa: Add DSA driver for Hirschmann Hellcreek
> switches")
> Signed-off-by: Colin Ian King
Reviewed-by: Kurt Kanzenbach
signature.asc
Description: PGP signature
Hi Colin,
On Mon Nov 09 2020, Colin Ian King wrote:
> Hi
>
> Static analysis on linux-next with Coverity has detected a potential
> null pointer dereference issue on the following commit:
>
> commit f0d4ba9eff75a79fccb7793f4d9f12303d458603
> Author: Kamil Alkhouri
> Date: Tue Nov 3 08:10:58 202
Add myself to cover the Hirschmann Hellcreek TSN Ethernet Switch Driver.
Suggested-by: Andrew Lunn
Signed-off-by: Kurt Kanzenbach
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2a0fde12b650..7fe936fc7e76 100644
--- a/MAINTAINERS
On Mon Nov 09 2020, Florian Fainelli wrote:
> From: Kurt Kanzenbach
>
> Convert the b53 DSA device tree bindings to YAML in order to allow
> for automatic checking and such.
>
> Suggested-by: Florian Fainelli
> Signed-off-by: Kurt Kanzenbach
> ---
> .../devicetr
On Tue Nov 10 2020, Vladimir Oltean wrote:
> On Tue, Nov 10, 2020 at 08:18:29AM +0100, Kurt Kanzenbach wrote:
>> Add myself to cover the Hirschmann Hellcreek TSN Ethernet Switch Driver.
>>
>> Suggested-by: Andrew Lunn
>> Signed-off-by: Kurt Kanzenbach
>> ---
&g
On Thu Nov 12 2020, YueHaibing wrote:
> drivers/net/dsa/sja1105/sja1105_ptp.c:869 sja1105_ptp_clock_register() warn:
> passing zero to 'PTR_ERR'
>
> ptp_clock_register() returns ERR_PTR() and never returns
> NULL. The NULL test should be removed.
Which is not true. From the documentation:
* Ret
On Thu Jan 07 2021, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The call path of a switchdev VLAN addition to the bridge looks something
> like this today:
>
> nbp_vlan_init
> | __br_vlan_set_default_pvid
> | | |
> | |br_afspec
ee':
> (.text+0x1018): undefined reference to `led_classdev_unregister'
> microblaze-linux-ld: (.text+0x1024): undefined reference to
> `led_classdev_unregister'
>
> Signed-off-by: Randy Dunlap
> Reported-by: kernel test robot
> Link: lore.kernel.org/r/202101060655.iuvmjqs2-...@int
x Spectrum supports offloading more than one VLAN at a time,
> through mlxsw_sp_port_vlan_set. I have kept that code internal to the
> driver, because there is some more bookkeeping that makes use of it, but
> I deleted it from the switchdev API. But since the switchdev support for
> ranges has already been de facto deleted by a Mellanox employee and
> nobody noticed for 4 years, I'm going to assume it's not a biggie.
>
> Signed-off-by: Vladimir Oltean
> Reviewed-by: Ido Schimmel # switchdev and mlxsw
Reviewed-by: Kurt Kanzenbach # hellcreek
signature.asc
Description: PGP signature
On Mon Oct 19 2020, Christian Eggers wrote:
> Convert the bindings document for Microchip KSZ Series Ethernet switches
> from txt to yaml.
A few comments/questions below.
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> b/Documentation/devicetree/bindings/net/dsa/mic
On Wed Oct 21 2020, Florian Fainelli wrote:
> On 10/21/2020 5:16 PM, Vladimir Oltean wrote:
>> On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote:
>>> On Mon Oct 19 2020, Christian Eggers wrote:
>>> The node names should be switch. See dsa.yaml.
>&
pen when a timestamp is read and at this point another
message is timestamped. So, that lost bit is checked just in case to indicate
to the user that the driver or the software is somewhat buggy.
Signed-off-by: Kamil Alkhouri
Signed-off-by: Kurt Kanzenbach
Acked-by: Richard Cochran
Add basic documentation and example.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Rob Herring
Reviewed-by: Florian Fainelli
---
.../net/dsa/hirschmann,hellcreek.yaml | 127 ++
1 file changed, 127 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net
be activated if the current device is in sync with the network
time.
Expose these via the LED framework to be controlled via user space
e.g. linuxptp.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/hirschmann/hellcreek.h | 4
ntation is
based on that code.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
Reviewed-by: Vladimir Oltean
---
include/net/dsa.h | 2 +
net/dsa/Kconfig | 6 +++
net/dsa/Makefile| 1 +
net/dsa/tag_hellcreek.c | 102 +++
handling
* FDB handling
* Port statistics
* STP
* Phylink
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/Kconfig |2 +
drivers/net/dsa/Makefile |1 +
drivers/net/dsa/hirschmann/Kconfig|8 +
drivers/net/dsa/hirschmann
hirschmann/hellcreek_ptp.c
b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
new file mode 100644
index ..856fcb9ba3c6
--- /dev/null
+++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
@@ -0,0 +1,283 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * DSA driver for:
+ * Hirschmann He
Hirschmann is building devices for automation and networking. Add them to the
vendor prefixes.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a
y can only accept an 8021q upper on a port as
long as it isn't installed on any other port too. So give them the
chance to veto bad user requests.
Signed-off-by: Vladimir Oltean
Signed-off-by: Kurt Kanzenbach
---
include/net/dsa.h | 6 ++
net/dsa/slave.c | 12
2 files changed
L DT bindings
* Richard Cochran
* Fix typo
* Add missing NULL checks
Kamil Alkhouri (2):
net: dsa: hellcreek: Add PTP clock support
net: dsa: hellcreek: Add support for hardware timestamping
Kurt Kanzenbach (5):
net: dsa: Add tag handling for Hirschmann Hellcreek switches
net: dsa: A
need to be unshared.
> The tx_reallocs counter should prove that.
>
> Signed-off-by: Vladimir Oltean
> Tested-by: Christian Eggers # For tail taggers only
Tested-by: Kurt Kanzenbach
I'll wait with the hellcreek series until this is merged.
Thanks,
Kurt
signature.asc
Description: PGP signature
ntation is
based on that code.
Signed-off-by: Kurt Kanzenbach
---
include/net/dsa.h | 2 ++
net/dsa/Kconfig | 6
net/dsa/Makefile| 1 +
net/dsa/tag_hellcreek.c | 66 +
4 files changed, 75 insertions(+)
create mode 1006
handling
* FDB handling
* Port statistics
* STP
* Phylink
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/Kconfig |2 +
drivers/net/dsa/Makefile |1 +
drivers/net/dsa/hirschmann
y can only accept an 8021q upper on a port as
long as it isn't installed on any other port too. So give them the
chance to veto bad user requests.
Signed-off-by: Vladimir Oltean
[Kurt: Pass info instead of ptr]
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
---
include/net/dsa.h |
checks
Kamil Alkhouri (2):
net: dsa: hellcreek: Add PTP clock support
net: dsa: hellcreek: Add support for hardware timestamping
Kurt Kanzenbach (5):
net: dsa: Add tag handling for Hirschmann Hellcreek switches
net: dsa: Add DSA driver for Hirschmann Hellcreek switches
net: dsa: hellcreek: A
Add basic documentation and example.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Rob Herring
Reviewed-by: Florian Fainelli
---
.../net/dsa/hirschmann,hellcreek.yaml | 127 ++
1 file changed, 127 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net
Hirschmann is building devices for automation and networking. Add them to the
vendor prefixes.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian Fainelli
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a
be activated if the current device is in sync with the network
time.
Expose these via the LED framework to be controlled via user space
e.g. linuxptp.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/hirschmann/hellcreek.h | 4
pen when a timestamp is read and at this point another
message is timestamped. So, that lost bit is checked just in case to indicate
to the user that the driver or the software is somewhat buggy.
Signed-off-by: Kamil Alkhouri
Signed-off-by: Kurt Kanzenbach
Acked-by: Richard Cochran
hirschmann/hellcreek_ptp.c
b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
new file mode 100644
index ..856fcb9ba3c6
--- /dev/null
+++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
@@ -0,0 +1,283 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * DSA driver for:
+ * Hirschmann He
On Fri Nov 06 2020, Arnd Bergmann wrote:
> On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko
> wrote:
>> On 06/11/2020 09:56, Wang Qing wrote:
>
>> > +++ b/drivers/net/ethernet/ti/am65-cpts.c
>> > @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device
>> > *dev, void __iomem *regs
ailure of
> port_txtstamp (this may usually happen), the skb clone has to be freed.
> So put skb cloning into port_txtstamp where it really needs.
>
> Signed-off-by: Yangbo Lu
PTP still works.
Tested-by: Kurt Kanzenbach # hellcreek
signature.asc
Description: PGP signature
ng any XDP operations and adjust all other code
accordingly. The igc driver does it like that as well.
Tested with Intel i210 card and AF_XDP sockets.
Fixes: 9cbc948b5a20 ("igb: add XDP support")
Signed-off-by: Kurt Kanzenbach
---
Changes since v1:
* Use xdp_prepare_buff() (Lorenz
here ]
|[ 112.731418] WARNING: CPU: 1 PID: 257 at net/hsr/hsr_forward.c:560
hsr_forward_skb+0x484/0x568
|[ 112.739962] net/hsr/hsr_forward.c:560: Malformed frame (port_src hsr0)
The MAC header is also reset unconditionally in case of PACKET_QDISC_BYPASS is
not used.
Signed-off-by: Kurt Kanzenbach
---
On Sun Mar 28 2021, Willem de Bruijn wrote:
> On Fri, Mar 26, 2021 at 11:49 AM Kurt Kanzenbach wrote:
>>
>> Reset MAC header in case of using packet_direct_xmit(), e.g. by specifying
>> PACKET_QDISC_BYPASS. This is needed, because other code such as the HSR layer
>> e
Fixes: d346a3fae3ff ("packet: introduce PACKET_QDISC_BYPASS socket option")
Signed-off-by: Kurt Kanzenbach
---
Changes since v1:
* Move skb_reset_mac_header() to __dev_direct_xmit()
* Add Fixes tag
* Target net tree
Previous versions:
* https://lkml.kernel.org/netdev/202103261
On Mon Mar 29 2021, Eric Dumazet wrote:
> Note that last year, I addressed the issue differently in commit
> 96cc4b69581db68efc9749ef32e9cf8e0160c509
> ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
> (amended with commit 1712b2fff8c682d145c7889d2290696647d82dab
> "macvlan: use
introduce PACKET_QDISC_BYPASS socket option")
Signed-off-by: Kurt Kanzenbach
---
Changes since v2:
* Move skb_reset_mac_header() to hsr_dev_xmit()
* Remove HSR malformed frame warning
Changes since v1:
* Move skb_reset_mac_header() to __dev_direct_xmit()
* Add Fixes tag
* Target net
ng any XDP operations and adjust all other code
accordingly. The igc driver does it like that as well.
Tested with Intel i210 card and AF_XDP sockets.
Fixes: 9cbc948b5a20 ("igb: add XDP support")
Signed-off-by: Kurt Kanzenbach
---
drivers/net/ethernet/intel/igb/igb.h | 3 +-
On Mon Apr 12 2021, DENG Qingfang wrote:
> Add device tree binding to support MT7530 interrupt controller.
>
> Signed-off-by: DENG Qingfang
> Reviewed-by: Andrew Lunn
> ---
> RFC v3 -> RFC v4:
> - Add #interrupt-cells property.
>
> Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++
On Mon Apr 12 2021, Jesper Dangaard Brouer wrote:
> On Mon, 12 Apr 2021 12:17:13 +0200
> Kurt Kanzenbach wrote:
>
>> When using native XDP with the igb driver, the XDP frame data doesn't point
>> to
>> the beginning of the packet. It's off by 16 bytes. Eve
On Tue Apr 13 2021, Alexander Duyck wrote:
> On Mon, Apr 12, 2021 at 7:29 AM Jesper Dangaard Brouer
> wrote:
>> > +ktime_t igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va)
>> > {
>> > struct igb_adapter *adapter = q_vector->adapter;
>> > + struct skb_shared_hwtstamps ts;
>>
ng any XDP operations and adjust all other code
accordingly. The igc driver does it like that as well.
Tested with Intel i210 card and AF_XDP sockets.
Fixes: 9cbc948b5a20 ("igb: add XDP support")
Signed-off-by: Kurt Kanzenbach
---
Changes since RFC:
* Removed unused return value d
On Thu Apr 15 2021, Jesper Dangaard Brouer wrote:
> On Thu, 15 Apr 2021 11:21:45 +0200
> Kurt Kanzenbach wrote:
>
>> When using native XDP with the igb driver, the XDP frame data doesn't point
>> to
>> the beginning of the packet. It's off by 16 bytes. Eve
On Thu Apr 15 2021, Lorenzo Bianconi wrote:
> [...]
>> @@ -8683,7 +8676,10 @@ static int igb_clean_rx_irq(struct igb_q_vector
>> *q_vector, const int budget)
>> while (likely(total_packets < budget)) {
>> union e1000_adv_rx_desc *rx_desc;
>> struct igb_rx_buffer *rx_
On Thu Apr 15 2021, Jesper Dangaard Brouer wrote:
> I have a project involving i225+igc (using TSN). And someone suggested
> that I also looked at i210 for TSN. I've ordered hardware that have
> i210 on motherboard (and I will insert my i225 card) so I have a system
> with both chips for experime
data structure
* Calculate base_time if in past
* Validate input parameters
* Minor things
Kurt Kanzenbach (1):
net: dsa: hellcreek: Add TAPRIO offloading support
drivers/net/dsa/hirschmann/hellcreek.c | 303 -
drivers/net/dsa/hirschmann/hellcreek.h | 17 +-
2 files
schedule up to eight seconds in the future. The
TAPRIO interface provides an absolute base time. Therefore, periodic delayed
work is leveraged to check whether a schedule may be started or not.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Vladimir Oltean
---
drivers/net/dsa/hirschmann/hellcreek.c | 303
On Tue Jan 26 2021, Vladimir Oltean wrote:
> On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote:
>> Avoid possible TX Hangs caused by using long Qbv cycles. In some
>> cases, using long cycles (more than 1 second) can cause transmissions
>> to be blocked for that time. As the TX H
fc6eb39b2 ("net: dsa: hellcreek: Add TAPRIO offloading support")
Reported-by: Randy Dunlap
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/Kconfig | 1 +
1 file changed, 1 insertion(+)
Note: It's not against net, because the fixed commit is not in net tree, yet.
diff --git a
On Thu Jan 28 2021, Randy Dunlap wrote:
> On 1/28/21 1:11 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20210127:
>>
>
>
> on i386:
>
> ERROR: modpost: "taprio_offload_get"
> [drivers/net/dsa/hirschmann/hellcreek_sw.ko] undefined!
> ERROR: modpost: "taprio_offload_free"
> [drivers/
The VLAN membership configuration is cached in software already. So, it can be
reported via devlink. Add support for it:
|root@tsn:~# devlink resource show platform/ff24.switch
|platform/ff24.switch:
| name VLAN size 4096 occ 4 unit entry dpipe_tables none
Signed-off-by: Kurt Kanzenbach
dpipe_tables none
Suggested-by: Florian Fainelli
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 46 ++
drivers/net/dsa/hirschmann/hellcreek.h | 1 +
2 files changed, 40 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/hirschmann
Hi,
Florian, Andrew and Vladimir suggested at some point to use devlink for
reporting tables, features and debugging counters instead of using debugfs and
printk.
So, start by reporting the VLAN and FDB table sizes.
Thanks,
Kurt
Kurt Kanzenbach (2):
net: dsa: hellcreek: Report VLAN table
On Sun Jan 31 2021, Vladimir Oltean wrote:
> On Sat, Jan 30, 2021 at 02:59:32PM +0100, Kurt Kanzenbach wrote:
>> Florian, Andrew and Vladimir suggested at some point to use devlink for
>> reporting tables, features and debugging counters instead of using debugfs
>> and
>&g
Hi Vladimir,
On Mon Mar 08 2021, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> DSA is aware of switches with global VLAN filtering since the blamed
> commit, but it makes a bad decision when multiple bridges are spanning
> the same switch:
>
> ip link add br0 type bridge vlan_filtering 1
> i
There are two functions which need to populate fdb entries. Move that to a
helper function.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 85 +-
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a/drivers/net/dsa/hirschmann
entry dpipe_tables none
| name RAM size 320 occ 14 unit entry dpipe_tables none
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 38 --
drivers/net/dsa/hirschmann/hellcreek.h | 2 ++
2 files changed, 37 insertions(+), 3 deletions(-)
diff
hellcreek_select_vlan() takes a boolean instead of an integer.
So, use false accordingly.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c
b/drivers/net/dsa
Allow to dump the VLAN table via devlink. This especially useful, because the
driver internally leverages VLANs for the port separation. These are not visible
via the bridge utility.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 73
size 256 occ 6 unit entry dpipe_tables none
| name RAM size 320 occ 14 unit entry dpipe_tables none
| name META size 320 occ 5 unit entry dpipe_tables none
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 36 --
drivers/net/dsa/hirschmann
Hi,
add support for dumping the VLAN and FDB table via devlink. As the driver uses
internal VLANs and static FDB entries, this is a useful debugging feature. Also
report the current memory and descriptor usage.
Thanks,
Kurt
Kurt Kanzenbach (6):
net: dsa: hellcreek: Report RAM usage
net: dsa
Allow to dump the FDB table via devlink. This is a useful debugging feature.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 63 ++
drivers/net/dsa/hirschmann/hellcreek.h | 1 +
2 files changed, 64 insertions(+)
diff --git a/drivers/net/dsa
s/sec0 sender
|[ 5] 0.00-10.02 sec 48.7 MBytes 40.7 Mbits/sec receiver
Signed-off-by: Kurt Kanzenbach
---
net/sched/sch_taprio.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/net/sched/sch_taprio.c b/net/
On Fri Mar 12 2021, Vladimir Oltean wrote:
> On Thu, Mar 11, 2021 at 11:52:41PM +0100, Andrew Lunn wrote:
>> On Thu, Mar 11, 2021 at 06:53:40PM +0100, Kurt Kanzenbach wrote:
>> > Report the META data descriptor usage via devlink.
>>
>> Jakubs question is also releva
Allow to dump the FDB table via devlink. This is a useful debugging feature.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 62 ++
drivers/net/dsa/hirschmann/hellcreek.h | 1 +
2 files changed, 63 insertions
hellcreek_select_vlan() takes a boolean instead of an integer.
So, use false accordingly.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/hirschmann
There are two functions which need to populate fdb entries. Move that to a
helper function.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 85 +-
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a
Allow to dump the VLAN table via devlink. This especially useful, because the
driver internally leverages VLANs for the port separation. These are not visible
via the bridge utility.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 74
:
* https://lkml.kernel.org/netdev/20210311175344.3084-1-k...@kmk-computers.de/
Thanks,
Kurt
Kurt Kanzenbach (4):
net: dsa: hellcreek: Add devlink VLAN region
net: dsa: hellcreek: Use boolean value
net: dsa: hellcreek: Move common code to helper
net: dsa: hellcreek: Add devlink FDB region
The switch implements unicast and multicast filtering per port.
Add support for it. By default filtering is disabled.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 129 -
1 file changed, 104 insertions(+), 25 deletions(-)
diff --git a
On Sat Mar 13 2021, Vladimir Oltean wrote:
> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:
>> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>>
>> Signed-off-by: Kurt Kanzenbach
>> Reviewed-by: Andrew Lunn
>> ---
On Fri Mar 12 2021, Vinicius Costa Gomes wrote:
> My first worry was whether the segments had the same tstamp as their
> parent, and it seems that they do, so everything should just work with
> etf or the txtime-assisted mode.
>
> I just want to play with this patch a bit and see how it works in
>
On Mon Mar 15 2021, Vladimir Oltean wrote:
> On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote:
>> +if (enable)
>> +val &= ~HR_PTCFG_UUC_FLT;
>> +else
>> +val |= HR_PTCFG_UUC_FLT;
>
> What does 'unknown
On Mon Mar 15 2021, Vladimir Oltean wrote:
> On Mon, Mar 15, 2021 at 09:33:44PM +0100, Kurt Kanzenbach wrote:
>> On Mon Mar 15 2021, Vladimir Oltean wrote:
>> > On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote:
>> >> + if (enable)
>> &
0 sender
|[ 5] 0.00-10.02 sec 48.7 MBytes 40.7 Mbits/sec receiver
Furthermore, the segmentation can be skipped for the full offload case, as the
driver or the hardware is expected to handle this.
Signed-off-by: Kurt Kanzenbach
---
net/sched/sch_taprio.c
:
* Move segmentation, so that timestamps for tx assisted mode are
calculated for the segments
* Skip it for the full hardware offloading case
Previous versions:
* https://lkml.kernel.org/netdev/20210312092823.1429-1-k...@linutronix.de/
Kurt Kanzenbach (1):
taprio: Handle short intervals
Report the driver name, ASIC ID and the switch name via devlink. This is a
useful information for user space tooling.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 18 ++
.../linux/platform_data/hirschmann-hellcreek.h | 1 +
2 files changed
On Sun Mar 14 2021, Kurt Kanzenbach wrote:
> On Sat Mar 13 2021, Vladimir Oltean wrote:
>> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:
>>> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>>>
>>> Signed-off-
On Sat Mar 20 2021, Andrew Lunn wrote:
>> +static int hellcreek_devlink_info_get(struct dsa_switch *ds,
>> + struct devlink_info_req *req,
>> + struct netlink_ext_ack *extack)
>> +{
>> +struct hellcreek *hellcreek = ds->priv;
>>
Report the driver name, ASIC ID and the switch name via devlink. This is a
useful information for user space tooling.
Signed-off-by: Kurt Kanzenbach
---
Changes since v1:
* Include just the model name in ASIC ID
drivers/net/dsa/hirschmann/hellcreek.c | 18 ++
.../linux
le doing that.
>
> This patch checks whether any port exists at all and is under a
> VLAN-aware bridge.
>
> Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the
> bridge")
> Signed-off-by: Vladimir Oltean
> Tested-by: Florian Fainelli
> Reviewed-by: Florian Fainelli
Reviewed-by: Kurt Kanzenbach
signature.asc
Description: PGP signature
: Russell King
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Richard Cochran
Reviewed-by: Florian Fainelli
---
include/linux/ptp_classify.h | 44
net/core/ptp_classifier.c| 30
2 files changed, 74 insertions(+)
diff --git a/include
In order to reduce code duplication between ptp drivers, generic helper
functions were introduced. Use them.
Signed-off-by: Kurt Kanzenbach
Reviewed-and-tested-by: Petr Machata
Reviewed-by: Florian Fainelli
---
.../ethernet/mellanox/mlxsw/spectrum_ptp.c| 32 ---
1 file
The message type is located at different offsets within the ptp header depending
on the ptp version (v1 or v2). Therefore, drivers which also deal with ptp v1
have some code for it.
Extract this into a helper function for drivers to be used.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Richard
1 - 100 of 307 matches
Mail list logo
