From: Maxime Ripard
Date: Thu, May 23, 2019 at 10:56:49
> Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> schema to enable the DT validation.
>
> Signed-off-by: Maxime Ripard
How exactly can I see the final results of this ? Do you have any link ?
(I'm no expert in
From: Maxime Ripard
Date: Thu, May 23, 2019 at 12:07:15
> You can then run make dtbs_check, and those YAML files will be used to
> validate that any devicetree using those properties are doing it
> properly. That implies having the right node names, properties, types,
> ranges of values when rele
For review and testing only.
This converts stmmac to use phylink. Besides the code redution this will
allow to gain more flexibility.
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (2):
net: stmmac: Prepare to convert to phylink
net: stmmac
From: Shaokun Zhang
Date: Aug/07/2019, 09:17:29 (UTC+00:00)
> From: yuqi jin
>
> XGMAC_MTL_RXQ_DMA_MAP1 will be configured if the number of queues is
> greater than 3, but local variable chan will shift left more than 32-bits.
> Let's fix this issue.
This was already fixed in -net. Please see
Hello,
I've some sample code for Clause 73 support using Synopsys based XPCS
but I would like to clarify some things that I noticed.
I'm using USXGMII as interface and a single SERDES that operates at 10G
rate but MAC side is working at 2.5G. Maximum available bandwidth is
therefore 2.5Gbps.
++ PHY Experts
From: Jose Abreu
Date: Aug/07/2019, 16:46:23 (UTC+00:00)
> Hello,
>
> I've some sample code for Clause 73 support using Synopsys based XPCS
> but I would like to clarify some things that I noticed.
>
> I'm using USXGMII as interface and a single
USXGMII. As link is
operating in 10G but I configure USXGMII for 2.5G maybe autoneg outcome
should always be 10G ?
> On Thu, Aug 08, 2019 at 08:17:29AM +, Jose Abreu wrote:
> > ++ PHY Experts
> >
> > From: Jose Abreu
> > Date: Aug/07/2019, 16:46:23 (UTC+00:00)
>
From: Russell King - ARM Linux admin
Date: Aug/08/2019, 10:23:13 (UTC+00:00)
> On Thu, Aug 08, 2019 at 09:02:57AM +0000, Jose Abreu wrote:
> > From: Russell King - ARM Linux admin
> > Date: Aug/08/2019, 09:26:26 (UTC+00:00)
> >
> > > Hi,
> > >
>
TX Timestamp in XGMAC comes from MAC instead of descriptors. Implement
this in a new callback.
Also, RX Timestamp in XGMAC must be cheked against corruption and we need
a barrier to make sure that descriptor fields are read correctly.
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro
Add a counter that increments each time a packet with split header is
received.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 +
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c| 2 ++
3
Return the correct value when RX descriptor is not the last one.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
b/drivers/net
Add 4 new tests:
- SA Insertion (register based)
- SA Insertion (descriptor based)
- SA Replacament (register based)
- SA Replacement (descriptor based)
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 98
Add the ethtool interface to dump the register map in XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 11 +-
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 10
Couple of improvements for -next tree. More info in commit logs.
---
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Jose Abreu
Cc: "David S. Miller"
Cc: Maxime Coquelin
Cc: netdev@vger.kernel.org
Cc: linux-st...@st-md-mailman.stormreply.com
Cc: linux-arm-ker...@lists.infradead.org
Add the support for Source Address Insertion and Replacement in XGMAC
cores. Two methods are supported: Descriptor based and register based.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 ++
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 11
Adds the logic to insert a given VLAN ID in a packet. This is offloaded
to HW and its descriptor based. For now, only XGMAC implements the
necessary callbacks.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 8
drivers/net/ethernet/stmicro/stmmac
Add the support for Flexible PPS in XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 19
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 56 ++
2 files changed, 75 insertions(+)
diff --git a/drivers/net/ethernet
Add support for EEE in XGMAC cores by implementing the necessary
callbacks.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 12
.../net/ethernet/stmicro/stmmac/dwxgmac2_core.c| 75 --
drivers/net/ethernet/stmicro/stmmac
Add the support for Split Header feature in the RX path and enable it in
XGMAC cores.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 +
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 ++
.../net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 18
Add 2 new selftests for VLAN Insertion offloading. Tests are for inner
and outer VLAN offloading.
Signed-off-by: Jose Abreu
---
.../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 96 +-
1 file changed, 94 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet
In order to add Split Header support, stmmac_rx() needs to take into
account that packet may be split accross multiple descriptors.
Refactor the logic of this function in order to support this scenario.
Signed-off-by: Jose Abreu
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 6
From: Russell King - ARM Linux admin
Date: Aug/08/2019, 13:09:03 (UTC+00:00)
> On Thu, Aug 08, 2019 at 11:45:29AM +0000, Jose Abreu wrote:
> > From: Russell King - ARM Linux admin
> > Date: Aug/08/2019, 10:23:13 (UTC+00:00)
> >
> > > On Thu, Aug 08, 2019 at 09:0
Hi,
I'm trying to use u32 filter to filter specific fields of packets
by HW *only* but I'm having a hard time in trying to run tc to
configure it.
I implemented a dummy .ndo_setup_tc callback which always returns
success and I set NETIF_F_HW_TC field in hw_features. Then I run
tc, like this:
On 27-04-2018 16:04, Jiri Pirko wrote:
> Fri, Apr 27, 2018 at 04:15:46PM CEST, jose.ab...@synopsys.com wrote:
>> Hi,
>>
>> I'm trying to use u32 filter to filter specific fields of packets
>> by HW *only* but I'm having a hard time in trying to run tc to
>> configure it.
>> I implemented a dummy .n
;r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=TBD6a7UY2VbpPmV9LOW_eHAyg8uPq1ZPDhq93VROTVE&s=4fvOST1HhWmZ4lThQe-dHCJYEXNOwey00BCXOWm8tKo&e=
>
> Signed-off-by: Kees Cook
>
I rather prefer the variables declaration in reverse-tree order,
but thats just a minor pick.
Reviewed-by: Jose Abreu
Thanks
On 02-05-2018 13:36, Kees Cook wrote:
> On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote:
>> Hi Kees,
>>
>> On 01-05-2018 22:01, Kees Cook wrote:
>>> In the quest to remove all stack VLAs from the kernel[1], this switches
>>> the "status" stack
Hi Christophe,
On 02-05-2018 15:18, Christophe Roullier wrote:
> Manage dwmac-4.20a version from synopsys
>
>
Just being curious: Can you tell me which HW features do you have
on your NIC?
Thanks and Best Regards,
Jose Miguel Abreu
s involved.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/Makefile |2 +-
drivers/net/ethernet/stmicro/stmmac/common.h |5 +
drivers/net/ethernet/stmicro/stmma
s involved.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Jakub Kicinski
---
Changes from v1:
- Follow Linux network coding style (David)
- Use tc_cls_can_offload_and_chain0() (Jakub)
---
drivers/ne
Hi Jakub, David,
On 05-05-2018 02:33, Jakub Kicinski wrote:
> On Fri, 4 May 2018 10:01:38 +0100, Jose Abreu wrote:
>> This adds support for U32 filter by using an HW only feature called
>> Flexible RX Parser. This allow us to match any given packet field with a
>> pattern
r
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (10):
net: stmmac: Let descriptor code set skbuff address
net: stmmac: Let descriptor code clear the descriptor
net: stmmac: Uniformize the use of dma_{rx/tx}_mode callbacks
net: stmmac: Remove un
Stop using if conditions depending on the GMAC version for clearing the
descriptor and use instead a helper implemented in the descriptor files.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net
: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/hwif.c| 34 +
drivers/net/ethernet/stmicro/stmmac/hwif.h|5 +++
drivers/net/ethernet/stmicro/stmmac
The RX Descriptor is already initialized in at setup phase so there is
no need to set the values again, we just need to set the owner. This
allow us to remove another if condition.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc
With the introducion of callbacks check in hwif.h we only call the
callback if HW supports it so there is no longer need to check for GMAC
version.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net
We can remove the if condition and check if return code is different
than -EINVAL, meaning callback is present.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
Stop using if conditions depending on the GMAC version for getting the
descriptor skbuff address and use instead a helper implemented in the
descriptor files.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
We either have .enable_dma_transmission or .set_tx_tail_ptr in the HW
table callbacks, we can never have both so there is no need to check for
GMAC version.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers
rx/tx channels.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
.../net/ethernet/stmicro/stmmac/dwmac1000_dma.c| 25 ++--
drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c | 25 ++--
drivers/net
Stop using if conditions depending on the GMAC version for setting the
the descriptor skbuff address and use instead a helper implemented in
the descriptor files.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Instead of relying on the GMAC version for choosing if we need to use
dma_{rx/tx}_mode or just dma_mode callback lets uniformize this and
always use the dma_{rx/tx}_mode callbacks.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc
ec0
> 1.41 KBytes
> [ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec0 1.41
> KBytes
> [ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec0 1.41
> KBytes
> [ 5] 3.00-4.00 sec 0.00 Bytes 0.00 bits/sec0 1.41
> KBytes
> [ 5]
Hi Bhadram,
On 10-05-2018 09:55, Jose Abreu wrote:
> ++net-dev
>
> Hi Bhadram,
>
> On 09-05-2018 12:03, Bhadram Varka wrote:
>> Hi,
>>
>> Thanks for responding.
>>
>> Tried below suggested way. Still observing the issue -
> It seems stmmac
On 08-05-2018 15:45, Jose Abreu wrote:
> The RX Descriptor is already initialized in at setup phase so there is
> no need to set the values again, we just need to set the owner. This
> allow us to remove another if condition.
>
> Signed-off-by: Jose Abreu
> Cc: David S. Miller
On 10-05-2018 16:08, Bhadram Varka wrote:
> Hi Jose,
>
> On 5/10/2018 7:59 PM, Jose Abreu wrote:
>> Hi Bhadram,
>>
>> On 10-05-2018 09:55, Jose Abreu wrote:
>>> ++net-dev
>>>
>>> Hi Bhadram,
>>>
>>> On 09-05-2
On 10-05-2018 20:06, David Miller wrote:
> From: Jose Abreu
> Date: Tue, 8 May 2018 15:45:24 +0100
>
>> Stop using if conditions depending on the GMAC version for setting the
>> the descriptor skbuff address and use instead a helper implemented in
>> the descriptor
ip
the packets for this GMAC version.
Fixes: 477286b53f55 ("stmmac: add GMAC4 core support")
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
Hi David,
Requesting this to go up for stable also. I think its for v4.7+ but if
Move all the core version detection to a common place ("hwif.c") and
implement a table which can be used to lookup the correct callbacks for
each IP version.
This simplifies the initialization flow of each IP version and eases
future implementation of new IP versions.
Signed-off-by:
Move all the core version detection to a common place ("hwif.c") and
implement a table which can be used to lookup the correct callbacks for
each IP version.
This simplifies the initialization flow of each IP version and eases
future implementation of new IP versions.
Signed-off-by:
Hi David,
On 23-04-2018 01:59, David Miller wrote:
> From: Jose Abreu
> Date: Thu, 19 Apr 2018 16:24:15 +0100
>
>> @@ -0,0 +1,216 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
>> +// stmmac
Hi Florian,
On 07-04-2018 20:58, Florian Fainelli wrote:
>
> On 04/06/2018 06:51 AM, Jose Abreu wrote:
>> Hi Florian,
>>
>> On 05-04-2018 16:50, Florian Fainelli wrote:
>>> On 04/05/2018 03:47 AM, Jose Abreu wrote:
>>>> Hi All,
>>>>
>&g
On 24-04-2018 14:17, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc
Hi,
On 27-03-2018 15:46, Sinan Kaya wrote:
>
> Sinan
> "We are being told that if you use writel(), then you don't need a wmb() on
> all architectures."
>
> Alex:
> "I'm not sure who told you that but that is incorrect, at least for
> x86. If you attempt to use writel() without the wmb() we will h
Cc: Andrew Lunn
Jose Abreu (2):
net: stmmac: Rework and fix TX Timeout code
net: stmmac: Add support for DWMAC5 and implement Safety Features
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +-
drivers/net/ethernet/stmicro/stmmac/common.h | 22 ++
drivers/net/ethernet/stmicro
system.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Andrew Lunn
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 11
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 67 +--
2 files changed, 73
protection, FSM parity and timeout
protection and Application/CSR interface timeout protection.
In case of an uncorrectable error we call stmmac_global_err() and
reconfigure the whole core.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
We support more speeds now. Update the Kconfig entry.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
Hi Simon,
On 2/18/2019 6:05 PM, Simon Huelck wrote:
> disabling EEE doesnt help ( did it via the entry in the .dtb / .dts ),
> the results are the same. I can confirm the LPI counters are zero or one
> only after the test.
It's interesting to see that you have a lot of RX packets but few
RX i
interrupts that are enabled so, no event will
be missed.
In my tests withe XGMAC2 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 4 +++-
d
instances per each TX and RX queue, as
suggested by Florian.
Changes from v2:
- Only force restart transmission if there are pending packets
Changes from v1:
- Pass entire ring size to TX clean path (Florian)
Signed-off-by: Jose Abreu
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David
interrupts that are enabled so, no event will be
missed.
In my tests with GMAC5 this increased performance.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_
Tested in XGMAC2 and GMAC5.
Cc: Florian Fainelli
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (3):
net: stmmac: Fix NAPI poll in TX path when in multi-queue
net: stmmac: dwmac4: Also use TBU interrupt to clean TX path
net: stmmac: dwxgmac2
Hi Simon,
On 2/24/2019 8:34 PM, Simon Huelck wrote:
> the topic is about ODROID C2 / Amlogic S905X since the start. we have a
> performance regression since 4.14.
As we are not advancing in this topic I suggest you try bisecting
the offending commit.
Thanks,
Jose Miguel Abreu
Hi Simon,
On 2/27/2019 7:02 PM, Simon Huelck wrote:
> Hi,
>
>
> the thing is , that im not a stmmac developer. Yes , maybe i can bissect
> it and yes you are lucky since im a C-developer since a long time for
> embedded systems.
>
> The problem is that i dont understand the structure of stmmac
When using a C45 PHY that is in PHY_FORCING state we are currently not
taking into account that this kind of PHY has different update_link
functions.
Use the C45 Helpers instead or the driver built-in read_status() helper,
if possible.
Signed-off-by: Jose Abreu
Cc: Andrew Lunn
Cc: Florian
For -net. Please review!
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: "David S. Miller"
Cc: Joao Pinto
Jose Abreu (2):
net: phy: Use C45 Helpers in phy_read_status()
net: phy: Use C45 Helpers in PHY_FORCING state
drivers/net/phy/phy.c | 2 +-
include/linux/phy.h | 15
Currently phy_read_status() considers that either the PHY driver has the
read_status() callback or uses the generic callback.
For C45 PHYs we need to use the gen10g_read_status() callback.
Signed-off-by: Jose Abreu
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: "David S. Miller"
Cc:
Hi Andrew,
On 3/1/2019 1:53 PM, Andrew Lunn wrote:
> On Fri, Mar 01, 2019 at 11:54:24AM +0100, Jose Abreu wrote:
>> +static inline int phy_update_link(struct phy_device *phydev)
>> +{
>> +if (!phydev->drv)
>> +return -EIO;
>> +
On 3/3/2019 4:12 PM, Heiner Kallweit wrote:
> Not sure whether anybody is relying on the gen10g driver currently.
I do for stmmac (code not upstreamed yet) and it works okay. For
debug purposes I ended up writing my own phy driver but this is a
plain copy of Generic 10G driver + reset and suspend/
From: Simon Huelck
Date: Sat, May 11, 2019 at 15:53:34
> ethtool -S gave me some counts for mmc_rx_fifo_overflow, which i didnt
> recognize before.
Flow Control can prevent this to happen. Please check if your DT FIFO
bindings are >= 4096.
> Do we have new ideas / new direction to dig for ?
G
In preparation for the addition of selftests support for stmmac we add a
new callback to HWIF that can be used to set the controller in loopback
mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac1000 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac100 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwxgmac2 core.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
In case we don't use a given address entry we need to clear it because
it could contain previous values that are no longer valid.
Found out while running stmmac selftests.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Cor
From: Corentin Labbe
This patch enable use of set_mac_loopback in dwmac-sun8i
Signed-off-by: Corentin Labbe
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 13 +
1
In order for hash filter to work we need to set the HPF bit.
Fout out while running stmmac selftests
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1
)
- Only test in offline mode (Andrew)
- Do not call phy_loopback twice (Alexandre)
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
Cc: Andrew Lunn
---
drivers/net/ethernet/stmicro/stmmac/Kconfig| 9
In preparation for the addition of stmmac selftests we implement the MAC
loopback callback in dwmac4/5 cores.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac4.h
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
: stmmac: dwmac-sun8i: Enable control of loopback
Jose Abreu (13):
net: stmmac: Add MAC loopback callback to HWIF
net: stmmac: dwmac100: Add MAC loopback support
net: stmmac: dwmac1000: Add MAC loopback support
net: stmmac: dwmac4/5: Add MAC loopback support
net: stmmac: dwxgmac2: Add MAC
XGMAC has a different MMC module. Lets use HWIF callbacks for MMC module
so that correct callbacks are automatically selected.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac
In order for hash filter to work we need to set the HPF bit.
Found out while running stmmac selftests.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 1
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.
Pass this type of frames while in promiscuous mode.
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Cc: Corentin Labbe
From: Corentin Labbe
Date: Wed, May 15, 2019 at 18:29:22
> I will try to investigate the MMC failure. Does -1 (vs other -E) is the
> right error code to return from the driver ?
Thank you for testing!
Yes, I will fix to return a valid error code.
As per MMC failure this can be due to your
Hi,
Two improvements for stmmac: First one corrects the available fifo size per
queue, second one corrects enabling of AVB queues. More info in commit log.
Best regards,
Jose Miguel Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (2):
net
ields.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/common.h | 3 ++-
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 15 +--
drivers/net/ethernet/stmicro/stmmac/stmmac_m
Flow control must be disabled for AVB enabled queues and TX
AVB queues must be enabled by setting BIT(2) of TXQEN.
Correct this by passing the queue mode to DMA callbacks
and by checking in these functions wether we are in AVB
performing the necessary adjustments.
Signed-off-by: Jose Abreu
Cc
typo in second patch
Jose Abreu (2):
net: stmmac: Use correct values in TQS/RQS fields
net: stmmac: Disable flow ctrl for RX AVB queues and really enable TX
AVB queues
drivers/net/ethernet/stmicro/stmmac/common.h | 5 +--
drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 2
Flow control must be disabled for AVB enabled queues and TX
AVB queues must be enabled by setting BIT(2) of TXQEN.
Correct this by passing the queue mode to DMA callbacks
and by checking in these functions wether we are in AVB
performing the necessary adjustments.
Signed-off-by: Jose Abreu
Cc
ields.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/common.h | 3 ++-
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 15 +--
drivers/net/ethernet/stmicro/stmmac/stmmac_m
This adds support for CBS reconfiguration using the TC application.
A new callback was added to TC ops struct and another one to DMA ops to
reconfigure the channel mode.
Tested in GMAC5.10.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 12
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 2 ++
drivers/net/ethernet/stmicro/stmmac/hwif.h
David,
On 27-06-2018 15:03, Jose Abreu wrote:
> This is clearly a bug.
You will probably have an hard time backporting this because of
the way the callbacks are handled now.
I can send you a patch based on some -stable branch if you prefer.
Thanks and Best Regards,
Jose Miguel Abreu
++ SH Maintainers
++ SH ML
Hi SH Maintainers,
On 27-06-2018 15:15, kbuild test robot wrote:
> Hi Jose,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_0day-2Dci_lin
++ LKML because I just noticed this is using generic headers.
On 27-06-2018 15:32, Jose Abreu wrote:
> ++ SH Maintainers
> ++ SH ML
>
> Hi SH Maintainers,
>
> On 27-06-2018 15:15, kbuild test robot wrote:
>> Hi Jose,
>>
>> I love your patch! Perhaps somethin
Hi Geert,
On 27-06-2018 15:36, Geert Uytterhoeven wrote:
> Hi Jose,
>
> On Wed, Jun 27, 2018 at 4:32 PM Jose Abreu wrote:
>> ++ SH Maintainers
>> ++ SH ML
>>
>> Hi SH Maintainers,
>>
>> On 27-06-2018 15:15, kbuild test robot wrote:
>>> Hi
This adds support for CBS reconfiguration using the TC application.
A new callback was added to TC ops struct and another one to DMA ops to
reconfigure the channel mode.
Tested in GMAC5.10.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Vitor Soares
Cc: Giuseppe Cavallaro
Hi Niklas,
On 08-03-2018 10:30, Niklas Cassel wrote:
> These wmb() memory barriers are performed after the last descriptor write,
> and they are followed by enable_dma_transmission()/set_tx_tail_ptr(),
> i.e. a writel() to MMIO register space.
> Since writel() itself performs the equivalent of a w
1 - 100 of 358 matches
Mail list logo
