Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

Hi Jakub, On 17/01/2021 01:46, Jakub Kicinski wrote: On Sat, 9 Jan 2021 23:00:21 -0800 Pravin B Shelar wrote: Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using fl

Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

IFLA_GTP_FD1 to optional param for LWT dev. v1-v2: - Fixed according to comments from Jonas Bonn drivers/net/gtp.c | 527 + include/uapi/linux/gtp.h | 12 + include/uapi/linux/if_link.h | 1 + include/uapi/linux/if_tunnel.h | 1

Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

Hi Jakub, On 18/01/2021 18:27, Jakub Kicinski wrote: On Sun, 17 Jan 2021 14:23:52 +0100 Jonas Bonn wrote: On 17/01/2021 01:46, Jakub Kicinski wrote: On Sat, 9 Jan 2021 23:00:21 -0800 Pravin B Shelar wrote: Following patch add support for flow based tunneling API to send and recv GTP tunnel

[PATCH net-next v2 01/12] gtp: set initial MTU

: Jonas Bonn --- drivers/net/gtp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4c04e271f184..5a048f050a9c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -612,11 +612,16 @@ static const struct net_device_ops

[PATCH net-next v2 00/12] gtp: IPv6 support

comment from Jeremy Sowden on patch 2/5 Jonas Bonn (12): gtp: set initial MTU gtp: include role in link info gtp: really check namespaces before xmit gtp: drop unnecessary call to skb_dst_drop gtp: set device type gtp: rework IPv4 functionality gtp: use ephemeral source port gtp: set

[PATCH net-next v2 02/12] gtp: include role in link info

Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH net-next v2 03/12] gtp: really check namespaces before xmit

Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index

[PATCH net-next v2 05/12] gtp: set device type

Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 04d9de385549..a1bb02818977 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c

[PATCH net-next v2 07/12] gtp: use ephemeral source port

to help balancing the load in the transport network." Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4a3a52970856..236ebbcb37bf 100644 --- a/drivers/net/gtp.c +++ b/driv

[PATCH net-next v2 12/12] gtp: add dst_cache to tunnels

Destination caching on a per-tunnel basis is a performance win, so we enable this unconditionally for the module. Signed-off-by: Jonas Bonn --- drivers/net/Kconfig | 1 + drivers/net/gtp.c | 27 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/net/Kconfig b

[PATCH net-next v2 06/12] gtp: rework IPv4 functionality

This patch does some cleanup work in the IPv4 functionality to lay the groundwork for adding support for IPv6. The form of these changes is largely borrowed from the bareudp and geneve drivers, so there shouldn't be anything here that looks unnecessarily unfamiliar. Signed-off-by: Jonas

[PATCH net-next v2 09/12] gtp: support GRO

1.26 GBytes 1323848 KBytes/sec [ 5] 10.00-10.00 sec 384 KBytes 1113043 KBytes/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.00 sec 12.4 GBytes 1296036 KBytes/sec receiver Signed-off-by: Jonas Bonn

[PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e4e57c0552ee..04d9de385549 100644 --- a/drivers/net/gtp.c +++ b/drivers/net

[PATCH net-next v2 10/12] gtp: add IPv6 support

support for configuring the tunnels with IPv6 addresses. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 330 +- 1 file changed, 269 insertions(+), 61 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 86639fae8d45..4c902bffefa3 100644

[PATCH net-next v2 08/12] gtp: set dev features to enable GSO

Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 236ebbcb37bf..7bbeec173113 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -536,7 +536,11 @@ static int gtp_xmit_ip4

[PATCH net-next v2 11/12] gtp: netlink update for ipv6

This patch adds the netlink changes required to support IPv6. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c| 84 ++-- include/uapi/linux/gtp.h | 2 + 2 files changed, 65 insertions(+), 21 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net

Re: [PATCH net-next] GTP: add support for flow based tunneling API

Hi Pravin, On 11/12/2020 07:56, Pravin B Shelar wrote: Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. This is a big patch that would

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

Hi Pravin, On 12/12/2020 06:51, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: This patch adds support for handling IPv6. Both the GTP tunnel and the tunneled packets may be IPv6; as they constitute independent streams, both v4-over-v6 and v6-over-v4 are supported

Re: [PATCH net-next v2 08/12] gtp: set dev features to enable GSO

On 12/12/2020 06:31, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:28 AM Jonas Bonn wrote: Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 236ebbcb37bf..7bbeec173113

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

On 12/12/2020 06:35, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: /* Read the IP destination address and resolve the PDP context. @@ -527,6 +527,10 @@ static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev) return -EMSGSIZE

Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

On 12/12/2020 10:50, Harald Welte wrote: On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote: The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). I must be blind, can you please point out where exactly this happens? It's in skb_scrub_packet() which is c

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

Hi Harald, On 12/12/2020 11:07, Harald Welte wrote: Hi Jonas, On Fri, Dec 11, 2020 at 01:26:07PM +0100, Jonas Bonn wrote: From 3GPP TS 29.281: "...the UDP Source Port or the Flow Label field... should be set dynamically by the sending GTP-U entity to help balancing the load in the tran

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

tcn3-hacks/tree/ggsn_tests If I read your patch correctly On Fri, Dec 11, 2020 at 01:26:10PM +0100, Jonas Bonn wrote: - struct in_addr ms_addr_ip4; - struct in_addr peer_addr_ip4; + struct in6_addr ms_addr; + struct in6_addr peer_addr

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

t for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- Fixed according to comments from Jonas Bonn --- drivers/net/gtp.c

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

Hi Pravin, On 13/12/2020 20:32, Pravin Shelar wrote: On Sat, Dec 12, 2020 at 11:56 PM Jonas Bonn wrote: Hi Pravin, I've been thinking a bit about this and find it more and more interesting. Could you post a bit of information about the ip-route changes you'll make in order to s

[PATCH 1/1] bareudp: constify device_type declaration

device_type may be declared as const. Signed-off-by: Jonas Bonn --- drivers/net/bareudp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 28257bccec41..85ebd2b7e446 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net

[PATCH 3/5] gtp: really check namespaces before xmit

Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index

[PATCH 4/5] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e053f86f43f3..c19465458187 100644 --- a/drivers/net/gtp.c +++ b/drivers/net

[PATCH 5/5] gtp: set device type

Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index c19465458187..6de38e06588d 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c

[PATCH 1/5] gtp: set initial MTU

: Jonas Bonn --- drivers/net/gtp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4c04e271f184..5a048f050a9c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -612,11 +612,16 @@ static const struct net_device_ops

[PATCH 2/5] gtp: include role in link info

Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/driv

[RFC PATCH 07/16] gtp: rework IPv4 functionality

This patch does some cleanup work in the IPv4 functionality to lay the groundwork for adding support for IPv6. The form of these changes is largely borrowed from the bareudp and geneve drivers, so there shouldn't be anything here that looks unnecessarily unfamiliar. Signed-off-by: Jonas

[RFC PATCH 05/16] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e4e57c0552ee..04d9de385549 100644 --- a/drivers/net/gtp.c +++ b/drivers/net

[RFC PATCH 09/16] gtp: support GRO

1.26 GBytes 1323848 KBytes/sec [ 5] 10.00-10.00 sec 384 KBytes 1113043 KBytes/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate [ 5] 0.00-10.00 sec 12.4 GBytes 1296036 KBytes/sec receiver Signed-off-by: Jonas Bonn

[RFC PATCH 13/16] gtp: set skb protocol after pulling headers

Based on work by Pravin Shelar. Once the GTP headers have been the removed, the SKB protocol should be set to that of the inner packet. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c

[RFC PATCH 14/16] gtp: add support for flow based tunneling

required GTP tunnel parameters from the tunnel metadata instead of looking up a pre-configured PDP context. The tunnel metadata contains the necessary information for creating the GTP header. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 160 + include

[RFC PATCH 11/16] gtp: drop duplicated assignment

This assignment is already done a few line earlier. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index c42092bb505f..023d38b1098d 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -268,8 +268,6

[RFC PATCH 15/16] gtp: add ability to send GTP controls headers

From: Pravin B Shelar Please explain how this patch actually works... creation of the control header makes sense, but I don't understand how sending of a control header is actually triggered. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 43 +

[RFC PATCH 16/16] gtp: add netlink support for setting up flow based tunnels

From: Pravin B Shelar This adds the Netlink interface necessary to set up flow based tunnels. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c| 139 +++ include/uapi/linux/if_link.h | 1 + 2 files changed, 111 insertions(+), 29 deletions(-) diff

[RFC PATCH 12/16] gtp: update rx_length_errors for abnormally short packets

Based on work by Pravin Shelar. Update appropriate stats when packet transmission isn't possible. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 023d38b

[RFC PATCH 03/16] gtp: include role in link info

Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[RFC PATCH 02/16] gtp: set initial MTU

: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4c04e271f184..5a048f050a9c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -612,11 +612,16 @@ static

[RFC PATCH 01/16] Revert "GTP: add support for flow based tunneling API"

impedes other ongoing work with this driver This patch will be reworked into a series that aligns with other ongoing work and facilitates review. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 527 - include/uapi/linux/gtp.h | 12

[RFC PATCH 10/16] gtp: refactor check_ms back into version specific handlers

This is preparatory work for adding flow based tunneling work by Pravin Shelar. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index b20e17988bfa..c42092bb505f

[RFC PATCH 00/16] GTP: flow based

eeds a bit of explanation. This is still an RFC only because I'm not quite convinced that I'm done with this. I do want to get this onto the list quickly, though, since this has implications for the next merge window. So let's see if we can sort this out to everyone's satisfac

[RFC PATCH 08/16] gtp: set dev features to enable GSO

Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4a3a52970856..df2f227680eb 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -532,7 +532,11 @@ static int gtp_xmit_ip4

[RFC PATCH 06/16] gtp: set device type

Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 04d9de385549..a1bb02818977 100644 --- a/drivers/net/gtp.c +++

[RFC PATCH 04/16] gtp: really check namespaces before xmit

Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers

Re: [RFC PATCH 15/16] gtp: add ability to send GTP controls headers

eader would need to be added. It's not clear to me who sets up this metadata in the first place. Is that where OVS or eBPF come in? Can you give some pointers to how this works? Couple of comments below On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar Please expl

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

Hi Pravin, A couple more comments around the GTP_METADATA bits: On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar This patch adds support for flow based tunneling, allowing to send and receive GTP tunneled packets via the (lightweight) tunnel metadata mechanism. This would allow

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

Hi, On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar This patch adds support for flow based tunneling, allowing to send and receive GTP tunneled packets via the (lightweight) tunnel metadata mechanism. This would allow integration with OVS and eBPF using flow based tunneling APIs

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

Hi Pravin, On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar @@ -617,29 +686,84 @@ static void gtp_push_header(struct sk_buff *skb, struct pdp_ctx *pctx, static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev) { struct gtp_dev *gtp = netdev_priv(dev

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

Hi Pravin, I'm going to submit a new series without the GTP_METADATA bits. I think the whole "collect metadata" approach is fine, but the way GTP header information is passed through the tunnel via metadata needs a bit more thought. See below... On 23/01/2021 20:59, J

Re: [RFC PATCH 15/16] gtp: add ability to send GTP controls headers

Hi Jakub, On 01/02/2021 21:44, Jakub Kicinski wrote: On Sat, 30 Jan 2021 12:05:40 -0800 Pravin Shelar wrote: On Sat, Jan 30, 2021 at 10:44 AM Jakub Kicinski wrote: On Fri, 29 Jan 2021 22:59:06 -0800 Pravin Shelar wrote: On Fri, Jan 29, 2021 at 6:08 AM Jonas Bonn wrote: Following are the

[PATCH net-next 2/7] gtp: set initial MTU

: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4c04e271f184..5a048f050a9c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -612,11 +612,16 @@ static

[PATCH net-next 7/7] gtp: update rx_length_errors for abnormally short packets

Based on work by Pravin Shelar. Update appropriate stats when packet transmission isn't possible. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c

[PATCH net-next 6/7] gtp: set device type

Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 04d9de385549..a1bb02818977 100644 --- a/drivers/net/gtp.c +++

[PATCH net-next 0/7] GTP

ngs a bit before inclusion. /Jonas Jonas Bonn (7): Revert "GTP: add support for flow based tunneling API" gtp: set initial MTU gtp: include role in link info gtp: really check namespaces before xmit gtp: drop unnecessary call to skb_dst_drop gtp: set device type gtp: update

[PATCH net-next 3/7] gtp: include role in link info

Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH net-next 1/7] Revert "GTP: add support for flow based tunneling API"

eakage vii) most importantly, the patch contains a large amount of superfluous churn that impedes other ongoing work with this driver This patch will be reworked into a series that aligns with other ongoing work and facilitates review. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers

[PATCH net-next 5/7] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e4e57c0552ee..04d9de385549 100644 --- a/drivers/net

[PATCH net-next 4/7] gtp: really check namespaces before xmit

Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers

Re: [RFC PATCH 15/16] gtp: add ability to send GTP controls headers

On 02/02/2021 07:56, Pravin Shelar wrote: On Mon, Feb 1, 2021 at 9:24 PM Jonas Bonn wrote: Hi Jakub, On 01/02/2021 21:44, Jakub Kicinski wrote: On Sat, 30 Jan 2021 12:05:40 -0800 Pravin Shelar wrote: On Sat, Jan 30, 2021 at 10:44 AM Jakub Kicinski wrote: On Fri, 29 Jan 2021 22:59:06

[PATCH net-next v2 2/7] gtp: set initial MTU

: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4c04e271f184..5a048f050a9c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -612,11 +612,16 @@ static

[PATCH net-next v2 0/7] GTP

a bit before inclusion. Changes in v2: - fix fallout from "one rebase too many" /Jonas Jonas Bonn (7): Revert "GTP: add support for flow based tunneling API" gtp: set initial MTU gtp: include role in link info gtp: really check namespaces before xmit gtp: drop unnece

[PATCH net-next v2 3/7] gtp: include role in link info

Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH net-next v2 6/7] gtp: set device type

Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 04d9de385549..a1bb02818977 100644 --- a/drivers/net/gtp.c +++

[PATCH net-next v2 5/7] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e4e57c0552ee..04d9de385549 100644 --- a/drivers/net

[PATCH net-next v2 7/7] gtp: update rx_length_errors for abnormally short packets

Based on work by Pravin Shelar. Update appropriate stats when packet transmission isn't possible. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c

[PATCH net-next v2 1/7] Revert "GTP: add support for flow based tunneling API"

eakage vii) most importantly, the patch contains a large amount of superfluous churn that impedes other ongoing work with this driver This patch will be reworked into a series that aligns with other ongoing work and facilitates review. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers

[PATCH net-next v2 4/7] gtp: really check namespaces before xmit

Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn Acked-by: Harald Welte --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

not present; and make a decision on whether to allow packets into netstack without validating their IP address. On 23/01/2021 20:59, Jonas Bonn wrote: From: Pravin B Shelar This patch adds support for flow based tunneling, allowing to send and receive GTP tunneled packets via the (lig

Re: [PATCH 1/1] Address regression in inet6_validate_link_af

Hi Max, On 12/06/2019 12:42, Maxim Mikityanskiy wrote: On 2019-06-11 13:03, Jonas Bonn wrote: Patch 7dc2bccab0ee37ac28096b8fcdc390a679a15841 introduces a regression with systemd 241. In that revision, systemd-networkd fails to pass the required flags early enough. This appears to be

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

On 30/06/2020 21:14, Josh Hunt wrote: On 6/23/20 6:42 AM, Michael Zhivich wrote: From: Jonas Bonn To: Paolo Abeni , "netdev@vger.kernel.org" , LKML , "David S . Miller" , John Fastabend Subject: Re: Packet gets stuck in NOLOCK pfifo_fast qdisc Date: Fr

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

Hi Cong, On 01/07/2020 21:58, Cong Wang wrote: On Wed, Jul 1, 2020 at 9:05 AM Cong Wang wrote: On Tue, Jun 30, 2020 at 2:08 PM Josh Hunt wrote: Do either of you know if there's been any development on a fix for this issue? If not we can propose something. If you have a reproducer, I can l

Re: [PATCH v2 1/2] gtp: rename SGSN netlink attribute

On 03/21/2017 04:07 PM, Pablo Neira Ayuso wrote: On Tue, Mar 21, 2017 at 04:04:29PM +0100, Jonas Bonn wrote: diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h index 72a04a0..c51ebb0 100644 --- a/include/uapi/linux/gtp.h +++ b/include/uapi/linux/gtp.h @@ -19,7 +19,7 @@ enum

[PATCH v2 1/2] gtp: rename SGSN netlink attribute

naming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c| 22 +++--- include/uapi/linux/gtp.h | 3 ++- 2 files changed, 13 inserti

[PATCH v2 2/2] gtp: support SGSN-side tunnels

on time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c| 41 +++-- include/

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

Hi Harald, On 03/15/2017 05:39 PM, Harald Welte wrote: Hi Jonas, are you working on the review feedback that was provided back in early February? I think there were some comments like * remove unrelated cosmetic change in comment * change from FLAGS to a dedicated MODE netlink attribute * add

[PATCH net-next v3 0/2] GTP SGSN-side tunnels

Changes since v2: * Move #define of legacy netlink attribute into enum * Added note to commit message about load-testing use-case * Ack from Pablo Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 63

[PATCH net-next v3 1/2] gtp: rename SGSN netlink attribute

naming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso --- drivers/net/gtp.c| 22 +++--- include/uapi/linux/gtp.h | 3 ++- 2 fil

[PATCH net-next v3 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso --- drivers/net/g

Re: [PATCH net-next v3 0/2] GTP SGSN-side tunnels

Hi Harald, On 03/24/2017 11:15 AM, Harald Welte wrote: Hi Jonas, looks fine to me, but I haven't tested it. Did you manually test it using the extended libgtpnl + tools? I have tested it against your libgtpnl branch laforge/sgsn-role. Creating an interface with tools/gtp-link works fine.

[PATCH net-next v4 0/2] GTP SGSN-side tunnels

Changes from v3: * Coding style fixup: remove extraneous braces on if-statement * Ack from Harald Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 62 +--- include/uapi/linux/gtp.h

[PATCH net-next v4 1/2] gtp: rename SGSN netlink attribute

naming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso Acked-by: Harald Welte --- drivers/net/gtp.c| 22 +++--- include/uapi/l

[PATCH net-next v4 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso Acked-by: Harald Welte --- drivers/net/g

Re: [PATCH net-next v3 0/2] GTP SGSN-side tunnels

On 03/24/2017 11:41 AM, Pablo Neira Ayuso wrote: On Fri, Mar 24, 2017 at 10:33:56AM +0100, Jonas Bonn wrote: Changes since v2: * Move #define of legacy netlink attribute into enum * Added note to commit message about load-testing use-case * Ack from Pablo Thanks a lot Jonas! David, please

[PATCH net-next v5 1/2] gtp: rename SGSN netlink attribute

naming the parameter makes the relationship clearer. The legacy name is maintained as a define in the header file in order to not break existing code. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso Acked-by: Harald Welte --- drivers/net/gtp.c| 22 +++--- include/uapi/l

[PATCH net-next v5 0/2] GTP SGSN-side tunnel

Changes since v4: * Respin the series on top of net-next; the conflicts were trivial, amounting to just code having been shifted about Jonas Bonn (2): gtp: rename SGSN netlink attribute gtp: support SGSN-side tunnels drivers/net/gtp.c| 64

[PATCH net-next v5 2/2] gtp: support SGSN-side tunnels

at GTP-link creation time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn Acked-by: Pablo Neira Ayuso Acked-by: Harald Welte --- drivers/net/g

[PATCH 1/1] gtp: support SGSN-side tunnels

on time to specify whether we are on the GGSN or SGSN side of the tunnel; this flag is then used to determine which part of the IP packet to use in determining the PDP context. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c| 43 --- include/

Re: [PATCH 1/1] gtp: support SGSN-side tunnels

Hi Pablo, On 02/06/2017 12:08 PM, Pablo Neira Ayuso wrote: Hi Jonas, On Fri, Feb 03, 2017 at 10:12:31AM +0100, Jonas Bonn wrote: The GTP-tunnel driver is explicitly GGSN-side as it searches for PDP contexts based on the incoming packets _destination_ address. If we want to write an SGSN

[PATCH] [SIS190] Constify data marked as __devinitdata

This fixes build error as gcc complains about a "section type conflict" due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..e4

[PATCH] [SIS190] Use _devinitconst for const data

This fixes build error as gcc complains about a "section type conflict" due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..f84

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

instead? Because AFAIK, const *and* __sectionmarker does not mix. > You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To unsubscribe

[PATCH] [SIS190] Use __devinitconst for const devinit data

Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc "section type mismatch" build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c index 20890e4..eedcbeb 100644 --- a/drivers/net/sk98lin/skge.c +++ b/drivers/net/s

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]> --- drivers/net/starfire.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index c49214f..a67bac5 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]> --- drivers/net/skfp/skfddi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c index 7cf9b9f..2a8386b 100644 --- a/drivers/net/skfp/skfddi.c +++ b/drivers/net/skfp/sk

[PATCH] [net] use PCI_DEVICE_TABLE: makes struct pci_device_id array const and adds section attribute __devinitconst

Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]> --- drivers/net/wan/dscc4.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c index c6f26e2..16d3a4c 100644 --- a/drivers/net/wan/dscc4.c +++ b/drivers/net/wan/d

  1   2   >