[PATCH 5.1 01/40] bonding/802.3ad: fix slave link initialization transition states

2019-06-03 Thread Greg Kroah-Hartman
Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: netdev@vger.kernel.org Tested-by: Heesoon Kim Signed-off-by: Jarod Wilson Acked-by: Jay Vosburgh Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_main.c | 15 ++

Re: [PATCH net-next 01/16] qlge: Remove irq_cnt

2019-07-15 Thread Greg Kroah-Hartman
On Mon, Jul 15, 2019 at 10:40:16AM +0900, Benjamin Poirier wrote: > On 2019/06/17 16:48, Benjamin Poirier wrote: > > qlge uses an irq enable/disable refcounting scheme that is: > > * poorly implemented > > Uses a spin_lock to protect accesses to the irq_cnt atomic variable > > * buggy > > B

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > > > Errors: > >

[PATCH 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/marvell/mvpp2/mvpp2_debugfs.c| 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debug

[PATCH 14/17] fm10k: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c index dca104121c05..1d27b2fb23af 100644 --- a/drivers/ne

[PATCH 15/17] i40e: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/i40e/i40e_debugfs.c| 21 --- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..0d

[PATCH 00/17] Networking driver debugfs cleanups

2019-08-06 Thread Greg Kroah-Hartman
anted, I can take them through my driver-core tree where other debugfs cleanups are being slowly fed during major merge windows. thanks, greg k-h Greg Kroah-Hartman (17): wimax: no need to check return value of debugfs_create functions bonding: no need to print a message if debugfs_creat

[PATCH 10/17] dpaa2: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Ioana Radulescu Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../freescale/dpaa2/dpaa2-eth-debugfs.c | 54 +++ .../freescale/dpaa2/dpaa2-eth-debugfs.h | 3 -- 2 f

[PATCH 11/17] qca: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qualcomm/qca_debug.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index bcb890b18a94..702aa217a27a 100644 ---

[PATCH 12/17] skge: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
f-by: Greg Kroah-Hartman --- drivers/net/ethernet/marvell/skge.c | 39 +++-- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 06dffee81e02..0a2ec387a482 100644 --- a/drivers/ne

[PATCH 16/17] ixgbe: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +-- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c index 50dfb02fa34c..17

[PATCH 02/17] bonding: no need to print a message if debugfs_create_dir() fails

2019-08-06 Thread Greg Kroah-Hartman
darek Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_debugfs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c index 1360f1ffe070..f3f86ef68a

[PATCH 05/17] bnxt: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
easier to understand. Cc: Michael Chan Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - .../net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 39 ++- 2 files changed, 11 insertions(+), 29

[PATCH 06/17] cxgb4: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
also print a message, so that is one more reason to not care about checking the return values. Cc: Vishal Kulkarni Cc: "David S. Miller" Cc: Casey Leedom Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 5 ++--- .../net/e

[PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
Cc: linux-w...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/adf7242.c | 12 +++- drivers/net/ieee802154/at86rf230.c | 20 +--- drivers/net/ieee802154/ca8210.c| 9 + 3 files changed, 9 inserti

[PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
easier to understand as we don't need to keep the dentries saved anymore. Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 51 ++--- .../net/ethernet/mellanox/mlx5/core/debugfs.c

[PATCH 04/17] xgbe: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
easier to understand. Cc: Tom Lendacky Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++- 1 file changed, 31 insertions(+), 76 deletions(-) diff --git a/drivers/net/ethernet/amd

[PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
ard Brouer Cc: John Fastabend Cc: Edwin Peer Cc: Yangtao Li Cc: Simon Horman Cc: oss-driv...@netronome.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/netronome/nfp/nfp_net_debugfs.c| 17 + 1 file changed, 1 insertion(+), 16 deletions(-)

[PATCH 07/17] hns3: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Yisen Zhuang Cc: Salil Mehta Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by:

[PATCH 09/17] stmmac: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/

[PATCH 01/17] wimax: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
easier to understand. Cc: Inaky Perez-Gonzalez Cc: linux-wi...@intel.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/wimax/i2400m/debugfs.c | 149 + drivers/net/wimax/i2400m/driver.c | 7 +- drivers/net/wimax/i2400m/i2400m.h | 7

Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 09:50:08AM -0700, Jakub Kicinski wrote: > On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > &g

Re: [PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 09:22:43PM +0200, Stefan Schmidt wrote: > Hello. > > On 06.08.19 18:11, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should &

[PATCH v2 01/17] wimax: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
easier to understand. Cc: Inaky Perez-Gonzalez Cc: linux-wi...@intel.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/wimax/i2400m/debugfs.c | 149 + drivers/net/wimax/i2400m/driver.c | 7 +- drivers/net/wimax/i2400m/i2400m.h | 7

[PATCH v2 00/17] Networking driver debugfs cleanups

2019-08-09 Thread Greg Kroah-Hartman
top relying on 0-day as it isn't working well anymore :( Greg Kroah-Hartman (17): wimax: no need to check return value of debugfs_create functions bonding: no need to print a message if debugfs_create_dir() fails mlx5: no need to check return value of debugfs_create functions xg

[PATCH v2 02/17] bonding: no need to print a message if debugfs_create_dir() fails

2019-08-09 Thread Greg Kroah-Hartman
darek Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_debugfs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c index 1360f1ffe070..f3f86ef68a

[PATCH v2 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
easier to understand as we don't need to keep the dentries saved anymore. Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 51 ++--- .../net/ethernet/mellanox/mlx5/core/debugfs.c

[PATCH v2 14/17] fm10k: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c index dca104121c05..1d27b2fb23af 100644 --- a/drivers/ne

[PATCH v2 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
kernel.org Cc: netdev@vger.kernel.org Acked-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/adf7242.c | 13 +++-- drivers/net/ieee802154/at86rf230.c | 20 +--- drivers/net/ieee802154/ca8210.c| 9 + 3 files changed, 9 inserti

[PATCH v2 12/17] skge: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
f-by: Greg Kroah-Hartman --- drivers/net/ethernet/marvell/skge.c | 39 +++-- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 06dffee81e02..0a2ec387a482 100644 --- a/drivers/ne

[PATCH v2 15/17] i40e: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/i40e/i40e_debugfs.c| 22 --- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..41

[PATCH v2 04/17] xgbe: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
easier to understand. Cc: Tom Lendacky Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++- 1 file changed, 31 insertions(+), 76 deletions(-) diff --git a/drivers/net/ethernet/amd

[PATCH v2 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
ard Brouer Cc: John Fastabend Cc: Edwin Peer Cc: Yangtao Li Cc: Simon Horman Cc: oss-driv...@netronome.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/netronome/nfp/nfp_net_debugfs.c| 17 + 1 file changed, 1 insertion(+), 16 deletions(-)

[PATCH v2 16/17] ixgbe: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +-- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c index 50dfb02fa34c..17

[PATCH v2 09/17] stmmac: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/

[PATCH v2 10/17] dpaa2: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Ioana Radulescu Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../freescale/dpaa2/dpaa2-eth-debugfs.c | 54 +++ .../freescale/dpaa2/dpaa2-eth-debugfs.h | 3 -- 2 f

[PATCH v2 11/17] qca: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qualcomm/qca_debug.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index bcb890b18a94..702aa217a27a 100644 ---

[PATCH v2 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/marvell/mvpp2/mvpp2_debugfs.c| 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debug

[PATCH v2 07/17] hns3: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Yisen Zhuang Cc: Salil Mehta Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by:

[PATCH v2 05/17] bnxt: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
easier to understand. Cc: Michael Chan Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - .../net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 39 ++- 2 files changed, 11 insertions(+), 29

[PATCH v2 06/17] cxgb4: no need to check return value of debugfs_create functions

2019-08-09 Thread Greg Kroah-Hartman
also print a message, so that is one more reason to not care about checking the return values. Cc: Vishal Kulkarni Cc: "David S. Miller" Cc: Casey Leedom Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 5 ++--- .../net/e

[PATCH v3 14/17] fm10k: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c index dca104121c05..1d27b2fb23af 100644 --- a/drivers/ne

[PATCH v3 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/marvell/mvpp2/mvpp2_debugfs.c| 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debug

[PATCH v3 12/17] skge: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
f-by: Greg Kroah-Hartman --- drivers/net/ethernet/marvell/skge.c | 39 +++-- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 06dffee81e02..0a2ec387a482 100644 --- a/drivers/ne

[PATCH v3 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Cc: netdev@vger.kernel.org Acked-by: Stefan Schmidt Acked-by: Michael Hennerich Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/adf7242.c | 13 +++-- drivers/net/ieee802154/at86rf230.c | 20 +--- drivers/net/ieee802154/ca8210.c| 9 + 3 files changed, 9

[PATCH v3 11/17] qca: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qualcomm/qca_debug.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index bcb890b18a94..702aa217a27a 100644 ---

[PATCH v3 00/17] Networking driver debugfs cleanups

2019-08-10 Thread Greg Kroah-Hartman
never even built these. Ugh, so sorry for wasting people's time with the v1 series. I need to stop relying on 0-day as it isn't working well anymore :( Greg Kroah-Hartman (17): wimax: no need to check return value of debugfs_create functions bonding: no need t

[PATCH v3 01/17] wimax: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
easier to understand. Cc: Inaky Perez-Gonzalez Cc: linux-wi...@intel.com Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/wimax/i2400m/debugfs.c | 150 + drivers/net/wimax/i2400m/driver.c | 7 +- drivers/net/wimax/i2400m/i2400m.h | 7

[PATCH v3 15/17] i40e: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/i40e/i40e_debugfs.c| 22 --- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..41

[PATCH v3 10/17] dpaa2: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Ioana Radulescu Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../freescale/dpaa2/dpaa2-eth-debugfs.c | 54 +++ .../freescale/dpaa2/dpaa2-eth-debugfs.h | 3 -- 2 f

[PATCH v3 16/17] ixgbe: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +-- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c index 50dfb02fa34c..17

[PATCH v3 02/17] bonding: no need to print a message if debugfs_create_dir() fails

2019-08-10 Thread Greg Kroah-Hartman
darek Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_debugfs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c index 1360f1ffe070..f3f86ef68a

[PATCH v3 09/17] stmmac: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
e not needed to be kept track of at all. Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: netdev@vger.kernel.org Cc: linux-st...@st-md-mailman.stormreply.com Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/

[PATCH v3 06/17] cxgb4: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
also print a message, so that is one more reason to not care about checking the return values. Cc: Vishal Kulkarni Cc: "David S. Miller" Cc: Casey Leedom Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 5 ++--- .../net/e

[PATCH v3 07/17] hns3: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Yisen Zhuang Cc: Salil Mehta Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by:

[PATCH v3 04/17] xgbe: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
easier to understand. Cc: Tom Lendacky Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++- 1 file changed, 31 insertions(+), 76 deletions(-) diff --git a/drivers/net/ethernet/amd

[PATCH v3 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
easier to understand as we don't need to keep the dentries saved anymore. Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 51 ++--- .../net/ethernet/mellanox/mlx5/core/debugfs.c

[PATCH v3 05/17] bnxt: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
easier to understand. Cc: Michael Chan Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - .../net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 39 ++- 2 files changed, 11 insertions(+), 29

[PATCH v3 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Fastabend Cc: Edwin Peer Cc: Yangtao Li Cc: Simon Horman Cc: oss-driv...@netronome.com Cc: netdev@vger.kernel.org Acked-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- .../ethernet/netronome/nfp/nfp_net_debugfs.c| 17 + 1 file changed, 1 insertion(+), 16 deletion

[PATCH] xen-netback: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
Kroah-Hartman --- drivers/net/xen-netback/netback.c | 3 -- drivers/net/xen-netback/xenbus.c | 46 --- 2 files changed, 11 insertions(+), 38 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 1d9940d4e8c7

[PATCH] caif: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Richard Fontana Cc: Steve Winslow Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers

Re: [PATCH v3 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 10:55:51AM -0700, Nick Desaulniers wrote: > On Sat, Aug 10, 2019 at 3:17 AM Greg Kroah-Hartman > wrote: > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code l

Re: [PATCH v3 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 12:44:36PM -0700, Nick Desaulniers wrote: > On Mon, Aug 12, 2019 at 12:01 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Aug 12, 2019 at 10:55:51AM -0700, Nick Desaulniers wrote: > > > On Sat, Aug 10, 2019 at 3:17 AM Greg Kroah-Hartman > &g

Re: [PATCH net-next 1/1] stmmac: intel: change all EHL/TGL to auto detect phy addr

2021-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 16, 2021 at 04:59:14PM -0800, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 10:12:21 +0100 Jan Kiszka wrote: > > On 06.11.20 10:43, Wong Vee Khee wrote: > > > From: Voon Weifeng > > > > > > Set all EHL/TGL phy_addr to -1 so that the driver will automatically > > > detect it at run-time

[PATCH 5.9 032/105] vdpa: mlx5: fix vdpa/vhost dependencies

2020-12-14 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 98701a2a861fa87a5055cf2809758e8725e8b146 ] drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST_IOTLB to make them be built. However, if VHOST_IOTLB is the only VHOST symbol that is set/enabled, the object file still won't be built because driv

[PATCH 5.9 031/105] net: broadcom CNIC: requires MMU

2020-12-14 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 14483cbf040fcb38113497161088a1ce8ce5d713 ] The CNIC kconfig symbol selects UIO and UIO depends on MMU. Since 'select' does not follow dependency chains, add the same MMU dependency to CNIC. Quietens this kconfig warning: WARNING: unmet direct dependencies d

Re: [PATCH v18 0/3] userspace MHI client interface driver

2020-12-16 Thread Greg Kroah-Hartman
On Wed, Dec 16, 2020 at 10:17:30AM +0100, Loic Poulain wrote: > Hi Folks, > > On Fri, 11 Dec 2020 at 20:45, Hemant Kumar wrote: > > > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem. UCI driver probe > > c

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

2020-12-22 Thread Greg Kroah-Hartman
On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote: > Jerome Pouiller writes: > > > +/* > > + * Internal helpers. > > + * > > + * About CONFIG_VMAP_STACK: > > + * When CONFIG_VMAP_STACK is enabled, it is not possible to run DMA on > > stack > > + * allocated data. Functions below that wo

Re: [PATCH AUTOSEL 5.4 008/130] staging: wimax: depends on NET

2020-12-22 Thread Greg Kroah-Hartman
tif_carrier_on' > ld: stack.c:(.text+0x478): undefined reference to `netif_tx_wake_queue' > ld: drivers/staging/wimax/stack.o: in function `wimax_subsys_exit': > stack.c:(.exit.text+0xe): undefined reference to `genl_unregister_family' > ld: drivers/staging/wimax/stack.o:

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

2020-12-23 Thread Greg Kroah-Hartman
On Wed, Dec 23, 2020 at 09:01:33AM +0100, Jérôme Pouiller wrote: > On Tuesday 22 December 2020 16:27:01 CET Greg Kroah-Hartman wrote: > > On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote: > > > Jerome Pouiller writes: > > > > > >

[PATCH 5.4 04/98] netfilter: clear skb->next in NF_HOOK_LIST()

2020-12-01 Thread Greg Kroah-Hartman
en 4.19 and 5.4 Signed-off-by: Cong Wang Signed-off-by: Greg Kroah-Hartman --- include/linux/netfilter.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/netfilter.h +++ b/include/linux/netfilter.h @@ -316,7 +316,7 @@ NF_HOOK_LIST(uint8_t pf, unsigned int ho

[PATCH 4.19 02/57] netfilter: clear skb->next in NF_HOOK_LIST()

2020-12-01 Thread Greg Kroah-Hartman
en 4.19 and 5.4 Signed-off-by: Cong Wang Signed-off-by: Greg Kroah-Hartman --- include/linux/netfilter.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/netfilter.h +++ b/include/linux/netfilter.h @@ -300,7 +300,7 @@ NF_HOOK_LIST(uint8_t pf, unsigned int ho

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-09 Thread Greg Kroah-Hartman
esponse:. > > > > > > > > >pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman > > > napisał(a): > > >> > > >> On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > > >> > Hi Greg and Sasha, > > >> > > >

Re: [PATCHv2] bonding: wait for sysfs kobject destruction before freeing struct slave

2020-11-18 Thread Greg Kroah-Hartman
On Tue, Nov 17, 2020 at 12:34:01PM -0800, Jakub Kicinski wrote: > On Fri, 13 Nov 2020 17:12:44 + Jamie Iles wrote: > > syzkaller found that with CONFIG_DEBUG_KOBJECT_RELEASE=y, releasing a > > struct slave device could result in the following splat: > > > This is a potential use-after-free if

Re: [PATCH 5.9 000/255] 5.9.9-rc1 review

2020-11-19 Thread Greg Kroah-Hartman
On Wed, Nov 18, 2020 at 11:03:55AM +0530, Naresh Kamboju wrote: > On Tue, 17 Nov 2020 at 19:02, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 5.9.9 release. > > There are 255 patches in this series, all will be posted as a respo

Re: [PATCHv3] bonding: wait for sysfs kobject destruction before freeing struct slave

2020-11-20 Thread Greg Kroah-Hartman
4/kernel/entry.S:925 > > This is a potential use-after-free if the sysfs nodes are being accessed > whilst removing the struct slave, so wait for the object destruction to > complete before freeing the struct slave itself. > > Fixes: 07699f9a7c8d ("bonding: add sysfs /slave di

Re: [PATCH v12 1/5] bus: mhi: core: Add helper API to return number of free TREs

2020-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 28, 2020 at 11:59:46AM +0530, Manivannan Sadhasivam wrote: > On Wed, Nov 18, 2020 at 10:32:45AM +0100, Loic Poulain wrote: > > On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote: > > > > > > Introduce mhi_get_free_desc_count() API to return number > > > of TREs available to queue buffer.

Re: [Patch stable] netfilter: clear skb->next in NF_HOOK_LIST()

2020-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 28, 2020 at 05:09:18PM +0800, 刘志旭 wrote: > I still didn't see this patch in stable queue yet. Since we've a working POC > to panic the  > system (see https://bugzilla.kernel.org/show_bug.cgi?id=209823), I think it's > necessary > to merge this patch ASAP, thanks. Odd, I don't think S

Re: [PATCH v2 00/10] thunderbolt: Add DMA traffic test driver

2020-11-10 Thread Greg Kroah-Hartman
4140030.6853-1-mika.westerb...@linux.intel.com/ > > Changes from the previous version: > > * Fix resource leak in tb_xdp_handle_request() (patch 2/10) > * Use debugfs_remove_recursive() in tb_service_debugfs_remove() (patch 6/10) > * Add tags from Yehezkel Reviewed-by: Greg Kroah-Hartman

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Greg Kroah-Hartman
Ulf Hansson > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Sebastian Reichel > Cc: Ohad Ben-Cohen > Cc: Bjorn Andersson > Cc: Greg Kroah-Hartman > Signed-off-by: Rob Herring > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml >

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Greg Kroah-Hartman
On Tue, Jan 05, 2021 at 10:40:08AM -0700, Rob Herring wrote: > On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > > DT properties which can have multiple entries need to specify what the >

[PATCH 4.4 12/38] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

[PATCH 4.14 23/57] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

[PATCH 5.10 035/145] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

[PATCH 5.4 34/92] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

[PATCH 4.19 35/77] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

[PATCH 4.9 15/45] net: sched: prevent invalid Scell_log shift count

2021-01-11 Thread Greg Kroah-Hartman
Wang Cc: Jiri Pirko Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- include/net/red.h |4 +++- net/sched/sch_choke.c |2 +- net/sched/sch_gred.c |2 +- net/sched/sch_red.c

Re: [PATCH AUTOSEL 5.10 23/51] CDC-NCM: remove "connected" log message

2021-01-12 Thread Greg Kroah-Hartman
> > messages every 60 msec or so. > > Signed-off-by: Roland Dreier > Reviewed-by: Greg Kroah-Hartman > Link: https://lore.kernel.org/r/20201224032116.2453938-1-rol...@kernel.org > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin > --- > drivers/net/usb/cd

Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-25 Thread Greg Kroah-Hartman
On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit mo

[PATCH 5.9 457/757] perf metricgroup: Fix uncore metric expressions

2020-10-27 Thread Greg Kroah-Hartman
From: Ian Rogers [ Upstream commit dcc81be0fc4e66943041e6e19a5faf8f8704a27e ] A metric like DRAM_BW_Use has on SkylakeX events uncore_imc/cas_count_read/ and uncore_imc/case_count_write/. These events open 6 events per socket with pmu names of uncore_imc_[0-5]. The current metric setup code in

Re: [RFC] wimax: move out to staging

2020-10-28 Thread Greg Kroah-Hartman
take through the staging tree? If so, I need an ack from the networking maintainers. If not, feel free to send it through the networking tree and add: Acked-by: Greg Kroah-Hartman

Re: [PATCH v2 20/39] docs: ABI: testing: make the files compatible with ReST output

2020-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2020 at 12:04:36PM +0100, Fabrice Gasnier wrote: > On 10/30/20 11:09 AM, Mauro Carvalho Chehab wrote: > > Em Fri, 30 Oct 2020 10:19:12 +0100 > > Fabrice Gasnier escreveu: > > > >> Hi Mauro, > >> > >> [...] > >> > >>> > >>> +What: > >>> /sys/bus/iio/devices/iio:device

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > Hi Greg and Sasha, > > pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > > > Hi, > > > > sob., 20 cze 2020 o 11:21 Russell King > > napisał(a): > > > > > > Add a helper to convert the struct phylink_config pointer passed in >

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote: > On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote: > > Jakub Kicinski > > > Can you describe the use case in more detail? > > > > > > AFAICT r8152 defines a match for the exact same device. > > > Does it not mean that which driver

Re: [RFC PATCH bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 05, 2020 at 08:39:25AM -0800, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 20:51:39 -0800 Andrii Nakryiko wrote: > > Add kernel module listener that will load/validate and unload module BTF. > > Module BTFs gets ID generated for them, which makes it possible to iterate > > them with exist

Re: [PATCH bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 05, 2020 at 09:51:09PM -0800, Andrii Nakryiko wrote: > Add kernel module listener that will load/validate and unload module BTF. > Module BTFs gets ID generated for them, which makes it possible to iterate > them with existing BTF iteration API. They are given their respective module's

Re: [PATCH v2 bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-07 Thread Greg Kroah-Hartman
ernel/bpf/btf.c | 194 + > kernel/bpf/sysfs_btf.c | 2 +- > kernel/module.c | 32 > 6 files changed, 241 insertions(+), 1 deletion(-) Reviewed-by: Greg Kroah-Hartman

Re: [PATCH v2 0/2] of: of_device.h cleanups

2021-02-11 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 05:27:43PM -0600, Rob Herring wrote: > This is a couple of cleanups for of_device.h. They fell out from my > attempt at decoupling of_device.h and of_platform.h which is a mess > and I haven't finished, but there's no reason to wait on these. Revi

Re: [PATCH] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 03:18:49PM +0800, Du Cheng wrote: > align * in block comments on each line > > Signed-off-by: Du Cheng > --- > drivers/staging/qlge/qlge_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_main.c > b/drivers/staging/

Re: [PATCH v2] fix coding style in driver/staging/qlge/qlge_main.c

2021-02-15 Thread Greg Kroah-Hartman
ean(qdev); > > - /* Call netif_napi_del() from common point. > - */ > + /* Call netif_napi_del() from common point. */ > for (i = 0; i < qdev->rss_ring_count; i++) > netif_napi_del(&qdev->rx_ring[i].napi); > > -- > 2.27.0 >

  1   2   3   4   5   >