Hi,
any comment?
regards Frank
> Gesendet: Mittwoch, 31. März 2021 um 15:34 Uhr
> Von: "Frank Wunderlich"
> Betreff: [PATCH][net-next] net: mediatek: add flow offload for mt7623
>
> mt7623 uses offload version 2 too
>
> tested on Bananapi-R2
quot;net: ethernet: mtk_eth_soc: add flow offloading
>support")
>Reported-by: Frank Wunderlich
>Signed-off-by: Pablo Neira Ayuso
Hi Pablo,
As far we tested it, the mutex does not avoid the hang. It looks a bit
better,but at the end it was fixed by this Patch
https:/
mt7623 uses offload version 2 too
tested on Bananapi-R2
Signed-off-by: Frank Wunderlich
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index
Am 12. April 2021 17:30:58 MESZ schrieb DENG Qingfang :
>So we somehow configured default CPU port in dts (by port name). In
>my opinion we can just add a default CPU property in dts to specify
>it (like Frank Wunderlich did earlier), and fall back to round-robin
>if the property is
Am 15. April 2021 11:40:05 MESZ schrieb DENG Qingfang :
>.key_offset was assigned to .head_offset instead. Fix the typo.
>
>Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
>support")
>Signed-off-by: DENG Qingfang
Thanks for posting the fix,but imho commit-message is not good
Tested on Bananapi-r2 (please see my mt7623 patch for supporting offloading)
with ~300 iperf3 iterations and uptime >6h
Tested-by: Frank Wunderlich
regards Frank
From: Frank Wunderlich
commit 2019554f9656 introduces implementation of icmp{,v6}_ndo_send in
include/linux/icmp{,v6}.h in case of NF_NAT is enabled. Now these
functions are defined twice in wireguard. Fix this by hiding code if
NF_NAT is set (reverse condition as in icmp*.h)
././net/wireguard
Hi,
sorry, please ignore this
wireguard was included with 5.6, my 5.4 uses external wireguard
regards Frank
Hi René,Ilya
> Gesendet: Freitag, 19. März 2021 um 11:25 Uhr
> Von: "René van Dorst"
> Hi Ilya,
>
> Thanks for fixing this issue.
>
> I remember that Frank also had an issue with TRGMII on his MT7623 ARM board.
> I never found why it did not work but this may be also fix his issue
> on the MT
From: Frank Wunderlich
Extending functionality of recently sent nftables flow offload.
This Series contains 2 Patches where the second is for RFC, because i cannot
test it,
but it is reported by author as working and i should send it
Series depend on HW offload Patches:
https
From: Frank Wunderlich
adding ipv6 hardware offload support
patch by user graphine (https://github.com/graphine27/)
http://forum.banana-pi.org/u/graphine/summary
Signed-off-by: Frank Wunderlich
---
.../net/ethernet/mediatek/mtk_ppe_offload.c | 55 +++
1 file changed, 55
From: Frank Wunderlich
mt7623 uses offload version 2 too
tested on Bananapi-R2
Signed-off-by: Frank Wunderlich
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek
Just a little typo you've inherited from existing code
>+/* Setup TX circuit incluing relevant PAD and driving */
including
regards Frank
Tested full series on Bananapi-R2+R64 with5.9-rc1 (iperf3 no retransmitts,
Throughput >900Mbit/s)
Tested-By: Frank Wunderlich
maybe you can include the port_change_mtu callback you've send me? or do you
want to send it separately
regards Frank
Tested on Bananapi R2 (mt7623)
Tested-by: "Frank Wunderlich"
Am 20. Juni 2019 14:21:53 MESZ schrieb "René van Dorst" :
>Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530
>switch both supports TRGMII mode. MT7621 TRGMII speed is fix 1200MBit.
>
Tested on Bananapi R2 (mt7623) with 5.2-rc5 + net-next
Tested-by: Frank Wunderlich
Am 20. Juni 2019 14:21:55 MESZ schrieb "René van Dorst" :
>This patch add support TRGMII mode for MT7621 internal MT7530 switch.
>MT7621 TRGMII has only one fix speed mode of 1200MBit.
>
>A
Hi,
tested on BPI-R2 (mt7623) with 2 Problems (already reported to Rene, just to
inform everyone)...maybe anybody has an idea
- linux-next (i know it's not part of the series, but a pitfall on testing
other devices) seems to break power-regulator somewhere here:
priv->core_pwr = devm_regulator
tested now also on bpi-r64 (mt7622) v0.1 (rtl8367 switch), without linux-next
to avoid power-regulator-problems like on bpi-r2
dmesg without warnings/errors caused by this patches
link came up as desired
iperf3 looks good: 943 Mbits/sec in both directions and no other issues
so it is currently o
tested on bpi-r2 (mt7623/mt7530) and bpi-r64 (mt7622/rtl8367)
as reported to rene directly rx-path needs some rework because current rx-speed
on bpi-r2 is 865 Mbits/sec instead of ~940 Mbits/sec
Tested-by: Frank Wunderlich
regards Frank
> Gesendet: Freitag, 23. August 2019 um 15:45 Uhr
&g
Tested on Bananapi-R2 (mt7623+mt7530) and Bananapi-R64 v0.1 (mt7622+rtl8367)
Tested-by: Frank Wunderlich
regards Frank
Hi
> Gesendet: Samstag, 05. September 2020 um 10:45 Uhr
> Von: "Frank Wunderlich"
> similar to bananapi-r2 (mt7530)
...
> reverse-mode:
>
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.01 sec 1.05 GBytes 905 Mbits/s
Tested full series on Bananapi-r2 and r64, results as in v3
Tested-By: Frank Wunderlich
regards Frank
ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: René van Dorst
Signed-off-by: Frank Wunderlich
---
drivers/net/ethernet/mediatek/mtk_eth_so
Hi,
Thank you David's to get this finally applied. Add recipient for stable tree as
TRGMII on 5.4+ is also broken without this Patch.
regards Frank
> Gesendet: Mittwoch, 29. Juli 2020 um 02:05 Uhr
> Von: "David Miller"
Applied.
ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: Landen Chao
Signed-off-by: Frank Wunderlich
Reviewed-by: Andrew Lunn
---
v3->v4
- fix c
ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: Landen Chao
Signed-off-by: Frank Wunderlich
Reviewed-by: Andrew Lunn
---
v3->v4
- fix c
sorry, send this accidentally while posting my hdmi series v4 (have not deleted
patch-file)
just ignore this...it's already merged
regards Frank
tested full series on Bananapi-r64 (mt7531) running iperf3-server
[ ID] Interval Transfer Bitrate Retr
[ 5] 0.00-10.00 sec 1.09 GBytes 939 Mbits/sec0 sender
[ 5] 0.00-10.01 sec 1.09 GBytes 935 Mbits/sec receiver
reverse mode (-R
Should i make v3 with all tags or me as author?
Regards Frank
Hi,
linux-net-mailinglist for reporting bugs seems not existing anymore and i have
not found out the right one..."scripts/get_maintainer.pl -f
./include/linux/skbuff.h" shows only linux-kernel as mailing list which is not
specific for network, so sorry, if i'm in the wrong mailinglist.
i've re
ing this connection in devicetree.
Regards Frank
Mit freundlichen Grüßen
Frank Wunderlich
:deacea10
[ 5.335963] [] (platform_drv_probe) from []
(really_probe+0x2d8/0x424)
maybe other boards using this generic driver are affected
Signed-off-by: Frank Wunderlich
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
> In mtk_phy_connect() I would say this complete block can be removed.
> All this is handled internally by phylib.
>
> dev->phydev->autoneg = AUTONEG_ENABLE;
> dev->phydev->speed = 0;
> dev->phydev->duplex = 0;
>
> phy_set_max_speed(dev->phydev, SPEED_1000);
> phy_
carrier_on/netif_carrier_off in mtk_phy_link_adjust() isn't
needed. It's done by phy_link_change() in phylib.
Signed-off-by: Frank Wunderlich
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/media
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
include/net/dsa.h | 18 ++
net/dsa/dsa2.c| 18 ++
2 files changed, 36 insertions(+)
diff --git a/include
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/drivers/net
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
include/net/dsa.h | 4
net/dsa/dsa_priv.h | 5 +
2 files changed, 9 insertions(+)
diff --git a/include/net/dsa.h b/include/net/dsa.h
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0044-net-next-dsa-mediatek-tell-GDMA-when-we-are-turning-.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 6 ++
drivers/net/dsa/mt7530.h | 4
2 files changed, 10 insertions
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0045-net-dsa-mediatek-turn-into-platform-driver.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
net/dsa/dsa2.c | 18 ++
net/dsa/slave.c | 3 ++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/net/dsa/dsa2
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0032-net-dsa-mediatek-add-support-for-GMAC2-wired-to-ext-.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/dsa/mt7530
Dezember 2018 um 23:37 Uhr
> Von: "Florian Fainelli"
> An: "Frank Wunderlich" , "Andrew Lunn"
> , "Vivien Didelot" ,
> "David S. Miller" , "Matthias Brugger"
> , netdev@vger.kernel.org,
> linux-ker...@vger.kernel.org
this patch adds the core-functionality of multiple cpu-ports
currently it uses definition in dts to make connection between cpu and user-port
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
switch (7530) needs to to be linked to mdio-bus
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0045-net-dsa-mediatek-turn-into-platform-driver.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 10 --
1 file changed, 8
implementing changes to mt7530 switch driver for supporting multiple (2)
cpu-ports
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 34
cpu-ports of mt7530 need some special flags to be set
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0032-net-dsa-mediatek-add-support-for-GMAC2-wired-to-ext-.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 5 +
1 file
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 29 ++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
index 2b760f90f38c..64f3da148dbb 100644
--- a/arch/arm/boot/dts/m
for multiple cpu-Ports aech port needs storing the the cpu-port to be used
this Patch adds the needed fields for this
based on
https://github.com/openwrt/openwrt/blob/master/target/linux/mediatek/patches-4.14/0033-dsa-multi-cpu.patch
Signed-off-by: Frank Wunderlich
---
include/net/dsa.h | 4
ding eth-patches) is uploaded here:
https://github.com/frank-w/BPI-R2-4.14/commits/4.20-gmac-test
new in v2:
- added DTS-changes
- added cover-letter
- added change of dts-option (default_cpu)
currently posted not to full maintainers-list for first review,
will do it when patches are ready :)
-cpu.patch
Signed-off-by: Frank Wunderlich
---
include/net/dsa.h | 18 ++
net/dsa/dsa2.c| 18 ++
2 files changed, 36 insertions(+)
diff --git a/include/net/dsa.h b/include/net/dsa.h
index 3efa81e08993..612942ac56de 100644
--- a/include/net/dsa.h
+++ b/include
-GDMA-when-we-are-turning-.patch
Signed-off-by: Frank Wunderlich
---
drivers/net/dsa/mt7530.c | 6 ++
drivers/net/dsa/mt7530.h | 4
2 files changed, 10 insertions(+)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 441320d4d779..83669f53cb36 100644
--- a/drivers/net
ees the Problem
regards Frank
> Gesendet: Freitag, 14. Dezember 2018 um 18:26 Uhr
> Von: "Florian Fainelli"
> An: "Frank Wunderlich" , "Matthias Brugger"
> , netdev@vger.kernel.org, "Sean Wang"
> , "Andrew Lunn" ,
> linux-media
Hi,
> Von: "Florian Fainelli"
>
> Yes, this is what I mean with DT is dictating policy. If you have a
> properly working DSA switch driver, then all ports are segregated from
> one another and there is no cross talk, so there is no risk of e.g:
> exposing LAN devices to the WAN accidentally.
ho
Hi,
have tested only my dsa-Patches (no ethernet-changes), and what should i
say...it seems to work well. second gmac is recognized, i can have traffic on
both and iperf works...without any crash (tried 5 port changes with iperf
between).
root@bpi-r2:~# ip a
in the right one?
regards Frank
> Gesendet: Mittwoch, 06. Februar 2019 um 19:48 Uhr
> Von: "Eric Dumazet"
> On 02/06/2019 09:36 AM, Frank Wunderlich wrote:
> > linux-net-mailinglist for reporting bugs seems not existing anymore and i
> > have not fou
Hi,
i've found an oops in 4.19.23/10, seems to be fixed anyhow in 5.0 (also works
in 4.14.101)
root@bpi-r2:~# ip link add link lan0 name lan0.5 type vlan id 5
root@bpi-r2:~# ip addr add 192.168.5.200/24 brd 192.168.5.255 dev lan0.5
root@bpi-r2:~# ip link set dev lan0 up
root@bpi-r2:~# ip link se
Hi Florian
a user from Bananapi-forum has reported the oops and i had reproduced this and
patched out this oops.
That means not that vlan in bridge works, only no crash.
my kernel only conatins the second gmac dsa-patches for mt7530/bpi-r2 i've
posted at the end of last year, but the oops also
um 00:20 Uhr
> Von: "Florian Fainelli"
> An: "Frank Wunderlich" , netdev@vger.kernel.org,
> "Andrew Lunn" , "Vivien Didelot"
> Betreff: Re: [BUG] [FIX] net: dsa: oops in br_vlan_enabled
>
>
>
> On 2/17/2019 9:13 AM, Florian
-off-by: René van Dorst
Signed-off-by: Frank Wunderlich
Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink
: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: René van Dorst
Signed-off
> Gesendet: Donnerstag, 09. Juli 2020 um 15:41 Uhr
> Von: "Andrew Lunn"
> > + eth->netdev[id]->max_mtu = 1536;
>
> I assume this is enough to make the DSA warning go away, but it is the
> true max? I have a similar patch for the FEC driver which i should
> post sometime. Reviewing the FEC code
Am 9. Juli 2020 22:31:34 MESZ schrieb Russell King - ARM Linux admin
:
>Are there any plans to solve these warnings for Marvell 88e6xxx DSA
>ports?
Maybe it's a better idea to restore previous condition?
if (ret && ret != -EOPNOTSUPP)
Or use another loglevel (dev_dbg)
regards Frank
62 matches
Mail list logo
